Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-08 Thread Pavel Rappo
On Wed, 7 Jun 2023 20:33:00 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-08 Thread Pavel Rappo
On Wed, 7 Jun 2023 21:39:33 GMT, Jonathan Gibbons wrote: >> The general criticism here is whether we should restrict in any way the set >> of super types from which one can inherit documentation, and/or what should >> the set of checks be? >> >> For example, if a method in C inherits a method

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-08 Thread Pavel Rappo
On Thu, 8 Jun 2023 09:18:04 GMT, Pavel Rappo wrote: >> test/langtools/jdk/javadoc/doclet/testDirectedInheritance/TestDirectedInheritance.java >> line 289: >> >>> 287: >>> 288: /* >>> 289: * C1.m inherits documentation from B1.m explicitly and undirect. >> >> possible typo: do you

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-08 Thread Pavel Rappo
On Wed, 7 Jun 2023 20:23:09 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-08 Thread Pavel Rappo
On Wed, 7 Jun 2023 18:55:10 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 21:37:42 GMT, Jonathan Gibbons wrote: >> Sure we can; this relates to an earlier comment of yours on >> Utils.isDirectSupertype here: >> https://github.com/openjdk/jdk/pull/14357#discussion_r1222053011 > > The general criticism here is whether we should restrict in any way

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 20:48:58 GMT, Pavel Rappo wrote: >> test/langtools/jdk/javadoc/doclet/testDirectedInheritance/TestDirectedInheritance.java >> line 673: >> >>> 671: * >>> 672: * For now a warning is issued if a doc comment inherits from >>> 673: * an indirect supertype. >> >>

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 19:16:51 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 19:13:55 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 20:29:07 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback: make warning less scary > >

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Pavel Rappo
> Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for inheritable documentation -- has been improved, it still