Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

2020-05-20 Thread Rui Wang
I built the site both from the repo (git tag) and apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot checked. From what I could tell, there wasn't an obvious difference (random clicks were limited though). My personal opinion is that the 1.23.0 rc1 can continue. If someone knows

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

2020-05-20 Thread Rui Wang
Indeed there is an extra site/fonts in the git tag. I didn't see it in the last two releases (the diff on licenses are normal). So the question is, does it matter for the diff on site/? At least the artifact has the same source code as the tag (thus can build the same jar, behave the same when

[jira] [Created] (CALCITE-4018) Implement trait propagation for EnumerableValues

2020-05-20 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4018: -- Summary: Implement trait propagation for EnumerableValues Key: CALCITE-4018 URL: https://issues.apache.org/jira/browse/CALCITE-4018 Project: Calcite

[jira] [Created] (CALCITE-4017) Implement trait propagation for Enumerable Setop

2020-05-20 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4017: -- Summary: Implement trait propagation for Enumerable Setop Key: CALCITE-4017 URL: https://issues.apache.org/jira/browse/CALCITE-4017 Project: Calcite

[jira] [Created] (CALCITE-4016) Implement trait propagation for EnumerableCalc

2020-05-20 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4016: -- Summary: Implement trait propagation for EnumerableCalc Key: CALCITE-4016 URL: https://issues.apache.org/jira/browse/CALCITE-4016 Project: Calcite Issue

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

2020-05-20 Thread Stamatis Zampetakis
5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper * Checked signatures and checksums OK * Build (./gradlew clean assemble) on git repo and source artifacts OK * Run unit tests (./gradlew clean test) on git repo and source artifacts OK * Run slow tests (./gradlew clean

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

2020-05-20 Thread Danny Chan
Thanks Haisheng for driving this! Verified GPG signature - OK Verified SHA512 - OK Release notes - OK Diff the files in the release artifact and tag - ok As for Calcite 3997, it only affects the Physical node, I’m fine with that ~ So +1 (binding) ~ Gradle 6.3 (via gradlew) Mac OS High Sierra