Re: [DISCUSS] KIP-933 Publish metrics when source connector fails to poll data

2023-07-05 Thread Sagar
Hi Ravindra, One minor thing, the discussion thread URL that you had provided points to an incorrect page. Can you plz update it to this ( https://www.mail-archive.com/dev@kafka.apache.org/msg131894.html)? Thanks! Sagar. On Sun, Jul 2, 2023 at 12:06 AM Ravindra Nath Kakarla <

Re: [DISCUSS] KIP-933 Publish metrics when source connector fails to poll data

2023-07-05 Thread Sagar
Hi Ravindra, When you say we should ignore retryable exceptions when SourceTasks switches to using > RetryWithToleranceOperator. you mean the metrics computation should be avoided? Now that I think about it, it might be better to keep the PR and the KIP separated from each other. For now,

Re: [DISCUSS] KIP-933 Publish metrics when source connector fails to poll data

2023-07-01 Thread Ravindra Nath Kakarla
Thanks for reviewing and providing the feedback. > 1) Does it make sense to drop the *record *part from the metric name as it doesn't seem to serve much purpose? I would rather call the metric as *source-poll-errors-total Yes, "records" is not needed and misleading. > Staying on names, I am

Re: [DISCUSS] KIP-933 Publish metrics when source connector fails to poll data

2023-06-28 Thread Sagar
Hey Ravindra, Thanks for the KIP! It appears to be a useful addition to the metrics to understand poll related failures which can go untracked as of now. I just have a couple of minor comments: 1) Does it make sense to drop the *record *part from the metric name as it doesn't seem to serve much

[DISCUSS] KIP-933 Publish metrics when source connector fails to poll data

2023-06-24 Thread Ravindra Nath Kakarla
Hello, I would like to start a discussion on KIP-933 to add new metrics to Kafka Connect that helps monitoring polling failures with source connectors. https://cwiki.apache.org/confluence/display/KAFKA/KIP-933%3A+Publish+metrics+when+source+connector+fails+to+poll+data Looking forward to