Build failed in Jenkins: kafka-trunk-jdk8 #1175

See Changes: [me] KAFKA-3209: KIP-66: single message transforms [wangguoz] MINOR: make methods introduced in KAFKA-4490 consistent with KIP-100 [me] MINOR: avoid closing over both pre & post-transform record in [ismael] MINOR:

Build failed in Jenkins: kafka-trunk-jdk7 #1832

See Changes: [ismael] MINOR: Remove unnecessary options in SCRAM test jaas config [ismael] MINOR: Minor improvements in consumer close timeout handling -- [...truncated 18659 lines...]

Build failed in Jenkins: kafka-trunk-jdk7 #1831

See Changes: [me] MINOR: avoid closing over both pre & post-transform record in -- [...truncated 18646 lines...] org.apache.kafka.streams.processor.internals.assignment.TaskAssignorTest >

Jenkins build is back to normal : kafka-trunk-jdk8 #1174

See

[GitHub] kafka pull request #2348: MINOR: Minor improvements in consumer close timeou...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] KIP-112: Handle disk failure for JBOD

Thanks for the KIP. Just wanted to quickly say that it's great to see proposals for improving JBOD (KIP-113 too). More feedback soon, hopefully. Ismael On Thu, Jan 12, 2017 at 6:46 PM, Dong Lin wrote: > Hi all, > > We created KIP-112: Handle disk failure for JBOD. Please

[GitHub] kafka pull request #2353: MINOR: Remove unnecessary options in SCRAM test ja...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2365: MINOR: avoid closing over both pre & post-transfor...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2365 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2365: MINOR: avoid closing over both pre & post-transfor...

GitHub user shikhar opened a pull request: https://github.com/apache/kafka/pull/2365 MINOR: avoid closing over both pre & post-transform record in WorkerSourceTask Followup to #2299 for KAFKA-3209 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request #2363: MINOR: make methods introduced in KAFKA-4490 consi...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2363 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2299: KAFKA-3209: KIP-66: single message transforms

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2364: MINOR: fix JavaDoc

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2364: MINOR: fix JavaDoc

GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/2364 MINOR: fix JavaDoc You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/kafka hotfix Alternatively you can review and apply these changes as

[GitHub] kafka pull request #2363: MINOR: make methods introduced in KAFKA-4490 consi...

GitHub user xvrl opened a pull request: https://github.com/apache/kafka/pull/2363 MINOR: make methods introduced in KAFKA-4490 consistent with KIP-100 and remove some unnecessary @SuppressWarnings annotations You can merge this pull request into a Git repository by running: $

[GitHub] kafka pull request #2362: HOTFIX: Added another broker to smoke test

GitHub user enothereska opened a pull request: https://github.com/apache/kafka/pull/2362 HOTFIX: Added another broker to smoke test You can merge this pull request into a Git repository by running: $ git pull https://github.com/enothereska/kafka hotfix-smoke-test-2-brokers

UNSUBSCRIBE PLEASE

us...@kafka.apache.org;users-unsubscr...@kafka.apache.org; users_unsubscr...@kafka.apache.org; dev@kafka.apache.org; dev-unsubscr...@kafka.apache.org; dev_unsubscr...@kafka.apache.org -Original Message- From: Raj Tanneru [mailto:rtann...@fanatics.com] Sent: Saturday, May 7, 2016 6:46 PM

Build failed in Jenkins: kafka-trunk-jdk8 #1173

See Changes: [wangguoz] KAFKA-4603: Fixed the argument of shell in doc [cshapi] MINOR: Fix error in design docs [wangguoz] KAFKA-4490: Add Global Table support to Kafka Streams --

[GitHub] kafka pull request #2361: KAFKA-4591: Create Topic Policy (KIP-108)

GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/2361 KAFKA-4591: Create Topic Policy (KIP-108) You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-4591-create-topic-policy

[GitHub] kafka pull request #2360: KAFKA-3452 Follow-up: Refactoring StateStore hiera...

GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/2360 KAFKA-3452 Follow-up: Refactoring StateStore hierarchies This is a follow up of https://github.com/apache/kafka/pull/2166 - refactoring the store hierarchies as requested You can merge this pull

[GitHub] kafka pull request #2244: KAFKA-4490: Add Global Table support to Kafka Stre...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2357: Fix error in design docs

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #2322: KAFKA-4603 the argument of shell in doc wrong and ...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] KIP-111 : Kafka should preserve the Principal generated by the PrincipalBuilder while processing the request received on socket channel, on the broker.

Hi Ismael, Fair point. I will update it. Thanks, Mayuresh On Thu, Jan 12, 2017 at 11:07 AM, Ismael Juma wrote: > Hi Mayuresh, > > Thanks for the KIP. A quick comment before I do a more detailed analysis, > the KIP says: > > `This KIP is a pure addition to existing

Re: [DISCUSS] KIP-111 : Kafka should preserve the Principal generated by the PrincipalBuilder while processing the request received on socket channel, on the broker.

Hi Mayuresh, Thanks for the KIP. A quick comment before I do a more detailed analysis, the KIP says: `This KIP is a pure addition to existing functionality and does not include any backward incompatible changes.` However, the KIP is proposing the addition of a method to the PrincipalBuilder

[DISCUSS] KIP-113: Support replicas movement between log directories

Hi all, We created KIP-113: Support replicas movement between log directories. Please find the KIP wiki in the link *https://cwiki.apache.org/confluence/display/KAFKA/KIP-113%3A+Support+replicas+movement+between+log+directories

[DISCUSS] KIP-112: Handle disk failure for JBOD

Hi all, We created KIP-112: Handle disk failure for JBOD. Please find the KIP wiki in the link https://cwiki.apache.org/confluence/display/KAFKA/KIP- 112%3A+Handle+disk+failure+for+JBOD. This KIP is related to KIP-113

Re: [VOTE] KIP-107 Add purgeDataBefore() API in AdminClient

+1 (for the record, I favor the rejected alternative of not awaiting low watermarks to go past the purge offset. I realize it offers a weaker guarantee but it is still very useful, easier to implement, slightly simpler API (no need to return a future) and you can still get access to the current

Re: [ANNOUNCE] New committer: Grant Henke

Hey Grant - congrats! On Thu, Jan 12, 2017 at 10:00 AM, Neha Narkhede wrote: > Congratulations, Grant. Well deserved! > > On Thu, Jan 12, 2017 at 7:51 AM Grant Henke wrote: > > > Thanks everyone! > > > > On Thu, Jan 12, 2017 at 2:58 AM, Damian Guy

[GitHub] kafka pull request #2359: KAFKA-3452: follow up - fix state store restoratio...

GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/2359 KAFKA-3452: follow up - fix state store restoration for session and window stores The refactoring of the stores in https://github.com/apache/kafka/pull/2166 introduced

Re: [ANNOUNCE] New committer: Grant Henke

Congratulations, Grant. Well deserved! On Thu, Jan 12, 2017 at 7:51 AM Grant Henke wrote: > Thanks everyone! > > On Thu, Jan 12, 2017 at 2:58 AM, Damian Guy wrote: > > > Congratulations! > > > > On Thu, 12 Jan 2017 at 03:35 Jun Rao

[GitHub] kafka pull request #2358: WIP -- DO NOT MERGE -- KAFKA-4222: Transient failu...

GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/2358 WIP -- DO NOT MERGE -- KAFKA-4222: Transient failure in QueryableStateIntegrationTest.queryOnRebalance You can merge this pull request into a Git repository by running: $ git pull

Re: [VOTE] KIP-107 Add purgeDataBefore() API in AdminClient

+1 (non-binding). Thanks, Mayuresh On Wed, Jan 11, 2017 at 10:11 PM, radai wrote: > LGTM, +1 > > On Wed, Jan 11, 2017 at 1:01 PM, Dong Lin wrote: > > > Hi all, > > > > It seems that there is no further concern with the KIP-107. At this point >

[DISCUSS] KIP-111 : Kafka should preserve the Principal generated by the PrincipalBuilder while processing the request received on socket channel, on the broker.

Hi all. We created KIP-111 to propose that Kafka should preserve the Principal generated by the PrincipalBuilder while processing the request received on socket channel, on the broker. Please find the KIP wiki in the link https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=67638388.

Re: [VOTE] KIP-107: Add purgeDataBefore() API in AdminClient

+1 (non-binding) Thanks, Mayuresh On Wed, Jan 11, 2017 at 1:03 PM, Dong Lin wrote: > Sorry for the duplicated email. It seems that gmail will put the voting > email in this thread if I simply replace DISCUSS with VOTE in the subject. > > On Wed, Jan 11, 2017 at 12:57 PM,

[GitHub] kafka pull request #2357: Fix error in design docs

GitHub user dasl- opened a pull request: https://github.com/apache/kafka/pull/2357 Fix error in design docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/dasl-/kafka trunk Alternatively you can review and apply these changes

Re: [ANNOUNCE] New committer: Grant Henke

Thanks everyone! On Thu, Jan 12, 2017 at 2:58 AM, Damian Guy wrote: > Congratulations! > > On Thu, 12 Jan 2017 at 03:35 Jun Rao wrote: > > > Grant, > > > > Thanks for all your contribution! Congratulations! > > > > Jun > > > > On Wed, Jan 11, 2017 at

[jira] [Commented] (KAFKA-4581) Fail gracefully if multiple login modules are specified in sasl.jaas.config

[ https://issues.apache.org/jira/browse/KAFKA-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821237#comment-15821237 ] ASF GitHub Bot commented on KAFKA-4581: --- GitHub user rajinisivaram opened a pull request:

[GitHub] kafka pull request #2356: KAFKA-4581: Fail early if multiple client login mo...

GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2356 KAFKA-4581: Fail early if multiple client login modules in sasl.jaas.config Validate and fail client connection if multiple login modules are specified in sasl.jaas.config to avoid

[jira] [Work started] (KAFKA-4604) Gradle Eclipse plugin creates projects for non project subfolders

[ https://issues.apache.org/jira/browse/KAFKA-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-4604 started by Dhwani Katagade. -- > Gradle Eclipse plugin creates projects for non project subfolders >

[jira] [Updated] (KAFKA-4617) gradle-generated core eclipse project has incorrect source folder structure

[ https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-4617: - Description: The gradle-generated Eclipse Scala project for Kafka core has a classpath defined

[jira] [Updated] (KAFKA-4565) Separation of Internal and External traffic (KIP-103)

[ https://issues.apache.org/jira/browse/KAFKA-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4565: --- Status: Patch Available (was: In Progress) > Separation of Internal and External traffic (KIP-103) >

[jira] [Commented] (KAFKA-4590) Add system test for SASL/SCRAM

[ https://issues.apache.org/jira/browse/KAFKA-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821084#comment-15821084 ] ASF GitHub Bot commented on KAFKA-4590: --- GitHub user rajinisivaram opened a pull request:

[GitHub] kafka pull request #2355: KAFKA-4590: SASL/SCRAM system tests

GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2355 KAFKA-4590: SASL/SCRAM system tests Runs sanity test and one replication test using SASL/SCRAM. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (KAFKA-4565) Separation of Internal and External traffic (KIP-103)

[ https://issues.apache.org/jira/browse/KAFKA-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821082#comment-15821082 ] ASF GitHub Bot commented on KAFKA-4565: --- GitHub user ijuma opened a pull request:

[GitHub] kafka pull request #2354: KAFKA-4565: Separation of Internal and External tr...

GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/2354 KAFKA-4565: Separation of Internal and External traffic (KIP-103) You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821054#comment-15821054 ] Michael Noll commented on KAFKA-3745: - I think [~mjsax] meant to say "not a big deal" (rather than

[jira] [Updated] (KAFKA-4616) Message loss is seen when kafka-producer-perf-test.sh is running and any broker restarted in middle

[ https://issues.apache.org/jira/browse/KAFKA-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sandeep kumar singh updated KAFKA-4616: --- Summary: Message loss is seen when kafka-producer-perf-test.sh is running and any

[jira] [Commented] (KAFKA-4616) Message log is seen when kafka-producer-perf-test.sh is running and any broker restarted in middle in-between

[ https://issues.apache.org/jira/browse/KAFKA-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821003#comment-15821003 ] sandeep kumar singh commented on KAFKA-4616: thanks for reply. i applied acks=-1 option, but

[jira] [Updated] (KAFKA-4614) Long GC pause harming broker performance which is caused by mmap objects created for OffsetIndex

[ https://issues.apache.org/jira/browse/KAFKA-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuto Kawamura updated KAFKA-4614: - Status: Patch Available (was: Open) > Long GC pause harming broker performance which is caused

[jira] [Commented] (KAFKA-4614) Long GC pause harming broker performance which is caused by mmap objects created for OffsetIndex

[ https://issues.apache.org/jira/browse/KAFKA-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820948#comment-15820948 ] Yuto Kawamura commented on KAFKA-4614: -- I applied the patch to one of our production brokers,

[jira] [Commented] (KAFKA-4610) getting error:Batch containing 3 record(s) expired due to timeout while requesting metadata from brokers for test2R2P2-1

[ https://issues.apache.org/jira/browse/KAFKA-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820941#comment-15820941 ] sandeep kumar singh commented on KAFKA-4610: thanks for the update. i am trying to check in

[GitHub] kafka pull request #2353: MINOR: Remove unnecessary options in SCRAM test ja...

GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/2353 MINOR: Remove unnecessary options in SCRAM test jaas config You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajinisivaram/kafka

[GitHub] kafka pull request #2352: KAFKA-4614 Forcefully unmap mmap of OffsetIndex to...

GitHub user kawamuray opened a pull request: https://github.com/apache/kafka/pull/2352 KAFKA-4614 Forcefully unmap mmap of OffsetIndex to prevent long GC pause Issue: https://issues.apache.org/jira/browse/KAFKA-4614 Fixes the problem that the broker threads suffered by long

[jira] [Commented] (KAFKA-4614) Long GC pause harming broker performance which is caused by mmap objects created for OffsetIndex

[ https://issues.apache.org/jira/browse/KAFKA-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820924#comment-15820924 ] ASF GitHub Bot commented on KAFKA-4614: --- GitHub user kawamuray opened a pull request:

[jira] [Commented] (KAFKA-3992) InstanceAlreadyExistsException Error for Consumers Starting in Parallel

[ https://issues.apache.org/jira/browse/KAFKA-3992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820918#comment-15820918 ] darmagan commented on KAFKA-3992: - I have the same problem. I have started 20 consumer_threads and it

[jira] [Commented] (KAFKA-1843) Metadata fetch/refresh in new producer should handle all node connection states gracefully

[ https://issues.apache.org/jira/browse/KAFKA-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820892#comment-15820892 ] sandeep kumar singh commented on KAFKA-1843: in step 4 when you bring K1 up, should it not

[jira] [Commented] (KAFKA-4614) Long GC pause harming broker performance which is caused by mmap objects created for OffsetIndex

[ https://issues.apache.org/jira/browse/KAFKA-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820875#comment-15820875 ] Michael Noll commented on KAFKA-4614: - [~kawamuray] Sorry to hear that you ran into this. Thanks a

FOSDEM 2017 Open Source Conference - Brussels

Hello Everyone This email is to tell you about ASF participation at FOSDEM. The event will be held in Brussels on 4^th & 5^th February 2017 and we are hoping that many people from our ASF projects will be there. https://fosdem.org/2017/ Attending FOSDEM is completely free and the ASF will

[GitHub] kafka pull request #2351: MINOR: add Eclipse generated files to toplevel .gi...

GitHub user edoardocomar opened a pull request: https://github.com/apache/kafka/pull/2351 MINOR: add Eclipse generated files to toplevel .gitignore Ignoring sibfolders' .gitignore except tests Ignoring core/cache-main and core/cache-tests You can merge this pull request into a

[GitHub] kafka pull request #2350: MINOR: Finished exposing the broker config

GitHub user enothereska opened a pull request: https://github.com/apache/kafka/pull/2350 MINOR: Finished exposing the broker config This was left over from KIP-104. Thanks to @ijuma for pointing out. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request #2349: KAFKA-4603 Command parsed error, change all Option...

GitHub user auroraxlh opened a pull request: https://github.com/apache/kafka/pull/2349 KAFKA-4603 Command parsed error, change all OptionParser constructor KAFKA-4603 the command parsed error Using "new OptionParser" might result in parse error Change all the

[jira] [Commented] (KAFKA-4603) the argument of shell in doc wrong and command parsed error

[ https://issues.apache.org/jira/browse/KAFKA-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820676#comment-15820676 ] ASF GitHub Bot commented on KAFKA-4603: --- GitHub user auroraxlh opened a pull request:

[jira] [Resolved] (KAFKA-3701) Expose KafkaStreams metrics in public API

[ https://issues.apache.org/jira/browse/KAFKA-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eno Thereska resolved KAFKA-3701. - Resolution: Fixed > Expose KafkaStreams metrics in public API >

[jira] [Commented] (KAFKA-3701) Expose KafkaStreams metrics in public API

[ https://issues.apache.org/jira/browse/KAFKA-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820651#comment-15820651 ] Eno Thereska commented on KAFKA-3701: - This was fixed at part of KIP-104. > Expose KafkaStreams

Re: [VOTE] KIP-106 - Default unclean.leader.election.enabled True => False

+1 (non-binding) On Wed, Jan 11, 2017 at 11:15 PM, Tom Crayford wrote: > +1 (non-binding) > > On Wed, Jan 11, 2017 at 11:12 PM, Stevo Slavić wrote: > > > +1 (non-binding) > > > > On Thu, Jan 12, 2017 at 12:11 AM, Guozhang Wang > >

Re: [ANNOUNCE] New committer: Grant Henke

Congratulations, Grant! Regards, Rajini On Thu, Jan 12, 2017 at 8:58 AM, Damian Guy wrote: > Congratulations! > > On Thu, 12 Jan 2017 at 03:35 Jun Rao wrote: > > > Grant, > > > > Thanks for all your contribution! Congratulations! > > > > Jun > > > >

Re: [ANNOUNCE] New committer: Grant Henke

Congratulations! On Thu, 12 Jan 2017 at 03:35 Jun Rao wrote: > Grant, > > Thanks for all your contribution! Congratulations! > > Jun > > On Wed, Jan 11, 2017 at 2:51 PM, Gwen Shapira wrote: > > > The PMC for Apache Kafka has invited Grant Henke to join as

[jira] [Resolved] (KAFKA-3714) Allow users greater access to register custom streams metrics

[ https://issues.apache.org/jira/browse/KAFKA-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eno Thereska resolved KAFKA-3714. - Resolution: Fixed > Allow users greater access to register custom streams metrics >

[jira] [Commented] (KAFKA-3714) Allow users greater access to register custom streams metrics

[ https://issues.apache.org/jira/browse/KAFKA-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820484#comment-15820484 ] Eno Thereska commented on KAFKA-3714: - This was addressed in https://github.com/apache/kafka/pull/1446

[jira] [Comment Edited] (KAFKA-3714) Allow users greater access to register custom streams metrics

[ https://issues.apache.org/jira/browse/KAFKA-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820484#comment-15820484 ] Eno Thereska edited comment on KAFKA-3714 at 1/12/17 8:36 AM: -- This was