Re: [ovs-dev] [PATCH 3/3] ovn: Apply ACL changes to existing connections.

On Wed, Mar 2, 2016 at 1:43 PM, Russell Bryant wrote: > > Prior to this commit, once a connection had been committed to the > connection tracker, the connection would continue to be allowed, even > if the policy defined in the ACL table changed. This patch changes > the

Re: [ovs-dev] [PATCH] ovsdb-server: Fix a reference count leak bug

> When destroying an ovsdb_jsonrpc_monitor, the jsonrpc monitor still > holds a reference count to the monitors 'changes' indexed with > 'unflushed' transaction id. The bug is that the reference count was > not decremented as it should in the code path. > > The bug caused 'changes' that have

Re: [ovs-dev] [PATCH V6] Add Passive TCP connection to IDL.

Hi Ben, I'm still waiting for you response. Do you see the reason for the current usage of IDL, where Neutron and my patch get the schema from the server, or do you insist that the schema will be read from a file? I do think that if Neutron is using is like that and I took this approach too than

[ovs-dev] [PATCH] bond: don't re-zero recirc_id when creating bond

The bond structure is already zeroed as it is allocated using xzalloc so there is no need to re-zero the recirc_id field. Signed-off-by: Simon Horman --- Found by inspection. --- ofproto/bond.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ofproto/bond.c

Re: [ovs-dev] [PATCH 4/4] openflow: Support matching and modifying MPLS TTL field.

On Mon, Mar 07, 2016 at 05:38:59PM -0800, Justin Pettit wrote: > > > On Mar 7, 2016, at 11:18 AM, Ben Pfaff wrote: > > > > +/* Modifies 'match' so that the MPLS TTL is wildcarded. */ > > +void > > +match_set_any_mpls_ttl(struct match *match, int idx) > > +{ > > +

Re: [ovs-dev] [PATCH 3/4] netdev: Improve comments on netdev_rxq_recv().

On Mon, Mar 07, 2016 at 05:31:17PM -0800, Justin Pettit wrote: > > > On Mar 7, 2016, at 11:18 AM, Ben Pfaff wrote: > > > > The comment was incomplete in some ways and simply wrong in others. > > > > Also ensure that *cnt is set to 0 if an error is encountered. It's nice > > when

Re: [ovs-dev] [PATCH 2/4] dpif-netdev: Fix typo in comment.

On Mon, Mar 07, 2016 at 05:26:35PM -0800, Justin Pettit wrote: > > > On Mar 7, 2016, at 11:18 AM, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks, applied to master.

Re: [ovs-dev] [PATCH 1/4] ovs-ofctl: Fix command names in documentation.

On Mon, Mar 07, 2016 at 05:25:41PM -0800, Justin Pettit wrote: > > > On Mar 7, 2016, at 11:18 AM, Ben Pfaff wrote: > > > > The actual command names do not capitalize "tlv". > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks,

Re: [ovs-dev] why we need op wait when add-port or delete port

On Tue, Mar 08, 2016 at 11:43:53AM +0800, ychen wrote: > I noticed that when add or delete port, the transaction always send op wait > with all the ports in the same bridge. > If the port p0 and p1 are totally independent, and have no relationship with > each other, why when I add port p1, I

[ovs-dev] why we need op wait when add-port or delete port

hi: I noticed that when add or delete port, the transaction always send op wait with all the ports in the same bridge. If the port p0 and p1 are totally independent, and have no relationship with each other, why when I add port p1, I need to wait port p0?

[ovs-dev] [PATCH] netdev-dpdk: fix mbuf leaks

mbufs could be chained (by the "next" field of rte_mbuf struct), when an mbuf is not big enough to hold a big packet, say when TSO is enabled. rte_pktmbuf_free_seg() frees the head mbuf only, leading mbuf leaks. This patch fix it by invoking the right API rte_pktmbuf_free(), to free all mbufs in

Re: [ovs-dev] [PATCH] datapath-windows: Fix a couple of bugs during port enumeration

Still that breaks our prerequisites (elementname of the VIFs are unique) and does not inform the user regarding the error behind it. We could write a wrapper over Enable-Vmswitchextension, i.e. Enable-OvsExtension, in which we require a switch name as a mandatory field, in that way we can

Re: [ovs-dev] [PATCH 4/4] openflow: Support matching and modifying MPLS TTL field.

> On Mar 7, 2016, at 11:18 AM, Ben Pfaff wrote: > > +/* Modifies 'match' so that the MPLS TTL is wildcarded. */ > +void > +match_set_any_mpls_ttl(struct match *match, int idx) > +{ > +match->wc.masks.mpls_lse[idx] &= ~htonl(MPLS_TTL_MASK); > +flow_set_mpls_ttl(>flow, idx,

Re: [ovs-dev] [PATCH 3/4] netdev: Improve comments on netdev_rxq_recv().

> On Mar 7, 2016, at 11:18 AM, Ben Pfaff wrote: > > The comment was incomplete in some ways and simply wrong in others. > > Also ensure that *cnt is set to 0 if an error is encountered. It's nice > when callers can rely on this. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH 2/4] dpif-netdev: Fix typo in comment.

> On Mar 7, 2016, at 11:18 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovsdb-server: Fix a reference count leak bug

On Mon, Mar 7, 2016 at 3:44 PM, Andy Zhou wrote: > > When destroying an ovsdb_jsonrpc_monitor, the jsonrpc monitor still > holds a reference count to the monitors 'changes' indexed with > 'unflushed' transaction id. The bug is that the reference count was > not decremented as it

Re: [ovs-dev] [PATCH 1/4] ovs-ofctl: Fix command names in documentation.

> On Mar 7, 2016, at 11:18 AM, Ben Pfaff wrote: > > The actual command names do not capitalize "tlv". > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list

Re: [ovs-dev] [PATCH] datapath-windows: Fix a couple of bugs during port enumeration

Hi Alin, Valid point. I’ll update the code. The change I was trying to make was as follows. If user forgot to assign OVS names to for VIFs, the first VIF gets added to the hash tables but subsequent ones will throw errors - either a NDIS_STATUS_DATA_NOT_ACCEPTED or NDIS_STATUS_ADAPTER_NOT_FOUND.

[ovs-dev] [PATCH v4 1/6] datapath-windows: Added recirculation support.

Recirculation support for the OVS extension. Tested using PING and iperf with Driver Verifier enabled. Signed-off-by: Sorin Vinturis Co-authored-by: Alin Gabriel Serdean Reported-by: Sorin Vinturis

Re: [ovs-dev] [PATCH] tests: Expand 'bundle with many ports' test.

On 7 March 2016 at 15:39, Ben Pfaff wrote: > On Mon, Mar 07, 2016 at 03:36:38PM -0800, Joe Stringer wrote: >> Explain what this test is doing, and check that the decoded action can >> be re-encoded and dumped back out of OVS. >> >> Suggested-by: Ben Pfaff >>

Re: [ovs-dev] [PATCH] ofp-actions: Assert variable actions have len>0.

On 7 March 2016 at 15:38, Ben Pfaff wrote: > On Mon, Mar 07, 2016 at 03:36:36PM -0800, Joe Stringer wrote: >> Variable-length actions must have a nonzero length; if they don't, >> something went wrong and we should bail out. >> >> Suggested-by: Ben Pfaff >>

Re: [ovs-dev] [PATCH] Revert "ovn-controller: race between binding-run and patch-run for localnet ports"

Thanks, applied. On Mon, Mar 07, 2016 at 06:42:18PM -0500, Russell Bryant wrote: > Acked-by: Russell Bryant > > On Monday, March 7, 2016, Ben Pfaff wrote: > > > This reverts commit 3a83007a76bbf05144cee1fda7ad81c1c717dca7. It's really > > nonobvious from the

Re: [ovs-dev] [PATCH v4 0/3] Testsuite fixes.

This series looks good to me, thanks! Ben, did you have any remaining comments? On 3 March 2016 at 21:31, Ilya Maximets wrote: > version 4: > * Reworked prohibition of parallel execution. > > version 3: > * AT_SKIP_IF ---> AT_CHECK(... || return 77). >

Re: [ovs-dev] ovn northbound ovsdb-server’s memory usage problem

On Mon, Mar 7, 2016 at 1:57 PM, Han Zhou wrote: > > > On Sun, Mar 6, 2016 at 11:02 PM, Lei Huang wrote: > > > > Hi, > > > > > > During a scalability test, we found that the ovn northbound > ovsdb-server’s > > memory usage becomes very high while

[ovs-dev] [PATCH] ovsdb-server: Fix a reference count leak bug

When destroying an ovsdb_jsonrpc_monitor, the jsonrpc monitor still holds a reference count to the monitors 'changes' indexed with 'unflushed' transaction id. The bug is that the reference count was not decremented as it should in the code path. The bug caused 'changes' that have been flushed to

Re: [ovs-dev] [PATCH] nx-match: Fix use-after-free parsing matches.

Hi Joe, I've tested this patch (with modification to ofpbuf_put to force using newly allocated address) and it works fine. Thanks! Regards, William On Mon, Mar 7, 2016 at 11:31 AM, Joe Stringer wrote: > Address pointed by header_ptr might be free'd due to realloc > happened in

Re: [ovs-dev] [PATCH] Revert "ovn-controller: race between binding-run and patch-run for localnet ports"

Acked-by: Russell Bryant On Monday, March 7, 2016, Ben Pfaff wrote: > This reverts commit 3a83007a76bbf05144cee1fda7ad81c1c717dca7. It's really > nonobvious from the code why the condition added by that commit makes > sense. > The new condition should not be

Re: [ovs-dev] [PATCH] datapath-windows: Fix a couple of bugs during port enumeration

Unless I am reading wrong: OvsAddConfiguredSwitchPorts and OvsInitConfiguredSwitchNics only fail if we could not allocate memory or could not issue an OID request. I am not in favor of reporting back to NDIS gracefully if any of the above conditions was broken even once. Thanks, Alin. >

Re: [ovs-dev] [PATCH] tests: Expand 'bundle with many ports' test.

On Mon, Mar 07, 2016 at 03:36:38PM -0800, Joe Stringer wrote: > Explain what this test is doing, and check that the decoded action can > be re-encoded and dumped back out of OVS. > > Suggested-by: Ben Pfaff > Signed-off-by: Joe Stringer Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH] ofp-actions: Assert variable actions have len>0.

On Mon, Mar 07, 2016 at 03:36:36PM -0800, Joe Stringer wrote: > Variable-length actions must have a nonzero length; if they don't, > something went wrong and we should bail out. > > Suggested-by: Ben Pfaff > Signed-off-by: Joe Stringer Acked-by: Ben Pfaff

[ovs-dev] [PATCH] ofp-actions: Fix use-after-free with ofpact_finish().

ofpact_finish() may now reallocate the buffer it is passed, but not all callers updated their local pointers to the current action in the buffer. This could potentially lead to several use-after-free bugs. Update ofpact_finish() to return the new pointer to the ofpact which is provided, and

[ovs-dev] [PATCH] tests: Expand 'bundle with many ports' test.

Explain what this test is doing, and check that the decoded action can be re-encoded and dumped back out of OVS. Suggested-by: Ben Pfaff Signed-off-by: Joe Stringer --- tests/bundle.at | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/bundle.at

[ovs-dev] [PATCH] ofp-actions: Assert variable actions have len>0.

Variable-length actions must have a nonzero length; if they don't, something went wrong and we should bail out. Suggested-by: Ben Pfaff Signed-off-by: Joe Stringer --- lib/ofp-actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [ovs-dev] ovn northbound ovsdb-server’s memory usage problem

On Mon, Mar 07, 2016 at 01:57:22PM -0800, Han Zhou wrote: > On Sun, Mar 6, 2016 at 11:02 PM, Lei Huang wrote: > > > > Hi, > > > > > > During a scalability test, we found that the ovn northbound ovsdb-server’s > > memory usage becomes very high while creating and binding

Re: [ovs-dev] [PATCH] unixctl: Log commands received and their replies (at debug level).

On Mon, Mar 07, 2016 at 01:00:28PM -0800, Justin Pettit wrote: > > > On Mar 7, 2016, at 11:19 AM, Ben Pfaff wrote: > > > > +if (VLOG_IS_DBG_ENABLED()) { > > +char *params = json_to_string(request->params, 0); > > +char *id = json_to_string(request->id, 0); > >

[ovs-dev] Say "Oh!" and "Ah!" all the nights with Rafa Camillo Dev

Heard her hand reached across from.Good evening f#ck sensei!!i found yr profile via facebook!! you are rogue!!My husband cheated on me! Now I want to get him back 8-D I'm up for anythingMy account is here: http://qhegipco.DatingPrint.ruThe cure for my loneliness is in your pants, Dev .

Re: [ovs-dev] [PATCH] binding: Track local datapaths even when no transaction is possible.

On Mon, Mar 07, 2016 at 04:06:11PM -0500, Russell Bryant wrote: > On Mon, Mar 7, 2016 at 3:55 PM, Ben Pfaff wrote: > > > Plenty of other code depends on the set of local datapaths. Most notably, > > the lflow code will drop logical flows when their logical datapaths aren't > >

[ovs-dev] [PATCH] Revert "ovn-controller: race between binding-run and patch-run for localnet ports"

This reverts commit 3a83007a76bbf05144cee1fda7ad81c1c717dca7. It's really nonobvious from the code why the condition added by that commit makes sense. The new condition should not be necessary now that binding_run() always keeps track of the local datapaths, since commit 7c040135cf351 (binding:

Re: [ovs-dev] [PATCH 3/4] ofp-actions: Prevent integer overflow in decode.

On 5 March 2016 at 13:25, Ben Pfaff wrote: > On Thu, Mar 03, 2016 at 09:22:50PM +1300, Joe Stringer wrote: >> When decoding a variable-length action, if the length of the action >> exceeds the length storable in a uint16_t then something has gone >> terribly wrong. Assert that this

Re: [ovs-dev] [PATCH 1/4] tests: Add bundle action test with buffer realloc.

On 5 March 2016 at 11:26, Ben Pfaff wrote: > On Thu, Mar 03, 2016 at 09:22:48PM +1300, Joe Stringer wrote: >> Add a test which causes internal reallocation of the ofpacts buffer, >> followed by a large bundle action which should cause a subsequent >> reallocation while decoding

[ovs-dev] [CudaMailTagged] Urgent Purchase Order

Hi dev@openvswitch.org, Please view the underlisted purchase order in Excel spreadsheet and tell me the duration which the items could be readily made available. Please view the Purchase Order below. View | Download 15KB Kindly get back to me asap Thank you, Best Regards, Blaise

Re: [ovs-dev] ovn northbound ovsdb-server’s memory usage problem

On Sun, Mar 6, 2016 at 11:02 PM, Lei Huang wrote: > > Hi, > > > During a scalability test, we found that the ovn northbound ovsdb-server’s > memory usage becomes very high while creating and binding ports, the test > step is: > > 1. Create 1000 sandboxes > > 2. Create 5

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

> What I would probably do is submit them together: the zone-ids fix + this > test case that helps test it. If you take out your "xyz" change, will this > test fail currently? > > If i take out the change which masks the zone-ids, this test fails on master because, zone-ids dont match before and

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

On Mon, Mar 7, 2016 at 4:27 PM, ramu wrote: > > >> Does this depend on your zone-ids fix? Do you have another rev of that >> coming? >> > > Russell, This test does not depend on the zone-id fix, because it replaces > zone-ids on flows > with a dummy string "xyz". It

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

> > Does this depend on your zone-ids fix? Do you have another rev of that > coming? > Russell, This test does not depend on the zone-id fix, because it replaces zone-ids on flows with a dummy string "xyz". It passes on the master as is. I will send the next revision of the zone-id fix soon,

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

On Mon, Mar 7, 2016 at 4:03 PM, Ramu Ramamurthy wrote: > Add a test to validate that a restart of the ovn-controller > will program flows in table 0 consistently. Flows before > restart are compared against flows after restart to detect > problems with ofports or

Re: [ovs-dev] [PATCH] binding: Track local datapaths even when no transaction is possible.

On Mon, Mar 7, 2016 at 3:55 PM, Ben Pfaff wrote: > Plenty of other code depends on the set of local datapaths. Most notably, > the lflow code will drop logical flows when their logical datapaths aren't > present locally. > > Signed-off-by: Ben Pfaff > I think this

[ovs-dev] [PATCH] ovn-controller: add restart test

Add a test to validate that a restart of the ovn-controller will program flows in table 0 consistently. Flows before restart are compared against flows after restart to detect problems with ofports or zone-ids. Signed-off-by: Ramu Ramamurthy ---

Re: [ovs-dev] [PATCH v2] Use 'RUNDIR' from make for rhel/ovn-controller.service

On Mon, Mar 7, 2016 at 2:39 PM, Russell Bryant wrote: > > > On Mon, Mar 7, 2016 at 1:15 PM, Ben Pfaff wrote: > >> On Mon, Mar 07, 2016 at 10:34:30AM -0500, Russell Bryant wrote: >> > On Mon, Mar 7, 2016 at 9:37 AM, Russell Bryant wrote: >> > >> >

Re: [ovs-dev] [PATCH] unixctl: Log commands received and their replies (at debug level).

> On Mar 7, 2016, at 11:19 AM, Ben Pfaff wrote: > > +if (VLOG_IS_DBG_ENABLED()) { > +char *params = json_to_string(request->params, 0); > +char *id = json_to_string(request->id, 0); > +VLOG_DBG("received request %s%s, id=%s", request->method, params, >

Re: [ovs-dev] [PATCH v5 5/5] [RFC] lflow: Disable egress table optimization.

On Fri, Feb 19, 2016 at 04:40:19PM -0800, Ben Pfaff wrote: > I don't understand why, but without this change, the test in the previous > commit does not pass. > > Signed-off-by: Ben Pfaff I figured out the correct fix:

[ovs-dev] [PATCH] binding: Track local datapaths even when no transaction is possible.

Plenty of other code depends on the set of local datapaths. Most notably, the lflow code will drop logical flows when their logical datapaths aren't present locally. Signed-off-by: Ben Pfaff --- ovn/controller/binding.c | 31 --- 1 file changed, 16

[ovs-dev] re

I have a proposal for you kindly E-mail me at mrrsshhui7...@hotmail.com Yours Faithfully Mrs Huian Shao __ This email has been scanned by the Symantec Email Security.cloud service. For more information please

Re: [ovs-dev] [PATCH v2] Use 'RUNDIR' from make for rhel/ovn-controller.service

On Mon, Mar 7, 2016 at 1:15 PM, Ben Pfaff wrote: > On Mon, Mar 07, 2016 at 10:34:30AM -0500, Russell Bryant wrote: > > On Mon, Mar 7, 2016 at 9:37 AM, Russell Bryant wrote: > > > > > > > > > > > On Mon, Mar 7, 2016 at 12:03 AM, wrote: > > > >

Re: [ovs-dev] [PATCH] nx-match: Fix use-after-free.

On 4 March 2016 at 17:35, William Tu wrote: > Address pointed by header_ptr might be free'd due to realloc > happened at ofpbuf_put_uninit() and ofpbuf_put_hex(). Reported > by valgrind 379: check TCP flags expression in OXM and NXM. > > Invalid write of size 4 >

[ovs-dev] [PATCH] nx-match: Fix use-after-free parsing matches.

Address pointed by header_ptr might be free'd due to realloc happened in ofpbuf_put_hex(). Reported by valgrind in the test 379: check TCP flags expression in OXM and NXM. Invalid write of size 4 nx_match_from_string_raw (nx-match.c:1510) nx_match_from_string (nx-match.c:1538)

[ovs-dev] Unpaid Invoice #963125

Dear Valued Customer, Please make sure you send payment for your parcel to avoid any inconvenience. Open the attached file to review the confirmation listing. Sincerely, Norma Nieves Courier Service ___ dev mailing list dev@openvswitch.org

[ovs-dev] [PATCH 4/4] openflow: Support matching and modifying MPLS TTL field.

Occasionally we get asked about this and I don't see a reason not to support it. Signed-off-by: Ben Pfaff --- NEWS | 1 + lib/match.c | 19 ++- lib/match.h | 4 +++- lib/meta-flow.c | 20 lib/meta-flow.h | 15

[ovs-dev] [PATCH] unixctl: Log commands received and their replies (at debug level).

These commands are also visible through the "jsonrpc" module, but turning up the log level there also exposes a lot of OVSDB traffic that usually isn't interesting. Also, enable this logging for the tests. Signed-off-by: Ben Pfaff --- lib/unixctl.c | 17

[ovs-dev] [PATCH 2/4] dpif-netdev: Fix typo in comment.

Signed-off-by: Ben Pfaff --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index a7e224a..cf574ad 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -1598,7 +1598,7 @@ netdev_flow_key_equal(const

[ovs-dev] [PATCH 3/4] netdev: Improve comments on netdev_rxq_recv().

The comment was incomplete in some ways and simply wrong in others. Also ensure that *cnt is set to 0 if an error is encountered. It's nice when callers can rely on this. Signed-off-by: Ben Pfaff --- lib/netdev-provider.h | 32 +++- lib/netdev.c

[ovs-dev] [PATCH 1/4] ovs-ofctl: Fix command names in documentation.

The actual command names do not capitalize "tlv". Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.8.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index a414408..bc3ddae 100644 ---

Re: [ovs-dev] [CudaMailTagged] [PATCH] ofp-util: Fix use-after-free in group append.

On 4 March 2016 at 15:18, William Tu wrote: > It is possible for ofpbuf_put() to realloc a newly allocated address, > casuing the previously referenced pointer, ogds, points to old/free'd > address. The issue is generated by forcing ofpbuf_put() to use newly > allocated buffer

Re: [ovs-dev] [PATCH] ovs-sandbox: Add note about OVN to initial output.

On Mon, Mar 7, 2016 at 11:17 AM, Ben Pfaff wrote: > On Mon, Mar 07, 2016 at 10:48:21AM -0500, Russell Bryant wrote: > > When you run ovs-sandbox, it finishes with a note describing the dummy > > environment it has set up. Add some additional text that indicates that > > OVN is

Re: [ovs-dev] [PATCH] ofpbuf: Fix use-after-free in bundle parse.

Oh! I've been looking mostly at v2.5 lately and didn't notice how commit 2bd318dec2428ae6c0febbf79453982676ccb672 changed the "update_len" (now ofpact_finish) function. Thanks, I applied this to master. As a separate thing, I was wondering about whether it's worthwhile to do something additional

Re: [ovs-dev] [PATCH] nx-match: Fix use-after-free.

Hi Jarno, Thanks for the feedback. I forgot to mention that this issue is found by changing the ofpbuf code to make each put reallocate the memory. I patched the code with: --- a/lib/ofpbuf.c +++ b/lib/ofpbuf.c @@ -383,6 +383,7 @@ ofpbuf_put_zeros(struct ofpbuf *b, size_t size) void *

Re: [ovs-dev] [PATCH 2/2] ofpbuf: Fix setting of 'msg' in ofpbuf_clone_with_headroom()

Thanks for the review! I split out the more substantial change you pointed out to a separate patch and pushed the series to master. Jarno > On Mar 4, 2016, at 6:55 PM, Joe Stringer wrote: > > (Responding to both patches here as I'm having email reception problems) > > On 3

Re: [ovs-dev] [PATCH] nx-match: Fix use-after-free.

It might be super slow, but how about running the test suite with valgrind and ofpbuf code changed so that each put reallocates the memory? That way we would not have to be lucky about the timing/placement of reallocations to find these bugs? Jarno > On Mar 4, 2016, at 5:35 PM, William Tu

Re: [ovs-dev] [PATCH v2] Use 'RUNDIR' from make for rhel/ovn-controller.service

On Mon, Mar 07, 2016 at 10:34:30AM -0500, Russell Bryant wrote: > On Mon, Mar 7, 2016 at 9:37 AM, Russell Bryant wrote: > > > > > > > On Mon, Mar 7, 2016 at 12:03 AM, wrote: > > > >> Perviously it was using the platform's runtime directory which can be > >>

Re: [ovs-dev] [PATCH v5 3/5] ovn-controller: Add data structure for indexing lports, multicast groups.

On Thu, Mar 03, 2016 at 02:42:45PM -0800, Ben Pfaff wrote: > On Thu, Mar 03, 2016 at 02:29:16PM -0800, Justin Pettit wrote: > > > > > On Feb 19, 2016, at 4:40 PM, Ben Pfaff wrote: > > > > > +struct mcgroup { > > > +struct hmap_node dp_name_node; /* Index by (logical datapath,

Re: [ovs-dev] [PATCH v5 2/5] ovn: Use callback function instead of simap for logical port number map.

On Wed, Mar 02, 2016 at 06:26:03PM -0800, Justin Pettit wrote: > > > On Feb 19, 2016, at 4:40 PM, Ben Pfaff wrote: > > > @@ -2433,10 +2442,13 @@ add_cmp_flow(const struct expr *cmp, const struct > > simap *ports, > > * caller should remap the conj_id and add the OpenFlow

Re: [ovs-dev] [PATCH] ovs-sandbox: Add note about OVN to initial output.

"dev" wrote on 03/07/2016 09:48:21 AM: > From: Russell Bryant > To: dev@openvswitch.org > Date: 03/07/2016 09:48 AM > Subject: [ovs-dev] [PATCH] ovs-sandbox: Add note about OVN to initial output. > Sent by: "dev" > >

Re: [ovs-dev] [PATCH] ovs-sandbox: Add note about OVN to initial output.

On Mon, Mar 07, 2016 at 10:48:21AM -0500, Russell Bryant wrote: > When you run ovs-sandbox, it finishes with a note describing the dummy > environment it has set up. Add some additional text that indicates that > OVN is also enabled when that is the case. > > Signed-off-by: Russell Bryant

Re: [ovs-dev] [PATCH] AUTHORS: Add Ramu Ramamurthy.

On Mon, Mar 07, 2016 at 10:25:43AM -0500, Russell Bryant wrote: > Ramu is the author of 3a83007a76bbf05144cee1fda7ad81c1c717dca7. > > Signed-off-by: Russell Bryant Acked-by: Ben Pfaff ___ dev mailing list

[ovs-dev] [PATCH v10 0/1] Separating OVN NB and SB database processes

From: RYAN D. MOATS Changes from V9: Updated tutorial/ovs-sandbox to work with the split database processes Addressed russellb's comments on V9: - fixed vtep test case to split databases rather than change all the ovn-*ctl calls - fixed indentation on set_defaults() -

[ovs-dev] [PATCH v10 1/1] Separating OVN NB and SB database processes

From: RYAN D. MOATS OVN NB & SB DB's should be run in separate ovsdb-server processes and should run with ovn-ctl start_northd / stop_northd. This patch includes changes to unit tests, tutorial and debian scripts to remain self-consistent. Signed-off-by: RYAN D. MOATS

[ovs-dev] [PATCH] ovs-sandbox: Add note about OVN to initial output.

When you run ovs-sandbox, it finishes with a note describing the dummy environment it has set up. Add some additional text that indicates that OVN is also enabled when that is the case. Signed-off-by: Russell Bryant --- tutorial/ovs-sandbox | 10 +- 1 file changed, 9

Re: [ovs-dev] [PATCH v2] Use 'RUNDIR' from make for rhel/ovn-controller.service

On Mon, Mar 7, 2016 at 9:37 AM, Russell Bryant wrote: > > > On Mon, Mar 7, 2016 at 12:03 AM, wrote: > >> Perviously it was using the platform's runtime directory which can be >> different from the runtime directory of ovsdb-server started by the >>

[ovs-dev] [PATCH] AUTHORS: Add Ramu Ramamurthy.

Ramu is the author of 3a83007a76bbf05144cee1fda7ad81c1c717dca7. Signed-off-by: Russell Bryant --- AUTHORS | 1 + 1 file changed, 1 insertion(+) I meant to incldue this when I pushed Ramu's bug fix, but forgot to amend the commit. I have already pushed this to master. diff

Re: [ovs-dev] weekly OVN report

On Mon, Mar 7, 2016 at 9:47 AM, Dan Mihai Dumitriu wrote: > I would argue for a server-side OVSDB to other backend proxy. I would also > argue against a client side (in ovn-controller) abstraction of the other-db > - one reason for this is related to the security/safety

[ovs-dev] Shipping Information - Your Order #357-3610

Dear Customer, Your order will be shipped shortly, we apologize for the troubles. Please, review the invoice in the attached file. Sincerely, Graciela Simon Project Manager ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] weekly OVN report

I would argue for a server-side OVSDB to other backend proxy. I would also argue against a client side (in ovn-controller) abstraction of the other-db - one reason for this is related to the security/safety argument, in the sense that other-db may not have any ACL mechanism, or any way to limit

Re: [ovs-dev] [PATCH] ovn-controller: race between binding-run and patch-run for localnet ports

On Fri, Mar 4, 2016 at 8:40 PM, Ramu Ramamurthy wrote: > when ctx->ovnsb_idl_txn is null, binding_run exits early > and does not add any local_datapaths, but patch_run > doesnt check this, and ends up deleting localnet ports, > because there are no local datapaths for

Re: [ovs-dev] weekly OVN report

Hi Russell, Nice writeup of the issues and potential solutions. We have been thinking along the same lines. Cheers, Dan On Mon, Mar 7, 2016 at 11:29 PM, Russell Bryant wrote: > On Sun, Mar 6, 2016 at 11:40 PM, Dan Mihai Dumitriu > wrote: > >> I'd argue

Re: [ovs-dev] [PATCH v2] Use 'RUNDIR' from make for rhel/ovn-controller.service

On Mon, Mar 7, 2016 at 12:03 AM, wrote: > Perviously it was using the platform's runtime directory which can be > different from the runtime directory of ovsdb-server started by the > openvswitch service > > Signed-off-by: Babu Shanmugam > > Thanks! I

Re: [ovs-dev] weekly OVN report

On Mon, Mar 7, 2016 at 9:29 AM, Russell Bryant wrote: > On Sun, Mar 6, 2016 at 11:40 PM, Dan Mihai Dumitriu > wrote: > >> I'd argue for the approach of keeping the OVSDB protocol in place, >> because the SB schema is already there, well understood, and making

Re: [ovs-dev] weekly OVN report

On Sun, Mar 6, 2016 at 11:40 PM, Dan Mihai Dumitriu wrote: > I'd argue for the approach of keeping the OVSDB protocol in place, because > the SB schema is already there, well understood, and making the central DB > a fault tolerant cluster would have little or no impact on the

Re: [ovs-dev] vhost-user invalid txqid cause discard of packets

> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, March 4, 2016 7:14 PM > To: Wang, Zhihong ; dev@openvswitch.org > Cc: Flavio Leitner ; Traynor, Kevin > ; > Dyasly Sergey

[ovs-dev] Queues for DPDK interfaces in OVS-DPDK

Hi Team, We have the support for queues creation on QoS record in OVS. Can anyone help in creation of queues for DPDK type interfaces in OVS-DPDK. Thanks in advance. Thanks & Regards, Ravali The information contained in this electronic message and any attachments to this message are intended

[ovs-dev] Shipping Information - Your Order #632-1504

Dear Customer, Your order will be shipped shortly, we apologize for the troubles. Please, review the invoice in the attached file. Sincerely, Bart Stark Project Manager ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH v2 11/11] netdev-dpdk: Use ->reconfigure() call to change rx/tx queues.

Hi Daniele, Thanks for making the changes to this patch and also 1/11 and 7/11. Apart from one minor comment below, all LGTM. Thanks, Mark > >This introduces in dpif-netdev and netdev-dpdk the first use for the >newly introduce reconfigure netdev call. > >When a request to change the number

[ovs-dev] Message could not be delivered

The message was undeliverable due to the following reason(s): Your message was not delivered because the destination computer was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely