Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-12 Thread Sean Owen
I don't think we'd fail the current RC for this change, no. On Tue, Mar 12, 2019 at 3:51 AM Jakub Wozniak wrote: > > Hello, > > Any more thoughts on this one? > Will that be let in 2.4.1 or rather not? > > Thanks in advance, > Jakub > > > On 8 Mar 2019, at 11:26, Jakub Wozniak wrote: > > Hi, >

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-12 Thread Jakub Wozniak
Hello, Any more thoughts on this one? Will that be let in 2.4.1 or rather not? Thanks in advance, Jakub On 8 Mar 2019, at 11:26, Jakub Wozniak mailto:jakub.wozn...@cern.ch>> wrote: Hi, To me it is backwards compatible with older Hbase versions. The code actually only falls back to the newer

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-08 Thread Jakub Wozniak
Hi, To me it is backwards compatible with older Hbase versions. The code actually only falls back to the newer api on exception. It would be great if this gets in. Otherwise a setup with Hbase 2 + Spark 2.4 gets a bit complicated as we are forced to use an older version of the Hbase client

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-08 Thread Jakub Wozniak
I guess it is that one: https://github.com/apache/spark/commit/dfed439e33b7bf224dd412b0960402068d961c7b#diff-9ebb59b7b008c694a8f583b94bd24e1d Cheers, Jakub On 7 Mar 2019, at 17:25, Sean Owen mailto:sro...@gmail.com>> wrote: Do you know what change fixed it? If it's not a regression from 2.4.0

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-07 Thread shane knapp
https://issues.apache.org/jira/browse/SPARK-26742 On Thu, Mar 7, 2019 at 10:52 AM shane knapp wrote: > i'm ready to update the ubuntu workers/minikube/k8s to support the 4.1.2 > client: > https://issues.apache.org/jira/browse/SPARK-2674 > > i am more than comfortable with this build system

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-07 Thread shane knapp
i'm ready to update the ubuntu workers/minikube/k8s to support the 4.1.2 client: https://issues.apache.org/jira/browse/SPARK-2674 i am more than comfortable with this build system update, both on the ops and spark project side. we were incredibly far behind the release cycle for k8s and

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-07 Thread DB Tsai
Saisai, There is no blocker now. I ran into some difficulties in publishing the jars into Nexus. The publish task was finished, but Nexus gave me the following error. *failureMessage Failed to validate the pgp signature of

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-07 Thread Felix Cheung
There is SPARK-26604 we are looking into From: Saisai Shao Sent: Wednesday, March 6, 2019 6:05 PM To: shane knapp Cc: Stavros Kontopoulos; Sean Owen; DB Tsai; Spark dev list; d_t...@apple.com Subject: Re: [VOTE] Release Apache Spark 2.4.1 (RC2) Do we have other

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-07 Thread Sean Owen
Do you know what change fixed it? If it's not a regression from 2.4.0 it wouldn't necessarily go into a maintenance release. If there were no downside, maybe; does it cause any incompatibility with older HBase versions? It may be that this support is targeted for Spark 3 on purpose, which is

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-07 Thread Jakub Wozniak
Hello, I have a question regarding the 2.4.1 release. It looks like Spark 2.4 (and 2.4.1-rc) is not exactly compatible with Hbase 2.x+ for the Yarn mode. The problem is in the org.apache.spark.deploy.security.HbaseDelegationTokenProvider class that expects a specific version of TokenUtil

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-06 Thread Saisai Shao
Do we have other block/critical issues for Spark 2.4.1 or waiting something to be fixed? I roughly searched the JIRA, seems there's no block/critical issues marked for 2.4.1. Thanks Saisai shane knapp 于2019年3月7日周四 上午4:57写道: > i'll be popping in to the sig-big-data meeting on the 20th to talk

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-06 Thread shane knapp
i'll be popping in to the sig-big-data meeting on the 20th to talk about stuff like this. On Wed, Mar 6, 2019 at 12:40 PM Stavros Kontopoulos < stavros.kontopou...@lightbend.com> wrote: > Yes its a touch decision and as we discussed today ( >

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-06 Thread Stavros Kontopoulos
Yes its a touch decision and as we discussed today ( https://docs.google.com/document/d/1pnF38NF6N5eM8DlK088XUW85Vms4V2uTsGZvSp8MNIA ) "Kubernetes support window is 9 months, Spark is two years". So we may end up with old client versions on branches still supported like 2.4.x in the future. That

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-06 Thread Sean Owen
If the old client is basically unusable with the versions of K8S people mostly use now, and the new client still works with older versions, I could see including this in 2.4.1. Looking at https://github.com/fabric8io/kubernetes-client#compatibility-matrix it seems like the 4.1.1 client is needed

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-06 Thread Stavros Kontopoulos
Yes Shane Knapp has done the work for that already, and also tests pass, I am working on a PR now, I could submit it for the 2.4 branch . I understand that this is a major dependency update, but the problem I see is that the client version is so old that I dont think it makes much sense for

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-06 Thread shane knapp
On Wed, Mar 6, 2019 at 7:17 AM Sean Owen wrote: > The problem is that that's a major dependency upgrade in a maintenance > release. It didn't seem to work when we applied it to master. I don't > think it would block a release. > > i tested the k8s client 4.1.2 against master a couple of weeks

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-06 Thread Sean Owen
The problem is that that's a major dependency upgrade in a maintenance release. It didn't seem to work when we applied it to master. I don't think it would block a release. On Wed, Mar 6, 2019 at 6:32 AM Stavros Kontopoulos wrote: > > We need to resolve this

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-06 Thread Stavros Kontopoulos
> > From: Felix Cheung >> > Sent: Wednesday, February 20, 2019 9:34 PM >> > To: DB Tsai; Spark dev list >> > Cc: Cesar Delgado >> > Subject: Re: [VOTE] Release Apache Spark 2.4.1 (RC2) >> > >> > Could you hold for a bit - I have one more fix

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-03-05 Thread Saisai Shao
> Sent: Wednesday, February 20, 2019 9:34 PM > > To: DB Tsai; Spark dev list > > Cc: Cesar Delgado > > Subject: Re: [VOTE] Release Apache Spark 2.4.1 (RC2) > > > > Could you hold for a bit - I have one more fix to get in > > > > > > __

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-02-21 Thread DB Tsai
to 2.4. > > > > From: Felix Cheung > Sent: Wednesday, February 20, 2019 9:34 PM > To: DB Tsai; Spark dev list > Cc: Cesar Delgado > Subject: Re: [VOTE] Release Apache Spark 2.4.1 (RC2) > > Could you hold for a bit - I have one more fix to get in > > >

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-02-21 Thread Felix Cheung
I merged the fix to 2.4. From: Felix Cheung Sent: Wednesday, February 20, 2019 9:34 PM To: DB Tsai; Spark dev list Cc: Cesar Delgado Subject: Re: [VOTE] Release Apache Spark 2.4.1 (RC2) Could you hold for a bit - I have one more fix to get

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-02-21 Thread Sean Owen
> wrote: >> >> Could you hold for a bit - I have one more fix to get in >> >> >> >> From: d_t...@apple.com on behalf of DB Tsai >> Sent: Wednesday, February 20, 2019 12:25 PM >> To: Spark dev list >> Cc

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-02-21 Thread Parth Gandhi
B Tsai > *Sent:* Wednesday, February 20, 2019 12:25 PM > *To:* Spark dev list > *Cc:* Cesar Delgado > *Subject:* Re: [VOTE] Release Apache Spark 2.4.1 (RC2) > > Okay. Let's fail rc2, and I'll prepare rc3 with SPARK-26859. > > DB Tsai | Siri Open Source Technologies [not a contrib

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-02-20 Thread Felix Cheung
Could you hold for a bit - I have one more fix to get in From: d_t...@apple.com on behalf of DB Tsai Sent: Wednesday, February 20, 2019 12:25 PM To: Spark dev list Cc: Cesar Delgado Subject: Re: [VOTE] Release Apache Spark 2.4.1 (RC2) Okay. Let's fail rc2

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-02-20 Thread DB Tsai
Okay. Let's fail rc2, and I'll prepare rc3 with SPARK-26859. DB Tsai | Siri Open Source Technologies [not a contribution] |  Apple, Inc > On Feb 20, 2019, at 12:11 PM, Marcelo Vanzin > wrote: > > Just wanted to point out that > https://issues.apache.org/jira/browse/SPARK-26859 is not in

Re: [VOTE] Release Apache Spark 2.4.1 (RC2)

2019-02-20 Thread Marcelo Vanzin
Just wanted to point out that https://issues.apache.org/jira/browse/SPARK-26859 is not in this RC, and is marked as a correctness bug. (The fix is in the 2.4 branch, just not in rc2.) On Wed, Feb 20, 2019 at 12:07 PM DB Tsai wrote: > > Please vote on releasing the following candidate as Apache

[VOTE] Release Apache Spark 2.4.1 (RC2)

2019-02-20 Thread DB Tsai
Please vote on releasing the following candidate as Apache Spark version 2.4.1. The vote is open until Feb 24 PST and passes if a majority +1 PMC votes are cast, with a minimum of 3 +1 votes. [ ] +1 Release this package as Apache Spark 2.4.1 [ ] -1 Do not release this package because ... To