> In general a test should be self descriptive and I don't think we should
be adding JIRA ticket references wholesale. Any action that the reader has
to take to understand why a test was introduced is one too many. However in
some cases the thing we are trying to test is very subtle and in that
thx as always, Shane!
On Wed, Nov 13, 2019 at 3:25 AM Shane Knapp wrote:
> it's coming back up now.
>
> --
> Shane Knapp
> UC Berkeley EECS Research / RISELab Staff Technical Lead
> https://rise.cs.berkeley.edu
>
> -
> To
Let's suggest "SPARK-12345:" but not go back and change a bunch of test cases.
I'd add this only when a test specifically targets a certain issue.
It's a nice-to-have, not super essential, just because in the rare
case you need to understand why a test asserts something, you can go
back and find
+1
Two confusions to clarify:
1. what if multiple JIRA IDs relating to the same test? we just take the
very first JIRA ID?
2. are we going to have a full scan of all existing tests and attach a JIRA
ID to it?
Thank you Hyukjin :)
On Tue, Nov 12, 2019 at 1:47 PM Dongjoon Hyun
wrote:
> Thank
Thank you for the suggestion, Hyukjin.
Previously, we added Jira IDs for the bug fix PR test cases as Gabor said.
For the new features (and improvements), we didn't add them
because all test cases in the newly added test suite share the same prefix
JIRA ID in that case.
It might looks
Oops, sorry about the typo there; I’ll correct that.
> On Nov 12, 2019, at 12:43 AM, ruifengz wrote:
>
> nit: Ruifeng Zhang as committers in the past three months. <- Ruifeng Zheng
>
> ☺Thanks
>
> On 11/12/19 3:54 PM, Matei Zaharia wrote:
>> Good catch, thanks.
>>
>>> On Nov 11, 2019, at
it's coming back up now.
--
Shane Knapp
UC Berkeley EECS Research / RISELab Staff Technical Lead
https://rise.cs.berkeley.edu
-
To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
+1 for having that consistent rule in test names.
+1 for making it a guideline.
+1 defining exact guides in general.
Until now I've followed the alternative (only add the prefix when the
JIRA's type is bug) and that way I knew that such tests contain edge cases.
In case of new features I'm pretty
nit: Ruifeng Zhang as committers in the past three months. <- Ruifeng Zheng
☺Thanks
On 11/12/19 3:54 PM, Matei Zaharia wrote:
Good catch, thanks.
On Nov 11, 2019, at 6:46 PM, Jungtaek Lim
mailto:kabhwan.opensou...@gmail.com>>
wrote:
nit: - The latest committer was added on Sept 4th, 2019
