Re: remove MarkupContainer.isTransparentResolver

2009-11-10 Thread Erik van Oosten
Can we not use just this TransparentMarkupContainer and add the atrtibutemodifiers to that component? Erik. Juergen Donnerstag wrote: Yes, it is trivial. Just copy the code from the TransparentMarkupContainer (still on my disk). As another option: In 1.5 we removed the final keyword from

Re: remove MarkupContainer.isTransparentResolver

2009-11-10 Thread Juergen Donnerstag
Yes, that should do as well Juergen On Tue, Nov 10, 2009 at 9:53 PM, Erik van Oosten e.vanoos...@grons.nl wrote: Can we not use just this TransparentMarkupContainer and add the atrtibutemodifiers to that component?   Erik. Juergen Donnerstag wrote: Yes, it is trivial. Just copy the code

Re: remove MarkupContainer.isTransparentResolver

2009-11-09 Thread Erik van Oosten
Ah yes, I do that as well. Regards, Erik. Olivier Croisier wrote: I use the same technique (WebMarkupContainer + isTransparentResolver=true) on the body element to add an id attribute to it, with a unique value for each page extending the base template. This is useful to build unique CSS

Re: remove MarkupContainer.isTransparentResolver

2009-11-09 Thread Igor Vaynberg
you guys can still do that by allowing your webmarkupcontainer to implement icomponentresolver instead of simply overriding istransparentresolver(true). the impl itself should be trivia, just check for the component in the page body. -igor On Mon, Nov 9, 2009 at 7:08 AM, Erik van Oosten

Re: remove MarkupContainer.isTransparentResolver

2009-11-08 Thread Erik van Oosten
This will break almost every project I have (in a trivial way), but if it will simplify the Wicket core you have my: +1 (non binding) Regards, Erik. Juergen Donnerstag wrote: Hi, MarkupContainer.isTransparentResolver() regularly is the root cause for some problems where users don't

Re: remove MarkupContainer.isTransparentResolver

2009-11-08 Thread Juergen Donnerstag
Hi Erik may I ask what you need it for in your project? Did you develop your own markup filter/resolver? Juergen

remove MarkupContainer.isTransparentResolver

2009-11-07 Thread Juergen Donnerstag
Hi, MarkupContainer.isTransparentResolver() regularly is the root cause for some problems where users don't fully understand the implications. It's main purpose is for auto-components which shall be hidden from the user. Unfortunately it is at a very prominent position and may be too easy to use.

Re: remove MarkupContainer.isTransparentResolver

2009-11-07 Thread Igor Vaynberg
+1 -igor On Sat, Nov 7, 2009 at 7:58 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: Hi, MarkupContainer.isTransparentResolver() regularly is the root cause for some problems where users don't fully understand the implications. It's main purpose is for auto-components which shall

Re: remove MarkupContainer.isTransparentResolver

2009-11-07 Thread James Carman
Sounds like a great opportunity to make things more intuitive and avoid confusion. +1 (non-binding) from me On Sat, Nov 7, 2009 at 1:03 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: +1 -igor On Sat, Nov 7, 2009 at 7:58 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: Hi,