Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-30 Thread Yu Li
*bq. no need to add anything into NOTICE* Correction: here we need to analyze the Spark NOTICE file and the relevant portions bubbled up into the top-level NOTICE file [1], as already pointed out by Justin in previous reply [2]. Best Regards, Yu [1]

Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-30 Thread Yu Li
Thanks for the further clarification Justin, it helps a lot. And thanks for correcting me. Now I understand that I should have referred to the 3rd-party section [1] instead. Explicitly, I think the action-to-do is to add (append) the below lines into the Celeborn LICENSE file [2] (similar to that

Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-30 Thread Justin Mclean
Hi, > *bq. It belongs in LICENSE not NOTICE only copyright notices that have been > removed (by or with the permission of the owner) get listed in NOTICE* > Since Guava is also with ALv2, referring to [1], my understanding is that: > 1. There should be no copyright notice in the header (#2) > 2.

Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-30 Thread Yu Li
l#headers > [2] > https://github.com/apache/spark/blob/master/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java > [3] > https://github.com/google/guava/blob/master/guava/src/com/google/common/io/ByteStreams.java#L706 > [4] https://infra.apach

Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-27 Thread Ethan Feng
Hi Justin, Thanks for your advice. We'll consult our mentors. This vote is closed. Thanks, Ethan Feng Justin Mclean 于2023年1月26日周四 06:29写道: > > Hi, > > I suggest you ask you mentors for help on this. > > > Thanks for your advice. We’ve checked the spark distribution > > package, and we

Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-25 Thread Justin Mclean
Hi, I suggest you ask you mentors for help on this. > Thanks for your advice. We’ve checked the spark distribution > package, and we figure out that there is no [3] related notice in > [1][2]. You still need to take the relevant parts from that NOTICE file and add it to yours. Please see [1]

Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-25 Thread Ethan Feng
Hi Justin, Thanks for your advice. We’ve checked the spark distribution package, and we figure out that there is no [3] related notice in [1][2]. Do we need to add the following text block to notice file in our source package according to [4]?

Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-25 Thread Justin Mclean
Hi, >1. [1] is copied and modified from Apache spark[2], we didn't > modify the headers. Apache Spark has a NOTICE file, you’ll need to work out what parts need to be added to your NOTICE file. Kind Regards, Justin - To

Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-24 Thread Ethan Feng
Hi Justin, Thanks for your review, we'll fix the problems you mentioned. Following are our solutions, if anything is wrong please let us know. 1. [1] is copied and modified from Apache spark[2], we didn't modify the headers. We'll add this information to the LICENSE file in the source

Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-23 Thread Justin Mclean
HI, Sorry it’s -1 (binding) form me as it contain 3rd party code that is not mentioned in LICENSE. I checked: - incubating in name - signatures and hashes are file - LICENSE is missing license for 3rd party code [1] (this file probably incorrect has an ASF header as well) [2]. Is there any

[VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3

2023-01-21 Thread Ethan Feng
Hello Incubator Community, This is a call for a vote to release Apache Celeborn(Incubating) version 0.2.0-incubating-rc3 The Apache Celeborn community has voted on and approved a proposal to release Apache Celeborn(Incubating) version 0.2.0-incubating-rc3 We now kindly request the Incubator PMC