[GitHub] flink pull request #4669: [FLINK-7618][table] Add BINARY supported in FlinkT...

2017-09-14 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/4669 [FLINK-7618][table] Add BINARY supported in FlinkTypeFactory ## What is the purpose of the change *Add BINARY supported in FlinkTypeFactory* ## Brief change log -

[GitHub] flink pull request #4597: [FLINK-7527] [rest] Let AbstractRestHandler extend...

2017-09-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4597#discussion_r138845374 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RedirectHandler.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink issue #3816: [FLINK-5720] Deprecate DataStream#fold()

2017-09-14 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3816 Hi @iduanyingjie, the replacement for fold has not been implemented yet. So you have to stick with `fold()` for now. `fold`'s replacement will correspond to

[jira] [Commented] (FLINK-5720) Deprecate "Folding" in all of DataStream API

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166024#comment-16166024 ] ASF GitHub Bot commented on FLINK-5720: --- Github user fhueske commented on the issue:

[GitHub] flink pull request #:

2017-09-14 Thread taizilongxu
Github user taizilongxu commented on the pull request: https://github.com/apache/flink/commit/2437da6e54cb48c4e29116b8789fbe4782b17ea7#commitcomment-24300072 In docs/dev/connectors/elasticsearch.md: In docs/dev/connectors/elasticsearch.md on line 358: I thinks the code is

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165979#comment-16165979 ] Jingsong Lee commented on FLINK-7617: - [~XKing] Good suggestion, this method is useful. But I think

[jira] [Commented] (FLINK-7614) Add a code snippet example of a valid POJO to "Data Types" documentation

2017-09-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165938#comment-16165938 ] Timo Walther commented on FLINK-7614: - I will work on improving the data types documentation soon. >

[jira] [Assigned] (FLINK-7614) Add a code snippet example of a valid POJO to "Data Types" documentation

2017-09-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-7614: --- Assignee: Timo Walther > Add a code snippet example of a valid POJO to "Data Types"

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-14 Thread uybhatti
GitHub user uybhatti opened a pull request: https://github.com/apache/flink/pull/4670 [FLINK-2170] [connectors] Add ORC connector for TableSource ## What is the purpose of the change Currently, we can't read data from ORC files. In this PR, we added the support to load data

[jira] [Commented] (FLINK-7527) Add redirection logic to AbstractRestHandler

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166032#comment-16166032 ] ASF GitHub Bot commented on FLINK-7527: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7508) switch FlinkKinesisProducer to use KPL's ThreadingMode to ThreadedPool mode rather than Per_Request mode

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165975#comment-16165975 ] ASF GitHub Bot commented on FLINK-7508: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #4656: [FLINK-7508][kinesis] switch FlinkKinesisProducer ...

2017-09-14 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4656#discussion_r138837100 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -171,8

[jira] [Commented] (FLINK-7508) switch FlinkKinesisProducer to use KPL's ThreadingMode to ThreadedPool mode rather than Per_Request mode

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165976#comment-16165976 ] ASF GitHub Bot commented on FLINK-7508: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-7618) Add BINARY supported in FlinkTypeFactory

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166000#comment-16166000 ] ASF GitHub Bot commented on FLINK-7618: --- GitHub user sunjincheng121 opened a pull request:

[jira] [Commented] (FLINK-2170) Add OrcTableSource

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166005#comment-16166005 ] ASF GitHub Bot commented on FLINK-2170: --- GitHub user uybhatti opened a pull request:

[GitHub] flink pull request #3860: [FLINK-6516] [table] using real row count instead ...

2017-09-14 Thread godfreyhe
Github user godfreyhe commented on a diff in the pull request: https://github.com/apache/flink/pull/3860#discussion_r138843966 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/PhysicalTableSourceScan.scala --- @@ -70,4 +73,18 @@ abstract

[jira] [Commented] (FLINK-7619) Improve abstraction in AbstractAsyncIOCallable to better fit

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166018#comment-16166018 ] ASF GitHub Bot commented on FLINK-7619: --- Github user StefanRRichter commented on the issue:

[GitHub] flink pull request #4671: [FLINK-7619] Improve abstraction in AbstractAsyncI...

2017-09-14 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/4671 [FLINK-7619] Improve abstraction in AbstractAsyncIOCallable to better fit ## What is the purpose of the change This PR improves the abstractions around resource management for async

[GitHub] flink issue #4671: [FLINK-7619] Improve abstraction in AbstractAsyncIOCallab...

2017-09-14 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4671 CC @aljoscha ---

[jira] [Assigned] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-14 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-7446: Assignee: Fabian Hueske > Support to define an existing field as the rowtime field for

[jira] [Created] (FLINK-7619) Improve abstraction in AbstractAsyncIOCallable to better fit

2017-09-14 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-7619: - Summary: Improve abstraction in AbstractAsyncIOCallable to better fit Key: FLINK-7619 URL: https://issues.apache.org/jira/browse/FLINK-7619 Project: Flink

[jira] [Commented] (FLINK-6516) using real row count instead of dummy row count when optimizing plan

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166006#comment-16166006 ] ASF GitHub Bot commented on FLINK-6516: --- Github user godfreyhe commented on a diff in the pull

[jira] [Created] (FLINK-7618) Add BINARY supported in FlinkTypeFactory

2017-09-14 Thread sunjincheng (JIRA)
sunjincheng created FLINK-7618: -- Summary: Add BINARY supported in FlinkTypeFactory Key: FLINK-7618 URL: https://issues.apache.org/jira/browse/FLINK-7618 Project: Flink Issue Type: Bug

[GitHub] flink pull request #4656: [FLINK-7508][kinesis] switch FlinkKinesisProducer ...

2017-09-14 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4656#discussion_r138836822 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtilTest.java --- @@

[jira] [Commented] (FLINK-7294) mesos.resourcemanager.framework.role not working

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165987#comment-16165987 ] ASF GitHub Bot commented on FLINK-7294: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4622: [FLINK-7294]:[flink-mesos] mesos.resourcemanager.framewor...

2017-09-14 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4622 Thanks for the contribution @bbayani and the review @EronWright. Changes look good to me. Will merge the fix and backport it to the `1.3` release branch. ---

[jira] [Commented] (FLINK-7615) Under mesos when using a role, TaskManagers fail to schedule

2017-09-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165985#comment-16165985 ] Till Rohrmann commented on FLINK-7615: -- Thanks for reporting the issue [~addis...@gmail.com]. Will

[jira] [Commented] (FLINK-7527) Add redirection logic to AbstractRestHandler

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166015#comment-16166015 ] ASF GitHub Bot commented on FLINK-7527: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7619) Improve abstraction in AbstractAsyncIOCallable to better fit

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166017#comment-16166017 ] ASF GitHub Bot commented on FLINK-7619: --- GitHub user StefanRRichter opened a pull request:

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread Jin Xiaojun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165962#comment-16165962 ] Jin Xiaojun commented on FLINK-7617: hi, [~lzljs3620320], I think a better is to call

[GitHub] flink pull request #4597: [FLINK-7527] [rest] Let AbstractRestHandler extend...

2017-09-14 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4597#discussion_r138849512 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RedirectHandler.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7561) Add support for pre-aggregation in DataStream API

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165875#comment-16165875 ] ASF GitHub Bot commented on FLINK-7561: --- Github user pnowojski commented on the issue:

[GitHub] flink issue #4626: [FLINK-7561][streaming] Implement PreAggregationOperator

2017-09-14 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4626 @mproch you might be interested in this one :) ---

[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

2017-09-14 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/4668 Thanks @JingsongLi for your contribution LGTM, +1 to merge cc @fhueske @StephanEwen ---

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165952#comment-16165952 ] ASF GitHub Bot commented on FLINK-7617: --- Github user KurtYoung commented on the issue:

[jira] [Updated] (FLINK-7620) Supports user defined optimization phase

2017-09-14 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-7620: -- Summary: Supports user defined optimization phase (was: Supports custom optimization phase) >

[GitHub] flink pull request #4668: [FLINK-7617] Remove string format in BitSet to imp...

2017-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4668 ---

[GitHub] flink issue #4669: [FLINK-7618][table] Add BINARY supported in FlinkTypeFact...

2017-09-14 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4669 Thanks @sunjincheng121 but we cannot merge this without tests. Adding a new type should have some tests esp. because you have to add this type at different positions. E.g. `FlinkRelNode` and in the

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166291#comment-16166291 ] ASF GitHub Bot commented on FLINK-7617: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-2733) ZooKeeperLeaderElectionTest.testZooKeeperReelection fails

2017-09-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-2733. Resolution: Not A Problem > ZooKeeperLeaderElectionTest.testZooKeeperReelection fails >

[jira] [Commented] (FLINK-2733) ZooKeeperLeaderElectionTest.testZooKeeperReelection fails

2017-09-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166301#comment-16166301 ] Till Rohrmann commented on FLINK-2733: -- I think [~tonycox], you actually did not use the fixed code

[jira] [Updated] (FLINK-7608) LatencyGauge change to histogram metric

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7608: Priority: Blocker (was: Major) > LatencyGauge change to histogram metric >

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166327#comment-16166327 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166329#comment-16166329 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166322#comment-16166322 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166323#comment-16166323 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166324#comment-16166324 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

2017-09-14 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r138891582 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java --- @@ -172,44 +178,117 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

2017-09-14 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r138889161 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java --- @@ -172,44 +178,117 @@ public void

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

2017-09-14 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r13882 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java --- @@ -172,44 +178,117 @@ public void

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166331#comment-16166331 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166330#comment-16166330 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166326#comment-16166326 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166325#comment-16166325 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166328#comment-16166328 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-14 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138905728 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java --- @@ -218,7 +221,7 @@ public long addRecord(T

[jira] [Assigned] (FLINK-4796) Add new Sink interface with access to more meta data

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-4796: --- Assignee: Aljoscha Krettek > Add new Sink interface with access to more meta data >

[jira] [Closed] (FLINK-4796) Add new Sink interface with access to more meta data

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-4796. --- Resolution: Duplicate > Add new Sink interface with access to more meta data >

[jira] [Comment Edited] (FLINK-7294) mesos.resourcemanager.framework.role not working

2017-09-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166202#comment-16166202 ] Till Rohrmann edited comment on FLINK-7294 at 9/14/17 12:55 PM: 1.4.0:

[jira] [Commented] (FLINK-7624) Add kafka-topic for "KafkaProducer" metrics

2017-09-14 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166204#comment-16166204 ] Tzu-Li (Gordon) Tai commented on FLINK-7624: I think changing an existing metric name would in

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-14 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r138889015 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -211,6 +218,14 @@ class

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-14 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r13586 --- Diff: flink-core/pom.xml --- @@ -80,6 +80,13 @@ under the License. + +

[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...

2017-09-14 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4655 You can try and run the build locally to have a look at the file generated by the compatibility plugin. Then we can figure out why it's complaining. ---

[jira] [Created] (FLINK-7621) Fix inconsistency of CaseSensitive Configuration

2017-09-14 Thread Ruidong Li (JIRA)
Ruidong Li created FLINK-7621: - Summary: Fix inconsistency of CaseSensitive Configuration Key: FLINK-7621 URL: https://issues.apache.org/jira/browse/FLINK-7621 Project: Flink Issue Type: Bug

[GitHub] flink pull request #4668: [FLINK-7617] Remove string format in BitSet to imp...

2017-09-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4668#discussion_r138876371 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java --- @@ -56,8 +56,7 @@ public void setMemorySegment(MemorySegment

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166161#comment-16166161 ] ASF GitHub Bot commented on FLINK-7617: --- Github user fhueske commented on a diff in the pull

[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

2017-09-14 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4668 +1 to merge this ---

[GitHub] flink pull request #4672: Flink 7621

2017-09-14 Thread Xpray
GitHub user Xpray opened a pull request: https://github.com/apache/flink/pull/4672 Flink 7621 *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way,

[jira] [Updated] (FLINK-7622) Respect local KPL queue size in FlinkKinesisProducer when adding records to KPL client

2017-09-14 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-7622: --- Description: This issue was brought to discussion by [~sthm] offline. Currently,

[GitHub] flink issue #4672: [Flink-7621][TableAPI & SQL] Fix Inconsistency of CaseSen...

2017-09-14 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4672 Thanks @Xpray. The changes look good, but I think if we would really want to have the correct behavior, we need to make more changes at different positions. Could you add some more tests to check

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-14 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138899420 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java --- @@ -218,7 +221,7 @@ public long addRecord(T

[jira] [Assigned] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-7617: --- Assignee: Jingsong Lee > Remove string format in BitSet to improve the performance

[GitHub] flink issue #4668: [FLINK-7617] Remove string format in BitSet to improve th...

2017-09-14 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4668 Hi @KurtYoung, do you want to merge this to the `release-1.3` branch as well? ---

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166387#comment-16166387 ] Aljoscha Krettek commented on FLINK-2646: - I thought about this and the new

[jira] [Updated] (FLINK-7620) Supports custom optimization phase

2017-09-14 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-7620: -- Issue Type: Improvement (was: Bug) > Supports custom optimization phase >

[jira] [Created] (FLINK-7620) Supports custom optimization phase

2017-09-14 Thread godfrey he (JIRA)
godfrey he created FLINK-7620: - Summary: Supports custom optimization phase Key: FLINK-7620 URL: https://issues.apache.org/jira/browse/FLINK-7620 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-7624) Add kafka-topic for "KafkaProducer" metrics

2017-09-14 Thread Hai Zhou (JIRA)
Hai Zhou created FLINK-7624: --- Summary: Add kafka-topic for "KafkaProducer" metrics Key: FLINK-7624 URL: https://issues.apache.org/jira/browse/FLINK-7624 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-7618) Add BINARY supported in FlinkTypeFactory

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166294#comment-16166294 ] ASF GitHub Bot commented on FLINK-7618: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-7606) CEP operator leaks state

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166340#comment-16166340 ] Aljoscha Krettek commented on FLINK-7606: - Will NFAs not be cleared when the allowed "within" time

[jira] [Commented] (FLINK-7589) org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 159764230; received: 64638536)

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166370#comment-16166370 ] Aljoscha Krettek commented on FLINK-7589: - Yes, I think we cannot do much except wait here.

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166369#comment-16166369 ] ASF GitHub Bot commented on FLINK-7617: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-4796) Add new Sink interface with access to more meta data

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166391#comment-16166391 ] Aljoscha Krettek commented on FLINK-4796: - Sorry, I didn't get what this workaround is for. Could

[jira] [Updated] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7623: Attachment: StreamingJob.java Attached example code. > Detecting whether an operator is

[jira] [Resolved] (FLINK-7294) mesos.resourcemanager.framework.role not working

2017-09-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7294. -- Resolution: Fixed Fix Version/s: 1.3.3 1.4.0 1.4.0:

[jira] [Closed] (FLINK-6331) StreamingOperatorsITCase.testAsyncWaitOperator spuriously failing on Travis

2017-09-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-6331. Resolution: Cannot Reproduce Could not reproduce the problem. Will close the issue therefore. If

[jira] [Closed] (FLINK-5205) Asynchronous remove job messages can interfere with recovered or resubmitted jobs

2017-09-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-5205. Resolution: Won't Fix Seems not to be a problem and with the Flip-6 changes obsolete. >

[jira] [Commented] (FLINK-7590) Flink failed to flush and close the file system output stream for checkpointing because of s3 read timeout

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166333#comment-16166333 ] Aljoscha Krettek commented on FLINK-7590: - Agreed! > Flink failed to flush and close the file

[jira] [Updated] (FLINK-7606) CEP operator leaks state

2017-09-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7606: Summary: CEP operator leaks state (was: Memory leak on NestedMapsStateTable) > CEP

[jira] [Commented] (FLINK-7567) DataStream#iterate() on env.fromElements() / env.fromCollection() does not work

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166365#comment-16166365 ] ASF GitHub Bot commented on FLINK-7567: --- Github user aljoscha commented on the issue:

[jira] [Created] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-09-14 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-7623: --- Summary: Detecting whether an operator is restored doesn't work with chained state Key: FLINK-7623 URL: https://issues.apache.org/jira/browse/FLINK-7623

[jira] [Commented] (FLINK-5098) Detect network problems to eagerly time out ask operations

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166216#comment-16166216 ] ASF GitHub Bot commented on FLINK-5098: --- Github user tillrohrmann closed the pull request at:

[GitHub] flink pull request #2830: [FLINK-5098] [akka] Detect unreachable remote acto...

2017-09-14 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/2830 ---

[jira] [Created] (FLINK-7625) typo in docs metrics sections

2017-09-14 Thread Hai Zhou (JIRA)
Hai Zhou created FLINK-7625: --- Summary: typo in docs metrics sections Key: FLINK-7625 URL: https://issues.apache.org/jira/browse/FLINK-7625 Project: Flink Issue Type: Bug Components:

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-14 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138904204 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java --- @@ -115,6 +115,13 @@ public Configuration

[GitHub] flink pull request #4659: [FLINK-4047] Fix documentation about determinism o...

2017-09-14 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4659#discussion_r138918167 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/functions/KeySelector.java --- @@ -36,7 +37,7 @@ public interface KeySelector

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166162#comment-16166162 ] ASF GitHub Bot commented on FLINK-7617: --- Github user fhueske commented on the issue:

[jira] [Closed] (FLINK-5098) Detect network problems to eagerly time out ask operations

2017-09-14 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-5098. Resolution: Won't Fix Fix Version/s: (was: 1.4.0) No longer relevant. > Detect network

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166289#comment-16166289 ] ASF GitHub Bot commented on FLINK-7491: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166288#comment-16166288 ] ASF GitHub Bot commented on FLINK-7491: --- Github user twalthr commented on a diff in the pull

[jira] [Created] (FLINK-7626) Add some metric description about checkpoints

2017-09-14 Thread Hai Zhou (JIRA)
Hai Zhou created FLINK-7626: --- Summary: Add some metric description about checkpoints Key: FLINK-7626 URL: https://issues.apache.org/jira/browse/FLINK-7626 Project: Flink Issue Type: Bug

  1   2   >