[GitHub] [hbase] Apache-HBase commented on pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4274: URL: https://github.com/apache/hbase/pull/4274#issuecomment-1079607318 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4278: HBASE-26882 Backport "HBASE-26810 Add dynamic configuration support f…

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4278: URL: https://github.com/apache/hbase/pull/4278#issuecomment-1079606876 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4180: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4180: URL: https://github.com/apache/hbase/pull/4180#issuecomment-1079604043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] d-c-manning commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
d-c-manning commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r835710881 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java ## @@ -488,26 +488,46 @@ private static boolean

[GitHub] [hbase] Apache-HBase commented on pull request #4180: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4180: URL: https://github.com/apache/hbase/pull/4180#issuecomment-1079588998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on a change in pull request #4275: HBASE-26884 Find unavailable regions by the startcode checking on hma…

2022-03-25 Thread GitBox
bsglz commented on a change in pull request #4275: URL: https://github.com/apache/hbase/pull/4275#discussion_r835692747 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -1696,7 +1696,29 @@ public void

[jira] [Commented] (HBASE-26810) Add dynamic configuration support for system coprocessors

2022-03-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512649#comment-17512649 ] Hudson commented on HBASE-26810: Results for branch master [build #549 on

[GitHub] [hbase] Apache-HBase commented on pull request #4180: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4180: URL: https://github.com/apache/hbase/pull/4180#issuecomment-1079545782 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4278: HBASE-26882 Backport "HBASE-26810 Add dynamic configuration support f…

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4278: URL: https://github.com/apache/hbase/pull/4278#issuecomment-1079545105 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4273: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4273: URL: https://github.com/apache/hbase/pull/4273#issuecomment-1079530431 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4277: HBASE-26886 Add unit test for custom RpcControllerFactory ability to overwrite priorities

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4277: URL: https://github.com/apache/hbase/pull/4277#issuecomment-1079516968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26876) Use toStringBinary for rowkey in RegionServerCallable error string

2022-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512623#comment-17512623 ] Bryan Beaudreault commented on HBASE-26876: --- Thanks [~Xiaolin Ha]! > Use toStringBinary for

[GitHub] [hbase] Apache-HBase commented on pull request #4273: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4273: URL: https://github.com/apache/hbase/pull/4273#issuecomment-1079506216 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] sunhelly commented on a change in pull request #4275: HBASE-26884 Find unavailable regions by the startcode checking on hma…

2022-03-25 Thread GitBox
sunhelly commented on a change in pull request #4275: URL: https://github.com/apache/hbase/pull/4275#discussion_r835659279 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -1696,7 +1696,29 @@ public void

[jira] [Updated] (HBASE-26876) Use toStringBinary for rowkey in RegionServerCallable error string

2022-03-25 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-26876: --- Resolution: Fixed Status: Resolved (was: Patch Available) Merged to branch-2.4+, thanks

[jira] [Updated] (HBASE-26876) Use toStringBinary for rowkey in RegionServerCallable error string

2022-03-25 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-26876: --- Fix Version/s: 2.5.0 2.6.0 2.4.12 > Use toStringBinary for

[jira] [Updated] (HBASE-26876) Use toStringBinary for rowkey in RegionServerCallable error string

2022-03-25 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-26876: --- Labels: (was: patch-available) > Use toStringBinary for rowkey in RegionServerCallable error

[GitHub] [hbase] sunhelly merged pull request #4269: HBASE-26876 Use toStringBinary for rowkey in RegionServerCallable error string

2022-03-25 Thread GitBox
sunhelly merged pull request #4269: URL: https://github.com/apache/hbase/pull/4269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] joshelser commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-25 Thread GitBox
joshelser commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r835650139 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -114,47 +107,42 @@ @Override protected void

[GitHub] [hbase] Apache-HBase commented on pull request #4277: HBASE-26886 Add unit test for custom RpcControllerFactory ability to overwrite priorities

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4277: URL: https://github.com/apache/hbase/pull/4277#issuecomment-1079491170 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] joshelser commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-25 Thread GitBox
joshelser commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r835648333 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache

[jira] [Updated] (HBASE-26667) Integrate user-experience for hbase-client

2022-03-25 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-26667: --- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [hbase] joshelser merged pull request #4064: HBASE-26667 Integrate user-experience for hbase-client

2022-03-25 Thread GitBox
joshelser merged pull request #4064: URL: https://github.com/apache/hbase/pull/4064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #4278: HBASE-26882 Backport "HBASE-26810 Add dynamic configuration support f…

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4278: URL: https://github.com/apache/hbase/pull/4278#issuecomment-1079480599 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wchevreuil commented on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-25 Thread GitBox
wchevreuil commented on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1079437545 I believe the latest test failure is unrelated, got it passing locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] taklwu commented on pull request #4278: HBASE-26882 Backport "HBASE-26810 Add dynamic configuration support f…

2022-03-25 Thread GitBox
taklwu commented on pull request #4278: URL: https://github.com/apache/hbase/pull/4278#issuecomment-1079428424 original commit for [HBASE-26810](https://github.com/apache/hbase/commit/4ac600b04b7537d1bb171ba1501ad845dbb37fdb) and

[GitHub] [hbase] taklwu opened a new pull request #4278: HBASE-26882 Backport "HBASE-26810 Add dynamic configuration support f…

2022-03-25 Thread GitBox
taklwu opened a new pull request #4278: URL: https://github.com/apache/hbase/pull/4278 …or system coprocessors" to branch-2 - Include HBASE-25288 that has the configuration manager registration in HMaster -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on pull request #4273: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4273: URL: https://github.com/apache/hbase/pull/4273#issuecomment-1079405694 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4277: HBASE-26886 Add unit test for custom RpcControllerFactory ability to overwrite priorities

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4277: URL: https://github.com/apache/hbase/pull/4277#issuecomment-1079401076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] bbeaudreault commented on pull request #4180: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
bbeaudreault commented on pull request #4180: URL: https://github.com/apache/hbase/pull/4180#issuecomment-1079399239 Great feedback @apurtell. I hadn't thought of it like that, I mostly considered ServerOverloaded to be a far better name than literally "cqtbe" :). Now that I think about

[jira] [Commented] (HBASE-26878) TableInputFormatBase should cache RegionSizeCalculator

2022-03-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512563#comment-17512563 ] Hudson commented on HBASE-26878: Results for branch branch-2.5 [build #76 on

[GitHub] [hbase] Apache-HBase commented on pull request #4273: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4273: URL: https://github.com/apache/hbase/pull/4273#issuecomment-1079365873 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Updated] (HBASE-26886) Add unit test for custom RpcControllerFactory's ability to overwrite priorities

2022-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-26886: -- Labels: patch-available (was: ) Status: Patch Available (was: Open) > Add unit

[GitHub] [hbase] bbeaudreault opened a new pull request #4277: HBASE-26886 Add unit test for custom RpcControllerFactory ability to overwrite priorities

2022-03-25 Thread GitBox
bbeaudreault opened a new pull request #4277: URL: https://github.com/apache/hbase/pull/4277 Simple test to give users peace of mind about the ability for their custom RpcControllerFactory to affect priorities. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HBASE-26878) TableInputFormatBase should cache RegionSizeCalculator

2022-03-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512534#comment-17512534 ] Hudson commented on HBASE-26878: Results for branch branch-2.4 [build #317 on

[jira] [Created] (HBASE-26886) Add unit test for custom RpcControllerFactory's ability to overwrite priorities

2022-03-25 Thread Bryan Beaudreault (Jira)
Bryan Beaudreault created HBASE-26886: - Summary: Add unit test for custom RpcControllerFactory's ability to overwrite priorities Key: HBASE-26886 URL: https://issues.apache.org/jira/browse/HBASE-26886

[GitHub] [hbase] Apache-HBase commented on pull request #4273: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4273: URL: https://github.com/apache/hbase/pull/4273#issuecomment-1079289443 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] huaxiangsun commented on pull request #4261: HBASE-26864 SplitTableRegionProcedure calls openParentRegions() at a …

2022-03-25 Thread GitBox
huaxiangsun commented on pull request #4261: URL: https://github.com/apache/hbase/pull/4261#issuecomment-1079265906 Ping @joshelser and @Apache9, any comments about the new diff? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] apurtell commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
apurtell commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r835476913 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java ## @@ -488,26 +488,46 @@ private static boolean

[GitHub] [hbase] apurtell commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
apurtell commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r835476913 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java ## @@ -488,26 +488,46 @@ private static boolean

[GitHub] [hbase] apurtell commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
apurtell commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r835476913 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java ## @@ -488,26 +488,46 @@ private static boolean

[GitHub] [hbase] apurtell commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
apurtell commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r835476913 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java ## @@ -488,26 +488,46 @@ private static boolean

[GitHub] [hbase] apurtell commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
apurtell commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r835476913 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java ## @@ -488,26 +488,46 @@ private static boolean

[GitHub] [hbase] apurtell commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
apurtell commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r835476913 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java ## @@ -488,26 +488,46 @@ private static boolean

[GitHub] [hbase] joshelser commented on pull request #4223: HBASE-26838 Junit jar is not included in the hbase tar ball, causing …

2022-03-25 Thread GitBox
joshelser commented on pull request #4223: URL: https://github.com/apache/hbase/pull/4223#issuecomment-1079236113 > what we need to do is restructure hbase-it so that the IntegrationTest jars are in src/main/java. > I don't mean to thrash things around. But I read through the

[jira] [Commented] (HBASE-26878) TableInputFormatBase should cache RegionSizeCalculator

2022-03-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512485#comment-17512485 ] Hudson commented on HBASE-26878: Results for branch branch-2 [build #498 on

[GitHub] [hbase] Apache-HBase commented on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1079216446 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on pull request #4180: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
apurtell commented on pull request #4180: URL: https://github.com/apache/hbase/pull/4180#issuecomment-1079217460 I have an objection as to the naming choice. Let's discuss that first. The bulk of the work seems great and I suspect we can incorporate it. > Creates a

[GitHub] [hbase] Apache-HBase commented on pull request #4276: HBASE-26885 The TRSP should not go on when it get a bogus server name…

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4276: URL: https://github.com/apache/hbase/pull/4276#issuecomment-1079214978 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[jira] [Commented] (HBASE-26880) Misspelling commands in hbase shell will crash the shell

2022-03-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512476#comment-17512476 ] Andrew Kyle Purtell commented on HBASE-26880: - Confirmed. We used to print help, and not

[jira] [Commented] (HBASE-26849) NPE caused by WAL Compression and Replication

2022-03-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512465#comment-17512465 ] Andrew Kyle Purtell commented on HBASE-26849: - bq. We might as well open another issue and

[jira] [Updated] (HBASE-26875) RpcRetryingCallerImpl translateException ignores return value of recursive call

2022-03-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26875: Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [hbase] apurtell closed pull request #4270: HBASE-26875 RpcRetryingCallerImpl translateException ignores return value of recursive call

2022-03-25 Thread GitBox
apurtell closed pull request #4270: URL: https://github.com/apache/hbase/pull/4270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-26875) RpcRetryingCallerImpl translateException ignores return value of recursive call

2022-03-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26875: Fix Version/s: 2.5.0 2.6.0 2.4.12

[GitHub] [hbase] apurtell commented on a change in pull request #4270: HBASE-26875 RpcRetryingCallerImpl translateException ignores return value of recursive call

2022-03-25 Thread GitBox
apurtell commented on a change in pull request #4270: URL: https://github.com/apache/hbase/pull/4270#discussion_r835410439 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java ## @@ -224,13 +224,12 @@ static Throwable

[GitHub] [hbase] apurtell commented on a change in pull request #4270: HBASE-26875 RpcRetryingCallerImpl translateException ignores return value of recursive call

2022-03-25 Thread GitBox
apurtell commented on a change in pull request #4270: URL: https://github.com/apache/hbase/pull/4270#discussion_r835408641 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java ## @@ -224,13 +224,12 @@ static Throwable

[jira] [Comment Edited] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512454#comment-17512454 ] Andrew Kyle Purtell edited comment on HBASE-26826 at 3/25/22, 3:57 PM:

[jira] [Comment Edited] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512454#comment-17512454 ] Andrew Kyle Purtell edited comment on HBASE-26826 at 3/25/22, 3:56 PM:

[jira] [Commented] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512454#comment-17512454 ] Andrew Kyle Purtell commented on HBASE-26826: - To fix a test issue [~wchevreuil] kindly

[GitHub] [hbase] Apache-HBase commented on pull request #4064: HBASE-26667 Integrate user-experience for hbase-client

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4064: URL: https://github.com/apache/hbase/pull/4064#issuecomment-1079155319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4064: HBASE-26667 Integrate user-experience for hbase-client

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4064: URL: https://github.com/apache/hbase/pull/4064#issuecomment-1079153953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-25 Thread GitBox
apurtell commented on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1079152290 Thanks so much for digging in on the TestHFileProcedurePrettyPrinter failure here @wchevreuil -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] apurtell edited a comment on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-25 Thread GitBox
apurtell edited a comment on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1079150863 HBASE-26881 has been cherry picked to the PR branch and the branch was rebased on branch-2.5 and force pushed just now as fb739b1ade. I read [this

[GitHub] [hbase] apurtell edited a comment on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-25 Thread GitBox
apurtell edited a comment on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1079150863 HBASE-26881 has been cherry picked to the PR branch and the branch was rebased on branch-2.5 and force pushed just now as fb739b1ade. I read [this

[GitHub] [hbase] Apache-HBase commented on pull request #4064: HBASE-26667 Integrate user-experience for hbase-client

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4064: URL: https://github.com/apache/hbase/pull/4064#issuecomment-1079146584 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] anmolnar commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-25 Thread GitBox
anmolnar commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r835327693 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -321,31 +320,39 @@ public void run(boolean cancelled)

[GitHub] [hbase] anmolnar commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-25 Thread GitBox
anmolnar commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r835325324 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -321,31 +320,39 @@ public void run(boolean cancelled)

[GitHub] [hbase] Apache-HBase commented on pull request #4180: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4180: URL: https://github.com/apache/hbase/pull/4180#issuecomment-1079081484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4275: HBASE-26884 Find unavailable regions by the startcode checking on hma…

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4275: URL: https://github.com/apache/hbase/pull/4275#issuecomment-1079010371 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #4276: HBASE-26885 The TRSP should not go on when it get a bogus server name…

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4276: URL: https://github.com/apache/hbase/pull/4276#issuecomment-1078984317 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bbeaudreault commented on pull request #4180: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
bbeaudreault commented on pull request #4180: URL: https://github.com/apache/hbase/pull/4180#issuecomment-1078974977 Trying to be thorough here -- I've been doing some testing of the new Configuration.addDeprecation. If we want to rely on the functionality it provides,unfortunately I

[GitHub] [hbase] wchevreuil commented on a change in pull request #4223: HBASE-26838 Junit jar is not included in the hbase tar ball, causing …

2022-03-25 Thread GitBox
wchevreuil commented on a change in pull request #4223: URL: https://github.com/apache/hbase/pull/4223#discussion_r835201843 ## File path: bin/hbase ## @@ -757,6 +757,13 @@ elif [ "$COMMAND" = "hbtop" ] ; then HBASE_OPTS="${HBASE_OPTS} ${HBASE_HBTOP_OPTS}" else

[GitHub] [hbase] bsglz opened a new pull request #4276: HBASE-26885 The TRSP should not go on when it get a bogus server name…

2022-03-25 Thread GitBox
bsglz opened a new pull request #4276: URL: https://github.com/apache/hbase/pull/4276 … from AM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (HBASE-26812) ShortCircuitingClusterConnection fails to close RegionScanners when making short-circuited calls

2022-03-25 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511247#comment-17511247 ] chenglei edited comment on HBASE-26812 at 3/25/22, 11:24 AM: - [~larsh],

[jira] [Created] (HBASE-26885) The TRSP should not go on when it get a bogus server name from AM

2022-03-25 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-26885: -- Summary: The TRSP should not go on when it get a bogus server name from AM Key: HBASE-26885 URL: https://issues.apache.org/jira/browse/HBASE-26885 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4274: URL: https://github.com/apache/hbase/pull/4274#issuecomment-1078899262 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] meszibalu commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-25 Thread GitBox
meszibalu commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r835140899 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -321,31 +320,39 @@ public void run(boolean cancelled)

[GitHub] [hbase] Apache-HBase commented on pull request #4275: HBASE-26884 Find unavailable regions by the startcode checking on hma…

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4275: URL: https://github.com/apache/hbase/pull/4275#issuecomment-1078885883 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil commented on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-25 Thread GitBox
wchevreuil commented on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1078863676 > > I had created #4267 PR for backporting [HBASE-25368](https://issues.apache.org/jira/browse/HBASE-25368) into branch-2. With those changes, the test is now passing. Let's

[jira] [Updated] (HBASE-26881) Backport HBASE-25368 to branch-2

2022-03-25 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-26881: - Fix Version/s: 2.6.0 > Backport HBASE-25368 to branch-2 >

[jira] [Resolved] (HBASE-26881) Backport HBASE-25368 to branch-2

2022-03-25 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-26881. -- Resolution: Fixed Merged to branch-2. Thanks for reviewing, [~apurtell] ! >

[GitHub] [hbase] wchevreuil merged pull request #4267: HBASE-26881 Backport HBASE-25368 to branch-2

2022-03-25 Thread GitBox
wchevreuil merged pull request #4267: URL: https://github.com/apache/hbase/pull/4267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] bsglz opened a new pull request #4275: HBASE-26884 Find unavailable regions by the startcode checking on hma…

2022-03-25 Thread GitBox
bsglz opened a new pull request #4275: URL: https://github.com/apache/hbase/pull/4275 …ster start up and reassign them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (HBASE-26884) Find unavailable regions by the startcode checking on hmaster start up and reassign them

2022-03-25 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-26884: -- Summary: Find unavailable regions by the startcode checking on hmaster start up and reassign them Key: HBASE-26884 URL: https://issues.apache.org/jira/browse/HBASE-26884

[jira] [Commented] (HBASE-26175) MetricsHBaseServer should record all kinds of Exceptions

2022-03-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512252#comment-17512252 ] Hudson commented on HBASE-26175: Results for branch branch-2.5 [build #75 on

[jira] [Commented] (HBASE-26175) MetricsHBaseServer should record all kinds of Exceptions

2022-03-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512235#comment-17512235 ] Hudson commented on HBASE-26175: Results for branch branch-2.4 [build #316 on

[jira] [Commented] (HBASE-26175) MetricsHBaseServer should record all kinds of Exceptions

2022-03-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512233#comment-17512233 ] Hudson commented on HBASE-26175: Results for branch branch-2 [build #497 on

[jira] [Commented] (HBASE-21065) Try ROW_INDEX_V1 encoding on meta table (fix bloomfilters on meta while we are at it)

2022-03-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512232#comment-17512232 ] Hudson commented on HBASE-21065: Results for branch branch-2 [build #497 on

[GitHub] [hbase] Apache-HBase commented on pull request #4253: HBASE-26872 Load rate calculator for cost functions should be more precise

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4253: URL: https://github.com/apache/hbase/pull/4253#issuecomment-1078734041 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4253: HBASE-26872 Load rate calculator for cost functions should be more precise

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4253: URL: https://github.com/apache/hbase/pull/4253#issuecomment-1078731637 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4253: HBASE-26872 Load rate calculator for cost functions should be more precise

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4253: URL: https://github.com/apache/hbase/pull/4253#issuecomment-1078727421 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4274: URL: https://github.com/apache/hbase/pull/4274#issuecomment-1078726060 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sunhelly commented on a change in pull request #4253: HBASE-26872 Load rate calculator for cost functions should be more precise

2022-03-25 Thread GitBox
sunhelly commented on a change in pull request #4253: URL: https://github.com/apache/hbase/pull/4253#discussion_r834993243 ## File path: hbase-balancer/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java ## @@ -519,6 +517,31 @@ public void

[jira] [Updated] (HBASE-26718) HFileArchiver can remove referenced StoreFiles from the archive

2022-03-25 Thread David Manning (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Manning updated HBASE-26718: -- Status: Patch Available (was: Open) > HFileArchiver can remove referenced StoreFiles from

[GitHub] [hbase] d-c-manning commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
d-c-manning commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r834989985 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java ## @@ -185,11 +215,30 @@ private void

[GitHub] [hbase] d-c-manning commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
d-c-manning commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r834989985 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java ## @@ -185,11 +215,30 @@ private void

[GitHub] [hbase] d-c-manning commented on a change in pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
d-c-manning commented on a change in pull request #4274: URL: https://github.com/apache/hbase/pull/4274#discussion_r834989985 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java ## @@ -185,11 +215,30 @@ private void

[GitHub] [hbase] d-c-manning opened a new pull request #4274: fix for HBASE-26718

2022-03-25 Thread GitBox
d-c-manning opened a new pull request #4274: URL: https://github.com/apache/hbase/pull/4274 [HBASE-26718](https://issues.apache.org/jira/browse/HBASE-26718) Of particular note: 1. The tests as they exist today are not validating a rename into archive, but instead validating a

[GitHub] [hbase] Apache-HBase commented on pull request #4273: HBASE-26807 Unify CallQueueTooBigException special pause with CallDroppedException

2022-03-25 Thread GitBox
Apache-HBase commented on pull request #4273: URL: https://github.com/apache/hbase/pull/4273#issuecomment-1078694558 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m