Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595963491 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

junrao commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595923193 ## raft/src/main/java/org/apache/kafka/raft/internals/TreeMapLogHistory.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

junrao commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595922267 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595916951 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSetHistory.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595915596 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java: ## @@ -728,83 +730,114 @@ public static MemoryRecords withLeaderChangeMessage(

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595916619 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595916355 ## raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java: ## @@ -245,6 +255,42 @@ private void appendControlMessage(Function valueCreat }

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595916070 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -370,8 +368,52 @@ private void maybeFireLeaderChange() { } } -@Override -

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595915829 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1470,6 +1524,10 @@ private boolean handleFetchSnapshotResponse(

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595910078 ## raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotReader.java: ## @@ -145,9 +147,7 @@ private Optional> nextBatch() { ); }

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595898159 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1595871101 ## raft/src/main/java/org/apache/kafka/raft/internals/TreeMapLogHistory.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

junrao commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1589798416 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio merged PR #15671: URL: https://github.com/apache/kafka/pull/15671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1589681992 ## raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotWriter.java: ## @@ -216,4 +140,132 @@ private void appendBatches(List> batches) {

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

hachikuji commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1589667403 ## raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotWriter.java: ## @@ -216,4 +140,132 @@ private void appendBatches(List> batches) {

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

junrao commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1588223773 ## clients/src/main/resources/common/message/VotersRecord.json: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

junrao commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1588223773 ## clients/src/main/resources/common/message/VotersRecord.json: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586871366 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2415,17 +2476,30 @@ public void resign(int epoch) { @Override public Optional>

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586869606 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -370,8 +363,52 @@ private void maybeFireLeaderChange() { } } -@Override -

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586867970 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -370,8 +363,52 @@ private void maybeFireLeaderChange() { } } -@Override -

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586861717 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -159,67 +165,76 @@ public class KafkaRaftClient implements RaftClient { private final

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586860365 ## raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java: ## @@ -213,20 +213,21 @@ private void completeCurrentBatch() { * * @param

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586828276 ## raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java: ## @@ -206,8 +151,16 @@ private static Integer parseVoterId(String idString) { } } -

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586825107 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -181,20 +181,12 @@ class KafkaRaftManager[T]( private val clientDriver = new

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586802072 ## raft/src/main/java/org/apache/kafka/raft/internals/History.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586782977 ## raft/src/test/java/org/apache/kafka/raft/internals/VoterSetHistoryTest.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586765460 ## raft/src/test/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachineTest.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586760874 ## raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotWriter.java: ## @@ -216,4 +140,132 @@ private void appendBatches(List> batches) {

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586731329 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586553978 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586526016 ## raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java: ## @@ -261,7 +260,7 @@ default long truncateToEndOffset(OffsetAndEpoch endOffset) { * @param

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1586489784 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java: ## @@ -807,4 +809,62 @@ private static void writeSnapshotFooterRecord(

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1580155319 ## clients/src/main/java/org/apache/kafka/common/record/ControlRecordType.java: ## @@ -44,11 +44,15 @@ public enum ControlRecordType { ABORT((short) 0),

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

hachikuji commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1583487039 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -181,20 +181,12 @@ class KafkaRaftManager[T]( private val clientDriver = new

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

hachikuji commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1583479619 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java: ## @@ -807,4 +809,62 @@ private static void writeSnapshotFooterRecord(

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581912927 ## raft/src/main/java/org/apache/kafka/raft/internals/History.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581912871 ## raft/src/main/java/org/apache/kafka/raft/internals/History.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581912802 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581912784 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581912764 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java: ## @@ -807,4 +809,62 @@ private static void writeSnapshotFooterRecord(

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581912667 ## raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581912628 ## raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581908701 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSetHistory.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581907968 ## raft/src/main/java/org/apache/kafka/raft/internals/TreeMapHistory.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581907636 ## raft/src/main/java/org/apache/kafka/raft/internals/History.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581907175 ## raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581905414 ## raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581905289 ## raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581905174 ## raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581904442 ## raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581903286 ## raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581900960 ## raft/src/main/java/org/apache/kafka/raft/internals/PartitionListener.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581517439 ## raft/src/main/java/org/apache/kafka/raft/internals/History.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581484869 ## raft/src/main/java/org/apache/kafka/raft/internals/History.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581480096 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581410429 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581410429 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581398905 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581392367 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581378400 ## raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java: ## @@ -261,7 +260,7 @@ default long truncateToEndOffset(OffsetAndEpoch endOffset) { * @param

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581343739 ## core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala: ## @@ -324,15 +323,11 @@ class DumpLogSegmentsTest { val lastContainedLogTimestamp = 1

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581332843 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1341,29 +1340,25 @@ class KafkaConfigTest { } @Test - def

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581322854 ## core/src/test/scala/integration/kafka/server/RaftClusterSnapshotTest.scala: ## @@ -87,9 +85,12 @@ class RaftClusterSnapshotTest { // Check that we can

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581315479 ## clients/src/test/java/org/apache/kafka/common/record/ControlRecordTypeTest.java: ## @@ -45,4 +45,58 @@ public void testParseUnknownVersion() {

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581234346 ## clients/src/main/resources/common/message/VotersRecord.json: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1580159998 ## clients/src/main/resources/common/message/VotersRecord.json: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1580159998 ## clients/src/main/resources/common/message/VotersRecord.json: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1580158966 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java: ## @@ -807,4 +809,62 @@ private static void writeSnapshotFooterRecord(

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1580155319 ## clients/src/main/java/org/apache/kafka/common/record/ControlRecordType.java: ## @@ -44,11 +44,15 @@ public enum ControlRecordType { ABORT((short) 0),

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1580152614 ## clients/src/main/java/org/apache/kafka/common/feature/BaseVersionRange.java: ## @@ -26,7 +26,7 @@ /** * Represents an immutable basic version range using 2

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

hachikuji commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1576879728 ## clients/src/main/java/org/apache/kafka/common/feature/BaseVersionRange.java: ## @@ -26,7 +26,7 @@ /** * Represents an immutable basic version range using 2

[PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

jsancio opened a new pull request, #15671: URL: https://github.com/apache/kafka/pull/15671 DRAFT ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including