gharris1727 commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2097110125
Thanks @linu-shibu for your patience, I was waiting for something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gharris1727 merged PR #15620:
URL: https://github.com/apache/kafka/pull/15620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2096976398
@gharris1727 any update on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2087468237
@gharris1727 I do not have permission/write access to merge the PR. Will I
get permission/right to merge?
--
This is an automated message from the Apache Git Service.
To respond to
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2087467721
> Test failures appear unrelated, there's a targeted
RemoteLogMetadataSerdeTest for this logic, and the storage tests appear to pass
for me locally.
Yes, in local, the tests
gharris1727 commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2083373419
Test failures appear unrelated, there's a targeted
RemoteLogMetadataSerdeTest for this logic, and the storage tests appear to pass
for me locally.
--
This is an automated message
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2081350906
@gharris1727 any other changes to be made for this PR? Could you review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2068156085
> Thanks @linu-shibu this is a lot closer to what I expected.
>
> Can you also add the build.gradle patch I mentioned earlier? I think this
is the only raw types used in the
gharris1727 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573875832
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -46,69 +44,65 @@ public class
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573871668
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -46,69 +44,65 @@ public class
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573870979
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -46,69 +44,65 @@ public class
gharris1727 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573855150
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -46,69 +44,65 @@ public class
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573854456
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -65,50 +59,45 @@ protected ApiMessage
gharris1727 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573784112
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -65,50 +59,45 @@ protected ApiMessage
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573755412
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,24 @@ protected final Map
gharris1727 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573729186
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,24 @@ protected final Map
linu-shibu commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573721007
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,24 @@ protected final Map
The-Gamer-01 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573677249
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,24 @@ protected final Map
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2064470343
> Hi @linu-shibu @showuon this still uses raw types, and so is still
type-unsafe. Fixing that was my motivation for creating the ticket, sorry for
not emphasizing it more.
>
>
gharris1727 commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2055290090
Hi @linu-shibu @showuon this still uses raw types, and so is still
type-unsafe. Fixing that was my motivation for creating the ticket, sorry for
not emphasizing it more.
I
showuon commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1544007618
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,25 @@ protected final Map
soarez commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1543811354
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,25 @@ protected final Map
gharris1727 commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2026008220
@linu-shibu Could you fix the rawtypes warnings in this class? You can see
them if you make this change in build.gradle:
```diff
options.encoding = 'UTF-8'
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2025930412
@gharris1727 please do take a look and provide some guidance/feedback.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
linu-shibu opened a new pull request, #15620:
URL: https://github.com/apache/kafka/pull/15620
RemoteLogMetadata object, and has to dispatch to one of four serializers
depending on it's type which is currently done by taking the class name of the
RemoteLogMetadata and looking it up
25 matches
Mail list logo
