chia7712 merged PR #15773:
URL: https://github.com/apache/kafka/pull/15773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
FrankYang0529 commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1584662969
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -86,7 +86,7 @@ public class ServerLogConfigs {
public static
chia7712 commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1583431374
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -86,7 +86,7 @@ public class ServerLogConfigs {
public static final
FrankYang0529 commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2082506746
> @FrankYang0529 thanks for updated PR. BTW, could you please enhance the
docs of `log.segment.delete.delay.ms`? It seems the function of
`log.segment.delete.delay.ms` includes the
FrankYang0529 commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073981282
@showuon thanks for the review and clarify scheduler behavior. Learn a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073971783
Re-trigger CI build:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15773/5/
--
This is an automated message from the Apache Git Service.
To respond to the message, please
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073971106
>
If we want to use taskRunning to check whether deletionTask is executed,
we may need a new value in LogManager class to keep scheduler future object.
WDYT?
> I think
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073966870
> I think deletionTask must be executed. From LogManager#startup to
LogManager#startupWithConfigOverrides is not asynchronous code, so deletionTask
must be put into scheduler queue.
FrankYang0529 commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1577187165
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1343,6 +1346,45 @@ class LogManagerTest {
assertFalse(f.exists())
}
}
+
+ /**
showuon commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1577162256
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1343,6 +1346,45 @@ class LogManagerTest {
assertFalse(f.exists())
}
}
+
+ /**
+ *
showuon commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1577162256
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1343,6 +1346,45 @@ class LogManagerTest {
assertFalse(f.exists())
}
}
+
+ /**
+ *
FrankYang0529 commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2072172997
> > Yeah, I tried to use unit test. However, I didn't find a good way to
check whether kafka-delete-logs task has run or not. I also tried to check
whether scheduler can be
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2071375745
> Yeah, I tried to use unit test. However, I didn't find a good way to check
whether kafka-delete-logs task has run or not. I also tried to check whether
scheduler can be stopped.
FrankYang0529 commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2069404596
> I think the better solution (or a workaround) for it, should be that we
set the `nextDeleteDelayMs = Math.max(1, fileDeleteDelayMs)` if if
logsToBeDeleted is empty. So, if
14 matches
Mail list logo
