Re: [PR] KAFKA-16298: Ensure rebalance listener exceptions are propagated to the user on consumer poll [kafka]

2024-04-26 Thread via GitHub
lucasbru merged PR #15742: URL: https://github.com/apache/kafka/pull/15742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14585: Move StorageTool to tools [kafka]

2024-04-26 Thread via GitHub
fvaleri commented on code in PR #14847: URL: https://github.com/apache/kafka/pull/14847#discussion_r1580741403 ## tools/src/test/java/org/apache/kafka/tools/StorageToolTest.java: ## @@ -0,0 +1,517 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-26 Thread via GitHub
FrankYang0529 commented on code in PR #15802: URL: https://github.com/apache/kafka/pull/15802#discussion_r1580759879 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -169,20 +201,22 @@ private static

Re: [PR] KAFKA-14585: Move StorageTool to tools [kafka]

2024-04-26 Thread via GitHub
fvaleri commented on code in PR #14847: URL: https://github.com/apache/kafka/pull/14847#discussion_r1580759331 ## tools/src/main/java/org/apache/kafka/tools/StorageTool.java: ## @@ -0,0 +1,555 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Resolved] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-26 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou resolved KAFKA-16621. Resolution: Not A Bug Fixed in KAFKA-15182: Normalize source connector offsets before invoking

[jira] [Comment Edited] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841134#comment-17841134 ] Edoardo Comar edited comment on KAFKA-16622 at 4/26/24 10:17 AM: - Hi

[jira] [Comment Edited] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841134#comment-17841134 ] Edoardo Comar edited comment on KAFKA-16622 at 4/26/24 10:17 AM: - Hi

[jira] [Comment Edited] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841134#comment-17841134 ] Edoardo Comar edited comment on KAFKA-16622 at 4/26/24 10:16 AM: - Hi

Re: [PR] KAFKA-16399: Add JBOD support in tiered storage [kafka]

2024-04-26 Thread via GitHub
soarez commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1580567800 ## core/src/main/java/kafka/server/TierStateMachine.java: ## @@ -54,5 +180,109 @@ PartitionFetchState start(TopicPartition topicPartition, * @return the new

[jira] [Comment Edited] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841134#comment-17841134 ] Edoardo Comar edited comment on KAFKA-16622 at 4/26/24 10:18 AM: - Hi

Re: [PR] KAFKA-16565: IncrementalAssignmentConsumerEventHandler throws error when attempting to remove a partition that isn't assigned [kafka]

2024-04-26 Thread via GitHub
lucasbru merged PR #15737: URL: https://github.com/apache/kafka/pull/15737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-26 Thread via GitHub
nizhikov commented on code in PR #15645: URL: https://github.com/apache/kafka/pull/15645#discussion_r1580711745 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-26 Thread via GitHub
nizhikov commented on code in PR #15645: URL: https://github.com/apache/kafka/pull/15645#discussion_r1580711310 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-26 Thread via GitHub
FrankYang0529 commented on code in PR #15802: URL: https://github.com/apache/kafka/pull/15802#discussion_r1580755873 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -91,65 +91,97 @@ public void

Re: [PR] KAFKA-16608: Honour interrupted thread state on KafkaConsumer.poll [kafka]

2024-04-26 Thread via GitHub
AndrewJSchofield commented on code in PR #15803: URL: https://github.com/apache/kafka/pull/15803#discussion_r1580787182 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -1789,6 +1791,33 @@ public void

[jira] [Updated] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-16622: -- Attachment: connect.log.2024-04-26-10.zip > Mirromaker2 first Checkpoint not emitted until

[jira] [Comment Edited] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841137#comment-17841137 ] Edoardo Comar edited comment on KAFKA-16622 at 4/26/24 10:40 AM: - if

[PR] Add retriable tag to ErrorsPerSec JMX metric [kafka]

2024-04-26 Thread via GitHub
dopuskh3 opened a new pull request, #15813: URL: https://github.com/apache/kafka/pull/15813 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] Add retriable tag to ErrorsPerSec JMX metric [kafka]

2024-04-26 Thread via GitHub
dopuskh3 closed pull request #15813: Add retriable tag to ErrorsPerSec JMX metric URL: https://github.com/apache/kafka/pull/15813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-14585: Move StorageTool to tools [kafka]

2024-04-26 Thread via GitHub
fvaleri commented on code in PR #14847: URL: https://github.com/apache/kafka/pull/14847#discussion_r1580757743 ## metadata/src/main/java/org/apache/kafka/metadata/properties/MetaProperties.java: ## @@ -47,7 +47,7 @@ public final class MetaProperties { /** * The

[jira] [Commented] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841134#comment-17841134 ] Edoardo Comar commented on KAFKA-16622: --- Hi [~gharris1727] The task did not restart. Here are the

[jira] [Comment Edited] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841134#comment-17841134 ] Edoardo Comar edited comment on KAFKA-16622 at 4/26/24 10:12 AM: - Hi

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-26 Thread via GitHub
cadonna merged PR #15698: URL: https://github.com/apache/kafka/pull/15698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-26 Thread via GitHub
nizhikov commented on code in PR #15645: URL: https://github.com/apache/kafka/pull/15645#discussion_r1580728829 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Commented] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841137#comment-17841137 ] Edoardo Comar commented on KAFKA-16622: --- if after the consumer reaches 1 and the 1st

Re: [PR] KAFKA-15615: Improve handling of fetching during metadata updates. [kafka]

2024-04-26 Thread via GitHub
appchemist commented on code in PR #15647: URL: https://github.com/apache/kafka/pull/15647#discussion_r1580504115 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node

[jira] [Comment Edited] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841134#comment-17841134 ] Edoardo Comar edited comment on KAFKA-16622 at 4/26/24 10:15 AM: - Hi

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

2024-04-26 Thread via GitHub
bachmanity1 commented on PR #15475: URL: https://github.com/apache/kafka/pull/15475#issuecomment-2079216075 Hi @mimaison, would you mind taking a look at the KIP and sharing your vote on it? Thank you! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-15615: Improve handling of fetching during metadata updates. [kafka]

2024-04-26 Thread via GitHub
appchemist commented on code in PR #15647: URL: https://github.com/apache/kafka/pull/15647#discussion_r1580510829 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java: ## @@ -327,21 +327,27 @@ private void handleInitializeErrors(final

[jira] [Comment Edited] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841134#comment-17841134 ] Edoardo Comar edited comment on KAFKA-16622 at 4/26/24 10:13 AM: - Hi

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-26 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1580785461 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1169,8 +1129,7 @@ private Map beginningOrEndOffset(Collection

[jira] [Commented] (KAFKA-16585) No way to forward message from punctuation method in the FixedKeyProcessor

2024-04-26 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841079#comment-17841079 ] Stanislav Spiridonov commented on KAFKA-16585: -- Ok. Let's not make simple things

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580532456 ## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ## @@ -48,14 +51,18 @@ public class ClusterTestExtensionsTest { // Static methods can

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580532188 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -139,28 +151,38 @@ public Map nameTags() { return tags; } -public ClusterConfig

Re: [PR] KAFKA-15615: Improve handling of fetching during metadata updates. [kafka]

2024-04-26 Thread via GitHub
appchemist commented on code in PR #15647: URL: https://github.com/apache/kafka/pull/15647#discussion_r1580510829 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java: ## @@ -327,21 +327,27 @@ private void handleInitializeErrors(final

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-26 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1580545776 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580513112 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -57,16 +57,18 @@ import org.slf4j.{Logger, LoggerFactory} import java.util

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580535934 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -139,28 +151,38 @@ public Map nameTags() { return tags; } -public ClusterConfig

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580536170 ## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ## @@ -48,14 +51,18 @@ public class ClusterTestExtensionsTest { // Static methods can generate

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580549838 ## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ## @@ -48,14 +51,18 @@ public class ClusterTestExtensionsTest { // Static methods can

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-26 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1580557688 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580538394 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -139,28 +151,38 @@ public Map nameTags() { return tags; } -public ClusterConfig

[jira] [Created] (KAFKA-16627) Remove ClusterConfig parameter in BeforeEach and AfterEach

2024-04-26 Thread Kuan Po Tseng (Jira)
Kuan Po Tseng created KAFKA-16627: - Summary: Remove ClusterConfig parameter in BeforeEach and AfterEach Key: KAFKA-16627 URL: https://issues.apache.org/jira/browse/KAFKA-16627 Project: Kafka

Re: [PR] MINOR: fix timeouts of EosIntegrationTest [kafka]

2024-04-26 Thread via GitHub
chia7712 merged PR #15811: URL: https://github.com/apache/kafka/pull/15811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841072#comment-17841072 ] Greg Harris commented on KAFKA-16622: - [~ecomar] Do you know if the MirrorCheckpointTask

Re: [PR] MINOR: fix timeouts of EosIntegrationTest [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on PR #15811: URL: https://github.com/apache/kafka/pull/15811#issuecomment-2078756363 The failed tests are unrelated. will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580544105 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -139,28 +151,38 @@ public Map nameTags() { return tags; } -public ClusterConfig

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580542830 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -139,28 +151,38 @@ public Map nameTags() { return tags; } -public ClusterConfig

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-26 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1580549399 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Comment Edited] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-26 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841137#comment-17841137 ] Edoardo Comar edited comment on KAFKA-16622 at 4/26/24 6:04 PM: if after

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581398905 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581410429 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[PR] [Minor] Fix the flaky testConsumerGroupHeartbeatWithStableClassicGroup by sorting the topic partition list [kafka]

2024-04-26 Thread via GitHub
dongnuo123 opened a new pull request, #15816: URL: https://github.com/apache/kafka/pull/15816 We are seeing flaky test in `testConsumerGroupHeartbeatWithStableClassicGroup` where the error is caused by the different ordering in the expected and actual values. The patch sorts the topic

[jira] [Commented] (KAFKA-15342) Considering upgrading to Mockito 5.4.1 or later

2024-04-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841294#comment-17841294 ] Chia-Ping Tsai commented on KAFKA-15342: not sure the benefit of having unit test and

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-26 Thread via GitHub
lucasbru commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1581306529 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581322854 ## core/src/test/scala/integration/kafka/server/RaftClusterSnapshotTest.scala: ## @@ -87,9 +85,12 @@ class RaftClusterSnapshotTest { // Check that we can

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581343739 ## core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala: ## @@ -324,15 +323,11 @@ class DumpLogSegmentsTest { val lastContainedLogTimestamp = 1

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581392367 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16211: Inconsistent config values in CreateTopicsResult and DescribeConfigsResult [kafka]

2024-04-26 Thread via GitHub
infantlikesprogramming commented on PR #15696: URL: https://github.com/apache/kafka/pull/15696#issuecomment-2079935542 @chia7712 Thank you! The cluster that I deployed in Kraft (locally) consists of 3 controllers and 4 brokers, using standard configurations from the config/kraft folder.

[PR] [Minor] Add replayRecords to CoordinatorResult [kafka]

2024-04-26 Thread via GitHub
dongnuo123 opened a new pull request, #15818: URL: https://github.com/apache/kafka/pull/15818 The patch adds a boolean attribute `replayRecords` that specifies whether the records should be replayed. The default value is `appendFuture == null` so no change is needed for the existing code.

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581410429 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[PR] KAFKA-16589: Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close [kafka]

2024-04-26 Thread via GitHub
FrankYang0529 opened a new pull request, #15815: URL: https://github.com/apache/kafka/pull/15815 Sometimes we close the admin created by `createAdminClient`, and sometimes we don't. That is not a true problem since the `ClusterInstance` will call `close` when stopping. However, that

Re: [PR] MINOR: Various cleanups in raft [kafka]

2024-04-26 Thread via GitHub
mimaison merged PR #15805: URL: https://github.com/apache/kafka/pull/15805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-04-26 Thread via GitHub
tinaselenge commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1581029496 ## core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala: ## @@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends

[PR] KAFKA-16511: Fix the leaking tiered segments during segment deletions [kafka]

2024-04-26 Thread via GitHub
kamalcph opened a new pull request, #15817: URL: https://github.com/apache/kafka/pull/15817 When there are overlapping segments in the remote storage, then the deletion may fail to remove the segments due to `isRemoteSegmentWithinLeaderEpochs` check. Once the deletion starts to fail for a

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581378400 ## raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java: ## @@ -261,7 +260,7 @@ default long truncateToEndOffset(OffsetAndEpoch endOffset) { * @param

[jira] [Resolved] (KAFKA-16609) Update parse_describe_topic to support new topic describe output

2024-04-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16609. --- Reviewer: Lucas Brutschy Resolution: Fixed > Update parse_describe_topic to support new topic

Re: [PR] KAFKA-16565: IncrementalAssignmentConsumerEventHandler throws error when attempting to remove a partition that isn't assigned [kafka]

2024-04-26 Thread via GitHub
kirktrue commented on code in PR #15737: URL: https://github.com/apache/kafka/pull/15737#discussion_r1581441497 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -140,22 +150,32 @@ class IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler): def

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581315479 ## clients/src/test/java/org/apache/kafka/common/record/ControlRecordTypeTest.java: ## @@ -45,4 +45,58 @@ public void testParseUnknownVersion() {

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581332843 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1341,29 +1340,25 @@ class KafkaConfigTest { } @Test - def

[jira] [Commented] (KAFKA-16584) Make log processing summary configurable or debug

2024-04-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841332#comment-17841332 ] Matthias J. Sax commented on KAFKA-16584: - There is an issue with creating new account:

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-26 Thread via GitHub
nizhikov commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2079970499 @chia7712 CI looks good to me. Do you have any other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16615: JoinGroup API for upgrading ConsumerGroup [kafka]

2024-04-26 Thread via GitHub
dajac commented on code in PR #15798: URL: https://github.com/apache/kafka/pull/15798#discussion_r1580929744 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1413,6 +1506,243 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16615: JoinGroup API for upgrading ConsumerGroup [kafka]

2024-04-26 Thread via GitHub
dongnuo123 commented on code in PR #15798: URL: https://github.com/apache/kafka/pull/15798#discussion_r1581026465 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1122,4 +1122,27 @@ private OUT handleOperationException(

Re: [PR] Refactor SSL/SASL admin integration tests to not use a custom authorizer [kafka]

2024-04-26 Thread via GitHub
tinaselenge commented on code in PR #15377: URL: https://github.com/apache/kafka/pull/15377#discussion_r1581029496 ## core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala: ## @@ -259,4 +275,22 @@ class SslAdminIntegrationTest extends

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1581234346 ## clients/src/main/resources/common/message/VotersRecord.json: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[jira] [Commented] (KAFKA-14892) Harmonize package names in storage module

2024-04-26 Thread Giuseppe Calabrese (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841254#comment-17841254 ] Giuseppe Calabrese commented on KAFKA-14892: Hi, I'm new in ASF. I wonder if this ticket

Re: [PR] KAFKA-9800: Exponential backoff for Kafka clients - KIP-580 [kafka]

2024-04-26 Thread via GitHub
msn-tldr commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1581106940 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java: ## @@ -384,6 +389,32 @@ int attempts() { return attempts.get();

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-26 Thread via GitHub
lianetm commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1581203195 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16615: JoinGroup API for upgrading ConsumerGroup [kafka]

2024-04-26 Thread via GitHub
dajac commented on code in PR #15798: URL: https://github.com/apache/kafka/pull/15798#discussion_r1580920772 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1288,25 +1396,10 @@ private CoordinatorResult consumerGr

Re: [PR] [Draft] Join, Sync, Heartbeat during Migration [kafka]

2024-04-26 Thread via GitHub
dajac commented on PR #15268: URL: https://github.com/apache/kafka/pull/15268#issuecomment-2079401308 I think that we don't need this anymore. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-15838) [Connect] ExtractField and InsertField NULL Values are replaced by default value even in NULLABLE fields

2024-04-26 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-15838: --- Component/s: connect > [Connect] ExtractField and InsertField NULL Values are replaced by

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

2024-04-26 Thread via GitHub
rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1581132398 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java: ## @@ -204,7 +198,7 @@ private void createAssignmentSpec() {

[jira] [Commented] (KAFKA-16611) Consider adding test name to "client.id" of Admin in testing

2024-04-26 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841193#comment-17841193 ] PoAn Yang commented on KAFKA-16611: --- Hi [~chia7712], I'm interested in this issue. May I take it?

Re: [PR] KAFKA-16589: Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on PR #15815: URL: https://github.com/apache/kafka/pull/15815#issuecomment-2079444105 We are doing the migration so can this PR get pending before we see more use cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

2024-04-26 Thread via GitHub
rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1581140616 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +987,23 @@ private static void

Re: [PR] [Draft] Join, Sync, Heartbeat during Migration [kafka]

2024-04-26 Thread via GitHub
dajac closed pull request #15268: [Draft] Join, Sync, Heartbeat during Migration URL: https://github.com/apache/kafka/pull/15268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] MINOR: KIP-848 Uniform Assignor Bugs [kafka]

2024-04-26 Thread via GitHub
dajac commented on PR #15286: URL: https://github.com/apache/kafka/pull/15286#issuecomment-2079402203 @rreddy-22 Do we still need this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16317: Add event process rate in GroupCoordinatorRuntimeMetrics [kafka]

2024-04-26 Thread via GitHub
dajac commented on PR #15448: URL: https://github.com/apache/kafka/pull/15448#issuecomment-2079403659 I think that we won't add this one in the end. Closing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16317: Add event process rate in GroupCoordinatorRuntimeMetrics [kafka]

2024-04-26 Thread via GitHub
dajac closed pull request #15448: KAFKA-16317: Add event process rate in GroupCoordinatorRuntimeMetrics URL: https://github.com/apache/kafka/pull/15448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KIP848- Add JMH Benchmarks for Client And Server Side Assignors [kafka]

2024-04-26 Thread via GitHub
dajac closed pull request #15329: KIP848- Add JMH Benchmarks for Client And Server Side Assignors URL: https://github.com/apache/kafka/pull/15329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KIP848- Add JMH Benchmarks for Client And Server Side Assignors [kafka]

2024-04-26 Thread via GitHub
dajac commented on PR #15329: URL: https://github.com/apache/kafka/pull/15329#issuecomment-2079402641 I think that we don't need this anymore. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Assigned] (KAFKA-16611) Consider adding test name to "client.id" of Admin in testing

2024-04-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16611: -- Assignee: PoAn Yang (was: Chia-Ping Tsai) > Consider adding test name to

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

2024-04-26 Thread via GitHub
rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1581134610 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -620,9 +637,10 @@ public Map computeSubscriptionMetadata(

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-04-26 Thread via GitHub
jsancio commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1580159998 ## clients/src/main/resources/common/message/VotersRecord.json: ## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[jira] [Closed] (KAFKA-16528) Reset member heartbeat interval when request sent

2024-04-26 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans closed KAFKA-16528. -- > Reset member heartbeat interval when request sent >

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1581597711 ## core/src/test/scala/integration/kafka/server/KafkaServerKRaftRegistrationTest.scala: ## @@ -71,11 +72,16 @@ class KafkaServerKRaftRegistrationTest { val

Re: [PR] MINOR: Various cleanups in generator [kafka]

2024-04-26 Thread via GitHub
chia7712 merged PR #15807: URL: https://github.com/apache/kafka/pull/15807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on code in PR #15645: URL: https://github.com/apache/kafka/pull/15645#discussion_r1581621779 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2080244534 @nizhikov I'm ok to accept this PR to be a java rewriting, and I file https://issues.apache.org/jira/browse/KAFKA-16629 to add more tests in the future. Hence, please fix comment

  1   2   >