Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-14 Thread via GitHub
chia7712 commented on PR #15507: URL: https://github.com/apache/kafka/pull/15507#issuecomment-1998993124 @ChrisAHolland thank for double checking the failed tests. Will merge it later! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-14 Thread via GitHub
ChrisAHolland commented on PR #15507: URL: https://github.com/apache/kafka/pull/15507#issuecomment-1998991332 @chia7712 I believe test failures are orthogonal, it seems all recently merged PR's have been having test failures. -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-14 Thread via GitHub
sjhajharia commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1525774714 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -42,14 +42,26 @@ object AddPartitionsToTxnManager { val VerificationTimeMsMetricName =

[jira] [Updated] (KAFKA-16370) offline rollback procedure from kraft mode to zookeeper mode.

2024-03-14 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kaushik srinivas updated KAFKA-16370: - Issue Type: Bug (was: Improvement) > offline rollback procedure from kraft mode to

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

2024-03-14 Thread via GitHub
satishd merged PR #15490: URL: https://github.com/apache/kafka/pull/15490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

2024-03-14 Thread via GitHub
satishd commented on PR #15490: URL: https://github.com/apache/kafka/pull/15490#issuecomment-1998903881 Failing tests are unrelated to this change, merging it to 3.6 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #14957: URL: https://github.com/apache/kafka/pull/14957#issuecomment-1998877709 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[PR] MINOR:Add hint for `resumeDeletions` in `TopicDeletionManager` [kafka]

2024-03-14 Thread via GitHub
hudeqi opened a new pull request, #15543: URL: https://github.com/apache/kafka/pull/15543 The `resumeDeletions` method is called from multiple places and is the core logic responsible for executing the deletion. Therefore, adding comments to indicate where this method is being called can

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-14 Thread via GitHub
jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1525699817 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1456,7 +1456,7 @@ public CompletableFuture

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-14 Thread via GitHub
jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1525699580 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -44,7 +44,7 @@ object AddPartitionsToTxnManager { /** * This is an enum which handles

[jira] [Updated] (KAFKA-15206) Flaky test RemoteIndexCacheTest.testClose()

2024-03-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15206: -- Fix Version/s: 3.7.1 > Flaky test RemoteIndexCacheTest.testClose() >

Re: [PR] KAFKA-15206: Fix the flaky RemoteIndexCacheTest.testClose test [kafka]

2024-03-14 Thread via GitHub
showuon merged PR #15523: URL: https://github.com/apache/kafka/pull/15523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15206: Fix the flaky RemoteIndexCacheTest.testClose test [kafka]

2024-03-14 Thread via GitHub
showuon commented on PR #15523: URL: https://github.com/apache/kafka/pull/15523#issuecomment-1998835444 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-14 Thread via GitHub
showuon commented on PR #15474: URL: https://github.com/apache/kafka/pull/15474#issuecomment-1998834117 Thanks all for the review! I've backported to v3.7. For v3.6, there are more codes diff, I'd like to run CI first before push the change. PR:

[PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-14 Thread via GitHub
showuon opened a new pull request, #15542: URL: https://github.com/apache/kafka/pull/15542 Backported https://github.com/apache/kafka/pull/15474 to v3.6 branch. Since there is more code diff, I'd like to make sure the backport doesn't break any tests. Fix getOffsetByMaxTimestamp for

[jira] [Updated] (KAFKA-16378) Under tiered storage, deleting local logs does not free disk space

2024-03-14 Thread Jianbin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jianbin Chen updated KAFKA-16378: - Component/s: Tiered-Storage > Under tiered storage, deleting local logs does not free disk

[jira] [Updated] (KAFKA-16378) Under tiered storage, deleting local logs does not free disk space

2024-03-14 Thread Jianbin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jianbin Chen updated KAFKA-16378: - Issue Type: Bug (was: Wish) > Under tiered storage, deleting local logs does not free disk

[jira] [Created] (KAFKA-16378) Under tiered storage, deleting local logs does not free disk space

2024-03-14 Thread Jianbin Chen (Jira)
Jianbin Chen created KAFKA-16378: Summary: Under tiered storage, deleting local logs does not free disk space Key: KAFKA-16378 URL: https://issues.apache.org/jira/browse/KAFKA-16378 Project: Kafka

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-14 Thread via GitHub
chia7712 commented on code in PR #14471: URL: https://github.com/apache/kafka/pull/14471#discussion_r1525644188 ## tools/src/main/java/org/apache/kafka/tools/consumer/group/CsvUtils.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-14 Thread via GitHub
ChrisAHolland commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1525616031 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -40,18 +40,22 @@ public static BoundedList newArrayBacked(int maxLength)

Re: [PR] KAFKA-16217: Stop the abort transaction try loop when closing producers [kafka]

2024-03-14 Thread via GitHub
jolshan commented on code in PR #15541: URL: https://github.com/apache/kafka/pull/15541#discussion_r1525612166 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -270,14 +270,7 @@ public void run() { while (!forceClose &&

[jira] [Updated] (KAFKA-16377) Fix flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2024-03-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16377: Component/s: streams unit tests > Fix flaky >

[PR] KAFKA-16217: Stop the abort transaction try loop when closing producers [kafka]

2024-03-14 Thread via GitHub
CalvinConfluent opened a new pull request, #15541: URL: https://github.com/apache/kafka/pull/15541 This is a mitigation fix for the https://issues.apache.org/jira/browse/KAFKA-16217. Exceptions should not block closing the producers. This PR reverts a part of the change

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-14 Thread via GitHub
chia7712 commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1525585193 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -40,18 +40,22 @@ public static BoundedList newArrayBacked(int maxLength) {

Re: [PR] KAFKA-7663: Reprocessing on user added global stores restore [kafka]

2024-03-14 Thread via GitHub
wcarlson5 commented on code in PR #15414: URL: https://github.com/apache/kafka/pull/15414#discussion_r1525585101 ## streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java: ## @@ -76,6 +76,8 @@ public void init(final ProcessorContext context,

[jira] [Assigned] (KAFKA-16274) Update replica_scale_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16274: - Assignee: (was: Philip Nee) > Update replica_scale_test.py to support KIP-848’s group

[jira] [Assigned] (KAFKA-16275) Update kraft_upgrade_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16275: - Assignee: (was: Philip Nee) > Update kraft_upgrade_test.py to support KIP-848’s group

[jira] [Assigned] (KAFKA-16271) Update consumer_rolling_upgrade_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16271: - Assignee: (was: Philip Nee) > Update consumer_rolling_upgrade_test.py to support KIP-848’s

[jira] [Assigned] (KAFKA-16276) Update transactions_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16276: - Assignee: (was: Philip Nee) > Update transactions_test.py to support KIP-848’s group

[jira] [Assigned] (KAFKA-16272) Update connect_distributed_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16272: - Assignee: (was: Philip Nee) > Update connect_distributed_test.py to support KIP-848’s

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-14 Thread via GitHub
soarez commented on PR #14903: URL: https://github.com/apache/kafka/pull/14903#issuecomment-1998592089 Rebased this due to merge conflict. @gaurav-narula I also made what I believe are some improvement to `BrokerLifecycleManagerTest.testKraftJBODMetadataVersionUpdateEvent`, can you

Re: [PR] KAFKA-16352: Txn may get get stuck in PrepareCommit or PrepareAbort s… [kafka]

2024-03-14 Thread via GitHub
jolshan commented on code in PR #15524: URL: https://github.com/apache/kafka/pull/15524#discussion_r1525559114 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala: ## @@ -177,6 +178,86 @@ class TransactionMarkerChannelManagerTest

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-14 Thread via GitHub
chia7712 commented on PR #15474: URL: https://github.com/apache/kafka/pull/15474#issuecomment-1998576991 Thanks for all reviews and @showuon. This is not only a important fix to kafka but also a great experience to me :) @showuon Could you please backport this fix? thanks! -- This

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-14 Thread via GitHub
chia7712 commented on PR #15476: URL: https://github.com/apache/kafka/pull/15476#issuecomment-1998570706 @johnnychhsu Could you please rebase code and address following comments. 1. update KIP-734 according to https://github.com/apache/kafka/pull/15476#discussion_r1523677272

[jira] [Resolved] (KAFKA-14971) Flaky Test org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest#testSyncTopicConfigs

2024-03-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-14971. Resolution: Duplicate KAFKA-15945 has filed PR so close this ticket > Flaky Test >

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-14 Thread via GitHub
chia7712 merged PR #15474: URL: https://github.com/apache/kafka/pull/15474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-15523) Flaky test org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testSyncTopicConfigs

2024-03-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-15523. Resolution: Duplicate KAFKA-15945 has filed PR so close this ticket > Flaky test >

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-14 Thread via GitHub
chia7712 commented on PR #15474: URL: https://github.com/apache/kafka/pull/15474#issuecomment-1998564199 the failed tests pass on my local. ```sh ./gradlew cleanTest core:test --tests LogDirFailureTest --tests ReplicaManagerTest connect:mirror:test --tests

[jira] [Created] (KAFKA-16377) Fix flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2024-03-14 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16377: -- Summary: Fix flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores Key: KAFKA-16377 URL:

[jira] [Created] (KAFKA-16376) Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric

2024-03-14 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16376: -- Summary: Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric Key: KAFKA-16376 URL: https://issues.apache.org/jira/browse/KAFKA-16376 Project: Kafka

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-14 Thread via GitHub
ChrisAHolland commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1525523190 ## server-common/src/test/java/org/apache/kafka/server/mutable/BoundedListTest.java: ## @@ -165,18 +199,24 @@ public void testIterator() { @Test

[PR] KAFKA-16269: Update reassign_partitions_test.py to support KIP-848’s group protocol config [kafka]

2024-03-14 Thread via GitHub
kirktrue opened a new pull request, #15540: URL: https://github.com/apache/kafka/pull/15540 Added a new optional `group_protocol` parameter to the test methods, then passed that down to the `setup_consumer` method. Unfortunately, because the new consumer can only be used with the new

[PR] KAFKA-16268: Update fetch_from_follower_test.py to support KIP-848’s group protocol config [kafka]

2024-03-14 Thread via GitHub
kirktrue opened a new pull request, #15539: URL: https://github.com/apache/kafka/pull/15539 Added a new optional `group_protocol` parameter to the test methods, then passed that down to the `setup_consumer` method. Unfortunately, because the new consumer can only be used with the new

[PR] KAFKA-16270: Update snapshot_test.py to support KIP-848’s group protocol config [kafka]

2024-03-14 Thread via GitHub
kirktrue opened a new pull request, #15538: URL: https://github.com/apache/kafka/pull/15538 Added a new optional `group_protocol` parameter to the test methods, then passed that down to the `setup_consumer` method. Unfortunately, because the new consumer can only be used with the new

[PR] KAFKA-16267: Update consumer_group_command_test.py to support KIP-848’s group protocol config [kafka]

2024-03-14 Thread via GitHub
kirktrue opened a new pull request, #15537: URL: https://github.com/apache/kafka/pull/15537 Added a new optional `group_protocol` parameter to the test methods, then passed that down to the `setup_consumer` method. Unfortunately, because the new consumer can only be used with the new

[jira] [Assigned] (KAFKA-16276) Update transactions_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16276: - Assignee: Philip Nee (was: Kirk True) > Update transactions_test.py to support KIP-848’s

[jira] [Assigned] (KAFKA-16273) Update consume_bench_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16273: - Assignee: Philip Nee (was: Kirk True) > Update consume_bench_test.py to support KIP-848’s

[jira] [Assigned] (KAFKA-16271) Update consumer_rolling_upgrade_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16271: - Assignee: Philip Nee (was: Kirk True) > Update consumer_rolling_upgrade_test.py to support

[jira] [Assigned] (KAFKA-16272) Update connect_distributed_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16272: - Assignee: Philip Nee (was: Kirk True) > Update connect_distributed_test.py to support

[jira] [Assigned] (KAFKA-16275) Update kraft_upgrade_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16275: - Assignee: Philip Nee (was: Kirk True) > Update kraft_upgrade_test.py to support KIP-848’s

[jira] [Assigned] (KAFKA-16274) Update replica_scale_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16274: - Assignee: Philip Nee (was: Kirk True) > Update replica_scale_test.py to support KIP-848’s

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-14 Thread via GitHub
chia7712 commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1525490485 ## server-common/src/test/java/org/apache/kafka/server/mutable/BoundedListTest.java: ## @@ -165,18 +199,24 @@ public void testIterator() { @Test public

[jira] [Updated] (KAFKA-15691) Update system tests to use AsyncKafkaConsumer

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15691: -- Summary: Update system tests to use AsyncKafkaConsumer (was: Update system tests to use new

[jira] [Updated] (KAFKA-15691) Add new system tests to use new consumer

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15691: -- Priority: Blocker (was: Major) > Add new system tests to use new consumer >

[jira] [Reopened] (KAFKA-15691) Add new system tests to use new consumer

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reopened KAFKA-15691: --- > Add new system tests to use new consumer > > >

[jira] [Updated] (KAFKA-15691) Update system tests to use new consumer

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15691: -- Summary: Update system tests to use new consumer (was: Add new system tests to use new consumer) >

[jira] [Updated] (KAFKA-16269) Update reassign_partitions_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16269: -- Description: This task is to update the test method(s) in {{reassign_partitions_test.py}} to support

[jira] [Updated] (KAFKA-16270) Update snapshot_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16270: -- Description: This task is to update the test method(s) in {{snapshot_test.py}} to support the 

[jira] [Updated] (KAFKA-16275) Update kraft_upgrade_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16275: -- Description: This task is to update the test method(s) in {{kraft_upgrade_test.py}} to support the 

[jira] [Updated] (KAFKA-16273) Update consume_bench_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16273: -- Description: This task is to update the test method(s) in {{consume_bench_test.py}} to support the 

[jira] [Updated] (KAFKA-16267) Update consumer_group_command_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16267: -- Description: This task is to update the test method(s) in {{consumer_group_command_test.py}}  to

[jira] [Updated] (KAFKA-16269) Update reassign_partitions_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16269: -- Description: This task is to update the test method(s) in {{reassign_partitions_test.py}} to support

[jira] [Updated] (KAFKA-16268) Update fetch_from_follower_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16268: -- Description: This task is to update the test method(s) in {{fetch_from_follower_test.py}} to support

[jira] [Updated] (KAFKA-16272) Update connect_distributed_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16272: -- Description: This task is to update the test method(s) in {{connect_distributed_test.py}} to support

[jira] [Updated] (KAFKA-16274) Update replica_scale_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16274: -- Description: This task is to update the test method(s) in {{replica_scale_test.py}} to support the 

[jira] [Updated] (KAFKA-16271) Update consumer_rolling_upgrade_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16271: -- Description: This task is to update the test method(s) in {{consumer_rolling_upgrade_test.py}} to

[jira] [Updated] (KAFKA-16231) Update consumer_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16231: -- Description: This task is to update {{consumer_test.py}} to support the {{group.protocol}}

[jira] [Updated] (KAFKA-16276) Update transactions_test.py to support KIP-848’s group protocol config

2024-03-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16276: -- Description: This task is to update the test method(s) in {{transactions_test.py}} to support the 

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
lianetm commented on PR #15511: URL: https://github.com/apache/kafka/pull/15511#issuecomment-1998471082 Thanks for the updates @lucasbru, left some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (KAFKA-16375) Fix logic for discarding reconciliation if member rejoined

2024-03-14 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16375: --- Description: The current implementation of the new consumer discards the result of a

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1525452774 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -976,6 +974,10 @@ void maybeReconcile() { }

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-14 Thread via GitHub
ChrisAHolland commented on PR #15507: URL: https://github.com/apache/kafka/pull/15507#issuecomment-1998410642 @chia7712 Thank you, updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1525446624 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -1028,9 +1028,9 @@ public void

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-14 Thread via GitHub
chia7712 commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1525419354 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -40,18 +40,17 @@ public static BoundedList newArrayBacked(int maxLength) {

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1525418611 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -2279,22 +2277,23 @@ private MembershipManagerImpl

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-14 Thread via GitHub
chia7712 merged PR #15506: URL: https://github.com/apache/kafka/pull/15506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1525386165 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -911,9 +911,13 @@ void maybeReconcile() { SortedSet

[jira] [Updated] (KAFKA-16375) Fix logic for discarding reconciliation if member rejoined

2024-03-14 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16375: --- Priority: Critical (was: Major) > Fix logic for discarding reconciliation if member

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1525360383 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -988,7 +989,8 @@ long getExpirationTimeForTimeout(final long

[jira] [Created] (KAFKA-16375) Fix logic for discarding reconciliation if member rejoined

2024-03-14 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16375: -- Summary: Fix logic for discarding reconciliation if member rejoined Key: KAFKA-16375 URL: https://issues.apache.org/jira/browse/KAFKA-16375 Project: Kafka

Re: [PR] MINOR: AddPartitionsToTxnManager performance optimizations [kafka]

2024-03-14 Thread via GitHub
jolshan commented on PR #15454: URL: https://github.com/apache/kafka/pull/15454#issuecomment-1998091660 Hmm. I was rerunning just to confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: AddPartitionsToTxnManager performance optimizations [kafka]

2024-03-14 Thread via GitHub
mimaison merged PR #15454: URL: https://github.com/apache/kafka/pull/15454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KAFKA-16371: fix lingering pending commit when handling OFFSET_METADATA_TOO_LARGE [kafka]

2024-03-14 Thread via GitHub
kphelps opened a new pull request, #15536: URL: https://github.com/apache/kafka/pull/15536 When there is a commit for multiple topic partitions and some, but not all, exceed the offset metadata limit, the pending commit is not properly cleaned up leading to `UNSTABLE_OFFSET_COMMIT` errors

Re: [PR] MINOR: AddPartitionsToTxnManager performance optimizations [kafka]

2024-03-14 Thread via GitHub
mimaison commented on PR #15454: URL: https://github.com/apache/kafka/pull/15454#issuecomment-1998016477 Test failures don't seem related (all passed locally), merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] [WIP] Splitting consumer tests [kafka]

2024-03-14 Thread via GitHub
lianetm opened a new pull request, #15535: URL: https://github.com/apache/kafka/pull/15535 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] MINOR: Change link to deprecated class to substitute class [kafka]

2024-03-14 Thread via GitHub
cadonna closed pull request #15531: MINOR: Change link to deprecated class to substitute class URL: https://github.com/apache/kafka/pull/15531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Change link to deprecated class to substitute class [kafka]

2024-03-14 Thread via GitHub
cadonna commented on PR #15531: URL: https://github.com/apache/kafka/pull/15531#issuecomment-1997917052 Closing because it does not make sense to only change a link when the rest of the content is out-of-date. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-16373) Docker Official Image for Apache Kafka

2024-03-14 Thread Kenneth Eversole (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827162#comment-17827162 ] Kenneth Eversole commented on KAFKA-16373: -- This already seems to have been done in a previous

Re: [PR] KAFKA-15417 Sloppy bug: moved the outerJounBreak-flags out of the loop [kafka]

2024-03-14 Thread via GitHub
VictorvandenHoven commented on code in PR #15510: URL: https://github.com/apache/kafka/pull/15510#discussion_r1525144034 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -223,9 +223,9 @@ private void emitNonJoinedOuterRecords(

Re: [PR] KAFKA-15417 Sloppy bug: moved the outerJounBreak-flags out of the loop [kafka]

2024-03-14 Thread via GitHub
VictorvandenHoven commented on code in PR #15510: URL: https://github.com/apache/kafka/pull/15510#discussion_r1525144034 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -223,9 +223,9 @@ private void emitNonJoinedOuterRecords(

[jira] [Comment Edited] (KAFKA-16361) Rack aware sticky assignor minQuota violations

2024-03-14 Thread BDeus (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827134#comment-17827134 ] BDeus edited comment on KAFKA-16361 at 3/14/24 3:47 PM: Is it a regression

[jira] [Comment Edited] (KAFKA-16361) Rack aware sticky assignor minQuota violations

2024-03-14 Thread BDeus (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827134#comment-17827134 ] BDeus edited comment on KAFKA-16361 at 3/14/24 3:46 PM: Is it a regression

[jira] [Commented] (KAFKA-16361) Rack aware sticky assignor minQuota violations

2024-03-14 Thread BDeus (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827134#comment-17827134 ] BDeus commented on KAFKA-16361: --- Is it a regression related to this ticket

Re: [PR] KAFKA-16226; Reduce synchronization between producer threads (#15323) [kafka]

2024-03-14 Thread via GitHub
msn-tldr commented on PR #15498: URL: https://github.com/apache/kafka/pull/15498#issuecomment-1997688081 @ijuma thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-16226; Reduce synchronization between producer threads (#15323) [kafka]

2024-03-14 Thread via GitHub
msn-tldr commented on PR #15493: URL: https://github.com/apache/kafka/pull/15493#issuecomment-199768 @ijuma thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
lucasbru commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1524575611 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1497,4 +1502,93 @@ public PollResult poll(final long

[jira] [Resolved] (KAFKA-16180) Full metadata request sometimes fails during zk migration

2024-03-14 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-16180. -- Resolution: Fixed > Full metadata request sometimes fails during zk migration >

[jira] [Updated] (KAFKA-16180) Full metadata request sometimes fails during zk migration

2024-03-14 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16180: - Fix Version/s: 3.6.2 3.7.0 > Full metadata request sometimes fails during zk

[jira] [Updated] (KAFKA-16372) max.block.ms behavior inconsistency with javadoc and the config description

2024-03-14 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-16372: - Description: As of Kafka 3.7.0, the javadoc of

[jira] [Commented] (KAFKA-16369) Broker may not shut down when SocketServer fails to bind as Address already in use

2024-03-14 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827107#comment-17827107 ] Edoardo Comar commented on KAFKA-16369: --- PR is ready for review - can anyone take a look please ?

  1   2   3   4   >