[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831631#comment-17831631
]
Manikumar commented on KAFKA-16310:
---
Thanks, I have reverted KAFKA-16341 and KAFKA-16342. commits
[
https://issues.apache.org/jira/browse/KAFKA-16342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-16342:
--
Fix Version/s: (was: 3.6.2)
> Fix compressed records
> --
>
>
[
https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-16341:
--
Fix Version/s: (was: 3.6.2)
> Fix un-compressed records
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar reopened KAFKA-16310:
---
> ListOffsets doesn't report the offset with maxTimestamp anymore
>
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-16310:
--
Fix Version/s: (was: 3.6.2)
> ListOffsets doesn't report the offset with maxTimestamp anymore
>
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831629#comment-17831629
]
Chia-Ping Tsai commented on KAFKA-16310:
{quote}
Can we revert the relavent changes from 3.6
[
https://issues.apache.org/jira/browse/KAFKA-16211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dung Ha reassigned KAFKA-16211:
---
Assignee: Dung Ha
> Inconsistent config values in CreateTopicsResult and DescribeConfigsResult
>
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831624#comment-17831624
]
Manikumar commented on KAFKA-16310:
---
[~chia7712] [~showuon] Can we revert the relavent changes from
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831624#comment-17831624
]
Manikumar edited comment on KAFKA-16310 at 3/28/24 5:15 AM:
[~chia7712]
kamalcph commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2024392191
@johnnychhsu
Can you update the PR summary if it is ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831619#comment-17831619
]
Kamal Chandraprakash commented on KAFKA-16161:
--
Not yet started. Will work on this task by
[
https://issues.apache.org/jira/browse/KAFKA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831617#comment-17831617
]
Abhijeet Kumar commented on KAFKA-15265:
I plan to raise the PRs in the next couple of weeks. I
sjhajharia commented on PR #15609:
URL: https://github.com/apache/kafka/pull/15609#issuecomment-2024377686
Thank you @chia7712 @jolshan @soarez for the review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
showuon commented on PR #15502:
URL: https://github.com/apache/kafka/pull/15502#issuecomment-2024338012
@FrankYang0529 , do we have any update for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831609#comment-17831609
]
Luke Chen commented on KAFKA-16435:
---
Thanks [~brandboat] !
> Add test for KAFKA-16428
>
github-actions[bot] commented on PR #14348:
URL: https://github.com/apache/kafka/pull/14348#issuecomment-2024335297
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
showuon merged PR #15549:
URL: https://github.com/apache/kafka/pull/15549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15549:
URL: https://github.com/apache/kafka/pull/15549#issuecomment-2024290120
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
showuon commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1542235961
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2024287098
> printUsageAndExit
Agree. Setting a dumb exit procedure solves the failed build. Let me revise
that
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831605#comment-17831605
]
Kuan Po Tseng commented on KAFKA-16435:
---
I'm willing to take over this ! Let me add some test~
[
https://issues.apache.org/jira/browse/KAFKA-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng reassigned KAFKA-16435:
-
Assignee: Kuan Po Tseng
> Add test for KAFKA-16428
>
>
>
KevinZTW commented on code in PR #15610:
URL: https://github.com/apache/kafka/pull/15610#discussion_r1542216359
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -806,12 +806,10 @@ private static void executeMoves(Admin adminClient,
showuon commented on code in PR #15610:
URL: https://github.com/apache/kafka/pull/15610#discussion_r1542188367
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -1485,6 +1483,7 @@ static Set
alterReplicaLogDirs(Admin adminClient,
apoorvmittal10 commented on code in PR #15532:
URL: https://github.com/apache/kafka/pull/15532#discussion_r1542173327
##
build.gradle:
##
@@ -1435,10 +1454,10 @@ project(':clients') {
implementation libs.opentelemetryProto
// libraries which should be added as
[
https://issues.apache.org/jira/browse/KAFKA-16437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher L. Shannon updated KAFKA-16437:
---
Description:
Jira to track
[
https://issues.apache.org/jira/browse/KAFKA-16437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher L. Shannon updated KAFKA-16437:
---
Description:
Jira to track
Christopher L. Shannon created KAFKA-16437:
--
Summary: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0 (KIP-1032)
Key: KAFKA-16437
URL: https://issues.apache.org/jira/browse/KAFKA-16437
Project:
jolshan commented on PR #15303:
URL: https://github.com/apache/kafka/pull/15303#issuecomment-2024062457
Closing since I will repurpose this for the Transaction Record change and we
have https://issues.apache.org/jira/browse/KAFKA-16308 for the general changes
to support new feature
jolshan closed pull request #15303: [WIP] KAFKA-16192: Introduce usage of
flexible records to coordinators
URL: https://github.com/apache/kafka/pull/15303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AndrewJSchofield commented on code in PR #15610:
URL: https://github.com/apache/kafka/pull/15610#discussion_r1542090972
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -806,12 +806,10 @@ private static void executeMoves(Admin
AndrewJSchofield commented on PR #15611:
URL: https://github.com/apache/kafka/pull/15611#issuecomment-2024044460
I'm not sure this is really an improvement. It's just an overloading method
which has one existing caller.
--
This is an automated message from the Apache Git Service.
To
AndrewJSchofield commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1542082131
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java:
##
@@ -204,16 +202,14 @@ public static byte[] compress(byte[]
dongnuo123 commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1542076157
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupProtocolMigrationPolicy.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831553#comment-17831553
]
Jun Rao commented on KAFKA-16310:
-
[~johnnyhsu] , [~showuon] and [~chia7712] : Sorry, but I just
Dongnuo Lyu created KAFKA-16436:
---
Summary: Online upgrade triggering and group type conversion
Key: KAFKA-16436
URL: https://issues.apache.org/jira/browse/KAFKA-16436
Project: Kafka
Issue
dongnuo123 commented on code in PR #15593:
URL: https://github.com/apache/kafka/pull/15593#discussion_r1542011267
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -760,6 +776,28 @@ public ClassicGroup classicGroup(
philipnee commented on code in PR #15594:
URL: https://github.com/apache/kafka/pull/15594#discussion_r1541985614
##
tests/kafkatest/services/connect.py:
##
@@ -534,33 +535,40 @@ def received_messages(self):
def start(self):
self.logger.info("Creating connector
gharris1727 commented on PR #15597:
URL: https://github.com/apache/kafka/pull/15597#issuecomment-2023838245
Hi @mimaison @C0urante PTAL at the latest WorkerConfig change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-16411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-16411.
--
Resolution: Fixed
> Correctly migrate default client quota entities in KRaft migration
>
[
https://issues.apache.org/jira/browse/KAFKA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-16428.
--
Resolution: Fixed
> Fix bug where config change notification znode may not get created during
Colin McCabe created KAFKA-16435:
Summary: Add test for KAFKA-16428
Key: KAFKA-16435
URL: https://issues.apache.org/jira/browse/KAFKA-16435
Project: Kafka
Issue Type: Bug
cmccabe merged PR #15608:
URL: https://github.com/apache/kafka/pull/15608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cmccabe commented on PR #15608:
URL: https://github.com/apache/kafka/pull/15608#issuecomment-2023799788
Yeah, I need to add a test. But I really want this fix to make 3.6.2. I
filed a follow-up here: https://issues.apache.org/jira/browse/KAFKA-16435
--
This is an automated message from
[
https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayoub Omari updated KAFKA-16434:
Description:
We have two topics : _left-topic[String, LeftRecord]_ and _right-topic[String,
[
https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayoub Omari updated KAFKA-16434:
Description:
We have two topics : _left-topic[String, LeftRecord]_ and _right-topic[String,
Ayoub Omari created KAFKA-16434:
---
Summary: ForeignKey INNER join does not unset join result when FK
becomes null
Key: KAFKA-16434
URL: https://issues.apache.org/jira/browse/KAFKA-16434
Project: Kafka
chia7712 merged PR #15609:
URL: https://github.com/apache/kafka/pull/15609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15609:
URL: https://github.com/apache/kafka/pull/15609#issuecomment-2023772318
the failed tests pass on my machine, so I'm going to merge it.
```sh
./gradlew cleanTest :streams:test --tests
[
https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831501#comment-17831501
]
Ayoub Omari commented on KAFKA-16407:
-
Actually this behavior is not concerned by this KIP, it's a
[
https://issues.apache.org/jira/browse/KAFKA-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831494#comment-17831494
]
Pavel Pozdeev commented on KAFKA-15713:
---
[~johndoe] now I've got access to assign tickets,
[
https://issues.apache.org/jira/browse/KAFKA-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pavel Pozdeev reassigned KAFKA-15713:
-
Assignee: Pavel Pozdeev
> KRaft support in SaslClientsWithInvalidCredentialsTest
>
[
https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15561:
--
Priority: Blocker (was: Major)
> Client support for new SubscriptionPattern based subscription
>
[
https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15561:
--
Fix Version/s: 4.0.0
(was: 3.8.0)
> Client support for new SubscriptionPattern
[
https://issues.apache.org/jira/browse/KAFKA-15697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15697:
--
Fix Version/s: (was: 4.0.0)
> Add local assignor and ensure it cannot be used with server side
[
https://issues.apache.org/jira/browse/KAFKA-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16109:
--
Summary: Write system tests cover the "simple consumer + commit" use case
(was: Ensure system tests
[
https://issues.apache.org/jira/browse/KAFKA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15283:
--
Priority: Critical (was: Major)
> Client support for OffsetFetch and OffsetCommit with topic ID
>
[
https://issues.apache.org/jira/browse/KAFKA-15279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15279:
--
Fix Version/s: (was: 4.0.0)
> Implement client support for KIP-848 client-side assigner RPCs
>
[
https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15284:
--
Fix Version/s: (was: 4.0.0)
> Implement ConsumerGroupProtocolVersionResolver to determine
[
https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16110:
--
Priority: Blocker (was: Major)
> Implement consumer performance tests
>
[
https://issues.apache.org/jira/browse/KAFKA-15282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15282:
--
Fix Version/s: (was: 4.0.0)
> Implement client support for KIP-848 client-side assignors
>
[
https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16143:
--
Priority: Minor (was: Major)
> New metrics for KIP-848 protocol
>
>
apoorvmittal10 commented on code in PR #15589:
URL: https://github.com/apache/kafka/pull/15589#discussion_r1541573651
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java:
##
@@ -132,9 +133,9 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16310.
Resolution: Fixed
> ListOffsets doesn't report the offset with maxTimestamp anymore
>
mimaison commented on code in PR #15532:
URL: https://github.com/apache/kafka/pull/15532#discussion_r1541600741
##
build.gradle:
##
@@ -1435,10 +1454,10 @@ project(':clients') {
implementation libs.opentelemetryProto
// libraries which should be added as runtime
[
https://issues.apache.org/jira/browse/KAFKA-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16433:
--
Labels: consumer-threading-refactor timeout (was:
consumer-threading-refactor)
> beginningOffsets
[
https://issues.apache.org/jira/browse/KAFKA-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16433:
--
Issue Type: Bug (was: Task)
> beginningOffsets and offsetsForTimes don't behave consistently when
[
https://issues.apache.org/jira/browse/KAFKA-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16433:
--
Component/s: clients
> beginningOffsets and offsetsForTimes don't behave consistently when providing
[
https://issues.apache.org/jira/browse/KAFKA-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16433:
--
Fix Version/s: 3.8.0
> beginningOffsets and offsetsForTimes don't behave consistently when providing
[
https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831468#comment-17831468
]
Matthias J. Sax commented on KAFKA-16407:
-
Did
ijuma commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1541513692
##
core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala:
##
@@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1541508048
##
core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala:
##
@@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831464#comment-17831464
]
Johnny Hsu commented on KAFKA-16310:
{quote}[~chia7712] thanks for the help!
This returns the
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831464#comment-17831464
]
Johnny Hsu edited comment on KAFKA-16310 at 3/27/24 5:01 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-16433:
---
Labels: consumer-threading-refactor (was: )
> beginningOffsets and offsetsForTimes don't behave
Philip Nee created KAFKA-16433:
--
Summary: beginningOffsets and offsetsForTimes don't behave
consistently when providing a zero timeout
Key: KAFKA-16433
URL: https://issues.apache.org/jira/browse/KAFKA-16433
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831463#comment-17831463
]
Chia-Ping Tsai commented on KAFKA-16310:
@johnnyhsu thanks for offers the description. I add
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1541492785
##
server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java:
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
philipnee commented on PR #15525:
URL: https://github.com/apache/kafka/pull/15525#issuecomment-2023293507
@lucasbru - If I'm not mistaken, the current implementation for both
beginningOrEndOffsets and OffsetsForTimes both need to send out a request upon
getting ZERO duration. Seems like
ijuma commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1541483681
##
core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala:
##
@@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831460#comment-17831460
]
Johnny Hsu commented on KAFKA-16310:
The update is in below section:
## When the TimestampType
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1541475816
##
core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala:
##
@@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1541472627
##
server/src/main/java/org/apache/kafka/security/CredentialProvider.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1541471761
##
server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java:
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
lianetm commented on code in PR #15612:
URL: https://github.com/apache/kafka/pull/15612#discussion_r1541452355
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##
@@ -0,0 +1,320 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
mimaison commented on PR #15569:
URL: https://github.com/apache/kafka/pull/15569#issuecomment-2023212508
Now that https://github.com/apache/kafka/pull/15075 got merged, this needs
rebasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
clolov commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-2023192543
Hello @cadonna! This ought to be one of the last PRs for the migration. I
will circle back tomorrow morning to rebase it since it has been out for a long
time
--
This is an automated
CalvinConfluent commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2023173614
@kirktrue @jolshan Anything else we need to address for this ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831438#comment-17831438
]
Henry Cai commented on KAFKA-15265:
---
Thanks. [~abhijeetkumar] Do you have a rough timeline when the
gharris1727 commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541420383
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -580,8 +601,15 @@ private Map
instantiateConfigProviders(Map
johnnychhsu commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1541419703
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
OmniaGM commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1541382798
##
server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java:
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
akatona84 commented on code in PR #15605:
URL: https://github.com/apache/kafka/pull/15605#discussion_r1541384909
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when}
import
akatona84 commented on code in PR #15605:
URL: https://github.com/apache/kafka/pull/15605#discussion_r1541384909
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when}
import
lucasbru opened a new pull request, #15613:
URL: https://github.com/apache/kafka/pull/15613
The javadoc for `KafkaConsumer.commitSync` says:
> Note that asynchronous offset commits sent previously with the {@link
#commitAsync(OffsetCommitCallback)}
> (or similar) are guaranteed to
akatona84 commented on code in PR #15605:
URL: https://github.com/apache/kafka/pull/15605#discussion_r1541378249
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when}
import
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2023109755
@Owen-CH-Leung The `printUsageAndExit` call `exit(1)` so `KRAFT` and
`CO_KRAFT` will stop the JVM. `ZK` can capture the exit code to throw exception
so it does not terminate the JVM.
soarez commented on code in PR #15605:
URL: https://github.com/apache/kafka/pull/15605#discussion_r1541375369
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when}
import
lianetm commented on PR #15612:
URL: https://github.com/apache/kafka/pull/15612#issuecomment-2023088189
@lucasbru this is one more last split that I find would make sense. With
this, all the tests left in the `PlainTextConsumer` do not seem to belong to
any sensible group other than the
akatona84 commented on code in PR #15605:
URL: https://github.com/apache/kafka/pull/15605#discussion_r1541357369
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -38,19 +38,57 @@ import org.mockito.Mockito.{mock, when}
import
1 - 100 of 179 matches
Mail list logo
