omkreddy opened a new pull request, #15665:
URL: https://github.com/apache/kafka/pull/15665
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2038933841
blocked by #15663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2038916109
previous failed tests are gone. rebase to trigger QA again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834133#comment-17834133
]
Chia-Ping Tsai commented on KAFKA-16471:
I have pushed to master
FrankYang0529 opened a new pull request, #15664:
URL: https://github.com/apache/kafka/pull/15664
Add how to run local website to `docs` folder.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
chia7712 merged PR #15641:
URL: https://github.com/apache/kafka/pull/15641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 merged PR #15655:
URL: https://github.com/apache/kafka/pull/15655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834131#comment-17834131
]
Chia-Ping Tsai commented on KAFKA-16310:
{quote}
Will this bug not be fixed in 3.6.2 ?
{quote}
chia7712 closed pull request #15637: KAFKA-16225 Flaky test suite
LogDirFailureTest#testIOExceptionDuringLogRoll
URL: https://github.com/apache/kafka/pull/15637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on PR #15637:
URL: https://github.com/apache/kafka/pull/15637#issuecomment-2038837427
close as duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
showuon commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2038807461
@FrankYang0529 , thanks for the fix! Nice catch!
Questions:
1. How could we confirm the `String quorum` missing only in
`DeleteOffsetsConsumerGroupCommandIntegrationTest`, not
[
https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834130#comment-17834130
]
PoAn Yang commented on KAFKA-16472:
---
{quote}could you confirm only these 4 test suites are impacted,
github-actions[bot] commented on PR #14666:
URL: https://github.com/apache/kafka/pull/14666#issuecomment-2038787933
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #14715:
URL: https://github.com/apache/kafka/pull/14715#issuecomment-2038787793
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #15099:
URL: https://github.com/apache/kafka/pull/15099#issuecomment-2038787254
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834129#comment-17834129
]
HiroArai commented on KAFKA-16310:
--
[~chia7712] [~omkreddy]
> [~ijuma] Are you worry about the
[
https://issues.apache.org/jira/browse/KAFKA-16262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834123#comment-17834123
]
Matthias J. Sax commented on KAFKA-16262:
-
Of course you can work on this ticket.
Did you
FrankYang0529 opened a new pull request, #15663:
URL: https://github.com/apache/kafka/pull/15663
Following test cases don't really run kraft case. The reason is that the
test info doesn't contain parameter name, so it always returns false in
TestInfoUtils#isKRaft.
-
showuon commented on PR #15335:
URL: https://github.com/apache/kafka/pull/15335#issuecomment-2038496756
@OmniaGM , there is compilation error in jdk8_scala2.12 job. Could you have
a look?
```
[2024-04-04T09:19:51.266Z] [Error]
[
https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834106#comment-17834106
]
Luke Chen commented on KAFKA-16472:
---
[~yangpoan] , great find! But how could you confirm only these 4
gaurav-narula commented on PR #15637:
URL: https://github.com/apache/kafka/pull/15637#issuecomment-2038293124
I think this might be due to KAFKA-16234 which has a PR at
https://github.com/apache/kafka/pull/15335
--
This is an automated message from the Apache Git Service.
To respond to
thaumatoast commented on PR #7139:
URL: https://github.com/apache/kafka/pull/7139#issuecomment-2038272787
I'm currently facing this issue (and not mixing versions). This appears to
be a bug regardless of version mixing, is there a reason not to merge this?
--
This is an automated message
philipnee commented on PR #15661:
URL: https://github.com/apache/kafka/pull/15661#issuecomment-2038266652
Can we change the message to : `err_msg="expecting valid assignments of %d
partitions for node %d but got: %s" % \`
--
This is an automated message from the Apache Git Service.
To
philipnee commented on PR #15661:
URL: https://github.com/apache/kafka/pull/15661#issuecomment-2038263452
Thanks for reviewing this. This is the test results:
```
SESSION REPORT (ALL TESTS)
[
https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834082#comment-17834082
]
Kirk True commented on KAFKA-16460:
---
Good or bad, the test actually passes a good fraction of the
dongnuo123 opened a new pull request, #15662:
URL: https://github.com/apache/kafka/pull/15662
Based on https://github.com/apache/kafka/pull/15411, the pr contains
triggering of group conversion from a classic group to a consumer group.
In consumerGroupHeartbeat, the online migration
philipnee commented on PR #15661:
URL: https://github.com/apache/kafka/pull/15661#issuecomment-2038186018
@kirktrue - This inherits from the patch you attached to the jira ticket.
Would you have time to review this PR?
--
This is an automated message from the Apache Git Service.
To
philipnee opened a new pull request, #15661:
URL: https://github.com/apache/kafka/pull/15661
The current AssignmentValidationTest only tests EAGER assignment protocol
and does not support incremental assignment like CooperativeStickyAssignor and
consumer protocol. Therefore in the
cadonna commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1552378325
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -309,49 +300,49 @@ public void
junrao commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1552358023
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -189,14 +215,56 @@ class ListOffsetsIntegrationTest extends
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2038064405
@junrao thanks for reviews. I have removed the useless log and revise the
test. let us see what happens.
--
This is an automated message from the Apache Git Service.
To respond to
junrao commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1552264764
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -483,12 +484,13 @@ public int recover(ProducerStateManager
producerStateManager,
cmccabe commented on PR #15604:
URL: https://github.com/apache/kafka/pull/15604#issuecomment-2037940819
This is not bad but does the RPC show up on the server yet? We can't add it
until it's implemented.
I think you should set `latestVersionUnstable: "true"` and then maybe we
could
cmccabe commented on PR #15603:
URL: https://github.com/apache/kafka/pull/15603#issuecomment-2037928952
I think the very first thing to do is to implement an enum for the new
"recovery strategy" thing, and replace all the cases where we're using a
boolean with this enum. So the boolean
junrao commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1552178574
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {
smarsching commented on code in PR #15658:
URL: https://github.com/apache/kafka/pull/15658#discussion_r1552171112
##
core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala:
##
@@ -87,8 +87,12 @@ object KafkaDockerWrapper {
parser.parseArgsOrFail(args)
}
- private
dongnuo123 commented on PR #15411:
URL: https://github.com/apache/kafka/pull/15411#issuecomment-2037835825
Will need to add unit tests for the change when group upgrade/downgrade
conversion is finished.
--
This is an automated message from the Apache Git Service.
To respond to the
dongnuo123 commented on PR #15587:
URL: https://github.com/apache/kafka/pull/15587#issuecomment-2037838999
Need to add unit tests for the change when the group upgrade/downgrade
conversion are finished.
--
This is an automated message from the Apache Git Service.
To respond to the
Colin McCabe created KAFKA-16475:
Summary: Create unit test for TopicImageNode
Key: KAFKA-16475
URL: https://issues.apache.org/jira/browse/KAFKA-16475
Project: Kafka
Issue Type: Improvement
mjsax opened a new pull request, #15660:
URL: https://github.com/apache/kafka/pull/15660
Kafka Streams DSL operators use internal wall-clock based throttling
parameters for performance reasons. These configs make the usage of TTD
difficult: users need to advance the mocked wall-clock time
gaurav-narula commented on code in PR #15655:
URL: https://github.com/apache/kafka/pull/15655#discussion_r1552109605
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -1528,4 +1530,29 @@ public void
brandboat commented on code in PR #15658:
URL: https://github.com/apache/kafka/pull/15658#discussion_r1552104493
##
core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala:
##
@@ -87,8 +87,12 @@ object KafkaDockerWrapper {
parser.parseArgsOrFail(args)
}
- private
chia7712 commented on code in PR #15655:
URL: https://github.com/apache/kafka/pull/15655#discussion_r1552096474
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -1528,4 +1530,29 @@ public void
brandboat opened a new pull request, #15659:
URL: https://github.com/apache/kafka/pull/15659
related to KAFKA-16455
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify
[
https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834021#comment-17834021
]
Sebastian Marsching commented on KAFKA-16473:
-
[~brandboat] The PR is now available at
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2037697246
>
(kafka.admin.ListOffsetsIntegrationTest.testThreeCompressedRecordsInSeparateBatch(String).quorum=kraft)
failed with the following.
I'm trying to reproduce it on my local :(
smarsching opened a new pull request, #15658:
URL: https://github.com/apache/kafka/pull/15658
This fixes an issue that when starting a Docker container for the first
time, the cluster ID used when formatting the log dir would not be
`$CLUSTER_ID` but `Some($CLUSTER_ID)` (KAFKA-16473).
CalvinConfluent opened a new pull request, #15657:
URL: https://github.com/apache/kafka/pull/15657
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dongnuo123 commented on code in PR #15587:
URL: https://github.com/apache/kafka/pull/15587#discussion_r1552050811
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2451,6 +2451,8 @@ private CoordinatorResult
Joker-5 commented on code in PR #15642:
URL: https://github.com/apache/kafka/pull/15642#discussion_r1552049826
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java:
##
@@ -69,6 +69,9 @@ public static void setup() {
Joker-5 commented on code in PR #15642:
URL: https://github.com/apache/kafka/pull/15642#discussion_r1552049826
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java:
##
@@ -69,6 +69,9 @@ public static void setup() {
junrao commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1552022713
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -189,14 +220,49 @@ class ListOffsetsIntegrationTest extends
[
https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834001#comment-17834001
]
Kuan Po Tseng commented on KAFKA-16473:
---
> I would appreciate a review of that PR, though.
Sure,
[
https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833999#comment-17833999
]
Sebastian Marsching commented on KAFKA-16473:
-
I am currently working on a PR that should
[
https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-16474:
---
Summary: AsyncKafkaConsumer might send out heartbeat request without
waiting for its response
[
https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833997#comment-17833997
]
Kuan Po Tseng commented on KAFKA-16473:
---
Thank you for the detailed description. Are you planning
[
https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-16474:
---
Summary: AsyncKafkaConsumer might rapidly send out successive heartbeat
without waiting for the
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2037601997
merge trunk to trigger QA again. Also, the error seems happen due to
unchanged leader. will check it later
--
This is an automated message from the Apache Git Service.
To respond to
Philip Nee created KAFKA-16474:
--
Summary: AsyncKafkaConsumer might rapidly send out successive
heartbeat causing partitions getting revoked
Key: KAFKA-16474
URL: https://issues.apache.org/jira/browse/KAFKA-16474
[
https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833990#comment-17833990
]
Kuan Po Tseng commented on KAFKA-16472:
---
And the javadoc in junit5 also mentions that
[
https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833988#comment-17833988
]
Kuan Po Tseng commented on KAFKA-16472:
---
Looks like
Sebastian Marsching created KAFKA-16473:
---
Summary: KafkaDockerWrapper uses wrong cluster ID when formatting
log dir
Key: KAFKA-16473
URL: https://issues.apache.org/jira/browse/KAFKA-16473
[
https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833985#comment-17833985
]
Chia-Ping Tsai commented on KAFKA-16472:
[~brandboat] Could you share the junit 5 details we
PoAn Yang created KAFKA-16472:
-
Summary: Integration tests in Java don't really run kraft case
Key: KAFKA-16472
URL: https://issues.apache.org/jira/browse/KAFKA-16472
Project: Kafka
Issue Type:
dongnuo123 commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1551865511
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -251,6 +252,7 @@ object KafkaConfig {
val ConsumerGroupMaxHeartbeatIntervalMsProp
dajac commented on PR #15652:
URL: https://github.com/apache/kafka/pull/15652#issuecomment-2037428994
> Also, it seems the following classes are useless.
Yeah, I noticed those classes too. I am actually not sure what we kept them.
It may be for backward compatibility. I need to dig a
dajac commented on code in PR #15652:
URL: https://github.com/apache/kafka/pull/15652#discussion_r1551827679
##
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##
@@ -398,9 +399,34 @@ object DumpLogSegments {
}
}
- private class OffsetsMessageParser extends
chia7712 commented on code in PR #15652:
URL: https://github.com/apache/kafka/pull/15652#discussion_r1551795883
##
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##
@@ -398,9 +399,34 @@ object DumpLogSegments {
}
}
- private class OffsetsMessageParser extends
OmniaGM commented on PR #15655:
URL: https://github.com/apache/kafka/pull/15655#issuecomment-2037372617
Nice catch @gaurav-narula! the fix seems straightforward! LGTM assuming the
pipeline will pass
--
This is an automated message from the Apache Git Service.
To respond to the message,
gaurav-narula commented on code in PR #15655:
URL: https://github.com/apache/kafka/pull/15655#discussion_r1551794309
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -1528,4 +1530,30 @@ public void
OmniaGM commented on code in PR #15655:
URL: https://github.com/apache/kafka/pull/15655#discussion_r1551791995
##
clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java:
##
@@ -204,7 +204,9 @@ public void close() throws IOException {
} catch
OmniaGM commented on code in PR #15655:
URL: https://github.com/apache/kafka/pull/15655#discussion_r1551791995
##
clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java:
##
@@ -204,7 +204,9 @@ public void close() throws IOException {
} catch
OmniaGM commented on code in PR #15655:
URL: https://github.com/apache/kafka/pull/15655#discussion_r1551790292
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -1528,4 +1530,30 @@ public void
OmniaGM commented on code in PR #15655:
URL: https://github.com/apache/kafka/pull/15655#discussion_r1551787559
##
clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java:
##
@@ -199,6 +199,14 @@ public void close() throws IOException {
} catch
OmniaGM commented on PR #15656:
URL: https://github.com/apache/kafka/pull/15656#issuecomment-2037325362
@nizhikov can you have a look when you have time please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula updated KAFKA-16471:
--
Fix Version/s: 3.8.0
3.7.1
> SslTransportLayer may leak SSLEngine
gaurav-narula commented on PR #15655:
URL: https://github.com/apache/kafka/pull/15655#issuecomment-2037308254
CC: @rajinisivaram @ijuma @harshach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gaurav-narula opened a new pull request, #15655:
URL: https://github.com/apache/kafka/pull/15655
Invokes `SSLEngine::closeInbound` after we flush close_notify alert to the
socket. This fixes memory leak in Netty/OpenSSL based SSLEngine which only free
native resources once closeInbound has
OmniaGM opened a new pull request, #15656:
URL: https://github.com/apache/kafka/pull/15656
part 3 for https://github.com/apache/kafka/pull/15501
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
[
https://issues.apache.org/jira/browse/KAFKA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula reassigned KAFKA-16471:
-
Assignee: Gaurav Narula
> SslTransportLayer may leak SSLEngine resources
>
Gaurav Narula created KAFKA-16471:
-
Summary: SslTransportLayer may leak SSLEngine resources
Key: KAFKA-16471
URL: https://issues.apache.org/jira/browse/KAFKA-16471
Project: Kafka
Issue Type:
chia7712 commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1551687551
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -260,9 +274,12 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
mumrah commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1551680241
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2185,9 +2185,157 @@ void handleFailure(Throwable throwable) {
mumrah merged PR #14706:
URL: https://github.com/apache/kafka/pull/14706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #15645:
URL: https://github.com/apache/kafka/pull/15645#discussion_r1551656009
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
chia7712 opened a new pull request, #15654:
URL: https://github.com/apache/kafka/pull/15654
we can't get correct offsets :(
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
chia7712 commented on PR #15645:
URL: https://github.com/apache/kafka/pull/15645#issuecomment-2037116797
> Looks like CI OK. Can you, please, take a look?
thanks for updated PR. Sorry that I'm digging in the flaky tests in our CI,
but I will take a look at this one ASAP.
--
This
dajac commented on code in PR #15587:
URL: https://github.com/apache/kafka/pull/15587#discussion_r1551577818
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2814,7 +2820,9 @@ private CoordinatorResult
nizhikov commented on PR #15645:
URL: https://github.com/apache/kafka/pull/15645#issuecomment-2037008993
Hello @chia7712
Looks like CI OK. Can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1551485397
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -251,6 +252,7 @@ object KafkaConfig {
val ConsumerGroupMaxHeartbeatIntervalMsProp
vamossagar12 commented on PR #15305:
URL: https://github.com/apache/kafka/pull/15305#issuecomment-2036805236
@showuon would you have time to review this? It's a smallish change. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vamossagar12 commented on code in PR #15642:
URL: https://github.com/apache/kafka/pull/15642#discussion_r1551420344
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java:
##
@@ -69,6 +69,9 @@ public static void setup() {
vamossagar12 opened a new pull request, #15653:
URL: https://github.com/apache/kafka/pull/15653
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vamossagar12 commented on PR #15556:
URL: https://github.com/apache/kafka/pull/15556#issuecomment-2036758332
@johnnychhsu I am still not sure that this is the root cause. As I said
above:
> I ran the test locally and noticed the same plugin loading errors but the
test did pass
chia7712 commented on PR #15639:
URL: https://github.com/apache/kafka/pull/15639#issuecomment-2036758667
> have delayed backporting either change to 3.6 as we're currently in an
ongoing release. If you'd like me to backport it now, I can do that.
That makes sense. Let's wait for the
chia7712 commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1551371510
##
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala:
##
@@ -197,12 +198,11 @@ class ServerShutdownTest extends KafkaServerTestHarness {
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16359.
---
Fix Version/s: 3.8.0
3.7.1
Resolution: Fixed
> kafka-clients-3.7.0.jar
showuon merged PR #15532:
URL: https://github.com/apache/kafka/pull/15532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gaurav-narula commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1551349514
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File],
}
}
+ def
OmniaGM commented on PR #15335:
URL: https://github.com/apache/kafka/pull/15335#issuecomment-2036695494
Thanks, and sorry for the delay I was trying to find any test beside the
system test to test the full scenario in this PR but I think proofing the main
cause is enough for now
--
This
1 - 100 of 107 matches
Mail list logo
