[Lift] Re: Master is fundamentally broken!!!!!!

2010-02-24 Thread Timothy Perrett
Scratch that, it just does this all the time - irrelevant of the mime type. Reproduce this by making a blank lift app and looking at the source. Cheers, Tim On Feb 24, 11:14 am, Timothy Perrett timo...@getintheloop.eu wrote: Guys, I see DPP made a bunch of commits last night. Something in

[Lift] Re: Master is fundamentally broken!!!!!!

2010-02-24 Thread Timothy Perrett
I can verify that the issue causing this is: 703a728af05fddda0f8c5e302cce21a9dc065b54 Can we please back this change out as this is affecting ALL lift applications Cheers, Tim On Feb 24, 1:09 pm, Timothy Perrett timo...@getintheloop.eu wrote: Scratch that, it just does this all the time -

Re: [Lift] Re: Master is fundamentally broken!!!!!!

2010-02-24 Thread Indrajit Raychaudhuri
Done in master. Wait for Hudson to respin. Committers, sorry for direct commit to master and breaking the rule but Tim's need was urgent. Have done quick smoke test locally. - Indrajit On 24/02/10 6:56 PM, Timothy Perrett wrote: I can verify that the issue causing this is:

Re: [Lift] Re: Master is fundamentally broken!!!!!!

2010-02-24 Thread Timothy Perrett
Yeah I already fixed it locally to work around the issue; thanks for pushing. Was going to do it anyway after lunch. Do you know who reviewed this? I can't find any reference to it Sent from my iPhone On 24 Feb 2010, at 13:51, Indrajit Raychaudhuri indraj...@gmail.com wrote: Done in

[Lift] Re: Master is fundamentally broken!!!!!!

2010-02-24 Thread Timothy Perrett
To clarify, im wondering who reviewed this on RB and gave it a ship it? A simple test would have shown it to be broken ;-) Cheers, Tim PS: thanks Indrajit for your concern :-) On Feb 24, 1:57 pm, Timothy Perrett timo...@getintheloop.eu wrote: Yeah I already fixed it locally to work around the