Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On 17-02-07 10:32:16, Steve Calfee wrote: > On Mon, Feb 6, 2017 at 4:51 AM, Petko Manolov wrote: > > On 17-02-06 09:28:22, Greg KH wrote: > >> On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: > >> > On 17-02-05 01:30:39, Greg KH wrote: > >> > > On Sat, Feb 04,

[PATCH 2/2] drivers: usb: gadget: udc: remove logically dead code

Remove unnecesary code because zlt never evaluates to zero. Addresses-Coverity-ID: 1226747 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/udc/mv_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

Add missing break in switch. Addresses-Coverity-ID: 201385 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/udc/mv_udc_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index

[PATCH] drivers: usb: early: remove unused code

Remove this line of code because devnum is overwritten before it can be used. This could happen if line of code 609 (goto try_again;) is executed. Otherwise, devnum is never used again. Addresses-Coverity-ID: 1226870 Signed-off-by: Gustavo A. R. Silva ---

How to resolve "Waited 2000ms for CONNECT" in system resuming?

Hi, In my environment, it causes the following message during system resume if debug messages are enabled: usb 2-1: Waited 2000ms for CONNECT < My environment > - EHCI/OHCI controllers on R-Car H3 (arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts) - Greg's usb.git / next branch

[PATCH] drivers: usb-misc: sisusbvga: remove dead code

The condition modex % 16 cannot be true when modex value is equal to 640 The condition du & 0xff cannot be true when du value is equal to 0x1400 Addresses-Coverity-Id: 101163 Addresses-Coverity-Id: 744373 Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH net-next v2 08/12] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

Hi Florian, On Tue, 2017-02-07 at 15:03 -0800, Florian Fainelli wrote: > From: Russell King > > drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration > of function 'try_module_get' [-Werror=implicit-function-declaration] > > Add

Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

Hi Stefan, [auto build test WARNING on net-next/master] [also build test WARNING on v4.10-rc7] [cannot apply to next-20170207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stefan-Br-ns

[PATCH v3 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

If a context is configured as dualstack ("IPv4v6"), the modem indicates the context activation with a slightly different indication message. The dual-stack indication omits the link_type (IPv4/v6) and adds additional address fields. IPv6 LSIs are identical to IPv4 LSIs, but have a different link

[PATCH v3 2/2] sierra_net: Skip validating irrelevant fields for IDLE LSIs

When the context is deactivated, the link_type is set to 0xff, which triggers a warning message, and results in a wrong link status, as the LSI is ignored. Signed-off-by: Stefan Brüns --- drivers/net/usb/sierra_net.c | 14 +++--- 1 file changed, 7

[PATCH v3 0/2] Fixes for sierra_net driver

When trying to initiate a dual-stack (ipv4v6) connection, a MC7710, FW version SWI9200X_03.05.24.00ap answers with an unsupported LSI. Add support for this LSI. Also the link_type should be ignored when going idle, otherwise the modem is stuck in a bad link state. Tested on MC7710, T-Mobile DE,

RE: [PATCH resend v5 0/4] xhci fixes for usb-linus

> >> On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: >> > Hi Greg >> > >> > This series by Arnd Bergmann was originally six patches, but last >> > two of them were already taken to 4.10. Without the rest of them >> > there will be a regression in 4.10. >> > >> > Original cover

Re: USB SUBSYSTEM - drivers/usb/core/config.c

Am Dienstag, den 07.02.2017, 19:01 +0100 schrieb John Skelton: > I'm open to any suggestions.  As I see it the above code is probably > wrong > in trying to use a low speed Bulk endpoint.  The low performance of > cheap > Arduinos and digistump etc (with no hardware USB) is not going to > allow >

[PATCH net-next v2 02/12] net: cgroups: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or '...' before string constant MODULE_LICENSE("GPL v2"); ^~~~ Add linux/module.h to fix this. Signed-off-by: Russell King

[PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

Hi all, Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures

[PATCH net-next v2 03/12] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of declaration drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/ethernet/cadence/macb.h:862:33: sparse: got

[PATCH net-next v2 04/12] net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/usb/lan78xx.c:394:33: sparse: expected ; at end of declaration drivers/net/usb/lan78xx.c:394:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/usb/lan78xx.c:394:33: sparse: got interface

[PATCH net-next v2 01/12] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc code: net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put': net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function

[PATCH net-next v2 05/12] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus' drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start'

[PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*()

From: Russell King octeon-platform.c can not be built as a module for two reasons: (a) the Makefile doesn't allow it: obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o (b) the multiple *_initcall() statements, each of which are translated

[PATCH net-next v2 12/12] net: dsa: remove unnecessary phy*.h includes

From: Russell King Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the

[PATCH net-next v2 10/12] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class

[PATCH net-next v2 08/12] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration] Add linux/module.h to iscsi_target_login.c. Signed-off-by: Russell King

[PATCH net-next v2 06/12] net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing pointer to incomplete type 'struct fixed_phy_status' Add linux/phy_fixed.h to fman_memac.c Signed-off-by: Russell King ---

[PATCH net-next v2 07/12] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable

[PATCH net-next v2 11/12] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

From: Russell King Fix these errors reported by the 0-day builder by replacing the linux/export.h include with linux/module.h. In file included from include/linux/platform_device.h:14:0, from drivers/net/wireless/ath/ath5k/ahb.c:20:

Re: [PATCH V2 1/2] dt-bindings: leds: document new led-triggers property

On Wed, Feb 1, 2017 at 3:55 PM, Rafał Miłecki wrote: > On 02/01/2017 10:26 PM, Jacek Anaszewski wrote: >> >> On 02/01/2017 04:56 PM, Rafał Miłecki wrote: >>> >>> On 01/31/2017 10:34 PM, Jacek Anaszewski wrote: On 01/31/2017 05:11 PM, Rafał Miłecki wrote: > >

Re: [PATCH V2 1/2] dt-bindings: leds: document new led-triggers property

On 02/03/2017 12:00 AM, Rafał Miłecki wrote: > On 02/02/2017 09:44 PM, Jacek Anaszewski wrote: >> On 02/01/2017 10:55 PM, Rafał Miłecki wrote: >>> On 02/01/2017 10:26 PM, Jacek Anaszewski wrote: On 02/01/2017 04:56 PM, Rafał Miłecki wrote: > On 01/31/2017 10:34 PM, Jacek Anaszewski wrote:

Re: USB SUBSYSTEM - drivers/usb/core/config.c

On Tue, 7 Feb 2017, John Skelton wrote: > > What happens after that? Does the cdc-acm driver refuse to bind? Any > > other types of error/warning messages? > > Along the lines of: > usb 2-1.2: >new low-speed USB device number 95 using ehci_hcd > usb 2-1.2: >device descriptor read/64, error -32

Re: USB SUBSYSTEM - drivers/usb/core/config.c

On Tue, Feb 07, 2017 at 07:28:40PM +0100, John Skelton wrote: > > From: "Greg KH" > > On Tue, Feb 07, 2017 at 06:56:20PM +0100, John Skelton wrote: > > > > From: "Felipe Balbi" > > > > > I'm particularly interested in drivers/usb/core/config.c > > >

Re: [PATCH v2 2/2] sierra_net: Skip validating irrelevant fields for IDLE LSIs

From: Stefan Brüns Date: Tue, 7 Feb 2017 03:33:17 +0100 > When the context is deactivated, the link_type is set to 0xff, which > triggers a warning message, and results in a wrong link status, as > the LSI is ignored. > > Signed-off-by: Stefan Brüns

Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

From: Stefan Brüns Date: Tue, 7 Feb 2017 03:33:16 +0100 > If a context is configured as dualstack ("IPv4v6"), the modem indicates > the context activation with a slightly different indication message. > The dual-stack indication omits the link_type (IPv4/v6) and

Re: USB SUBSYSTEM - drivers/usb/core/config.c

> From: "Greg KH" > To: "John Skelton" [snip] > > > > It is code which is derived from V-USB > > > > https://www.obdev.at/products/vusb/index.html > > > > and is described at > > > > http://www.recursion.jp/prose/avrcdc/cdc-232.html > > > > > > > > If it worked

Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

From: David Miller Date: Tue, 07 Feb 2017 13:53:12 -0500 (EST) > From: Stefan Brüns > Date: Tue, 7 Feb 2017 03:33:16 +0100 > >> If a context is configured as dualstack ("IPv4v6"), the modem indicates >> the context activation with a slightly

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On Mon, Feb 6, 2017 at 4:51 AM, Petko Manolov wrote: > On 17-02-06 09:28:22, Greg KH wrote: >> On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: >> > On 17-02-05 01:30:39, Greg KH wrote: >> > > On Sat, Feb 04, 2017 at 04:56:03PM +, Ben Hutchings wrote: >> >

Re: USB SUBSYSTEM - drivers/usb/core/config.c

> From: "Greg KH" > On Tue, Feb 07, 2017 at 06:56:20PM +0100, John Skelton wrote: > > > From: "Felipe Balbi" > > > > I'm particularly interested in drivers/usb/core/config.c > > > > which appears to enforce the USB specification by refusing to allow

Re: USB SUBSYSTEM - drivers/usb/core/config.c

On Tue, Feb 07, 2017 at 06:56:20PM +0100, John Skelton wrote: > > From: "Felipe Balbi" > > > I'm particularly interested in drivers/usb/core/config.c > > > which appears to enforce the USB specification by refusing to allow a > > > low speed CDC ACM. (Comment "Some

Re: USB SUBSYSTEM - drivers/usb/core/config.c

> From: "Greg KH" > On Tue, Feb 07, 2017 at 05:51:05PM +0100, John Skelton wrote: > > Apologies if this ought to have gone to the USB maintainer (but his > > auto-reply implies not). > > This is the correct place. Thanks. > > I'm particularly interested in

Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

From: Stefan Brüns Date: Mon, 6 Feb 2017 21:20:33 +0100 > > /* Validate the protocol - only support UMTS for now */ > - if (lsi->protocol != SIERRA_NET_PROTOCOL_UMTS) { > + if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS) { ... > + } else if

Re: USB SUBSYSTEM - drivers/usb/core/config.c

> From: "Felipe Balbi" > > I'm particularly interested in drivers/usb/core/config.c > > which appears to enforce the USB specification by refusing to allow a > > low speed CDC ACM. (Comment "Some buggy low-speed devices ...", at > > about line 300.) > > > > However,

Re: USB SUBSYSTEM - drivers/usb/core/config.c

On Tue, Feb 07, 2017 at 05:51:05PM +0100, John Skelton wrote: > Apologies if this ought to have gone to the USB maintainer (but his > auto-reply implies not). This is the correct place. > I'm particularly interested in drivers/usb/core/config.c > which appears to enforce the USB specification by

Re: USB SUBSYSTEM - drivers/usb/core/config.c

Hi, John Skelton writes: > Apologies if this ought to have gone to the USB maintainer (but his > auto-reply implies not). > > I'm particularly interested in drivers/usb/core/config.c > which appears to enforce the USB specification by refusing to allow a > low speed CDC ACM.

USB SUBSYSTEM - drivers/usb/core/config.c

Apologies if this ought to have gone to the USB maintainer (but his auto-reply implies not). I'm particularly interested in drivers/usb/core/config.c which appears to enforce the USB specification by refusing to allow a low speed CDC ACM. (Comment "Some buggy low-speed devices ...", at about

[PATCH -next] usb: dwc2: Fix the error handling of dwc2_pci_probe()

From: Wei Yongjun Fix the error handling of dwc2_pci_probe() to avoid resources leak. Signed-off-by: Wei Yongjun --- drivers/usb/dwc2/pci.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git

Re: Typo in "drivers/usb/host/ohci-hub.c"

On Tue, 7 Feb 2017, Jelle Martijn Kok wrote: > I actually stumbled on the next (quite unimportant) typo. > > In "ohci-hub.c" there is "dbg_port" macro which uses the "outside" > parameter (="temp") instead of the parameters (="value") given in the macro. > > This actually poses no problem as

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

On Tue, 7 Feb 2017, Peter Chen wrote: > On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: > > Hi Greg > > > > This series by Arnd Bergmann was originally six patches, but last two of > > them were already taken to 4.10. Without the rest of them there will > > be a regression in

Re: [PATCH net 0/4] Fix on-stack USB buffers

From: Ben Hutchings Date: Sat, 4 Feb 2017 16:54:51 + > Allocating USB buffers on the stack is not portable, and no longer > works on x86_64 (with VMAP_STACK enabled as per default). This > series fixes all the instances I could find where USB networking > drivers do

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-07 14:14:30, David Laight wrote: > From: Petko Manolov > > Sent: 07 February 2017 13:21 > ... > > > > Would you consider what David proposed (usb_control_msg_with_malloc()) > > > > for 4.11, > > > > for example? I for one will use something like that in all my drivers. > > > > > > Sure,

RE: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

From: Petko Manolov > Sent: 07 February 2017 13:21 ... > > > Would you consider what David proposed (usb_control_msg_with_malloc()) > > > for 4.11, > > > for example? I for one will use something like that in all my drivers. > > > > Sure, but you might want to make it a bit smaller of a function

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-07 14:01:02, Greg KH wrote: > On Tue, Feb 07, 2017 at 02:53:24PM +0200, Petko Manolov wrote: > > On 17-02-07 11:51:31, Greg KH wrote: > > > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > > > > On 17-02-06 16:25:20, Ben Hutchings wrote: > > > > > On Mon, Feb 06, 2017 at

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On Tue, Feb 07, 2017 at 02:53:24PM +0200, Petko Manolov wrote: > On 17-02-07 11:51:31, Greg KH wrote: > > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > > > On 17-02-06 16:25:20, Ben Hutchings wrote: > > > > On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > > > > >

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-07 11:51:31, Greg KH wrote: > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > > On 17-02-06 16:25:20, Ben Hutchings wrote: > > > On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > > > > From: Ben Hutchings > > > [...] > > > > > + ret =

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On 17-02-07 11:45:06, Greg KH wrote: > On Tue, Feb 07, 2017 at 12:24:12PM +0200, Petko Manolov wrote: > > On 17-02-06 14:46:21, Johan Hovold wrote: > > > On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > > > > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > > > > On

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On Tue, Feb 07, 2017 at 11:56:51AM +, David Laight wrote: > From: Greg KH > > Sent: 07 February 2017 10:52 > > To: Petko Manolov > > Cc: Ben Hutchings; David Laight; net...@vger.kernel.org; > > linux-usb@vger.kernel.org > > Subject: Re: [PATCH net 2/4] rtl8150: Use heap buffers for all

RE: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

From: Greg KH > Sent: 07 February 2017 10:52 > To: Petko Manolov > Cc: Ben Hutchings; David Laight; net...@vger.kernel.org; > linux-usb@vger.kernel.org > Subject: Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access > > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > On 17-02-06 16:25:20, Ben Hutchings wrote: > > On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > > > From: Ben Hutchings > > [...] > > > > + ret = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0), > > > >

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On Tue, Feb 07, 2017 at 12:24:12PM +0200, Petko Manolov wrote: > On 17-02-06 14:46:21, Johan Hovold wrote: > > On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > > > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > > > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-06 16:25:20, Ben Hutchings wrote: > On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > > From: Ben Hutchings > [...] > > > + ret = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0), > > > + RTL8150_REQ_GET_REGS, RTL8150_REQT_READ, > > > +

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On 17-02-06 14:46:21, Johan Hovold wrote: > On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote: > > > > On 17-02-06 09:28:22, Greg KH wrote: > > > > > On

Re: [RESEND PATCH 1/1] usb: dwc2: add multiple clock handling

On 2/6/2017 7:18 PM, Frank Wang wrote: > Hi Heiko, John and Greg, > > On 2017/2/7 8:06, Heiko Stuebner wrote: >> Hi Frank, >> >> Am Sonntag, 5. Februar 2017, 10:51:01 CET schrieb Frank Wang: >>> Originally, dwc2 just handle one clock named otg, however, it may have >>> two or more clock need to

Re: [PATCH] ALSA: line6: Always setup isochronous transfer properties

On Mon, 06 Feb 2017 22:54:59 +0100, Andrej Kruták wrote: > > On Mon, Feb 6, 2017 at 10:19 PM, Takashi Iwai wrote: > > On Mon, 06 Feb 2017 20:34:58 +0100, > > Andrej Krutak wrote: > >> > >> While not all line6 devices currently support PCM, it causes no > >> harm to 'have it

Re: [PATCH linux-next] fixup! usb: gadget: udc: atmel: Update endpoint allocation scheme

On Mon, Feb 06, 2017 at 10:02:50PM +0200, cristian.bir...@microchip.com wrote: > From: Cristian Birsan > > Signed-off-by: Cristian Birsan I can't take a patch with no changelog comments at all, sorry. And what is with the "fixup!"