Re: [PATCH drivers\usb\serial\pl2303.c & pl2303.h] Prolific's PL2303G: new USB to UART chip

2018-12-06 Thread Greg KH
On Thu, Dec 06, 2018 at 03:47:46PM +0800, Charles Yeh wrote: > Hi Greg, > The patch file: diffpl2303.patch is attached.. > Please you kindly check... Please fix up the patch to look like all other patches on this mailing list. You do not need the huge comment in the file, that should be in

Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare

2018-12-05 Thread Greg KH
On Wed, Nov 28, 2018 at 06:19:31PM -0500, Kyle Williams wrote: > Description: Some USB device / host controller combinations seem to have > problems with Link Power management. In particular it is described that > the combination of a Logitech Flare and other powered devices such as > the Atrus

Re: Support Mac address pass through on Dell DS1000 dock

2018-11-21 Thread Greg KH
On Tue, Nov 20, 2018 at 09:10:22PM +0100, Bjørn Mork wrote: > Greg KH writes: > > > I do not see any USB networking device here at all. > > No, It wasn't easy to see. But it's there both with and without the > feature enabled: > > /: Bus 02.Port 1: Dev 1, Class=r

Re: Support Mac address pass through on Dell DS1000 dock

2018-11-20 Thread Greg KH
On Tue, Nov 20, 2018 at 06:04:58PM +0100, FRÉDÉRIC PARRENIN wrote: > > - Mail original - > > De: "Greg KH" > > À: "FRÉDÉRIC PARRENIN" > > Cc: "linux-usb" > > Envoyé: Mardi 20 Novembre 2018 17:54:06 > > Objet: Re: Supp

Re: Support Mac address pass through on Dell DS1000 dock

2018-11-20 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? http://daringfireball.net/2007/07/on_top On Tue, Nov 20, 2018 at 05:46:21PM +0100, Frédéric Parrenin wrote: > I am runing

Re: Support Mac address pass through on Dell DS1000 dock

2018-11-20 Thread Greg KH
On Tue, Nov 20, 2018 at 05:33:54PM +0100, Frédéric Parrenin wrote: > I have a Dell latitude 5285 laptop connected to a Dell DS1000 docking station > through an usb-c cable. > Both devices are supposed to support Mac Address "pass through", that is, the > internal laptop mac address is used

Re: [PATCH drivers\usb\serial\pl2303.c & pl2303.h] Prolific's PL2303G: new USB to UART chip

2018-11-20 Thread Greg KH
On Tue, Nov 20, 2018 at 05:21:04PM +0800, Charles Yeh wrote: > Hi Johan, > After read Documentation\process\submitting-patches.rst, > I have write some describe in attach file : "diffpl2303c.patch" > "diffpl2303h.patch" > > If this file does not meet the file requirements, please

Re: Prolific: PL2303G Linux driver ( new USB to UART chip)

2018-11-07 Thread Greg KH
On Wed, Nov 07, 2018 at 06:18:07PM +0800, Charles Yeh wrote: > Hi Greg, > > The " Documentation/SubmittingPatches is write : This file has moved > to process/submitting-patches.rst > > The document is "Documentation\process\submitting-patches.rst" ? > please confirm Yes, that is what

Re: Prolific: PL2303G Linux driver ( new USB to UART chip)

2018-11-07 Thread Greg KH
On Wed, Nov 07, 2018 at 05:17:02PM +0800, Charles Yeh wrote: > Hi Greg, > Can you give me a link URL about " Documentation/SubmittingPatches "? > I am not very familiar with Linux kernel OS... It is in the main kernel source tree that you had to patch in order to create the diff you did, you

Re: Prolific: PL2303G Linux driver ( new USB to UART chip)

2018-11-07 Thread Greg KH
On Wed, Nov 07, 2018 at 04:07:03PM +0800, Charles Yeh wrote: > Hi Johan, > I use latest mainline releas: 4.19 to make patch file.. > please refer to attach file: "diff419pl2303c.patch" & " > diff419pl2303h.patch " Please read the file, Documentation/SubmittingPatches in the kernel

Re: [PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs

2018-11-05 Thread Greg KH
On Mon, Nov 05, 2018 at 06:46:26PM +, Thinh Nguyen wrote: > Hi Greg, > > On 11/2/2018 11:26 PM, Greg KH wrote: > > On Fri, Nov 02, 2018 at 06:47:38PM -0700, Thinh Nguyen wrote: > >> Move Synopsys HAPS platform device IDs to pci_ids.h. > > Why? pci_ids.h

Re: [PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs

2018-11-03 Thread Greg KH
On Fri, Nov 02, 2018 at 06:47:38PM -0700, Thinh Nguyen wrote: > Move Synopsys HAPS platform device IDs to pci_ids.h. Why? pci_ids.h, at the top of the file, says to not add new entries to the file. thanks, greg k-h

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-10-24 Thread Greg KH
On Wed, Oct 24, 2018 at 05:46:22PM +, Ajay Gupta wrote: > Hi Wolfram, > > > I don't think SMBus is an option in this case since the intended > > > client (Cypress something in patch 2/2) does xfers that would need > > > 16-bit commands and I think they are always 8-bit in SMBus, no? > > > >

Re: [PATCH] HID: hiddev: fix potential Spectre v1

2018-10-18 Thread Greg KH
On Thu, Oct 18, 2018 at 01:50:26PM -0300, Breno Leitao wrote: > Hi Gustavo, > > On 10/17/2018 05:30 PM, Gustavo A. R. Silva wrote: > > > > Hi Breno, > > > > On 10/17/18 9:47 PM, Breno Leitao wrote: > >> uref->usage_index can be indirectly controlled by userspace, hence leading > >> to a

Re: Logitech G27 leds no more supported

2018-10-17 Thread Greg KH
On Wed, Oct 17, 2018 at 02:44:51PM +, elrond...@protonmail.com wrote: > > > Hi, > > No more leds subdirectory for this wheel, someone reports me G29 leds stays > supported correctly. > > No more path: /sys/class/leds/logitechwheelpath, just my keyboard leds are > detected. Force feedback

Re: “Mouse battery low” notification appears even when all notifications disabled

2018-10-16 Thread Greg KH
On Tue, Oct 16, 2018 at 04:15:34PM -0300, Cristian wrote: > Hello, > > Open bug in launchpad.net > https://bugs.launchpad.net/bugs/1798166 > > "I have a wireless mouse powered by non-rechargeable battery. The > mouse works absolutely fine even with low battery level. Problem is, > Ubuntu gives

Re: It can not be formatted with 'gnome-disk-utility' the pendrive

2018-10-10 Thread Greg KH
On Wed, Oct 10, 2018 at 03:39:01PM -0300, Cristian wrote: > Hello, > > Open bug in launchpad.net > https://bugs.launchpad.net/bugs/1797190 > > "I am trying to format a pendrive of 2TB(Purchased in China for ebay). > What I do is the following: > > 1) I start the notebook with Linux 4.18.0-9 >

Re: Query on usb/core/devio.c

2018-10-09 Thread Greg KH
On Tue, Oct 09, 2018 at 10:51:53AM +0100, Mayuresh Kulkarni wrote: > With all due respect, one of the possible reason for this could be, > power saving on mobile/tablet platforms (running Android). These > platforms usually have a single USB port. Specifically from our point > of view, these

Re: UVC gadget changes for v4.20

2018-10-02 Thread Greg KH
On Tue, Oct 02, 2018 at 01:03:34PM +0300, Felipe Balbi wrote: > > Hi, > > Laurent Pinchart writes: > > On Tuesday, 2 October 2018 10:26:25 EEST Felipe Balbi wrote: > >> Laurent Pinchart writes: > >> > Hi Felipe, > >> > > >> > (CC'ing Greg, in case you're on vacation) > >> > > >> > Ping ? I'd

Re: ioctl for HID Power devices (UPS) always returning 0

2018-10-02 Thread Greg KH
On Sun, Sep 30, 2018 at 08:15:16PM +0200, Laurent Bigonville wrote: > Le 30/09/18 à 13:59, Laurent Bigonville a écrit : > > Hello, > > > > For quite some time, upower is not properly displaying the information > > from my Eaton UPS, looking at this it seems that the kernel is not > > returning

Re: [PATCH v2 0/3] xhci fixes for usb-linus

2018-09-28 Thread Greg KH
On Thu, Sep 20, 2018 at 06:43:19PM +0300, Mathias Nyman wrote: > Hi Greg > > Second try, shuffling patches between for-usb-linus and for-usb-next > > A few patches that makes sure USB3 devices enumerate to correct speed > after resume on Mediatek hosts, enables role mux on Apollo lake platforms,

Re: Fwd: Lenovo wireless keyboard - kernel/driver problem

2018-09-25 Thread Greg KH
On Tue, Sep 25, 2018 at 07:29:43PM +0200, Peter Hostačný wrote: > Hello there, > > there is quite a big trouble around few specific keyboards that are > not working in Linux. > I personally have "Lenovo Professional Wireless Keyboard and Mouse > Combo 4X30H56803" > The keyboard is not working,

Re: [PATCH v3] usb: core: added uevent for over-current

2018-09-20 Thread Greg KH
On Thu, Sep 20, 2018 at 10:17:54AM -0700, Jon Flatley wrote: > After commit 1cbd53c8cd85 ("usb: core: introduce per-port over-current > counters") usb ports expose a sysfs value 'over_current_count' > to user space. This value on its own is not very useful as it requires > manual polling. > > As

Re: [PATCH 1/2] usb: typec: mux: Take care of driver module reference counting

2018-09-20 Thread Greg KH
On Thu, Sep 20, 2018 at 02:26:28PM +0300, Heikki Krogerus wrote: > On Thu, Sep 20, 2018 at 01:20:03PM +0200, Greg KH wrote: > > On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote: > > > Functions typec_mux_get() and typec_switch_get() already > > > ma

Re: [PATCH 1/2] usb: typec: mux: Take care of driver module reference counting

2018-09-20 Thread Greg KH
On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote: > Functions typec_mux_get() and typec_switch_get() already > make sure that the mux device reference count is > incremented, but the same must be done to the driver module > as well to prevent the drivers from being unloaded in the >

Re: [PATCH v2] usb: core: added uevent for over-current

2018-09-20 Thread Greg KH
On Tue, Sep 11, 2018 at 10:43:10AM -0700, Jon Flatley wrote: > After commit 1cbd53c8cd85 ("usb: core: introduce per-port over-current > counters") usb ports expose a sysfs value 'over_current_count' > to user space. This value on its own is not very useful as it requires > manual polling. > > As

Re: [PATCH v6 01/22] usb: usbtmc: Add ioctl for generic requests on control

2018-09-20 Thread Greg KH
On Thu, Sep 20, 2018 at 01:00:35PM +0200, Greg KH wrote: > On Wed, Sep 12, 2018 at 10:50:51AM +0200, Guido Kiener wrote: > > --- a/include/uapi/linux/usb/tmc.h > > +++ b/include/uapi/linux/usb/tmc.h > > @@ -4,6 +4,7 @@ > > * Copyright (C) 2008 Novell, Inc. > >

Re: [PATCH v6 02/22] usb: usbtmc: Add ioctl for vendor specific write

2018-09-20 Thread Greg KH
On Wed, Sep 12, 2018 at 10:50:52AM +0200, Guido Kiener wrote: > +/* > + * usbtmc_message->flags: > + */ > +#define USBTMC_FLAG_ASYNC0x0001 > +#define USBTMC_FLAG_APPEND 0x0002 > + > +struct usbtmc_message { > + __u32 transfer_size; /* size of bytes to transfer */ > +

Re: [PATCH v6 01/22] usb: usbtmc: Add ioctl for generic requests on control

2018-09-20 Thread Greg KH
On Wed, Sep 12, 2018 at 10:50:51AM +0200, Guido Kiener wrote: > --- a/include/uapi/linux/usb/tmc.h > +++ b/include/uapi/linux/usb/tmc.h > @@ -4,6 +4,7 @@ > * Copyright (C) 2008 Novell, Inc. > * Copyright (C) 2008 Greg Kroah-Hartman > * Copyright (C) 2015 Dave Penkler > + * Copyright (C)

Re: [PATCH 2/2] USB: usbdevfs: restore warning for nonsensical flags

2018-09-20 Thread Greg KH
On Thu, Sep 06, 2018 at 11:34:04AM -0400, Alan Stern wrote: > On Thu, 6 Sep 2018, Oliver Neukum wrote: > > > On Mi, 2018-09-05 at 15:07 +0200, Greg KH wrote: > > > On Wed, Sep 05, 2018 at 03:02:48PM +0200, Oliver Neukum wrote: > > > > On Mi, 2018-09

Re: [PATCH 01/10] usb: xhci-mtk: resume USB3 roothub first

2018-09-20 Thread Greg KH
On Mon, Sep 17, 2018 at 10:35:46AM +0300, Mathias Nyman wrote: > On 14.09.2018 16:27, Greg KH wrote: > > On Thu, Sep 13, 2018 at 03:23:54PM +0300, Mathias Nyman wrote: > > > From: Chunfeng Yun > > > > > > Give USB3 devices a better chance to enumerate at USB

Re: [PATCH 1/3] usb: xhci: tegra: Firmware header is little endian

2018-09-20 Thread Greg KH
On Mon, Sep 17, 2018 at 08:40:44AM +0200, Thierry Reding wrote: > On Fri, Sep 14, 2018 at 03:01:22PM +0200, Greg KH wrote: > > On Fri, Sep 14, 2018 at 03:33:29PM +0300, Mathias Nyman wrote: > > > From: Thierry Reding > > > > > > The XUSB firmware header is

Re: [PATCH 2/3] xhci: Avoid USB autosuspend when resuming USB2 ports.

2018-09-20 Thread Greg KH
On Wed, Sep 19, 2018 at 10:54:45AM +0530, Anshuman Gupta wrote: > On Mon, Sep 17, 2018 at 11:24:20AM +0300, Mathias Nyman wrote: > > On 14.09.2018 16:00, Greg KH wrote: > > > On Fri, Sep 14, 2018 at 03:33:30PM +0300, Mathias Nyman wrote: > > > > From: Anshuman Gupta

Re: Kernel memory leak on CDC-ACM device plug/unplug

2018-09-19 Thread Greg KH
On Wed, Sep 19, 2018 at 04:11:55PM +0200, Romain Izard wrote: > While trying to debug a memory leak problem, I encountered the following > problem: > > After plugging/unplugging an USB CDC-ACM device, kmemleak reports multiple > copies of the following leak. It is not necessary to open the port

Re: Stylus reports 1% battery

2018-09-15 Thread Greg KH
On Sat, Sep 15, 2018 at 01:59:14AM -0600, Trent Gamblin wrote: > With an ELAN touchscreen and active stylus, the stylus reports 1% battery at > all times. I've used several batteries including 2 brand new ones, and tried > 2 new styluses. I noticed in the USB HID driver the possibility of ignoring

Re: [PATCH 01/10] usb: xhci-mtk: resume USB3 roothub first

2018-09-14 Thread Greg KH
On Thu, Sep 13, 2018 at 03:23:54PM +0300, Mathias Nyman wrote: > From: Chunfeng Yun > > Give USB3 devices a better chance to enumerate at USB3 speeds if > they are connected to a suspended host. > Porting from "671ffdff5b13 xhci: resume USB 3 roothub first" > > Signed-off-by: Chunfeng Yun >

Re: [PATCH 07/10] usb: typec: pci: Enable Intel USB role mux on Apollo Lake platforms

2018-09-14 Thread Greg KH
On Thu, Sep 13, 2018 at 03:24:00PM +0300, Mathias Nyman wrote: > From: Heikki Krogerus > > Intel Apollo Lake has the same internal USB role mux as > Intel Cherry Trail. > > Signed-off-by: Heikki Krogerus > Signed-off-by: Mathias Nyman > --- > drivers/usb/host/xhci-pci.c | 6 -- > 1 file

Re: [PATCH 1/3] usb: xhci: tegra: Firmware header is little endian

2018-09-14 Thread Greg KH
On Fri, Sep 14, 2018 at 03:33:29PM +0300, Mathias Nyman wrote: > From: Thierry Reding > > The XUSB firmware header is in little endian byte order, so make the > fields __le32 and __le16 instead of u32 and u16 to avoid warnings from > sparse when the fields are used with the endian-aware

Re: [PATCH 3/3] xhci: Add missing CAS workaround for Intel Sunrise Point xHCI

2018-09-14 Thread Greg KH
On Fri, Sep 14, 2018 at 03:33:31PM +0300, Mathias Nyman wrote: > The workaround for missing CAS bit is also needed for xHC on Intel > sunrisepoint PCH. For more details see: > > Intel 100/c230 series PCH specification update Doc #332692-006 Errata #8 > > Signed-off-by: Mathias Nyman > --- >

Re: [PATCH 2/3] xhci: Avoid USB autosuspend when resuming USB2 ports.

2018-09-14 Thread Greg KH
On Fri, Sep 14, 2018 at 03:33:30PM +0300, Mathias Nyman wrote: > From: Anshuman Gupta > > When USB bus host controller root hub resumes from autosuspend, > it immediately tries to enter auto-suspend, but there can be a > scenario when root hub is resuming its usb2 ports, in that particular >

Re: Inaccessible dual-role port on CherryTrail

2018-09-14 Thread Greg KH
On Thu, Sep 13, 2018 at 03:40:12PM -0700, Rob Weber wrote: > Hi linux-usb, > > I'm currently bringing up a custom board that uses a CherryTrail > processor and I'm having quite a bit of trouble accessing the dual-role > port from Linux. > > Our system includes two USB 3.0-capable ports with

Re: [PATCH V2] usbcore: Select UAC3 configuration for audio if present

2018-09-11 Thread Greg KH
On Wed, Sep 12, 2018 at 01:03:57AM +0530, saranya.go...@intel.com wrote: > From: Saranya Gopal Any reason you forgot to cc: the usb maintainer? :) > > USB audio class 3.0 specification introduced many significant > changes like > - new power domains, support for LPM/L1 > - new cluster

Re: [PATCH] usb: core: added uevent for over-current

2018-09-11 Thread Greg KH
On Mon, Sep 10, 2018 at 03:12:22PM -0700, Jon Flatley wrote: > On Mon, Sep 10, 2018 at 11:14 AM Greg KH wrote: > > > > On Fri, Aug 31, 2018 at 10:14:19AM -0700, Jon Flatley wrote: > > > After commit 1cbd53c8cd85 ("usb: core: introduce per-port over-current >

Re: [PATCH V4] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-10 Thread Greg KH
On Fri, Sep 07, 2018 at 09:59:40AM +0530, saranya.go...@intel.com wrote: > From: Saranya Gopal > > This patch adds static DRD mode for host/device > mode switch. This fixes the issue where device > mode was not working after DUT switches to host > mode with 3.0 OTG connector. > > Change-Id:

Re: [PATCH] usb: core: added uevent for over-current

2018-09-10 Thread Greg KH
On Fri, Aug 31, 2018 at 10:14:19AM -0700, Jon Flatley wrote: > After commit 1cbd53c8cd85 ("usb: core: introduce per-port over-current > counters") usb ports expose a sysfs value 'over_current_count' > to user space. This value on its own is not very useful as it requires > manual polling. > > As

Re: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread Greg KH
On Fri, Sep 07, 2018 at 11:33:23AM +0300, Felipe Balbi wrote: > > Hi Greg, > > "Gopal, Saranya" writes: > >> > diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c > >> b/drivers/usb/roles/intel-xhci-usb-role-switch.c > >> > index dad2d19..0d1ea82 100644 > >> > ---

Re: [PATCH V6] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread Greg KH
On Fri, Sep 07, 2018 at 12:32:01PM +0530, saranya.go...@intel.com wrote: > From: Saranya Gopal > > This patch adds static DRD mode for host/device > mode switch. This fixes the issue where device > mode was not working after DUT switches to host > mode with 3.0 OTG connector. > > Signed-off-by:

Re: [PATCH V5] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-07 Thread Greg KH
On Fri, Sep 07, 2018 at 11:45:18AM +0530, saranya.go...@intel.com wrote: > From: saranya That's not right :( > > This patch adds static DRD mode for host/device > mode switch. This fixes the issue where device > mode was not working after DUT switches to host > mode with 3.0 OTG connector. >

Re: [PATCH V4] roles: Fix USB 3.0 OTG issue on Intel platform

2018-09-06 Thread Greg KH
On Fri, Sep 07, 2018 at 09:59:40AM +0530, saranya.go...@intel.com wrote: > From: Saranya Gopal > > This patch adds static DRD mode for host/device > mode switch. This fixes the issue where device > mode was not working after DUT switches to host > mode with 3.0 OTG connector. > > Change-Id:

Re: [PATCH 2/2] USB: usbdevfs: restore warning for nonsensical flags

2018-09-05 Thread Greg KH
On Wed, Sep 05, 2018 at 03:02:48PM +0200, Oliver Neukum wrote: > On Mi, 2018-09-05 at 14:19 +0200, Greg KH wrote: > > On Wed, Sep 05, 2018 at 12:07:03PM +0200, Oliver Neukum wrote: > > > If we filter flags before they reach the core we need to generate our > > > own wa

Re: [PATCH] Revert "cdc-acm: implement put_char() and flush_chars()"

2018-09-05 Thread Greg KH
On Thu, Aug 30, 2018 at 11:18:36AM +0200, Oliver Neukum wrote: > This reverts commit a81cf9799ad7299b03a4dff020d9685f9ac5f3e0. > > The patch causes a regression, which I cannot find the reason for. > So let's revert for now, as a revert hurts only performance. > > I was trying to resolve the

Re: [PATCH v5 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-05 Thread Greg KH
On Fri, Aug 31, 2018 at 01:22:21PM -0700, Ajay Gupta wrote: > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller > over I2C interface. > > This UCSI I2C driver uses I2C bus driver interface for communicating > with Type-C controller. > > Signed-off-by: Ajay Gupta > --- > Changes from

Re: [PATCH v5 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-05 Thread Greg KH
On Fri, Aug 31, 2018 at 01:22:21PM -0700, Ajay Gupta wrote: > + dev_info(dev, "Silicon id %2ph", data + CCGX_I2C_RAB_READ_SILICON_ID); > + dev_info(dev, "FW1 version %8ph\n", data + CCGX_I2C_RAB_FW1_VERSION); > + dev_info(dev, "FW2 version %8ph\n", data + CCGX_I2C_RAB_FW2_VERSION);

Re: [PATCH 2/2] USB: usbdevfs: restore warning for nonsensical flags

2018-09-05 Thread Greg KH
On Wed, Sep 05, 2018 at 12:07:03PM +0200, Oliver Neukum wrote: > If we filter flags before they reach the core we need to generate our > own warnings. > > Signed-off-by: Oliver Neukum > Fixes: 0cb54a3e47cb ("USB: debugging code shouldn't alter control flow") > --- > drivers/usb/core/devio.c | 5

Re: Question about a patch for Worlde controller

2018-09-05 Thread Greg KH
On Wed, Sep 05, 2018 at 08:58:38AM +, Maxence Duprès wrote: > Sorry to ask you again but nothing appear in rc2 or in testing branch > for Worlde/Prodipe keyboard in drivers/usb/core/quirks.c > > USB: add quirk for WORLDE Controller KS49 or Prodipe MIDI 49C USB Sorry for the delay, it's been

Re: Fw: keyboard-problem on bpi-r2 since 4.17

2018-09-03 Thread Greg KH
On Tue, Sep 04, 2018 at 06:39:20AM +0200, Frank Wunderlich wrote: > >   > > Hi, > > i have problems with usb-keyboard on bananapi-r2 since 4.17. same keyboard > works till 4.16. > In 4.19-rc1 same issue occours. Keyboard is recognized and on keypress it is > disconnected > and connected

Re: Nothing in /sys/class/udc

2018-09-03 Thread Greg KH
On Mon, Sep 03, 2018 at 09:39:14AM +0300, Ranran wrote: > Hello, > > I try to add gadget configfs as described in: > https://www.kernel.org/doc/Documentation/usb/gadget_configfs.txt > Yet, I find nothing in /sys/class/udc: > > user@user-VirtualBox:~/tegra$ ls /sys/class/udc/ -al > total 0 >

Re: A question about 'lsusb'

2018-08-31 Thread Greg KH
On Thu, Aug 30, 2018 at 05:10:53PM -0400, Alan Stern wrote: > On Thu, 30 Aug 2018, Faisal Mehmood wrote: > > > Based on my (limited) understanding if I were to disable udev, the > > userspace should not be able to enumerate/interact with any newly > > connected device since udev handles uevents

Re: [PATCH v2 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-08-25 Thread Greg KH
On Sat, Aug 25, 2018 at 07:29:24PM +0300, Andy Shevchenko wrote: > > --- > > This email message is for the sole use of the intended recipient(s) and may > > contain > > confidential information. Any unauthorized

Re: Question about a patch for Worlde controller

2018-08-20 Thread Greg KH
On Mon, Aug 20, 2018 at 12:03:47PM +, Maxence Duprès wrote: > Hello, > > I found nothing about this patch on git: > > Something gone wrong  with it ? No, it got caught in my system and didn't get pushed out fully, my fault. I have it in my queue again to apply once 4.19-rc1 is out and get

Re: 4.18 regression: composite usb mouse/keyboard went mad

2018-08-19 Thread Greg KH
On Sun, Aug 19, 2018 at 01:32:47PM +0200, Harald Dunkel wrote: > Hi folks, > > since 4.18 my composite mouse/keyboard doesn't work correctly anymore. > Usually the device can switch between keyboard and (gyroscopic) mouse > mode, but with the new kernel the mouse movements seem to generate >

Re: Xiaomi Mi mouse 2717:003b

2018-08-17 Thread Greg KH
On Fri, Aug 17, 2018 at 06:31:55PM +0200, Domenico Suppa wrote: > Regarding my wireless mouse > 2717:003b MI Dongle MI Wireless Mouse, > beginnig from the Kernel 4.18 the > file /dev/input/mouse* is not more > associated to the correct /dev/input/event* > file (even if it exists and works). So no

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

2018-08-16 Thread Greg KH
On Thu, Aug 16, 2018 at 01:28:54AM -0700, Patong Yang wrote: > On Thu, Aug 16, 2018 at 08:34:47AM +0200, Greg KH wrote: > > On Wed, Aug 15, 2018 at 10:56:47PM -0700, Patong Yang wrote: > > > Greg, > > > > > > Please see my respon

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

2018-08-16 Thread Greg KH
On Wed, Aug 15, 2018 at 10:56:47PM -0700, Patong Yang wrote: > Greg, > > Please see my response inline below. > > Patong > > > But there is a bigger problem here: > > > > > + xrusb_tty_driver = alloc_tty_driver(XRUSB_TTY_MINORS); > > > + if (!xrusb_tty_driver) > > > + return -ENOMEM; >

Re: Delayed "registered new interface driver snd-usb-audio"

2018-08-14 Thread Greg KH
On Tue, Aug 14, 2018 at 09:29:26AM +0300, Ran Shalit wrote: > On Mon, Aug 13, 2018 at 9:57 PM, Greg KH wrote: > > On Mon, Aug 13, 2018 at 09:34:37PM +0300, Ran Shalit wrote: > >> Hello, > >> > >> I have a strange behabiour with sound card usb. > >&g

Re: patch ACS ACR122U

2018-08-10 Thread Greg KH
On Fri, Aug 10, 2018 at 07:42:07PM +, Julien F. wrote: > Hello, > > I'm running 4.15.0-30-generic (Ubuntu 18.04.1 LTS), so it shoud be ok, but i > still have the error :/ I would go file a bug with Ubuntu and tell them to upgrade their kernel :) The patch was never in any 4.15 kernel

Re: patch ACS ACR122U

2018-08-10 Thread Greg KH
On Fri, Aug 10, 2018 at 01:47:37PM +, Julien F. wrote: > Hello, > > I'm sending you this email because i found this topic > https://patchwork.kernel.org/patch/10407169/ on the error -11 when we > plug a NFC ACR122U reader, and ... that's exactly my problem ! and > nobodies on forums were

Re: [PATCH] WORLDE Controller KS49 or Prodipe MIDI 49C USB controller

2018-08-09 Thread Greg KH
On Wed, Aug 08, 2018 at 11:56:33PM +, Maxence Duprès wrote: > WORLDE Controller KS49 or Prodipe MIDI 49C USB controller > cause a -EPROTO error, a communication restart and loop again. > > This issue has already been fixed for KS25. > https://lore.kernel.org/patchwork/patch/753077/ > > I

Re: Strange bug with Prodipe MIDI 49C USB

2018-08-08 Thread Greg KH
On Tue, Aug 07, 2018 at 09:05:03PM +, Maxence Duprès wrote: > This is a proposed patch for KS49. > > The original patch for KS25: https://lore.kernel.org/patchwork/patch/753077/ > > About the authorship, I don't know what it is. My real  name is Roux > Laurent. > > > diff -Naur

Re: Strange bug with Prodipe MIDI 49C USB

2018-08-07 Thread Greg KH
On Tue, Aug 07, 2018 at 05:50:21PM +, Maxence Duprès wrote: > > > Hello, > > I just bought a midi keyboard Prodipe MIDI 49C USB for use within linux > Rosegarden and LMMS. > When I plug it in, nothing happen, no keyboard appears in software or in > lsusb. Changing USB cable did nothing. >

Re: wrong device idProduct?

2018-08-06 Thread Greg KH
On Mon, Aug 06, 2018 at 11:31:11AM -0700, Nick Desaulniers wrote: > On Mon, Aug 6, 2018 at 11:27 AM Alan Stern wrote: > > > > On Mon, 6 Aug 2018, Nick Desaulniers wrote: > > > > > On Mon, Jul 30, 2018 at 1:24 PM Alan Stern > > > wrote: > > > > > > > > On Mon, 30 Jul 2018, Nick Desaulniers

Re: ] Sandisk Ultra Fit USB 3.0 thumb drive overheating way more than same USB does in Windows

2018-08-03 Thread Greg KH
On Fri, Aug 03, 2018 at 04:15:22PM +0100, Mustafa A wrote: > The drive (128GB USB 3.0) > https://www.sandisk.co.uk/home/usb-flash/ultra-fit-usb overheats to > the point where the metal part would burn someone if they held it for > more than a second. > > The overheating only happens on this brand

Re: [PATCH v4 00/22] usb: usbtmc: Changes needed for compatible IVI/VISA library

2018-07-30 Thread Greg KH
On Mon, Jul 30, 2018 at 10:04:30AM +0200, Guido Kiener wrote: > The working group "VISA for Linux" of the IVI Foundation > www.ivifoundation.org specifies common rules, shared libraries and > drivers to implement the specification of "VPP-4.3: The VISA Library" > on Linux to be compatible with

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

2018-07-26 Thread Greg KH
On Tue, Jul 24, 2018 at 03:36:36PM -0700, Patong Yang wrote: > The original driver/patch was submitted on April 4, 2018. This is the > second version based on the feedback received on the original patch. > > v2: Removed custom IOCTLs, as suggested by Greg KH > Using standard

Re: [PATCH v3 02/23] usb: usbtmc: Add ioctl for generic requests on control

2018-07-24 Thread Greg KH
On Tue, Jul 24, 2018 at 11:05:29AM +0200, Guido Kiener wrote: > +struct usbtmc_ctrlrequest { > + struct usbtmc_request req; > + __u64 data; /* pointer to user space */ > +} __attribute__ ((packed)); Hint, this structure could just be: struct usbtmc_ctrlreqest {

Re: [PATCH v3 02/23] usb: usbtmc: Add ioctl for generic requests on control

2018-07-24 Thread Greg KH
On Tue, Jul 24, 2018 at 11:05:29AM +0200, Guido Kiener wrote: > Add USBTMC_IOCTL_CTRL_REQUEST to send arbitrary requests on the > control pipe. Used by specific applications of IVI Foundation, > Inc. to implement VISA API functions: viUsbControlIn/Out. > > The maximum length of control request

Re: [PATCH v2 08/29] usb: usbtmc: Add ioctl for generic requests on control

2018-07-21 Thread Greg KH
On Sat, Jul 21, 2018 at 11:11:55AM +, gu...@kiener-muenchen.de wrote: > > Zitat von Greg KH : > > > On Wed, Jul 18, 2018 at 10:45:41AM +0200, Guido Kiener wrote: > > > Add USBTMC_IOCTL_CTRL_REQUEST to send arbitrary requests on the > > > control pipe. Use

Re: [PATCH v2 09/29] usb: usbtmc: Add ioctl for vendor specific write

2018-07-21 Thread Greg KH
On Wed, Jul 18, 2018 at 10:45:42AM +0200, Guido Kiener wrote: > The new ioctl USBTMC_IOCTL_WRITE sends a generic message to bulk OUT. > This ioctl is used for vendor specific or asynchronous I/O as well. > > The message is split into chunks of 4k (page size). > Message size is aligned to 32 bit

Re: [PATCH v2 08/29] usb: usbtmc: Add ioctl for generic requests on control

2018-07-21 Thread Greg KH
On Wed, Jul 18, 2018 at 10:45:41AM +0200, Guido Kiener wrote: > Add USBTMC_IOCTL_CTRL_REQUEST to send arbitrary requests on the > control pipe. Used by specific applications of IVI Foundation, > Inc. to implement VISA API functions: viUsbControlIn/Out. > > The maximum length of control request

Re: [PATCH v2 03/29] usb: usbtmc: Add ioctls to set/get usb timeout

2018-07-21 Thread Greg KH
On Wed, Jul 18, 2018 at 10:45:36AM +0200, Guido Kiener wrote: > +/* > + * Set the usb timeout value > + */ > +static int usbtmc_ioctl_set_timeout(struct usbtmc_file_data *file_data, > + void __user *arg) > +{ > + u32 timeout; > + > + if (get_user(timeout, (__u32

Re: [PATCH v2 01/29] usb: usbtmc: Support Read Status Byte with SRQ per file

2018-07-21 Thread Greg KH
On Wed, Jul 18, 2018 at 10:45:34AM +0200, Guido Kiener wrote: > } > - dev_warn(dev, "invalid notification: %x\n", > data->iin_buffer[0]); > + dev_warn(dev, "invalid notification: %x\n", > + data->iin_buffer[0]); > break; >

Re: [PATCH 2/2] USB: iuu_phoenix: drop redundant input-speed re-encoding

2018-07-16 Thread Greg KH
On Mon, Jul 16, 2018 at 01:51:56PM +0200, Johan Hovold wrote: > Drop redundant input-speed re-encoding at every open(). The output and > input speeds are initialised to the same value and are kept in sync on > termios updates. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman --

Re: [PATCH 1/2] USB: serial: iuu_phoenix: drop unused driver-data baud rate

2018-07-16 Thread Greg KH
On Mon, Jul 16, 2018 at 01:51:55PM +0200, Johan Hovold wrote: > Drop unused driver-data baud rate. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] usb: quirks: add delay quirks for Corsair Strafe

2018-07-04 Thread Greg KH
On Wed, Jul 04, 2018 at 03:14:17PM +0300, Nico Sneck wrote: > CC Greg in hopes of having someone take a look at this patch before > Monday (when my military service starts). It's in my queue, will probably get to it next week. At first glance looks fine. Good luck on your service! greg k-h --

Re: [PATCH 0/1] xhci fix for usb-linus

2018-07-02 Thread Greg KH
On Mon, Jul 02, 2018 at 04:14:10PM +0300, Mathias Nyman wrote: > Hi Greg > > A small fix for usb-linus making sure runtime PM get/put is balanced > > -Mathias > > Kai-Heng Feng (1): > usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not > started > >

Re: [PATCH 1/2 ] cdc_ncm: Handle multicast Ethernet traffic

2018-06-29 Thread Greg KH
On Fri, Jun 29, 2018 at 04:47:28PM +0200, Miguel Rodríguez Pérez wrote: > Some CDC_NCM devices are used as docks for laptops. In this case, it > makes sense to accept multicast Ethernet traffic, as these devices > can reside in a proper LAN. Without this, mDNS or IPv6 simply do not > work. > >

Re: [PATCH v8 00/14] staging: typec: tcpci: move out of staging

2018-06-28 Thread Greg KH
On Wed, Jun 27, 2018 at 07:45:18AM +0800, Li Jun wrote: > This patch set attempts to move the tcpci drivers out of staging by fix > some tcpci driver issues and define typec and power delivery device > properties, the changes are verified on NXP PTN5110, which is a standard > tcpci typec port

Re: [PATCH 3/3] Fixed simple typo from ELCOM to ELECOM.

2018-06-27 Thread Greg KH
On Tue, Jun 26, 2018 at 07:07:59PM -0500, Guy Chronister wrote: > Signed-off-by: Guy Chronister I know I don't take patches with no change log at all, but other maintainers might be nicer :) greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: usb/serial - pl2303 module - buffer overflow

2018-06-25 Thread Greg KH
On Sun, Jun 24, 2018 at 05:40:37PM +0200, Matthias Dieter Wallnöfer wrote: > Hi people, > > as I am working with a PL2303-based USB-to-serial converter I discovered > that the SW-based flow control was unsupported for all kernels till the > upcoming 4.18 release. Thanks to the patch by Florian

Re: no exposure setting on webcams using uvcvideo

2018-06-24 Thread Greg KH
On Sun, Jun 24, 2018 at 05:23:26PM +0400, safocl wrote: > By the way, with the patch > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=0dc68cabdb626e33d02561529e6a4c681b72a784 > everything is fine with the allocated memory for data in 1 byte. > so I think the

Re: [PATCH v3] storage: Widen bcdDevice range for SanDisk SDDR-31 quirk

2018-06-11 Thread Greg KH
On Sun, Jun 10, 2018 at 08:54:09PM +0200, Mark Knibbs wrote: > When I re-sent the patch with tabs I accidentally left the new maximum > bcdDevice at 0x00ff. Sorry! Hopefully this is finally OK. This should not be in the change log text, please remove it. > > > The SanDisk SDDR-31 needs the

Re: [PATCH v2] storage: Widen bcdDevice range for SanDisk SDDR-31 quirk

2018-06-07 Thread Greg KH
On Thu, Jun 07, 2018 at 09:54:45PM +0200, Mark Knibbs wrote: > The SanDisk SDDR-31 needs the US_FL_FIX_CAPACITY quirk. Previously that > was only applied for bcdDevice 0x0009, but later firmware which reports > bcdDevice 0x0022 needs it too. > > Signed-off-by: Mark Knibbs > --- > diff --git

Re: add toshiba dtb305 to unusual_devs.h

2018-06-03 Thread Greg KH
On Sun, Jun 03, 2018 at 01:31:38AM +0800, Druggo Yang wrote: > --- a/drivers/usb/storage/unusual_devs.h2018-04-02 05:20:27.0 > +0800 > +++ b/drivers/usb/storage/unusual_devs.h2018-06-02 19:08:38.002689059 > +0800 > @@ -319,6 +319,13 @@ > USB_SC_DEVICE, USB_PR_DEVICE,

Re: [PATCH v3 0/3] Revised Renesas uPD72020x workaround for 32bit DMA issue

2018-06-01 Thread Greg KH
On Fri, Jun 01, 2018 at 01:14:22PM +0300, Mathias Nyman wrote: > On 01.06.2018 11:23, Greg KH wrote: > > On Wed, May 23, 2018 at 06:41:35PM +0100, Marc Zyngier wrote: > > > Back around the 4.13 timeframe, we tried to address a rather bad issue > > > with the Renesa

Re: [PATCH v3 0/3] Revised Renesas uPD72020x workaround for 32bit DMA issue

2018-06-01 Thread Greg KH
On Wed, May 23, 2018 at 06:41:35PM +0100, Marc Zyngier wrote: > Back around the 4.13 timeframe, we tried to address a rather bad issue > with the Renesas uPD72020x USB3 controller family. They have trouble > with the programming of the base addresses which tend to stick on XHCI > reset. This makes

Re: [PATCH] ftdi_sio: add Id for Physik Instrumente E-870

2018-05-31 Thread Greg KH
On Thu, May 31, 2018 at 01:24:52PM +0200, Johan Hovold wrote: > On Thu, May 31, 2018 at 12:39:41PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Mar 29, 2018 at 08:39:37AM +0200, Teichmann, Martin wrote: > > > This adds support for the Physik Instrumente E-870 PIShift Drive > > > Electronics, a

Re: [PATCH] ftdi_sio: add Id for Physik Instrumente E-870

2018-05-31 Thread Greg KH
On Thu, Mar 29, 2018 at 08:39:37AM +0200, Teichmann, Martin wrote: > This adds support for the Physik Instrumente E-870 PIShift Drive > Electronics, a Piezo motor driver. > > Signed-off-by: Martin Teichmann > --- > drivers/usb/serial/ftdi_sio.c | 1 + > drivers/usb/serial/ftdi_sio_ids.h | 1

Re: 4.16 issue with mbim modem and ping with size > 14552 bytes

2018-05-28 Thread Greg KH
On Mon, May 28, 2018 at 09:58:01AM +0200, Daniele Palmas wrote: > 2018-05-25 0:54 GMT+02:00 Daniele Palmas <dnl...@gmail.com>: > > Hi Greg, > > > > 2018-05-24 17:53 GMT+02:00 Greg KH <gre...@linuxfoundation.org>: > >> On Thu, May 24, 2018 at 05:04:49P

Re: 4.16 issue with mbim modem and ping with size > 14552 bytes

2018-05-24 Thread Greg KH
On Thu, May 24, 2018 at 05:04:49PM +0200, Daniele Palmas wrote: > Hello, > > I have an issue with an USB mbim modem when trying to send with ping > more than 14552 bytes: it looks like to me a kernel issue, but not at > the cdc_mbim or cdc_ncm level, anyway not sure, so I'm reporting the > issue.

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

2018-05-23 Thread Greg KH
On Wed, May 23, 2018 at 02:08:27PM +0200, Oliver Neukum wrote: > Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener: > > +static int usbtmc488_ioctl_wait_srq(struct usbtmc_file_data *file_data, > > +   unsigned int __user *arg) > > +{ > > +   struct

  1   2   3   4   5   6   7   8   9   10   >