platform_get_irq() returns an error code, but the xhci-plat driver
ignores it and always returns -ENODEV. This is not correct, and
prevents -EPROBE_DEFER from being propagated properly.
Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
---
drivers/usb/host/xhci-plat
Hello,
On Wed, 8 Mar 2017 17:24:21 +0100, Gregory CLEMENT wrote:
> Signed-off-by: jinghua <jing...@marvell.com>
I think you need a full first name + last name for this Signed-off-by.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel enginee
t;
> Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk>
Acked-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line
with the clock prepared and enabled as expected.
In practice, such issue is seen on the ARM64 Marvell 7K/8K platform,
where the clocks are registered by a platform driver.
Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
---
Changes since v1:
- Re-order how the EPROBE_DEFER
've just sent a v2 that addresses this comment.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vg
with the clock prepared and enabled as expected.
In practice, such issue is seen on the ARM64 Marvell 7K/8K platform,
where the clocks are registered by a platform driver.
Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
---
drivers/usb/host/xhci-plat.c | 4
1 file chan
put_hcd; instead of return ret;.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
m...@semihalf.com
Reviewed-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Tested-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
Indeed, on Armada XP GP, without this patch, no USB devices are
detected when the kernel runs in big endian mode. With this patch
applied, a USB key
version 2 or later.
so GPL match it.
And also, the vast majority of kernel drivers use
MODULE_LICENSE(GPL) :
$ git grep 'MODULE_LICENSE(GPL)' | wc -l
5615
$ git grep 'MODULE_LICENSE(GPLv2)' | wc -l
5
$ git grep 'MODULE_LICENSE(GPL v2)' | wc -l
932
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free
, and that therefore
not having the static qualifier is expected.
Should we resend a v6 with just this change?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe
: reword commit log, fix goto label names.]
Fixes: 8c869edaee07c623066266827371235fb9c12e01 ('ARM: Orion: EHCI: Add support
for enabling clocks')
Cc: sta...@vger.kernel.org # v3.8+
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free
In preparation to the introduction of additional initialization steps
in ehci_orion_drv_probe(), we rename the error goto labels from err1,
err2 and err3 names to some more meaningful names.
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
Acked-by: Alan Stern st
framework to
control this USB cluster feature.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
drivers/phy/Kconfig | 6 ++
drivers/phy/Makefile | 1 +
drivers/phy/phy-armada375-usb2
From: Gregory CLEMENT gregory.clem...@free-electrons.com
This patch adds the selection of the config symbol needed to build the
USB3 support for Armada 38x into mvebu_v7_defconfig.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz
of the EHCI controller on
Armada 38x
ARM: mvebu: add Device Tree description of USB cluster controller on
Armada 375
ARM: mvebu: add Device Tree description of the xHCI controller on
Armada 375
ARM: mvebu: add Device Tree description of the EHCI controller on
Armada 375
Thomas
From: Gregory CLEMENT gregory.clem...@free-electrons.com
This patch add the selection of the config symbol to build the USB3
support for Armada 375.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/configs/mvebu_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/mvebu_v7_defconfig
b/arch/arm/configs/mvebu_v7_defconfig
index a34713d..e881106 100644
--- a/arch/arm/configs
gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/boot/dts/armada-375-db.dts | 4
arch/arm/boot/dts/armada-375.dtsi | 18 ++
2 files changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/armada-375-db.dts
b
for this piece of hardware.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
.../bindings/phy/armada-375-usb-phy-cluster.txt | 19 +++
1 file changed, 19 insertions(+)
create mode 100644
in non-DT mode.
This is not necessary: platform_get_irq() works just as fine in
DT-mode, since the conversion from DT information to 'struct resource'
is done by the generic layers of the kernel.
Therefore, this commit switches back to use just platform_get_irq().
Signed-off-by: Thomas Petazzoni
This commit updates the Device Tree binding documentation of
ehci-orion to take into account the fact that we can now optionally
pass a clock and a PHY reference.
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
Documentation/devicetree/bindings/usb/ehci-orion.txt | 5
From: Gregory CLEMENT gregory.clem...@free-electrons.com
Sorting the headers in alphabetic order will help to reduce the conflict
when adding new headers later.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Acked-by: Felipe Balbi ba...@ti.com
Signed-off-by: Thomas Petazzoni
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
Cc: a...@kernel.org
Cc: Kevin Hilman khil...@linaro.org
Cc: Olof Johansson o...@lixom.net
Cc: Arnd Bergmann a...@arndb.de
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs
.
Two new compatible strings are added to identify the Armada 375 and
Armada 38x XHCI controllers, and therefore enable the relevant quirk.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
drivers/usb/host
385 RD platform.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/boot/dts/armada-385-db.dts | 8
arch/arm/boot/dts/armada-385-rd.dts | 4
arch/arm/boot/dts/armada-38x.dtsi | 17
.
It also indicates that an optional 'clocks' property is now supported.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
Documentation/devicetree/bindings/usb/usb-xhci.txt | 7 ++-
1 file changed, 6
: use devm_phy_optional_get() so that we handle -EPROBE_DEFER
properly. Also call phy_power_off() when needed, and rename goto
labels.]
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
Acked-by: Alan Stern st
CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
drivers/usb/host/xhci-plat.c | 24 +++-
drivers/usb/host/xhci.h | 2 ++
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci
gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/boot/dts/armada-375-db.dts | 4
arch/arm/boot/dts/armada-375.dtsi | 10 ++
2 files changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/armada-375-db.dts
b/arch/arm/boot
From: Gregory CLEMENT gregory.clem...@free-electrons.com
On Armada 375, the USB cluster allows to control the cluster composed
of the USB2 and USB3 host controllers.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free
to devm_phy_optional_get(), the fact of not having a PHY in the
DT is not considered an error. So on any error from
devm_phy_optional_get() (including -EPROBE_DEFER), we simply bail out.
Does this looks good?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http
more an option for the xhci-platform
driver than an additional separate module, IMO. What do you think?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux
sense to have a pointer to
it from xhci_hcd. If someone complains that the clock would only be
used by xhci_plat, then I could point him to the fact that xhci_hcd
already contains members such as msix_count and msix_entries, that are
only used in xhci_pci :-)
Best regards,
Thomas
--
Thomas
MACH_ARMADA_375) || COMPILE_TEST
Right, will do.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
+* to manage a USB2 device, so let's disable usb2 if usb3 is
+* slelected. In this case USB2 device will be managed by the
selected
Fixed.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from
-l
5
linux/drivers $ git grep MODULE_LICENSE | grep \GPL v2\ | wc -l
841
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
385 RD platform.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/boot/dts/armada-385-db.dts | 8
arch/arm/boot/dts/armada-385-rd.dts | 4
arch/arm/boot/dts/armada-38x.dtsi | 17
CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
drivers/usb/host/xhci-plat.c | 24 +++-
drivers/usb/host/xhci.h | 2 ++
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci
From: Gregory CLEMENT gregory.clem...@free-electrons.com
On Armada 375, the USB cluster allows to control the cluster composed
of the USB2 and USB3 host controllers.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free
gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/boot/dts/armada-375-db.dts | 4
arch/arm/boot/dts/armada-375.dtsi | 18 ++
2 files changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/armada-375-db.dts
b
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/configs/mvebu_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/mvebu_v7_defconfig
b/arch/arm/configs/mvebu_v7_defconfig
index a34713d..e881106 100644
--- a/arch/arm/configs
in non-DT mode.
This is not necessary: platform_get_irq() works just as fine in
DT-mode, since the conversion from DT information to 'struct resource'
is done by the generic layers of the kernel.
Therefore, this commit switches back to use just platform_get_irq().
Signed-off-by: Thomas Petazzoni
From: Gregory CLEMENT gregory.clem...@free-electrons.com
Sorting the headers in alphabetic order will help to reduce the conflict
when adding new headers later.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Acked-by: Felipe Balbi ba...@ti.com
Signed-off-by: Thomas Petazzoni
for this piece of hardware.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
.../bindings/phy/armada-375-usb-phy-cluster.txt | 19 +++
1 file changed, 19 insertions(+)
create mode 100644
gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/boot/dts/armada-375-db.dts | 4
arch/arm/boot/dts/armada-375.dtsi | 10 ++
2 files changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/armada-375-db.dts
b/arch/arm/boot
This commit updates the Device Tree binding documentation of
ehci-orion to take into account the fact that we can now optionally
pass a clock and a PHY reference.
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
Documentation/devicetree/bindings/usb/ehci-orion.txt | 5
: reword commit log, fix goto label names.]
Fixes: 8c869edaee07c623066266827371235fb9c12e01 ('ARM: Orion: EHCI: Add support
for enabling clocks')
Cc: sta...@vger.kernel.org # v3.8+
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free
framework to
control this USB cluster feature.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
drivers/phy/Kconfig | 6 ++
drivers/phy/Makefile | 1 +
drivers/phy/phy-armada375-usb2
.
It also indicates that an optional 'clocks' property is now supported.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
Documentation/devicetree/bindings/usb/usb-xhci.txt | 7 ++-
1 file changed, 6
: use devm_phy_optional_get() so that we handle -EPROBE_DEFER
properly. Also call phy_power_off() when needed, and rename goto
labels.]
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
drivers/usb/host/ehci
gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/boot/dts/armada-385-db.dts | 4
arch/arm/boot/dts/armada-38x.dtsi | 8
2 files changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/armada-385-db.dts
b/arch/arm/boot
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
Cc: a...@kernel.org
Cc: Kevin Hilman khil...@linaro.org
Cc: Olof Johansson o...@lixom.net
Cc: Arnd Bergmann a...@arndb.de
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs
In preparation to the introduction of additional initialization steps
in ehci_orion_drv_probe(), we rename the error goto labels from err1,
err2 and err3 names to some more meaningful names.
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
drivers/usb/host/ehci-orion.c
From: Gregory CLEMENT gregory.clem...@free-electrons.com
This patch adds the selection of the config symbol needed to build the
USB3 support for Armada 38x into mvebu_v7_defconfig.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz
.
Two new compatible strings are added to identify the Armada 375 and
Armada 38x XHCI controllers, and therefore enable the relevant quirk.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
drivers/usb/host
From: Gregory CLEMENT gregory.clem...@free-electrons.com
This patch add the selection of the config symbol to build the USB3
support for Armada 375.
Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm
-V4.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
selects it, if xhci-mvebu is a bool, there would no longer
be a way to have xhci-plat as a module. At least that's my
understanding of the kconfig stuff :)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe
drivers that use the
MVEBU_MBUS functions.
You probably need something like
depends on MVEBU_MBUS=y || (MVEBU_MBUS=m USB_XHCI=m)
MVEBU_MBUS is a bool, so there is no way is can be =m.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http
-mvebu driver, and its dependency is:
depends on ARCH_MVEBU || ARCH_DOVE || ARCH_KIRKWOOD
For this one, we could indeed add || (MVEBU_MBUS COMPILE_TEST)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free
= devm_clk_get(pdev-dev, NULL);
No, this isn't correct: you shouldn't be getting the clock to
disable/unprepare it, otherwise you have an unbalanced number of
get()/put() calls on the clocks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free
xhci_mvebu_mbus_init_quirk(struct platform_device *pdev)
I believe this should give you a warning about section mismatch: you
have a non-init function calling an __init function, no?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free
exactly what you suggest here, but Felipe explicitly requested the
patches to be changed like is now proposed in v2.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe
instead of 0?
This is not important. IRQs 0 and 1 are reserved for doorbells, which
are only used for IPI (IRQ 0) and MSI (IRQ 1). Therefore, doing
irq_find_mapping() for either IRQ 0 or IRQ 1 is not useful.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel
the issue in the first
place!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
in the Marvell PCI MSI code to try to understand what's going on.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
- as a separator, not _. So, it should
be:
disconnect-line-without-vbus
Also, all your patches touching Device Tree bindings should be Cc'ed to
the devicetree@ mailing list.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
to use
module_platform_driver() ?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
on the PCIe
bus. There is nothing like a PCIe port that uses a USB port, that
doesn't make sense.
So, IMHO, if OpenBlocks uses third USB port to connect some PCIe
controller, we should activate it in the dts file.
What do you think?
No, see above.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel
70 matches
Mail list logo
