I am encountering the following Null Pointer exception during runtime, however
the application keeps working as intended.
Exception posted at the end to declutter the mail.
Google search for this exception took me to this thread
On Wed, 28 Feb 2024 18:48:21 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Thu, 29 Feb 2024 00:27:33 GMT, Andy Goryachev wrote:
> P.S. Tested on on macOS 14.3.1. The results on Windows/Linux should be
> identical, but if we can get some testing done on these two platforms that
> would be nice.
I tested the changes in windows and do not see any issues.
I have
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to
On Wed, 28 Feb 2024 12:18:08 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation
On Mon, 26 Feb 2024 20:51:56 GMT, Marius Hanl wrote:
> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is
> broken when `sizeToScene()` was called before or after.
>
> The approach here is to ignore the `sizeToScene()` request when the `Stage`
> is maximized or set
On Wed, 28 Feb 2024 21:48:38 GMT, Andy Goryachev wrote:
> Q: Does this PR need a CSR?
Not if all of the changes are just clarification or documenting missing
parameters.
-
PR Comment: https://git.openjdk.org/jfx/pull/1384#issuecomment-1970132810
On Mon, 26 Feb 2024 20:51:56 GMT, Marius Hanl wrote:
> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is
> broken when `sizeToScene()` was called before or after.
>
> The approach here is to ignore the `sizeToScene()` request when the `Stage`
> is maximized or set
This change brings the number of javadoc warnings back to 91 (to be fixed in
[JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
- adds missing information in `@param` tags
- adds `@SuppressWarnings("doclint:missing")` to `Skinnable` to silence the
warning due to
On Wed, 28 Feb 2024 20:20:35 GMT, Martin Fox wrote:
> I don't think this is a problem with the nested event loop bookkeeping. It
> looks like a much simpler bug in the invokeLaterDispatcher.
Well, yes and no. My testing was showing that `notifyLeftNestedEventLoop` was
not even called in the
On Tue, 27 Feb 2024 18:24:02 GMT, John Hendrikx wrote:
> Looks okay. `threadId` was added in JDK 19, but since we're on 21 now that
> should be fine.
Exactly. And as I noted in the JBS issue, this fix must not be backported to
earlier versions of JavaFX (it would fail to compile anyway, since
On Tue, 27 Feb 2024 17:58:13 GMT, Anirvan Sarkar wrote:
> Replace Thread.currentThread().getId() with Thread.currentThread().threadId()
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx/pull/1383#pullrequestreview-1907489547
On Thu, 22 Feb 2024 23:13:26 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every
On Wed, 28 Feb 2024 18:48:21 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
> necessary, but the current doc explains it), and examples.
>
On Wed, 28 Feb 2024 18:24:30 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Wed, 28 Feb 2024 18:24:30 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Wed, 28 Feb 2024 18:24:30 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
> necessary, but the current doc explains it), and examples.
>
On Wed, 28 Feb 2024 16:01:15 GMT, Nir Lisker wrote:
> > One other thing I noticed is that the file names have spaces in them, which
> > is not a best practice and causes problems for scripts. Can you change all
> > spaces to _ in the names of the newly-added files?
>
> Yes. What about
All,
If you have backports that you want to get into jfx22u for JavaFX
22.0.1, please do so by Monday, March 11th. Note that approval from one
of the project leads is needed as outlined in this message [1].
Thanks.
-- Kevin
[1]
On Wed, 28 Feb 2024 14:21:55 GMT, Kevin Rushforth wrote:
> One other thing I noticed is that the file names have spaces in them, which
> is not a best practice and causes problems for scripts. Can you change all
> spaces to _ in the names of the newly-added files?
Yes. What about folders?
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
> necessary, but the current doc explains it), and examples.
>
On Tue, 27 Feb 2024 12:13:09 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java
> line 170:
>
>> 168: *
On Tue, 27 Feb 2024 11:24:08 GMT, Ambarish Rapte wrote:
> PhongMaterial is not suitable for surfaces that reflect or refract the
> incident light.
But it does reflect the incident light as explained in the paragraphs before.
-
PR Review Comment:
On Wed, 28 Feb 2024 13:50:38 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Wed, 28 Feb 2024 13:50:38 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Wed, 28 Feb 2024 13:50:38 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Tue, 27 Feb 2024 11:53:35 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java
> line 115:
>
>> 113: *
On Wed, 28 Feb 2024 13:50:38 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
> necessary, but the current doc explains it), and examples.
>
On Wed, 28 Feb 2024 05:19:06 GMT, Jayathirth D V wrote:
>> IJG has released latest version of libjpeg 9f and we need to update our
>> version also match 9f changes.
>> IJG reference : https://www.ijg.org/
>>
>> With updated changes both headless and headful tests are green on all
>>
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to
On Tue, 27 Feb 2024 16:18:31 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix repeating text node issue
>
> So, I looked into the mirroring problem as well. I had to remove a single
> line
34 matches
Mail list logo
