[ovs-dev] [PATCH v2] tests: Fix compatibility issue with Python 3.13 in vlog.at.

The vlog - Python3 test makes use of output from Python Tracebacks in its test assertion. In Python 3.13 a line with tophat (``^``) markers is added below Tracebacks from calls to assert [0], which makes the test fail. This change of behavior is also backported to the Python 3.12 and 3.11 stable

Re: [ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

On 4/8/24 22:10, Frode Nordahl wrote: > On Mon, Apr 8, 2024 at 9:18 PM Frode Nordahl wrote: >> >> On Mon, Apr 8, 2024 at 9:14 PM Ilya Maximets wrote: >>> >>> On 4/8/24 16:48, Frode Nordahl wrote: On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrote: > > On 4/8/24 16:39, Frode Nordahl

Re: [ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

On Mon, Apr 8, 2024 at 9:18 PM Frode Nordahl wrote: > > On Mon, Apr 8, 2024 at 9:14 PM Ilya Maximets wrote: > > > > On 4/8/24 16:48, Frode Nordahl wrote: > > > On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrote: > > >> > > >> On 4/8/24 16:39, Frode Nordahl wrote: > > >>> The vlog - Python3 test

Re: [ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

On Mon, Apr 8, 2024 at 9:14 PM Ilya Maximets wrote: > > On 4/8/24 16:48, Frode Nordahl wrote: > > On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrote: > >> > >> On 4/8/24 16:39, Frode Nordahl wrote: > >>> The vlog - Python3 test makes use of output from Python > >>> Tracebacks in its assertion. >

Re: [ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

On 4/8/24 16:48, Frode Nordahl wrote: > On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrote: >> >> On 4/8/24 16:39, Frode Nordahl wrote: >>> The vlog - Python3 test makes use of output from Python >>> Tracebacks in its assertion. >>> >>> In Python 3.12 a line with tophat (``^``) markers is added

Re: [ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrote: > > On 4/8/24 16:39, Frode Nordahl wrote: > > The vlog - Python3 test makes use of output from Python > > Tracebacks in its assertion. > > > > In Python 3.12 a line with tophat (``^``) markers is added below > > the assert line, which makes the

Re: [ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

On 4/8/24 16:39, Frode Nordahl wrote: > The vlog - Python3 test makes use of output from Python > Tracebacks in its assertion. > > In Python 3.12 a line with tophat (``^``) markers is added below > the assert line, which makes the test fail. Hmm. Are you sure it's 3.12? I believe I did run

[ovs-dev] [PATCH] tests: Fix compatibility issue with Python 3.12 in vlog.at.

The vlog - Python3 test makes use of output from Python Tracebacks in its assertion. In Python 3.12 a line with tophat (``^``) markers is added below the assert line, which makes the test fail. Strip lines starting whith whitespace and otherwise only containing one or more occurence of the ``^``

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Fallback to non tunnel offloading API.

On Fri, Apr 5, 2024 at 3:00 PM Ilya Maximets wrote: > >> > >>> Basically, resolving a neighbor with ARP inside tunnels is broken on > >>> Intel nics (even without re-enabling outer udp checksum). > >>> This can be observed with the following debug patch at the end of > >>>

Re: [ovs-dev] [PATCH ovn v4] Make tunnel ids exhaustion test trigger the problem.

Note to reviewers: looks like the port tunnel id test case revealed a number of undefined behaviors and leaks (?) in northd; I am working on addressing these. Before that, we should not merge this patch as-is. (Or at least we should not merge the part with the port case; I believe the network case

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

Ooops , my bad :) Sent from phone > On 8 Apr 2024, at 15:39, Ilya Maximets wrote: > > On 4/8/24 15:29, Alin Serdean wrote: >> >> The spellchecker one: >> https://github.com/openvswitch/ovs/blob/master/utilities/checkpatch.py#L115 >>

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

On 4/8/24 15:29, Alin Serdean wrote: > > The spellchecker one:  > https://github.com/openvswitch/ovs/blob/master/utilities/checkpatch.py#L115 > > > I don’t assume so but wanted to verify. Ah, this one was just added

[ovs-dev] ovsdb-idl: potential issues with the persistent UUID implementation

There was a patch in OVS 3.1 that added support to the IDL code for specifying the permanent UUID of a row when inserting [1]. There are both C and Python implementations. Initially, I was adding support to ovsdbapp for this feature and noticed that the Python tests for this feature passed

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

The spellchecker one: https://github.com/openvswitch/ovs/blob/master/utilities/checkpatch.py#L115 I don’t assume so but wanted to verify. > On 8 Apr 2024, at 13:30, Ilya Maximets wrote: > > On 4/8/24 13:26, Alin Serdean wrote: >> >> Just one question: do we have to remove the xenserver

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

On 4/8/24 13:26, Alin Serdean wrote: > > Just one question: do we have to remove the xenserver reference in the > checkpatch.py? Hmm. Which one? > > Otherwise looks good. > > Acked-by: Alin Gabriel Serdean > >> On 8 Apr 2024, at 13:06, Ilya Maximets wrote: >> >> Remaining bits from the

Re: [ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

Just one question: do we have to remove the xenserver reference in the checkpatch.py? Otherwise looks good. Acked-by: Alin Gabriel Serdean > On 8 Apr 2024, at 13:06, Ilya Maximets wrote: > > Remaining bits from the OVS/OVN split. > > Fixes: 1af37d11be73 ("Remove XenServer Code") >

[ovs-dev] [PATCH ovn] treewide: Remove remaining XenServer references.

Remaining bits from the OVS/OVN split. Fixes: 1af37d11be73 ("Remove XenServer Code") Signed-off-by: Ilya Maximets --- Documentation/tutorials/index.rst | 6 -- README.rst| 3 --- acinclude.m4 | 26 ---

Re: [ovs-dev] [PATCH] checkpatch: Add additional words to extra_keywords.

On 2 Apr 2024, at 19:46, Simon Horman wrote: > On Tue, Apr 02, 2024 at 03:21:16PM +0200, Eelco Chaudron wrote: >> This patch add another set of keywords based on the results >> of the last thousand committed patches. >> >> Signed-off-by: Eelco Chaudron > > Acked-by: Simon Horman Thanks Simon

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

On 7 Apr 2024, at 3:57, LIU Yulong wrote: > Hi Eelco, > > Sorry for the late reply. And thank you very much for your code examination. > > Today, I removed that "ovsrcu_quiesce();" at line 3066 [1], and > started to run the > test in my local environment. Let's see if such change can overcome

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Use paused controller action for packet buffering.

On Fri, Apr 5, 2024 at 10:35 PM Numan Siddique wrote: > > > On Tue, Apr 2, 2024 at 2:28 AM Ales Musil wrote: > >> The current packet injection loses ct_state in the process. When >> the ct_state is lost we might commit to DNAT zone and perform >> zero SNAT after the packet injection. This