On Mon, Jan 2, 2023 at 2:03 PM Dag Lem wrote:
> I also improved on the documentation example (using Full Text Search).
> AFAIK you can't make general queries like that using arrays, however in
> any case I must admit that text arrays seem like more natural building
> blocks than space delimited
On Wed, Jan 11, 2023 at 10:58:54AM -0800, Andres Freund wrote:
> Hi,
>
> On 2023-01-11 10:35:19 -0800, Peter Geoghegan wrote:
> > On Wed, Jan 11, 2023 at 10:27 AM Andres Freund wrote:
> > > Therefore I'd like to add an option to the VACUUM command to use to
> > > disable
> > > the use of the
Hi,
On 2023-01-10 10:01:25 +0100, Marco Slot wrote:
> On Fri, Dec 23, 2022 at 11:43 AM Will Mortensen wrote:
> > We'd like to be able to call the lock manager's WaitForLockers() and
> > WaitForLockersMultiple() from SQL. Below I describe our use case, but
> > basically I'm wondering if this:
> >
Hi,
On 2023-01-11 15:23:18 -0500, Robert Haas wrote:
> Yeah, I meant if #1 had committed and then #2 started to do its thing.
> I was worried that decoding might reach the nextval operations in
> transaction #2 before it replayed #1.
>
> This worry may be entirely based on me not understanding
Hi,
On 2023-01-06 10:52:06 +0100, Drouvot, Bertrand wrote:
> On 1/6/23 4:40 AM, Andres Freund wrote:
> > ISTM that the ordering of patches isn't quite right later on. ISTM that it
> > doesn't make sense to introduce working logic decoding without first fixing
> > WalSndWaitForWal() (i.e. patch
On Wed, Jan 11, 2023 at 1:29 PM Tomas Vondra
wrote:
> > I agree that it's fine for the sequence to be slightly ahead, but I
> > think that it can't be too far ahead without causing problems. Suppose
> > for example that transaction #1 creates a sequence. Transaction #2
> > does nextval on the
On Wed, Jan 11, 2023 at 10:16 AM Noah Misch wrote:
> A "git grep 'direct or indirect mem'" found a few more:
>
> doc/src/sgml/ref/alter_collation.sgml:42: To alter the owner, you must also
> be a direct or indirect member of the new
> doc/src/sgml/ref/create_database.sgml:92:role, you
Hi,
Heikki, CCed you due to the point about 2c03216d8311 below.
On 2023-01-10 19:32:12 +0100, Tomas Vondra wrote:
> 0001 is a fix for the pre-existing issue in logicalmsg_decode,
> attempting to build a snapshot before getting into a consistent state.
> AFAICS this only affects assert-enabled
Thanks for taking a look.
On Wed, Jan 11, 2023 at 04:53:39PM +0900, Michael Paquier wrote:
> Hmm. Is passing down the file name used as a cutoff point the best
> interface for the modules? Perhaps passing down the redo LSN and its
> TLI would be a cleaner approach in terms of flexibility? I
On Wed, Jan 11, 2023 at 11:18 AM Andres Freund wrote:
> I don't like that - it's also quite useful to disable use of ringbuffers when
> you actually need to clean up indexes. Especially when we have a lot of dead
> tuples we'll rescan indexes over and over...
That's a fair point.
My vote goes
Hi,
On 2023-01-11 11:06:26 -0800, Peter Geoghegan wrote:
> On Wed, Jan 11, 2023 at 10:58 AM Andres Freund wrote:
> > Any idea about the name? The obvious thing is to reference ring buffers in
> > the
> > option name, but that's more of an implementation detail...
>
> What are the chances that
On Wed, Jan 11, 2023 at 10:23 AM Magnus Hagander wrote:
> Sorry to jump in (very) late in this game. So first, I like this general
> approach :)
Thanks!
> It feels icky to have to add configure tests just to make a test work. But I
> guess there isn't really a way around that if we want to
On Wed, Jan 11, 2023 at 10:58 AM Andres Freund wrote:
> Any idea about the name? The obvious thing is to reference ring buffers in the
> option name, but that's more of an implementation detail...
What are the chances that anybody using this feature via a manual
VACUUM command will also use
Hi,
On 2023-01-11 10:35:19 -0800, Peter Geoghegan wrote:
> On Wed, Jan 11, 2023 at 10:27 AM Andres Freund wrote:
> > Therefore I'd like to add an option to the VACUUM command to use to disable
> > the use of the ringbuffer. Not sure about the name yet.
>
> Sounds like a good idea.
Any idea
Hi,
On 2023-01-11 10:27:20 -0800, Andres Freund wrote:
> On cloud hardware with higher fsync latency I've seen > 15x time differences
> between using the ringbuffers and avoiding them by using pg_prewarm.
A slightly edited version of what I've in the past to defeat the ringbuffers
using
On Wed, Jan 11, 2023 at 11:09:01AM +0100, Peter Eisentraut wrote:
> committed with that fixed
While rebasing my recovery modules patch set, I noticed a couple of small
things that might be worth cleaning up.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
diff --git
st 11. 1. 2023 v 19:31 odesílatel Magnus Hagander
napsal:
> On Wed, Jan 11, 2023 at 7:24 PM Isaac Morland
> wrote:
>
>> On Wed, 11 Jan 2023 at 13:11, Pavel Stehule
>> wrote:
>>
>> please, don't send top post replies -
>>> https://en.wikipedia.org/wiki/Posting_style
>>>
>>
>> Sorry about that;
On Wed, Jan 11, 2023 at 10:27 AM Andres Freund wrote:
> Therefore I'd like to add an option to the VACUUM command to use to disable
> the use of the ringbuffer. Not sure about the name yet.
Sounds like a good idea.
> I think we should auto-enable that mode once we're using the failsafe mode,
>
On Wed, Jan 11, 2023 at 7:24 PM Isaac Morland
wrote:
> On Wed, 11 Jan 2023 at 13:11, Pavel Stehule
> wrote:
>
> please, don't send top post replies -
>> https://en.wikipedia.org/wiki/Posting_style
>>
>
> Sorry about that; I do know to do it properly and usually get it right.
> GMail doesn’t
On 1/10/23 20:52, Robert Haas wrote:
> On Tue, Jan 10, 2023 at 1:32 PM Tomas Vondra
> wrote:
>> 0001 is a fix for the pre-existing issue in logicalmsg_decode,
>> attempting to build a snapshot before getting into a consistent state.
>> AFAICS this only affects assert-enabled builds and is
On Tue, Jan 10, 2023 at 7:53 PM Tom Lane wrote:
> Jacob Champion writes:
> > Unless I'm missing something obvious (please, let it be that) there's no
> > way to do this safely. Once you've marked an internal table as dumpable,
> > its schema is effectively frozen if you want your dumps to work
Hi,
The use of the ringbuffer in VACUUM often causes very substantial slowdowns.
The primary reason for that is that often most/all the buffers in the
ringbuffer have been dirtied when they were processed, with an associated WAL
record. When we then reuse the buffer via the (quite small)
On Tue, Jan 10, 2023 at 10:25 PM Tom Lane wrote:
> > Of course, if it's possible for a non-CREATEROLE user to set the value
> > that a CREATEROLE user experiences, that'd be more of a problem --
>
> That's exactly the case I'm worried about, and it's completely reachable
> if a CREATEROLE user
On Wed, 11 Jan 2023 at 13:11, Pavel Stehule wrote:
please, don't send top post replies -
> https://en.wikipedia.org/wiki/Posting_style
>
Sorry about that; I do know to do it properly and usually get it right.
GMail doesn’t seem to have an option (that I can find) to leave no space at
the top
On Wed, Jan 11, 2023 at 6:27 PM Jacob Champion
wrote:
> On Wed, Jan 11, 2023 at 6:37 AM Jelte Fennema wrote:
> >
> > LGTM. As far as I can tell this is ready for a committer.
>
> Thanks for the reviews!
>
Sorry to jump in (very) late in this game. So first, I like this general
approach :)
It
Or, only show the source in \df++. But it'd be a bit unfortunate if the
C language function wasn't shown in \df+
Hi
st 11. 1. 2023 v 18:57 odesílatel Isaac Morland
napsal:
> Right, for internal or C functions it just gives a symbol name or
> something similar. I've never been annoyed seeing that, just having pages
> of PL/PGSQL (I use a lot of that, possibly biased towards the “too much”
> direction) take
Right, for internal or C functions it just gives a symbol name or something
similar. I've never been annoyed seeing that, just having pages of PL/PGSQL
(I use a lot of that, possibly biased towards the “too much” direction)
take up all the space.
A bit hacky, but what about only showing the first
On Wed, Jan 11, 2023 at 02:22:26PM +0100, Gilles Darold wrote:
> I'm moving this commitfest entry to Ready for Committers.
Thank you for reviewing.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
st 11. 1. 2023 v 18:25 odesílatel Magnus Hagander
napsal:
>
>
> On Wed, Jan 11, 2023 at 6:19 PM Pavel Stehule
> wrote:
>
>>
>>
>> st 11. 1. 2023 v 17:50 odesílatel Isaac Morland
>> napsal:
>>
>>> I find \df+ much less useful than it should be because it tends to be
>>> cluttered up with source
On Wed, Jan 11, 2023 at 6:37 AM Jelte Fennema wrote:
>
> LGTM. As far as I can tell this is ready for a committer.
Thanks for the reviews!
--Jacob
On Wed, Jan 11, 2023 at 6:19 PM Pavel Stehule
wrote:
>
>
> st 11. 1. 2023 v 17:50 odesílatel Isaac Morland
> napsal:
>
>> I find \df+ much less useful than it should be because it tends to be
>> cluttered up with source code. Now that we have \sf, would it be reasonable
>> to remove the source
st 11. 1. 2023 v 17:50 odesílatel Isaac Morland
napsal:
> I find \df+ much less useful than it should be because it tends to be
> cluttered up with source code. Now that we have \sf, would it be reasonable
> to remove the source code from the \df+ display? This would make it easier
> to see
Hi Dilip! Thank you for the review!
On Tue, Jan 10, 2023 at 9:58 PM Dilip Kumar wrote:
>
> On Mon, Jan 9, 2023 at 9:49 AM Andrey Borodin wrote:
> >
> > On Tue, Jan 3, 2023 at 5:02 AM vignesh C wrote:
> > > does not apply on top of HEAD as in [1], please post a rebased patch:
> > >
> > Thanks!
Hi all,
I would like to propose a new pg_dump option called --with-child to
include or exclude from a dump all child and partition tables when a
parent table is specified using option -t/--table or -T/--exclude-table.
The whole tree is dumped with the root table.
To include all partitions
On Wed, 11 Jan 2023 at 12:19, Michael Paquier wrote:
>
> On Wed, Jan 11, 2023 at 12:10:33PM +0900, Kyotaro Horiguchi wrote:
> > It suggests the *kinds* of objects that are part of the extension, but
> > lists the objects of that kind regardless of dependency. I read
> > Michael suggested (and I
Hi,
On 2023-01-11 13:02:13 +0530, Bharath Rupireddy wrote:
> 3. Is this feature still a 'minimal logical decoding on standby'?
> Firstly, why is it 'minimal'?
It's minimal in comparison to other proposals at the time that did explicit /
active coordination between primary and standby to allow
I find \df+ much less useful than it should be because it tends to be
cluttered up with source code. Now that we have \sf, would it be reasonable
to remove the source code from the \df+ display? This would make it easier
to see function permissions and comments. If somebody wants to see the full
On Fri, 9 Dec 2022 at 16:01, Christoph Heiss wrote:
>
> Thanks for the review!
>
> On 12/8/22 12:19, Melih Mutlu wrote:
> > Hi Christoph,
> >
> > I just took a quick look at your patch.
> > Some suggestions:
> >
> > + else if (Matches("ALTER", "VIEW", MatchAny, "SET", "("))
> > +
On Wed, Jan 11, 2023 at 1:48 AM Aleksander Alekseev
wrote:
> After reading [1] carefully it looks like we shouldn't worry about
> this. The upgrade procedure explicitly requires to run `pg_ctl stop`
> during step 8 of the upgrade procedure, i.e. not in the immediate mode
> [2].
Yeah, pg_upgrade
On Tue, 8 Nov 2022 at 02:16, Fabien COELHO wrote:
>
>
> Hello Ian,
>
> > cfbot reports the patch no longer applies. As CommitFest 2022-11 is
> > currently underway, this would be an excellent time to update the patch.
>
> Attached a v5 which is just a rebase.
The patch does not apply on top of
On Sat, 31 Dec 2022 at 19:47, Peter Eisentraut
wrote:
>
> On 21.12.22 06:46, Peter Eisentraut wrote:
> > And another update. The main changes are that I added an 'unspecified'
> > CMK algorithm, which indicates that the external KMS knows what it is
> > but the database system doesn't. This was
On Tue, 29 Nov 2022 at 18:16, Daniel Gustafsson wrote:
>
> > On 3 Nov 2022, at 21:47, Daniel Gustafsson wrote:
>
> > The patch adds a new GUC, ignore_event_trigger with two option values, 'all'
> > and 'none' (the login event patch had 'login' as well).
>
> The attached v2 fixes a small bug
On Thu, 22 Dec 2022 at 11:11, Jeff Davis wrote:
>
> On Sat, 2022-12-17 at 19:14 -0800, Jeff Davis wrote:
> > Attached is a new patch series. I think there are enough changes that
> > this has become more of a "rework" of the collation code rather than
> > just a refactoring. This is a
On Wed, 11 Jan 2023 at 16:14, Melih Mutlu wrote:
>
> Hi,
>
> Thanks for your review.
>
> shiy.f...@fujitsu.com , 11 Oca 2023 Çar, 11:56
> tarihinde şunu yazdı:
>>
>> On Mon, Nov 14, 2022 8:08 PM Melih Mutlu wrote:
>> 1.
>> +# Binary enabled subscription should fail
>>
Hi,
On 2023-01-11 10:29:06 +0100, Anthonin Bonnefoy wrote:
> Currently, the Checkpointer process only reports SLRU statistics at server
> shutdown, leading to delayed statistics for SLRU flushes. This patch adds a
> flush of SLRU stats to the end of checkpoints.
Hm. I wonder if we should do this
On Tue, 10 Jan 2023 at 02:41, Melanie Plageman
wrote:
>
> Attached is v45 of the patchset. I've done some additional code cleanup
> and changes. The most significant change, however, is the docs. I've
> separated the docs into its own patch for ease of review.
>
> The docs patch here was edited
Peter Eisentraut writes:
> The current hierarchy of object types is like this:
> ...
> How does one decide whether something should be in a schema or not?
Roughly speaking, I think the intuition was "if there are not likely
to be a lot of objects of type X, maybe they don't need to be within
On Mon, Sep 5, 2022 at 2:04 PM Justin Pryzby wrote:
>
> On Thu, Aug 04, 2022 at 01:45:49AM -0400, Robert Treat wrote:
> > After reading this again, it isn't clear to me that this advice would
> > be more appropriately placed into Section 5.11, aka
> >
The current hierarchy of object types is like this:
database
access method
event trigger
extension
foreign data wrapper
foreign server
language
publication
schema
aggregate
collation
Hi,
On 1/11/23 8:32 AM, Bharath Rupireddy wrote:
On Tue, Jan 10, 2023 at 2:03 PM Drouvot, Bertrand
wrote:
Please find attached, V37 taking care of:
Thanks. I started to digest the design specified in the commit message
and these patches.
Thanks for looking at it!
Here are some quick
On Tue, Jan 10, 2023 at 11:06:52AM -0500, Robert Haas wrote:
> On Sat, Jan 7, 2023 at 12:00 AM Noah Misch wrote:
> > The docs are silent on the SET / OWNER TO connection. Hence,
>
> Reviewing the documentation again today, I realized that the
> documentation describes the rules for changing the
Hi, Thank you for your quick reply
I misunderstood the logic of pg_atomic_compare_exchange_u32, so the loop
cannot be infinite.
> I wonder if we should make ->nextVictimBuffer a 64bit atomic. At the time
the changes went in we didn't (or rather, couldn't) rely on it, but these
days we could. I
On Wed, Nov 30, 2022 at 11:43 AM Bharath Rupireddy
wrote:
>
> I'm attaching the v22 patch set for further review.
Needed a rebase due to 216a784829c2c5f03ab0c43e009126cbb819e9b2.
Attaching v23 patch set for further review.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source
LGTM. As far as I can tell this is ready for a committer.
On Wed, 11 Jan 2023 at 00:15, Jacob Champion wrote:
>
> On Mon, Jan 9, 2023 at 7:07 AM Jelte Fennema wrote:
> > I also took a closer look at the code, and the only comment I have is:
> >
> > > appendPQExpBuffer(>errorMessage,
> >
> >
> couldn't we also use a regexp for the pg-role rather than
> just a hardcoded keyword here then, so as it would be possible to
> allow a mapping to pass for a group of role names? "all" is just a
> pattern to allow everything, at the end.
That's a good point. I hadn't realised that you added
On 09.01.23 21:18, Tom Lane wrote:
* AFAIK our practice is to use "-" never "_" in XML ID attributes.
You weren't very consistent about that even within this patch, and
the overall effect would have been to have no standard about that
at all, which doesn't seem great. I changed them all to "-".
On 06.01.23 08:04, Jeff Davis wrote:
The existing code is not great, in my opinion: it doesn't have clear
API boundaries, the comments are insufficient, and lots of special
cases need to be handled awkwardly by callers. That style is hard to
beat when it comes to the raw line count; but it's
On Wed, Jan 11, 2023 at 3:28 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 1/11/23 5:17 AM, Bharath Rupireddy wrote:
> > On Wed, Jan 11, 2023 at 6:32 AM Michael Paquier wrote:
> >>
> >> On Tue, Jan 10, 2023 at 05:25:44PM +0100, Drouvot, Bertrand wrote:
> >>> I like the idea of comparing the full
On Wed, Jan 11, 2023 at 10:07 AM Michael Paquier wrote:
>
> +postgres=# SELECT lsn, tablespace_oid, database_oid, relfile_number,
> block_number, fork_name, length(fpi) > 0 as fpi_ok FROM
> pg_get_wal_fpi_info('0/7418E60', '0/7518218');
>
> This query in the docs is too long IMO. Could you split
Le 06/01/2023 à 01:26, Nathan Bossart a écrit :
Apparently I forgot to run all the tests before posting v4. Here is a new
version of the patch that should pass all tests.
Review status:
The patch applies and compiles without issues, make check and
checkinstall tests are running without
On 2023-01-11 11:28, Tom Lane wrote:
I wrote:
I've spent some effort previously on getting tab-completion to deal
sanely with single-quoted strings, but everything I've tried has
crashed and burned :-(, mainly because it's not clear when to take
the whole literal as one "word" and when not.
Dear Vignesh,
Thanks for reviewing!
> 1) Comment inconsistency across create and alter subscription, better
> to keep it same:
A comment for CREATE SUBSCRIPTION became same as ALTER's one.
> 2) ereport inconsistency, braces around errcode is present in few
> places and not present in few
> 2.
> I think users can set ' wal_receiver_status_interval ' to 0 or more
> than 'wal_sender_timeout'. But is this a frequent use-case scenario or
> do we see DBAs setting these in such a way by mistake? If so, then I
> think, it is better to give Warning message in such a case when a user
>
Dear Shveta,
Thanks for reviewing! PSA new version.
> 1.
> + errmsg("min_apply_delay must not be set when streaming = parallel")));
> we give the same error msg for both the cases:
> a. when subscription is created with streaming=parallel but we are
> trying to alter subscription to set
Hi Anthonin,
> This patch adds a flush of SLRU stats to the end of checkpoints.
The patch looks good to me and passes the tests but let's see if
anyone else has any feedback.
Also I added a CF entry: https://commitfest.postgresql.org/42/4120/
--
Best regards,
Aleksander Alekseev
On Tue, 10 Jan 2023 at 19:41, Takamichi Osumi (Fujitsu)
wrote:
>
> On Tuesday, January 3, 2023 4:01 PM vignesh C wrote:
> Hi, thanks for your review !
>
> Please have a look at the updated patch.
Thanks for the updated patch, few comments:
1) Comment inconsistency across create and alter
On Wed, Jan 11, 2023 at 09:04:56AM +, Jelte Fennema wrote:
> It's very different. I think easiest is to explain by example:
>
> If there exist three users on the postgres server: admin, jelte and michael
>
> Then this rule (your suggested rule):
> mapname /^(.*)$ \1
>
> Is equivalent to:
>
On 04.01.23 23:53, Andres Freund wrote:
dir_data = get_option('datadir')
-if not (dir_data.contains('pgsql') or dir_data.contains('postgres'))
+if not ((dir_prefix/dir_data).contains('pgsql') or
(dir_prefix/dir_data).contains('postgres'))
dir_data = dir_data / pkg
endif
Hm. Perhaps we
Hi,
When I was reading the "Logical Decoding Output Plugins" chapter in pg-doc [1],
I think in the summary section, only the callback message_cb is not described
whether it is required or optional, and the description of callback
stream_prepare_cb seems inaccurate.
And after the summary section,
Hi,
Thanks for your review.
shiy.f...@fujitsu.com , 11 Oca 2023 Çar, 11:56
tarihinde şunu yazdı:
> On Mon, Nov 14, 2022 8:08 PM Melih Mutlu wrote:
> 1.
> +# Binary enabled subscription should fail
> +$node_subscriber_binary->wait_for_log("ERROR: insufficient data left in
> message");
>
>
On Mon, Jan 9, 2023 at 13:04 PM Amit Kapila wrote:
>
Thanks for your comments.
> One more thing, I think it would be better to expose a new callback
> API via reorder buffer as suggested previously [2] similar to other
> reorder buffer APIs instead of directly using reorderbuffer API to
>
On Wed, Jan 11, 2023 at 3:27 PM shveta malik wrote:
>
> On Tue, Jan 10, 2023 at 7:42 PM Takamichi Osumi (Fujitsu)
> wrote:
> >
> > On Tuesday, January 3, 2023 4:01 PM vignesh C wrote:
> > Hi, thanks for your review !
> >
> >
> > > 1) This global variable can be removed as it is used only in
>
On Tue, Jan 10, 2023 at 11:09:23PM -0500, Regina Obe wrote:
> The only way we can fix that in the current setup, is to move to a minor
> version mode which means we can
> never do micro updates.
Or just not with standard PostgreSQL syntax, because we can of course
do upgrades using the `SELECT
Hi Marco, thanks for the reply! Glad to know you'd find it useful too. :-)
On Tue, Jan 10, 2023 at 1:01 AM Marco Slot wrote:
> I'm wondering whether it could be an option of the LOCK command.
> (LOCK WAIT ONLY?)
I assume that's doable, but just from looking at the docs, it might be
a little
On Tue, Jan 10, 2023 at 06:50:31PM -0500, Tom Lane wrote:
> With the proposed % feature, if foo--%--3.0.sql exists then the
> system will invoke it and expect the end result to be a valid
> 3.0 installation, whether or not the script actually has any
> ability to do a downgrade.
It is sane,
On 09.01.23 18:53, Nathan Bossart wrote:
+ nativePath = pstrdup(path);
+ make_native_path(nativePath);
+ nativePath = pstrdup(xlogpath);
+ make_native_path(nativePath);
Should these be freed?
committed with that fixed
Dear hackers,
I was not sure, but the cfbot could not be accepted the previous version.
I made the patch again from HEAD(5f6401) without any changes,
so I did not count up the version number.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
Hi,
On 1/11/23 5:17 AM, Bharath Rupireddy wrote:
On Wed, Jan 11, 2023 at 6:32 AM Michael Paquier wrote:
On Tue, Jan 10, 2023 at 05:25:44PM +0100, Drouvot, Bertrand wrote:
I like the idea of comparing the full page (and not just the LSN) but
I'm not sure that adding the pageinspect
On Tue, Jan 10, 2023 at 7:42 PM Takamichi Osumi (Fujitsu)
wrote:
>
> On Tuesday, January 3, 2023 4:01 PM vignesh C wrote:
> Hi, thanks for your review !
>
>
> > 1) This global variable can be removed as it is used only in send_feedback
> > which
> > is called from maybe_delay_apply so we could
I wrote:
> I see. IIUC from a brief re-reading of the code, saving that chunk would
only save us from re-loading "parent->shift" from L1 cache and shifting the
key. The cycles spent doing that seem small compared to the rest of the
work involved in growing a node. Expressions like "if (idx < 0)
Hi Maxim,
> Secondly, shouldn't we introduce a new WAL record type in order to
> make the code backward compatible with previous PG versions? I'm not
> 100% sure how the upgrade procedure works in all the details. If it
> requires the DBMS to be gracefully shut down before the upgrade then
> we
Hello hackers,
Currently, the Checkpointer process only reports SLRU statistics at server
shutdown, leading to delayed statistics for SLRU flushes. This patch adds a
flush of SLRU stats to the end of checkpoints.
Best regards,
Anthonin
flush-slru-counters.patch
Description: Binary data
Hi Maxim,
> Here is a new patch set.
> I've added comments and make use GetClogDirName call in copy_subdir_files.
Jacob Champion pointed out (offlist, cc:'ed) that we may be wrong on this one:
> 0001 patch changes the SLRU internals without affecting the callers.
> 0001 - should make SLRU
On Tue, Jan 10, 2023 at 08:35:16PM +0100, Pavel Stehule wrote:
> út 10. 1. 2023 v 3:20 odesílatel Julien Rouhaud napsal:
> >
> > Another new behavior I see is the new rowtype_only parameter for
> > LookupVariable. Has this been discussed?
> >
>
> I think so it was discussed about table shadowing
> The confusion that 0001 is addressing is fair (cough, fc579e1, cough),
> still I am wondering whether we could do a bit better to be more
Yeah, even after 0001 it's definitely suboptimal. I tried to keep the changes
minimal to not distract from the main purpose of this patch. But I'll update
I'm working on a new patchset for my commitfest entry. I'll make sure
to include a third patch for the +group support, and I'll include you
(Andrew) in the thread when I send it.
On Wed, 11 Jan 2023 at 02:14, Michael Paquier wrote:
>
> On Tue, Jan 10, 2023 at 09:42:19AM -0500, Andrew Dunstan
On Mon, Nov 14, 2022 8:08 PM Melih Mutlu wrote:
>
> Attached patch with updated version of this patch.
Thanks for your patch.
I tried to do a performance test for this patch, the result looks good to me.
(The steps are similar to what Melih shared [1].)
The time to synchronize about 1GB data
On Wed, Jan 11, 2023 at 12:13 PM David Rowley wrote:
> postgres=# set enable_presorted_aggregate=0;
> SET
> postgres=# select string_agg(random()::text, ',' order by random())
> from generate_series(1,3);
> string_agg
>
Hi hackers,
Rebased the patch to resolve conflicts.
Best,
--
Melih Mutlu
Microsoft
v3-0001-Add-replication-protocol-cmd-to-create-a-snapshot.patch
Description: Binary data
v7-0002-Reuse-Logical-Replication-Background-worker.patch
Description: Binary data
On Wed, Jan 11, 2023 at 1:38 PM Ankit Kumar Pandey
wrote:
>
>
> > On 11/01/23 09:57, Tom Lane wrote:
> > IME it's typically a lot more productive to approach things via
> > "scratch your own itch". If a problem is biting you directly, then
> > at least you have some clear idea of what it is that
101 - 191 of 191 matches
Mail list logo
