Re: CREATE INDEX CONCURRENTLY on partitioned index

Ilya Gladyshev писал(а) 2024-05-24 00:14: Hi, Hi. I think it's well worth the effort to revive the patch, so I rebased it on master, updated it and will return it back to the commitfest. Alexander, Justin feel free to add yourselves as authors On 29.01.2024 12:43, Alexander Pyhalov

Re: Partial aggregates pushdown

e_conds = lappend(fpinfo->remote_conds, rinfo); else fpinfo->local_conds = lappend(fpinfo->local_conds, rinfo); From: Alexander Pyhalov Sent: Wednesday, February 28, 2024 10:43 PM contrib/postgres_fdw/deparse.c: comment before append

Re: ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack

Etsuro Fujita писал(а) 2024-03-21 13:59: On Sun, Feb 25, 2024 at 6:34 PM Etsuro Fujita wrote: > On Fri, Feb 23, 2024 at 01:21:14PM +0300, Alexander Pyhalov wrote: > > Recent commit 555276f8594087ba15e0d58e38cd2186b9f39f6d introduced final > > cleanup of no

Re: Partial aggregates pushdown

y representations on different architectures and just refuse to push down partial aggregates on server version mismatch? At least at the first step? 3. Fixing the behavior when the HAVING clause is present From: Robert Haas Sent: Tuesday, November 28, 2023 4:08 AM On Wed, Nov 22, 2023 at 1:3

ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack

FDW. Unfortunately, I couldn't reproduce the issue with postgres_fdw, but it seems it is also affected. The following patch heals the issue. -- l Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 025f40894d6d8f499144f0f7c45c0a124a46c408 Mon Sep 17 00:00:00 2001 From: Alexander Pyha

Re: CREATE INDEX CONCURRENTLY on partitioned index

session, you'll get deadlocks. -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 37a13b7fa1c3277b9d038b7a0c75399ff05b28a7 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Mon, 29 Jan 2024 10:41:01 +0300 Subject: [PATCH] Allow CREATE INDEX CONCURRENTLY on partitioned table --- doc

Re: Assert failure on 'list_member_ptr(rel->joininfo, restrictinfo)'

have a size of about 1kB. Having bitmapset referencing Relation with a large index value, we had a lot of (for example, 1E4 * 1kB) copies on each reparametrization of such a field. Alexander Pyhalov should remember that case. Yes. If it matters, this happened during reparametrization when 2

Re: Add semi-join pushdown to postgres_fdw

Alexander Korotkov писал(а) 2023-12-03 23:52: Hi, Alexander! On Mon, Nov 27, 2023 at 5:11 PM Alexander Pyhalov wrote: Alexander Korotkov писал(а) 2023-11-27 03:49: > Thank you for the revision. > > I've revised the patch myself. I've replaced StringInfo with > additional conds

Re: Add semi-join pushdown to postgres_fdw

Pyhalov, Postgres ProfessionalFrom c17e05d09d5721d22785ed11bed053162d67d967 Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Mon, 27 Nov 2023 14:35:29 +0300 Subject: [PATCH] postgres_fdw: add support for deparsing semi joins --- contrib/postgres_fdw/deparse.c| 234

Re: Partial aggregates pushdown

aid above was wrong with respect to those. Or so I believe, anyway. But I still don't see why HAVING should be a problem. Hi. HAVING is also a problem. Consider the following query SELECT count(a) FROM t HAVING count(a) > 10 - we can't push it down to foreign server as HAVING needs full agg

Re: Add semi-join pushdown to postgres_fdw

n't try to push it down. As semi-join can be executed as JOIN_UNIQUE_INNER or JOIN_UNIQUE_OUTER, this can be a problem - we look at some of these paths and remember that we can't push down such join. -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 91ae85ac735c9f109cd3ab360369

Re: Partial aggregates pushdown

PathTarget cannot be used by FDW as-is to deparse this statement. * So, before modifying PathTarget, setGroupClausePartial generates * another Pathtarget and another list List of SortGroupClauses * to make deparsing possible. */ sounds better. -- Best regards, Alexander Pyhalov, Postgres

Re: Partial aggregates pushdown

fujii.y...@df.mitsubishielectric.co.jp писал 2023-09-27 01:35: Hi Mr.Momjian, Mr.Pyhalov. Tuesday, 26 September 2023 22:15 Alexander Pyhalov : Do you mean that extra->partial_target->sortgrouprefs is not replaced, and so we preserve tlesortgroupref numbers? Yes, that is correct.

Re: Partial aggregates pushdown

the remote server unless the partial aggregate function and the aggregate function match. The default is false. -- Thursday, 20 July 2023 19:23 Alexander Pyhalov : fujii.y...@df.mitsubishielectric.co.jp писал 2023-07-19 03:43: > Hi Mr.Pyhalov, hackers. > 3) > I modified the patch to sa

postgres_fdw could support row comparison pushdown

est regards, Alexander Pyhalov, Postgres ProfessionalFrom 655148c85768afbbfc034e6f5dc5a5a6d72139b8 Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Mon, 7 Aug 2023 11:47:31 +0300 Subject: [PATCH] postgres_fdw: support RowCompareExpr pushdown --- contrib/postgres_fdw/deparse.c|

Re: Partial aggregates pushdown

gt;exprs with partial_target->exprs after processing. Why are we sure that after this tleSortGroupRef is correct? -- Best regards, Alexander Pyhalov, Postgres Professionaldiff --git a/contrib/postgres_fdw/sql/postgres_fdw.sql b/contrib/postgres_fdw/sql/postgres_fdw.sql index 1

Re: Partial aggregates pushdown

'm attaching a patch which seems to fix it, but I'm not quite sure in it. We have not been able to add a test for the case where the remote server version is older than the local server version to the regression test. Is there any way to add such tests to the existing regression tests? --

Re: CREATE INDEX CONCURRENTLY on partitioned index

Justin Pryzby писал 2023-07-13 05:27: On Mon, Mar 27, 2023 at 01:28:24PM +0300, Alexander Pyhalov wrote: Justin Pryzby писал 2023-03-26 17:51: > On Sun, Dec 04, 2022 at 01:09:35PM -0600, Justin Pryzby wrote: > > This currently handles partitions with a loop around the

Re: memory leak in trigger handling (since PG12)

it into the proper long-lived context (e.g. AfterTriggerEvents). I'll get that fixed. Alexander, can you try if this fixes the issue for you? regard Hi. The patch fixes the problem and looks good to me. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: memory leak in trigger handling (since PG12)

ger test_update after update ON test FOR EACH ROW EXECUTE FUNCTION report_update_fields(); insert into test values (1, 12); update test set j=2; -- Best regards, Alexander Pyhalov, Postgres Professional#include #include #include #include #include #ifdef PG_MODULE_MAGIC PG_MODULE_MAGIC; #en

Re: Partial aggregates pushdown

ssible consequences. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Partial aggregates pushdown

in PostgreSQL is used, And here. Overall the code looks good to me, but I suppose that documentation needs further review from some native speaker. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Partial aggregates pushdown

fujii.y...@df.mitsubishielectric.co.jp писал 2023-06-08 02:08: From: Alexander Pyhalov Sent: Wednesday, June 7, 2023 6:47 PM This seems to be more robust, but the interface became more strange. I'm not sure what to do with it. Some ideas I had to avoid introducing this parameter. Not sure I

Re: Partial aggregates pushdown

- check it. If it's still not found, error out. Also seems to be a bit ugly - you leave uncommitted garbage for vacuum in catalogue. Another issue - the patch misses recording dependency between aggpartialfn and aggregate procedure. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Partial aggregates pushdown

fujii.y...@df.mitsubishielectric.co.jp писал 2023-06-06 06:08: Hi Mr.Pyhalov. Thank you for your always thoughtful review. From: Alexander Pyhalov Sent: Monday, June 5, 2023 6:00 PM Have found one issue - src/backend/catalog/pg_aggregate.c 585 if(strcmp(strVal(linitial

Re: Partial aggregates pushdown

Bruce Momjian писал 2023-06-05 19:26: On Mon, Jun 5, 2023 at 12:00:27PM +0300, Alexander Pyhalov wrote: Note that after these changes "select sum()" will fail for certain cases, when remote server version is not the latest. In other cases we tried to preserve compatibility. Shou

Re: Partial aggregates pushdown

ain cases, when remote server version is not the latest. In other cases we tried to preserve compatibility. Should we have a switch for a foreign server to turn this optimization off? Or do we just state that users should use different workarounds if remote server version doesn't match l

Re: buffer refcount leak in foreign batch insert code

the fix down to 14. The buildfarm is digesting it fine. -- Michael Thank you. Sorry for the late response, was on vacation. -- Best regards, Alexander Pyhalov, Postgres Professional

buffer refcount leak in foreign batch insert code

. But it seems that created slots should still be cleared in the end of ExecBatchInsert(). At least the attached patch seems to fix the issue. -- Best regards, Alexander Pyhalov, Postgres ProfessionalCREATE EXTENSION postgres_fdw; DO $d$ BEGIN EXECUTE $$CREATE SERVER loopback FOREIGN DATA

Re: CREATE INDEX CONCURRENTLY on partitioned index

are dealing with a partitioned relation. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Add semi-join pushdown to postgres_fdw

'&&'. Added comment. It seems to be a rephrasing of lower comment in joinrel_target_ok(). -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom f37d26d9b622767f94e89034fa8e4fccc69e358d Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Mon, 7 Nov 2022 10:23:32 +0300 Subject

Re: Inconsistency in vacuum behavior

acuum it" and return success status. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Inconsistency in vacuum behavior

that is not suitable for vacuum. Any thoughts or objections? No objections for not throwing an error. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Inconsistency in vacuum behavior

-- Best regards, Alexander Pyhalov, Postgres Professional

Inconsistency in vacuum behavior

intended? Why don't we perform vacuum_is_permitted_for_relation() check for inheritors in expand_vacuum_rel()? -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Add semi-join pushdown to postgres_fdw

r sounds better, but if you come with better idea, I'm fine with renaming them. question4) Although really detail, there is expression making space such as "ft4.c2 = ft2.c2" and one making no space such as "c1=ftupper.c1". Is there reason for this difference? If not, need we

Re: Partial aggregates pushdown

as expected. -- Best regards, Alexander Pyhalov, Postgres Professionaldiff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c index 35f2d102374..bd8a4acc112 100644 --- a/contrib/postgres_fdw/deparse.c +++ b/contrib/postgres_fdw/deparse.c @@ -3472,9 +3472,9 @@ deparseAggref(Aggref

Re: Partial aggregates pushdown

regards, Alexander Pyhalov, Postgres Professional

Re: Partial aggregates pushdown

s an issue - is_shippable() is too optimistic. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Partial aggregates pushdown

or better should be moved to src/test/regress/sql/create_aggregate.sql, as they are not specific to postgres_fdw -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Partial aggregates pushdown

m_complex,\nSTYPE=COMPLEX,\npartialaggfunc=scomplex,\npartialagg_minversion=1400\n);", readOnlyTree=false, context=PROCESS_UTILITY_TOPLEVEL, params=0x0, queryEnv=0x0, dest=0x562698671b48, qc=0x7ffd1a4053c0) at utility.c:1074 Later will look at it again. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: CREATE INDEX CONCURRENTLY on partitioned index

, Alexander Pyhalov, Postgres Professional

Re: Add semi-join pushdown to postgres_fdw

ate the patch. Once you think the patchset is ready for review again, you (or any interested party) can move the patch entry forward by visiting https://commitfest.postgresql.org/40/3838/ and changing the status to "Needs review". Hi. I've rebased the patch. -- Best regard

Re: Add semi-join pushdown to postgres_fdw

prdate(oid = 2029, args=Var ) = Const(type date) (date(r3.c5) = '1970-01-17'::date). Function is # select proname, provolatile from pg_proc where oid=2029; proname | provolatile -+- date| i So it's shippable. -- Best regards, Alexander Pyhalov, Postgres Professional

Add semi-join pushdown to postgres_fdw

.c5) = '1970-01-17'::date)) AND ((r1.c3 = r3.c3 Deparsing semi-joins leads to generating (text) conditions like 'EXISTS (SELECT NULL FROM inner_rel WHERE join_conds) . Such conditions are generated in deparseFromExprForRel() and distributed to nearest WHERE, where they are added to th

Re: CREATE INDEX CONCURRENTLY on partitioned index

Justin Pryzby писал 2022-06-28 21:33: Hi, On Thu, Feb 10, 2022 at 06:07:08PM +0300, Alexander Pyhalov wrote: I've rebased patches and tried to fix issues I've seen. I've fixed reference after table_close() in the first patch (can be seen while building with CPPFLAGS='-DRELCACHE_FORCE_RELEASE

Re: CREATE INDEX CONCURRENTLY on partitioned index

Justin Pryzby писал 2022-06-28 21:33: Hi, On Thu, Feb 10, 2022 at 06:07:08PM +0300, Alexander Pyhalov wrote: I've rebased patches and tried to fix issues I've seen. I've fixed reference after table_close() in the first patch (can be seen while building with CPPFLAGS='-DRELCACHE_FORCE_RELEASE

Re: Partial aggregates pushdown

Tomas Vondra писал 2022-03-22 15:28: On 3/22/22 01:49, Andres Freund wrote: On 2022-01-17 15:27:53 +0300, Alexander Pyhalov wrote: Alexander Pyhalov писал 2022-01-17 15:26: Updated patch. Sorry, missed attachment. Needs another update: http://cfbot.cputube.org/patch_37_3369.log Marked

Re: CREATE INDEX CONCURRENTLY on partitioned index

Hi. I've added 0005-Mark-intermediate-partitioned-indexes-as-valid.patch which fixed the following issues - when partitioned index is created, indexes on intermediate partitioned tables were preserved in invalid state. Also added some more tests. -- Best regards, Alexander Pyhalov, Postgres

Re: postgres_fdw and skip locked

Ashutosh Bapat писал 2022-02-17 16:30: On Wed, Feb 16, 2022 at 8:38 PM Alexander Pyhalov wrote: Ashutosh Bapat писал 2022-02-16 16:40: > On Mon, Feb 14, 2022 at 4:23 PM Alexander Pyhalov > wrote: >> > I see that these options will work for all kinds of relations. So no >

Re: postgres_fdw and skip locked

Ashutosh Bapat писал 2022-02-16 16:40: On Mon, Feb 14, 2022 at 4:23 PM Alexander Pyhalov wrote: Hi. Now select ... for update ... [skip locked|nowait] options are not pushed down to remote servers. I see the only reason is that we can speak to pre-9.5 server, which doesn't understand skip

postgres_fdw and skip locked

this behavior? -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom f416cb0afdf42b8ab5375e7a3ccab6e41ebb16ab Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Mon, 14 Feb 2022 12:01:26 +0300 Subject: [PATCH] postgres_fdw could pass lock wait policy to foreign server --- contrib

Re: CREATE INDEX CONCURRENTLY on partitioned index

any to correctly update PROGRESS_CREATEIDX_PARTITIONS_DONE counter. Also it needs IndexOid to correctly generate pg_stat_progress_create_index record, so we pass these parameters to it. -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom eaad7c3ed2fda93fdb91aea60294f60489444bf7 Mon Sep 17 00

CREATE INDEX CONCURRENTLY on partitioned index

Alexander Pyhalov писал 2022-02-09 15:18: Hi. I've looked at patches, introducing CREATE INDEX CONCURRENTLY for partitioned tables - https://www.postgresql.org/message-id/flat/20210226182019.GU20769%40telsasoft.com#da169a0a518bf8121604437d9ab053b3 . The thread didn't have any activity

Justin Pryzby

ast it shouldn't do much harm. -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom adf4242708c2d86092f7c942c7bbb6ef12e6891b Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Mon, 7 Feb 2022 10:28:42 +0300 Subject: [PATCH 1/4] Allow CREATE INDEX CONCURRENTLY on partitioned table 0001-Al

Re: Foreign join search stops on the first try

PM Alexander Pyhalov wrote: It is surprising that the planning time halves with the patch. I expected it to increase slightly since we will compute estimates thrice instead of once. I wouldn't look at estimate times here precisely (and would looked at costs). Real example where we found it had

Foreign join search stops on the first try

lt; r3.d_next_o_id)) AND ((r1.ol_o_id >= (r3.d_next_o_id - 20))) AND ((r3.d_id = 1)) AND ((r1.ol_d_id = 1 INNER JOIN test.stock r2 ON (((r1.ol_i_id = r2.s_i_id)) AND ((r2.s_quantity < 11 Planning Time: 0.928 ms Execution Time: 4.511 ms -- Best re

Re: Push down time-related SQLValue functions to foreign server

Tom Lane писал 2022-01-18 23:01: I wrote: Alexander Pyhalov writes: This means we'll translate something like explain select * from t where d > now() - '1 day'::interval; to select * from t where d > $1; Right. After thinking about that a bit more, I see that this will result in a

Re: Push down time-related SQLValue functions to foreign server

Tom Lane писал 2022-01-18 19:53: Alexander Pyhalov writes: [ updated patch ] Thanks for updating the patch. (BTW, please attach version numbers to new patch versions, to avoid confusion.) However, before we proceed any further with this patch, I think we really ought to stop and think

Re: Push down time-related SQLValue functions to foreign server

Hi. Tom Lane писал 2022-01-18 02:08: Alexander Pyhalov writes: Perhaps in a MACRO? Changed this check to a macro, also fixed condition in is_foreign_param() and added test for it. Also fixed comment in prepare_query_params(). I took a quick look at this. I'm unconvinced that you need

Re: Partial aggregates pushdown

Alexander Pyhalov писал 2022-01-17 15:26: Zhihong Yu писал 2022-01-17 11:43: Hi, + FdwScanPrivateConvertors + * Generate attinmeta if there are some converters: I think it would be better if converter is spelled the same way across the patch. For build_conv_list(): + if (IS_UPPER_REL

Re: Partial aggregates pushdown

for !IS_UPPER_REL(foreignrel) - this would save indentation for the body of the func. Hi. Updated patch. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Asymmetric partition-wise JOIN

INNER JOIN (public.ftprt2_p1 t2) Remote SQL: SELECT r4.a, r2.b FROM (public.fprt1_p1 r4 INNER JOIN public.fprt2_p1 r2 ON (((r4.a = r2.b)) AND ((r2.c ~~ '%0004')) AND ((r4.a < 250 -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 029f0662f5401e79468a315a658b05b2f2a4e7a6 M

Re: Partial aggregates pushdown

Julien Rouhaud писал 2022-01-14 15:16: Hi, On Mon, Nov 15, 2021 at 04:01:51PM +0300, Alexander Pyhalov wrote: I've updated patch - removed catversion dump. This version of the patchset doesn't apply anymore: http://cfbot.cputube.org/patch_36_3369.log === Applying patches on top

Re: postgres_fdw: incomplete subabort cleanup of connections used in async execution

-subabort (pgfdw_subxact_callback()). This causes a crash when re-executing a query that was aborted in a subtransaction: Hi. Looks good to me. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Partial aggregates pushdown

Daniel Gustafsson писал 2021-11-15 13:16: On 3 Nov 2021, at 15:50, Alexander Pyhalov wrote: Daniel Gustafsson писал 2021-11-03 16:45: On 2 Nov 2021, at 10:12, Alexander Pyhalov wrote: Updated and rebased patch. + state = (Int128AggState *) palloc0(sizeof(Int128AggState

Re: Partial aggregates pushdown

Daniel Gustafsson писал 2021-11-03 16:45: On 2 Nov 2021, at 10:12, Alexander Pyhalov wrote: Updated and rebased patch. + state = (Int128AggState *) palloc0(sizeof(Int128AggState)); + state->calcSumX2 = false; + + if (!PG_ARGISNULL(0)) + { +#ifdef HAVE_INT

Re: Partial aggregates pushdown

Hi. Updated and rebased patch. Ilya Gladyshev писал 2021-11-02 00:31: Hi, On 21.10.2021 13:55, Alexander Pyhalov wrote: Hi. Updated patch. Now aggregates with internal states can be pushed down, if they are marked as pushdown safe (this flag is set to true for min/max/sum), have internal

Re: Partial aggregates pushdown

Peter Eisentraut писал 2021-11-01 12:47: On 21.10.21 12:55, Alexander Pyhalov wrote: Now aggregates with internal states can be pushed down, if they are marked as pushdown safe (this flag is set to true for min/max/sum), have internal states and associated converters. Converters are called

Re: Partial aggregates pushdown

-- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom a18e2ff8de00592797e7c3ccb8d6cd536a2e4e72 Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Thu, 14 Oct 2021 17:30:34 +0300 Subject: [PATCH] Partial aggregates push down --- contrib/postgres_fdw/deparse.c| 46 +++-

Re: Partial aggregates pushdown

Tomas Vondra писал 2021-10-19 16:25: On 10/19/21 08:56, Alexander Pyhalov wrote: Hi. Tomas Vondra писал 2021-10-15 17:56: As for the proposed approach, it's probably good enough for the first version to restrict this to aggregates where the aggregate result is sufficient, i.e. we don't need

Re: Partial aggregates pushdown

, Alexander Pyhalov, Postgres ProfessionalFrom 823a389caf003a21dd4c8e758f89d08ba89c5856 Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Thu, 14 Oct 2021 17:30:34 +0300 Subject: [PATCH] Partial aggregates push down --- contrib/postgres_fdw/deparse.c| 45 +++- .../postgres_fdw

Re: Partial aggregates pushdown

is? Should it be server property or should it somehow find out it while connecting to the server? -- Best regards, Alexander Pyhalov, Postgres Professional

Partial aggregates pushdown

://www.postgresql.org/message-id/flat/9998c3af9fdb5f7d62a6c7ad0fcd9142%40postgrespro.ru -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom f2cf87a0ba1f4e4bf3f5f9e5b10b782c51717baf Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Thu, 14 Oct 2021 17:30:34 +0300 Subject: [PATCH

Re: Function scan FDW pushdown

arge foreign table by sending the local table rows down to the foreign server. -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom d997c313daf0031b812d3fca59d338be1a4f2196 Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Mon, 17 May 2021 19:19:31 +0300 Subject: [PATCH] Push join

Re: Defer selection of asynchronous subplans until the executor initialization stage

project and no separate Result is needed in that case, so I modified mark_async_capable_plan() as such, and added test cases to the postgres_fdw regression test. Attached is an updated version of the patch. Hi. The patch looks good to me and seems to work as expected. -- Best regards, Alexander

Re: Push down time-related SQLValue functions to foreign server

lized by makeNode(). -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Push down time-related SQLValue functions to foreign server

this list, then the comment is outdated? Fixed comment in the new version of the patches. -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Push down time-related SQLValue functions to foreign server

d comment in prepare_query_params(). -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 2cfd3e42cad07ed552a1eb23b06040b0f74a7f2f Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Thu, 29 Jul 2021 11:45:28 +0300 Subject: [PATCH 1/2] SQLValue functions pushdown current_timestamp, lo

Re: Push down time-related SQLValue functions to foreign server

we need additional check. -- Best regards, Alexander Pyhalov, Postgres Professional

Push down time-related SQLValue functions to foreign server

pdate test set t=current_timestamp where t -> Foreign Update on public.test (cost=100.00..137.93 rows=414 width=50) Remote SQL: UPDATE data.test SET t = $1::timestamp with time zone WHERE ((t < $1::timestamp with time zone)) -- Best regards, Alexander Pyhalov, Pos

Why timestamptz_pl_interval and timestamptz_mi_interval are not immutable?

' = timestamptz '2021-08-18 10:26:59.366452+00'; ?column? -- t (1 row) What do I miss? -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Case expression pushdown

Tom Lane писал 2021-07-29 23:54: Alexander Pyhalov writes: [ 0001-Allow-pushing-CASE-expression-to-foreign-server-v7.patch ] I looked this over. It's better than before, but the collation handling is still not at all correct. We have to consider that a CASE's arg expression supplies

Re: Case expression pushdown

Tom Lane писал 2021-07-26 18:18: Alexander Pyhalov writes: [ 0001-Allow-pushing-CASE-expression-to-foreign-server-v6.patch ] This doesn't compile cleanly: deparse.c: In function 'foreign_expr_walker.isra.4': deparse.c:920:8: warning: 'collation' may be used uninitialized in this function

Re: Case expression pushdown

fore isn't license to make things worse. regards, tom lane Fixed this. Thanks for review. -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom f323ce6e6e12004ee448bbd6721c396826bd9eeb Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Thu, 22 Jul 2021 11:4

Re: Case expression pushdown

Hi. Gilles Darold писал 2021-07-07 15:02: Le 22/06/2021 à 15:39, Alexander Pyhalov a écrit : Seino Yuki писал 2021-06-22 16:03: On 2021-06-16 01:29, Alexander Pyhalov wrote: Hi. Ashutosh Bapat писал 2021-06-15 16:24: Looks quite useful to me. Can you please add this to the next commitfest

PostgreSQL 14 backend crash on incorrect trigger

$2 = {type = T_Result, startup_cost = 0, total_cost = 0, plan_rows = 0, plan_width = 0, parallel_aware = false, parallel_safe = false, async_capable = false, plan_node_id = 0, targetlist = 0x563f06020d40, qual = 0x0, lefttree = 0x0, righttree = 0x0, initPlan = 0x0, extParam = 0x0, allPara

Re: Asymmetric partition-wise JOIN

copied, because as a part of a subplan its could 285 * be visited many times in the case of asymmetric join. 286 */ 287 foreach(lc, root->append_rel_list) 288 { its -> it (or they) ? -- Best regards, Alexander Pyhalov, Postgres Professional

Re: Partitioned index can be not dumped

Álvaro Herrera писал 2021-06-30 21:54: On 2021-Jun-30, Alexander Pyhalov wrote: I've seen the following effect on PostgreSQL 14 stable branch. Index, created on partitioned table, disappears from pg_dump or psql \d output. This seems to begin after analyze. Partitoned relation relhasindex

Re: Partitioned index can be not dumped

Alexander Pyhalov писал 2021-06-30 17:26: Hi. Sorry, test had an issue. -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 2aabf5e8e86d222e6a73b25ccc652fe645e12fc4 Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Wed, 30 Jun 2021 17:22:37 +0300 Subject: [PATCH] Set

Partitioned index can be not dumped

is not true. -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 0e66025a32c6e848b2b77355631b06b4b8d4dd08 Mon Sep 17 00:00:00 2001 From: Alexander Pyhalov Date: Wed, 30 Jun 2021 17:22:37 +0300 Subject: [PATCH] Set relhasindex for partitioned tables correctly. The issue appeared after

Re: Case expression pushdown

Seino Yuki писал 2021-06-22 16:03: On 2021-06-16 01:29, Alexander Pyhalov wrote: Hi. Ashutosh Bapat писал 2021-06-15 16:24: Looks quite useful to me. Can you please add this to the next commitfest? Addded to commitfest. Here is an updated patch version. Thanks for posting the patch. I

Re: Asymmetric partition-wise JOIN

ilds? -- Best regards, Alexander Pyhalov, Postgres Professional

Re: postgres_fdw batching vs. (re)creating the tuple slots

, ($274, $275, $276), ($277, $278, $279), ($280, $281, $282), ($283, $284, $285), ($286, $287, $288), ($289, $290, $291), ($292, $293, $294), ($295, $296, $297), ($298, $299, $300) -- Best regards, Alexander Pyhalov, Postgres Professionaldiff --git a/contrib/postgres_fdw/sql/postgres_fdw.sql b/

Re: Case expression pushdown

Hi. Ashutosh Bapat писал 2021-06-15 16:24: Looks quite useful to me. Can you please add this to the next commitfest? Addded to commitfest. Here is an updated patch version. -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 80d60eb9b1630ee55d1825964e0e976ae6c289a1 Mon Sep 17 00

Case expression pushdown

mote SQL: UPDATE "S 1"."T 1" SET c2 = (CASE WHEN (c2 > 0) THEN c2 ELSE 0 END) WHERE (("C 1" > 1000)) -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 19202bfa5ba8a7eadf1a3b0ce869106e967e0dd2 Mon Sep 17 00:00:00 2001 From: Alexander Pyhal

Re: join pushdown and issue with foreign update

rds, Alexander Pyhalov, Postgres Professional

Re: join pushdown and issue with foreign update

Tom Lane писал 2021-06-01 21:19: Alexander Pyhalov writes: What about the following patch? ISTM that using a specific rowtype rather than RECORD would be quite disastrous from the standpoint of bloating the number of distinct resjunk columns we need for a partition tree with a lot

Re: join pushdown and issue with foreign update

this issue, but it still preserves chances to get RECORD in fetch_more_data() (at least with combination with asymmetric partition-wise join). What about the following patch? -- Best regards, Alexander Pyhalov, Postgres ProfessionalFrom 806a9b4fbf376e8fa75669229c8401ea76dd1cb2 Mon Sep 17 00:00:00

Re: join pushdown and issue with foreign update

Alexander Pyhalov писал 2021-05-31 15:39: Hi. There's issue with join pushdown after commit 86dc90056dfdbd9d1b891718d2e5614e3e432f35 Author: Tom Lane Date: Wed Mar 31 11:52:34 2021 -0400 ... You'll get ERROR: input of anonymous composite types is not implemented CONTEXT: whole-row

  1   2   >