On Wed Jun 5, 2024 at 3:56 PM CDT, Robert Haas wrote:
On Wed, Jun 5, 2024 at 4:32 PM Tristan Partin wrote:
> Not entirely sure how I feel about the approach you've taken, but here
> is a patch that Heikki and I put together for extension compatibility.
> It's not a build time
value.
--
Tristan Partin
https://tristan.partin.io
From 60b0225d8e82d412237297710a7f007b006a7773 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Thu, 31 Aug 2023 11:08:01 -0500
Subject: [PATCH] Add PG_MODULE_MAGIC_REENTRANT
Extensions should use this if and only if they support reentrancy
On Sun Jun 2, 2024 at 12:25 AM CDT, Tom Lane wrote:
"Tristan Partin" writes:
> On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote:
>> We talked this off-list at the conference. It seems we have to somehow
>> avoid passing pg_regress --schedule argument
-C build regress/regress --test-args "--no-schedule
my_specific_test"
Does anyone have an opinion?
--
Tristan Partin
https://tristan.partin.io
, but that's also a big ask and we'd
probably still not have it.
Not sure how useful it would be as an example, but MariaDB has
a blackhole storage engine[0], which has helped serve as a guide for me
previously.
[0]: https://mariadb.com/kb/en/blackhole/
--
Tristan Partin
https
_dirs
isn't being properly translated to include arguments.
--
Tristan Partin
https://tristan.partin.io
On Tue May 7, 2024 at 1:29 PM CDT, Andres Freund wrote:
Hi,
On 2024-05-06 14:07:53 -0500, Tristan Partin wrote:
> Instead of needing to be explicit, we can just iterate the
> pgstat_kind_infos array to find the memory locations to read into.
> This was originally thought of
On Tue May 7, 2024 at 1:01 AM CDT, Michael Paquier wrote:
On Tue, May 07, 2024 at 12:44:51AM -0500, Tristan Partin wrote:
> Thanks for the feedback Michael. Should I just throw the patch in the next
> commitfest so it doesn't get left behind?
Better to do so, yes. I have noted this
On Mon May 6, 2024 at 9:50 PM CDT, Michael Paquier wrote:
On Mon, May 06, 2024 at 02:07:53PM -0500, Tristan Partin wrote:
> This was originally thought of by Andres in
> 5891c7a8ed8f2d3d577e7eea34dacff12d7b6bbd.
+1 because you are removing a duplication between the order of the
lead to someone deleting the comment, and keeping the code
as is. Either way, a win :).
--
Tristan Partin
Neon (https://neon.tech)
From 5cc5a67edbd3dee145ea582c024b6ee207ae4085 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Mon, 6 May 2024 13:52:58 -0500
Subject: [PATCH v1] Use
I thought that this might be a small quality of life improvement for
people scrolling through logs wondering which tranche name wasn't
registered.
--
Tristan Partin
Neon (https://neon.tech)
From 63c8d92a8a82acc5f8859ab47da5105cef46b88e Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Thu
te for any PRs from AIX folks on the Meson side. You
can find me as @tristan957 on github.
--
Tristan Partin
Neon (https://neon.tech)
On Wed Jan 24, 2024 at 11:57 AM CST, Tristan Partin wrote:
On Wed Jan 24, 2024 at 10:18 AM CST, Tristan Partin wrote:
> On Tue Jan 23, 2024 at 3:30 AM CST, Peter Eisentraut wrote:
> > On 22.01.24 21:04, Tristan Partin wrote:
> > 3. Meson does not support tar.bz2 archives.
today. Looks like your patch is messed
up? You seem to have more of the diff at the bottom which seems to add
a test. Want to send a v2 with a properly formatted patch?
Example command:
git format-patch -v2 -M HEAD^
--
Tristan Partin
Neon (https://neon.tech)
Thanks Jelte and Robert for the extra effort to correct my mistake.
I apologize. Bad copy-paste from a previous revision of the patch at
some point.
--
Tristan Partin
Neon (https://neon.tech)
On Wed Apr 3, 2024 at 10:05 AM CDT, Jelte Fennema-Nio wrote:
On Wed, 3 Apr 2024 at 16:55, Tristan Partin wrote:
> Removing from the switch statement causes a warning:
>
> > [1/2] Compiling C object src/bin/psql/psql.p/command.c.o
> > ../src/bin/psql/command.c: In function ‘wa
c.o
../src/bin/psql/command.c: In function ‘wait_until_connected’:
../src/bin/psql/command.c:3803:17: warning: enumeration value
‘PGRES_POLLING_ACTIVE’ not handled in switch [-Wswitch]
3803 | switch (PQconnectPoll(conn))
| ^~
--
Tristan Partin
Neon (https://neon.tech)
lls.
Patches look good. Sorry about causing you to do some work.
--
Tristan Partin
Neon (https://neon.tech)
On Tue Apr 2, 2024 at 9:32 AM CDT, Robert Haas wrote:
On Mon, Apr 1, 2024 at 12:04 PM Tristan Partin wrote:
> > This sentence seems a bit contorted to me, like maybe Yoda wrote it.
>
> Incorporated feedback, I have :).
Committed it, I did. My thanks for working on this iss
haps it is 0.55, which would still
get rid of the aforementioned warning.
Committer, please pick your patch :).
[0]:
https://www.postgresql.org/message-id/40e80f77-a294-4f29-a16f-e21bc7bc7...@eisentraut.org
--
Tristan Partin
Neon (https://neon.tech)
diff --git a/meson.build b/meson.build
in
On Mon Mar 25, 2024 at 1:44 PM CDT, Robert Haas wrote:
On Fri, Mar 22, 2024 at 4:58 PM Tristan Partin wrote:
> I had a question about parameter naming. Right now I have a mix of
> camel-case and snake-case in the function signature since that is what
> I inherited. Should
eone wants to make a plea here:
https://github.com/mesonbuild/meson/pull/12623
--
Tristan Partin
Neon (https://neon.tech)
: false' is the default if you feel like leaving it
out.
Otherwise, let's get this in!
--
Tristan Partin
Neon (https://neon.tech)
On Fri Mar 22, 2024 at 12:17 PM CDT, Robert Haas wrote:
On Fri, Mar 22, 2024 at 1:05 PM Tristan Partin wrote:
> Sorry for taking a while to get back to y'all. I have taken your
> feedback into consideration for v9. This is my first time writing
> Postgres docs, so I'm ready for anot
0002 looks pretty reasonable to me.
About the 0003 patch: It seems useful in principle to test these things
continuously. The dist script runs about 10 seconds in each task, and
takes a bit of disk space for the artifacts. I'm not sure to what
degree this might bother someone.
0003 works for me :).
--
Tristan Partin
Neon (https://neon.tech)
On Fri Mar 22, 2024 at 9:59 AM CDT, Robert Haas wrote:
On Wed, Jan 31, 2024 at 1:07 PM Tristan Partin wrote:
> I was looking for documentation of PQsocket(), but didn't find any
> standalone (unless I completely missed it). So I just copied how
> PQsocket() is documented in PQconnect
On Thu Mar 14, 2024 at 12:15 AM CDT, Michael Paquier wrote:
On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote:
> One of them adds version gates to two LLVM flags (-frwapv,
> -fno-strict-aliasing). I believe we moved the minimum LLVM version recently,
> so th
into the PGXS Makefile.
--
Tristan Partin
Neon (https://neon.tech)
On Tue Mar 12, 2024 at 6:56 PM CDT, Sutou Kouhei wrote:
Hi,
In
"Re: meson: Specify -Wformat as a common warning flag for extensions" on Fri,
08 Mar 2024 10:05:27 -0600,
"Tristan Partin" wrote:
> Ok, I figured this out. -Wall implies -Wformat=1. We set warning_le
On Fri Mar 8, 2024 at 12:32 AM CST, Michael Paquier wrote:
On Thu, Mar 07, 2024 at 11:39:39PM -0600, Tristan Partin wrote:
> It sounds like a legitimate issue. I have confirmed the issue exists with a
> pg_config compiled with Meson. I can also confirm that this issue exists in
> the
a pg_config compiled with Meson. I can also confirm that this issue
exists in the autotools build.
Here is a v2 of your patch which includes the fix for autotools. I will
mark this "Ready for Committer" in the commitfest. Thanks!
[0]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Option
name here?
XXX: We now have functions called AuxiliaryProcessInit() and
InitAuxiliaryProcess(). Confusing.
Based on my analysis, the *Init() is called in the Main functions, while
Init*() is called before the Main functions. Maybe
AuxiliaryProcessInit() could be renamed to AuxiliaryProcessStartup()?
Rename the other to AuxiliaryProcessInit().
--
Tristan Partin
Neon (https://neon.tech)
On Fri Mar 1, 2024 at 8:00 AM CST, Alvaro Herrera wrote:
On 2024-Feb-23, Heikki Linnakangas wrote:
> On 12/02/2024 19:01, Tristan Partin wrote:
> > On Wed Jan 24, 2024 at 8:09 AM CST, Alvaro Herrera wrote:
> > > IMO it would be less ugly to have the origin fi
.
I think with this change, it is unlikely I will be able to upstream
anything to Meson that would benefit Postgres here since setting this
option seems project dependent.
--
Tristan Partin
Neon (https://neon.tech)
nd include patterns would be great! I think
it would be good if there a Meson run_target()/Make .PHONY target that
people could use to test too. Then, eventually the cfbot could pick this
up.
--
Tristan Partin
Neon (https://neon.tech)
IMO it would be less ugly to have the origin file lwlocknames.txt be
not a text file but a .h with a macro that can be defined by
interested parties so that they can extract what they want from the
file, like PG_CMDTAG or PG_KEYWORD. Using Perl for this seems dirty...
I really like this idea, and would definitely be more inclined to see
a solution like this.
--
Tristan Partin
Neon (https://neon.tech)
On Tue Jan 30, 2024 at 3:58 PM CST, Andres Freund wrote:
Hi,
On 2024-01-30 09:59:25 -0600, Tristan Partin wrote:
> From 331cec1c9db6ff60dcc6d9ba62a9c8be4e5e95ed Mon Sep 17 00:00:00 2001
> From: Tristan Partin
> Date: Mon, 29 Jan 2024 18:03:39 -0600
> Subject: [PATCH v1 1/3] Refuse
On Tue Jan 30, 2024 at 10:00 PM CST, Alexander Lakhin wrote:
Hello,
30.01.2024 18:57, Tristan Partin wrote:
> Patch 1:
>
> Passing NULL as a second argument to memcpy breaks ubsan, ...
Maybe you would like to fix also one more similar place, reached with:
create extension xml
On Tue Jan 30, 2024 at 4:42 PM CST, Jelte Fennema-Nio wrote:
On Tue, 30 Jan 2024 at 23:20, Tristan Partin wrote:
> Not next week, but here is a respin. I've exposed pqSocketPoll as
> PQsocketPoll and am just using that. You can see the diff is so much
> smaller, which is great!
The ex
On Fri Jan 12, 2024 at 11:13 AM CST, Tristan Partin wrote:
On Fri Jan 12, 2024 at 10:45 AM CST, Robert Haas wrote:
> On Mon, Jan 8, 2024 at 1:03 AM Tristan Partin wrote:
> > I think the way to go is to expose some variation of libpq's
> > pqSocketPoll(), which I would be happy
Spend so much time writing out the email, I once again forget
attachments...UGH.
--
Tristan Partin
Neon (https://neon.tech)
From 331cec1c9db6ff60dcc6d9ba62a9c8be4e5e95ed Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Mon, 29 Jan 2024 18:03:39 -0600
Subject: [PATCH v1 1/3] Refuse
support is requested. That way
others don't spend time heading down a dead end.
--
Tristan Partin
Neon (https://neon.tech)
for you. Not sure how hard it will be, but
I can take a crack at it this week.
--
Tristan Partin
Neon (https://neon.tech)
On Fri Jan 26, 2024 at 12:28 AM CST, Peter Eisentraut wrote:
On 25.01.24 17:25, Tristan Partin wrote:
> For what it's worth, I run Meson 1.3, and the behavior of generating the
> tarballs even though it is a dirty tree still occurred. In the new patch
> you seem to say it was fixe
On Thu Jan 25, 2024 at 10:04 AM CST, Peter Eisentraut wrote:
On 22.01.24 21:04, Tristan Partin wrote:
>> + 'HEAD', '.'],
>> + install: false,
>> + output: distdir + '.tar.bz2',
>> +)
>
> The bz2 target should be wrapped in an `if bzip2.found()`.
The
On Wed Jan 24, 2024 at 10:18 AM CST, Tristan Partin wrote:
On Tue Jan 23, 2024 at 3:30 AM CST, Peter Eisentraut wrote:
> On 22.01.24 21:04, Tristan Partin wrote:
> > I am not really following why we can't use the builtin Meson dist
> > command. The only difference from my testin
if the issue described in this thread could be related
to the issue I ran into. Afaict the merged patch has not been released
yet.
Do you have a backtrace? Given that the version is 3.2.0, seems likely.
--
Tristan Partin
Neon (https://neon.tech)
On Tue Jan 23, 2024 at 3:30 AM CST, Peter Eisentraut wrote:
On 22.01.24 21:04, Tristan Partin wrote:
> I am not really following why we can't use the builtin Meson dist
> command. The only difference from my testing is it doesn't use a
> --prefix argument.
Here are some proble
On Tue Jan 23, 2024 at 4:23 PM CST, Andres Freund wrote:
Hi,
On 2024-01-23 15:50:11 -0600, Tristan Partin wrote:
> What is keeping us from using pthread_sigmask(3) instead of sigprocmask(2)?
We would need to make sure to compile with threading support everywhere. One
issue is that on s
On Tue Jan 23, 2024 at 2:10 PM CST, Tristan Partin wrote:
On Tue Jan 23, 2024 at 1:47 PM CST, Andres Freund wrote:
> Hi,
> On 2024-01-23 13:20:15 -0600, Tristan Partin wrote:
> > These checks are not effective for what they are trying to prevent. A recent
> > commit[0] in
On Tue Jan 23, 2024 at 1:47 PM CST, Andres Freund wrote:
Hi,
On 2024-01-23 13:20:15 -0600, Tristan Partin wrote:
> These checks are not effective for what they are trying to prevent. A recent
> commit[0] in libcurl when used on macOS has been tripping the
> pthread_is_threaded_n
mit/8b7cbe9decc205b08ec8258eb184c89a33e3084b
[1]:
https://developer.apple.com/documentation/systemconfiguration/1517088-scdynamicstorecopyproxies
--
Tristan Partin
Neon (https://neon.tech)
<>
From 0a514e7a8ea2af21d98cbcc2e4da799745786155 Mon Sep 17 00:00:00 2001
From: Tristan Partin
ht also do better as external scripts. It would reduce duplication
between the autotools and Meson builds.
+
+
+
###
# The End, The End, My Friend
###
I am not really following why we can't use the builtin Mes
install the perltidy file and whatever else too. I keep my Perl writing
to a minimum, so I am not the best person to vouch for these usecases.
[0]:
https://www.postgresql.org/message-id/aaa59ef5-dce8-7369-5cae-487727664127%40dunslane.net
--
Tristan Partin
Neon (https://neon.tech)
On Tue Jan 16, 2024 at 7:27 PM CST, Bruce Momjian wrote:
On Tue, Jan 16, 2024 at 07:22:23PM -0600, Tristan Partin wrote:
> I think a good solution would be to distribute pgindent and pg_bsd_indent.
> At Neon, we are trying to format our extension code using pgindent. I am
> sure there
that
pgindent out of tree code. It would also have the added benefit of
adding the tools to $PREFIX/bin, which would make the test that I added
not need a hack to get the pg_bsd_indent executable.
--
Tristan Partin
Neon (https://neon.tech)
From 6e9ca366b6e4976ae591012150fe77729e37c503 Mon Sep
message-id/20220127182838.ba3434dp2pe5vcia%40alap3.anarazel.de
--
Tristan Partin
Neon (https://neon.tech)
From 5ffbc7c35bb3248501b2517d26f99afe02fb53d6 Mon Sep 17 00:00:00 2001
From: Matthias van de Meent
Date: Tue, 27 Jun 2023 15:59:23 +0200
Subject: [PATCH v1 1/5] Expose f_smgr to extensions for manual impl
On Fri Jan 12, 2024 at 10:45 AM CST, Robert Haas wrote:
On Mon, Jan 8, 2024 at 1:03 AM Tristan Partin wrote:
> I think the way to go is to expose some variation of libpq's
> pqSocketPoll(), which I would be happy to put together a patch for.
> Making frontends, psql in this c
n just say "run this command line incantation of
pgindent," which in the grand scheme of things is easy compared to all
the other things you have to be aware of to contribute to Postgres.
--
Tristan Partin
Neon (https://neon.tech)
On Tue Jan 9, 2024 at 2:49 PM CST, Robert Haas wrote:
On Tue, Jan 9, 2024 at 2:20 PM Tristan Partin wrote:
> > I don't indent during most of development, and don't intend to start.
>
> Could you expand on why you don't? I could understand as you're writing,
> but I would t
no point in anything that I discussed.
[0]:
https://marketplace.visualstudio.com/items?itemName=tristan957.postgres-hacker
[1]: https://lists.sr.ht/~rjarry/aerc-devel/patches/48415
--
Tristan Partin
Neon (https://neon.tech)
On Mon Jan 8, 2024 at 6:08 PM CST, Tom Lane wrote:
"Tristan Partin" writes:
> On Mon Jan 8, 2024 at 2:48 PM CST, Tom Lane wrote:
>> +(isascii((unsigned char)
mybuf
ascii(3) explicitly mentions "unsigned char."
Small English nit-pick: I would drop the hyphen between semi and colons.
As for backpatching, seems useful in the sense that people can write the
same script for all supported version of Postgres using the relaxed
syntax.
--
Tristan Partin
Neon (https://neon.tech)
On Sun Dec 31, 2023 at 9:29 PM CST, John Naylor wrote:
On Thu, Dec 28, 2023 at 1:20 AM Tristan Partin wrote:
> I recently wound up in a situation where I was checking for NULL return
> values of a function that couldn't ever return NULL because the
> inability to allocate memory was al
On Fri Jan 5, 2024 at 12:24 PM CST, Robert Haas wrote:
On Tue, Dec 5, 2023 at 1:35 PM Tristan Partin wrote:
> On Wed Nov 29, 2023 at 11:48 AM CST, Tristan Partin wrote:
> > I am not completely in love with the code I have written. Lots of
> > conditional compilation which makes
t recall any
reports of trouble here -- but it sure looks fragile.
Hence, proposed patch attached.
Looks good to me.
--
Tristan Partin
Neon (https://neon.tech)
On Wed Dec 27, 2023 at 6:42 AM CST, Peter Eisentraut wrote:
On 19.12.23 21:43, Tristan Partin wrote:
> Here is a patch which adds support for the returns_nonnull attribute
> alongside all the other attributes we optionally support.
>
> I recently wound up in a situation where I
pg_strdup instead which handles it.
Looks good to me.
--
Tristan Partin
Neon (https://neon.tech)
was always elog(ERROR)ed (aborted).
I didn't go through and mark anything, but I feel like it could be
useful for people going forward, including myself.
--
Tristan Partin
Neon (https://neon.tech)
From 15a36d68519b332e7ae970708399744cbc69c6c3 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date
On Tue Dec 19, 2023 at 10:36 AM CST, Jelte Fennema-Nio wrote:
On Mon, 18 Dec 2023 at 22:18, Tristan Partin wrote:
> Here is an additional patch which implements the behavior you described.
> The first patch is just Daniel's squashed version of my patches.
I think we'd still want the earl
ppropriate.
Here are patches for these two issues. More testing would be appreciated.
Meson looks good to me!
--
Tristan Partin
Neon (https://neon.tech)
On Mon Dec 18, 2023 at 12:43 AM CST, John Naylor wrote:
On Tue, Dec 5, 2023 at 3:27 AM Tristan Partin wrote:
>
> On Mon Dec 4, 2023 at 2:10 PM CST, Tom Lane wrote:
> > Not sure what you were using, but are you aware that SQL access to the
> > buildfarm database is available
On Mon Dec 18, 2023 at 3:18 PM CST, Tristan Partin wrote:
On Mon Dec 18, 2023 at 10:50 AM CST, Tristan Partin wrote:
> On Mon Dec 18, 2023 at 10:14 AM CST, Jelte Fennema-Nio wrote:
> > On Mon, 18 Dec 2023 at 13:42, Daniel Gustafsson wrote:
> > > I think this is prett
On Mon Dec 18, 2023 at 11:21 AM CST, Jelte Fennema-Nio wrote:
On Mon, 18 Dec 2023 at 17:50, Tristan Partin wrote:
> I could propose something. It would help if I had an example of such
> a tool that already exists.
Basically the same behaviour as what you're trying to add now for
--check
On Mon Dec 18, 2023 at 10:50 AM CST, Tristan Partin wrote:
On Mon Dec 18, 2023 at 10:14 AM CST, Jelte Fennema-Nio wrote:
> On Mon, 18 Dec 2023 at 13:42, Daniel Gustafsson wrote:
> > I think this is pretty much ready to go, the attached v4 squashes the
changes
> > and fixes the
dy exists.
--
Tristan Partin
Neon (https://neon.tech)
On Mon Dec 18, 2023 at 7:56 AM CST, Euler Taveira wrote:
On Mon, Dec 18, 2023, at 9:41 AM, Daniel Gustafsson wrote:
> > On 15 Dec 2023, at 16:43, Tristan Partin wrote:
>
> > Here is a v3.
>
> I think this is pretty much ready to go, the attached v4 squashes the changes
On Mon Dec 18, 2023 at 6:41 AM CST, Daniel Gustafsson wrote:
> On 15 Dec 2023, at 16:43, Tristan Partin wrote:
> Here is a v3.
I think this is pretty much ready to go, the attached v4 squashes the changes
and fixes the man-page which also needed an update. The referenced Wiki page
wil
age,
and reduce the possibility for version-skew errors.
Seems like you would be forcing an extension author to keep a Postgres
source tree around if you went this route. Perhaps supporting either the
build tree or an install tree would get you the best of both worlds.
--
Tristan Partin
Neon (ht
voids this by specifying
# --libdir=lib to meson setup.)
Should we just default the Meson build to libdir=lib in
project(default_options:)? This assumes that you don't think what Tom
said about running it on the build tree is better.
--
Tristan Partin
Neon (https://neon.tech)
;
+ }
+ elsif ($check)
{
exit 2;
}
Weird how I was able to screw that up so bad :). Thanks! Here is a v3.
--
Tristan Partin
Neon (https://neon.tech)
From ed5a44a1552c407719ac8c94603b51a7e72084f0 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Mon, 11 Dec 2023 17:34:17
ff to --diff
- Allows one to use --check and --diff in the same command
I am not tied to the second patch if people like --show-diff better than
--diff.
Weirdly enough, my email client doesn't show this as part of the
original thread, but I will respond here anyway.
--
Tristan Partin
Neon (https://ne
On Thu Dec 14, 2023 at 9:16 AM CST, Andrew Dunstan wrote:
On 2023-12-13 We 15:59, Tristan Partin wrote:
> On Wed Dec 13, 2023 at 2:35 PM CST, Andrew Dunstan wrote:
>>
>> On 2023-12-12 Tu 18:02, Tom Lane wrote:
>> > "Tristan Partin" writes:
>> >>
On Wed Dec 13, 2023 at 2:35 PM CST, Andrew Dunstan wrote:
On 2023-12-12 Tu 18:02, Tom Lane wrote:
> "Tristan Partin" writes:
>> The big patch here is adding support for Mac. objdump -W doesn't work on
>> Mac. So, I used dsymutil and dwarfdump to achieve the same res
On Wed Dec 13, 2023 at 11:27 AM CST, Tom Lane wrote:
"Tristan Partin" writes:
> That makes sense to me. Where can I find the buildfarm code to propose
> a different patch, at least pulling in the current state of the
> buildfarm script? Or perhaps Andrew is the best perso
On Tue Dec 12, 2023 at 5:02 PM CST, Tom Lane wrote:
"Tristan Partin" writes:
> The big patch here is adding support for Mac. objdump -W doesn't work on
> Mac. So, I used dsymutil and dwarfdump to achieve the same result.
We should probably nuke the current version of src/to
also wrote this
without having a Mac. I had to ping a coworker with a Mac for help.
My goal with the Mac support is to enable use of find_typedef for
extension developers, where using a Mac might be more prominent than
upstream Postgres development, but that is just a guess.
--
Tristan Partin
N
taking the "Linux and sometimes windows"
code path instead of the $using_osx one. I think simplest fix is to
move the $using_osx branch ahead of the heuristic ones, as attached.
Hey Tom,
Was this patch ever committed?
--
Tristan Partin
Neon (https://neon.tech)
On Tue Dec 12, 2023 at 5:47 AM CST, Euler Taveira wrote:
On Tue, Dec 12, 2023, at 7:28 AM, Michael Banck wrote:
> On Tue, Dec 12, 2023 at 11:18:59AM +0100, Daniel Gustafsson wrote:
> > > On 12 Dec 2023, at 01:09, Tristan Partin wrote:
> > >
> > > Not
and exit 2 if the output isn't empty by yourself.
--
Tristan Partin
Neon (https://neon.tech)
From 1001252d49a47e660045cee3d2ba5abd87e925d9 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Mon, 11 Dec 2023 17:34:17 -0600
Subject: [PATCH v1] Add --check option to pgindent
The option is a combination
ot all builds. According to the OpenSSF[0], level
2 is only supposed to impact runtime performance by 0.1%.
[0]:
https://best.openssf.org/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.html#performance-implications
--
Tristan Partin
Neon (https://neon.tech)
The file is only referenced in Meson and MSVC scripts from what I can
tell, and the Meson reference is protected by a Windows check.
--
Tristan Partin
Neon (https://neon.tech)
From bc9ffc7b0b141959a4c2a3f8b731f457ff5825c1 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Tue, 5 Dec 2023 10
On Wed Nov 29, 2023 at 11:48 AM CST, Tristan Partin wrote:
I am not completely in love with the code I have written. Lots of
conditional compilation which makes it hard to read. Looking forward to
another round of review to see what y'all think.
Ok. Here is a patch which just uses select(2
On Mon Dec 4, 2023 at 2:10 PM CST, Tom Lane wrote:
"Tristan Partin" writes:
> On Fri Dec 1, 2023 at 12:16 PM CST, Tristan Partin wrote:
>>> Ok, so what I found is that we still have build farm animals using
>>> Python 3.4, specifically the AIX machines. There wa
On Fri Dec 1, 2023 at 12:16 PM CST, Tristan Partin wrote:
On Fri Dec 1, 2023 at 12:07 PM CST, Tom Lane wrote:
> "Tristan Partin" writes:
> > On the buildfarm page[0], it would be nice if more than just the
> > compiler versions were stated. It would be nice to ha
On Mon Dec 4, 2023 at 9:22 AM CST, Peter Eisentraut wrote:
On 01.12.23 23:10, Tristan Partin wrote:
> On Wed Jul 12, 2023 at 9:35 AM CDT, Tristan Partin wrote:
>> On Wed Jul 12, 2023 at 9:31 AM CDT, Peter Eisentraut wrote:
>> > On 12.07.23 16:23, Tristan Partin wrote:
>&g
a pair of ShmemSize
and ShmemInit functions, like all other shared memory structs.
+if (!IsUnderPostmaster)
+{
+Assert(!found);
+memset(ShmemVariableCache, 0, sizeof(VariableCacheData));
+}
+else
+Assert(found);
S
On Wed Jul 12, 2023 at 9:35 AM CDT, Tristan Partin wrote:
On Wed Jul 12, 2023 at 9:31 AM CDT, Peter Eisentraut wrote:
> On 12.07.23 16:23, Tristan Partin wrote:
> > It has come to my attention that STDOUT_FILENO might not be portable and
> > fileno(3) isn't marked as signal-safe,
On Fri Aug 4, 2023 at 5:47 AM CDT, Dmitry Dolgov wrote:
> On Thu, Aug 03, 2023 at 12:23:52PM -0500, Tristan Partin wrote:
>
> This is the first I am learning about clang plugins. Interesting concept.
> Did you give any thought to using libclang instead of a compiler plugin? I
> a
elf an
indentation.
- if len(targets_info_byname[name]) > 1:
+ if len(targets_info_byname[name]) <= 1:
+ continue
But whatever you want.
--
Tristan Partin
Neon (https://neon.tech)
1 - 100 of 265 matches
Mail list logo
