Re: meson documentation build open issues

On 21.11.23 14:23, Peter Eisentraut wrote: On 21.11.23 02:56, Andres Freund wrote: One remaining question is whether we should adjust install-doc-{html,man} to be install-{html,man}, to match the docs targets. Ah didn't notice that one; yes please. I think this was done?

Re: meson documentation build open issues

On 21.11.23 02:56, Andres Freund wrote: One remaining question is whether we should adjust install-doc-{html,man} to be install-{html,man}, to match the docs targets. Ah didn't notice that one; yes please.

Re: meson documentation build open issues

Hi, On 2023-11-20 08:27:48 +0100, Peter Eisentraut wrote: > On 17.11.23 19:53, Andres Freund wrote: > > I pushed the first two commits (the selinux stuff) and worked a bit more on > > the subsequent ones. > > Patches 0001 through 0004 look good to me. Cool, I pushed them now. > Some possible

Re: meson documentation build open issues

On 17.11.23 19:53, Andres Freund wrote: I pushed the first two commits (the selinux stuff) and worked a bit more on the subsequent ones. Patches 0001 through 0004 look good to me. Some possible small tweaks in 0004: +perl, '-ne', 'next if /^#/; print', If you're going for super-brief

Re: meson documentation build open issues

Hi, On 2023-11-14 16:30:24 -0800, Andres Freund wrote: > On 2023-11-14 16:22:31 -0800, Andres Freund wrote: > > > v2-0004-meson-Add-world-target.patch > > > > > > AFAICT, this world target doesn't include the man target. (Again, this > > > would all work better if we added "man" to "docs".) > >

Re: meson documentation build open issues

Hi, On 2023-11-14 16:22:31 -0800, Andres Freund wrote: > > v2-0004-meson-Add-world-target.patch > > > > AFAICT, this world target doesn't include the man target. (Again, this > > would all work better if we added "man" to "docs".) > > I agree with that sentiment - I only moved to the current

Re: meson documentation build open issues

Hi, On 2023-11-14 11:58:53 +0100, Peter Eisentraut wrote: > On 09.11.23 18:52, Andres Freund wrote: > > I think if we want to do this, we'd need a configure time check for being > > able > > to validate a document with > > > V4.5//EN""http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd;... >

Re: meson documentation build open issues

Hi, On 2023-11-14 21:16:13 +0100, Peter Eisentraut wrote: > Some comments on your patches: > > v2-0001-meson-Change-default-of-selinux-feature-option-to.patch > > Ok > > v2-0002-docs-Document-with-selinux-Dselinux-options-centr.patch > > Ok, but "selinux" should be "SELinux" when referring to

Re: meson documentation build open issues

Some comments on your patches: v2-0001-meson-Change-default-of-selinux-feature-option-to.patch Ok v2-0002-docs-Document-with-selinux-Dselinux-options-centr.patch Ok, but "selinux" should be "SELinux" when referring to the product. v2-0003-meson-docs-Add-doc-html-man-targets.patch We have

Re: meson documentation build open issues

On 09.11.23 18:52, Andres Freund wrote: Besides giving you a quick validity check of the XML, this also builds the doc_generated, which draw from non-doc source files, so this would also serve to check that those are sound and didn't mess up the docs. Unfortunately presence of xmllint doesn't

Re: meson documentation build open issues

Hi, On 2023-11-09 15:32:39 +0100, Peter Eisentraut wrote: > On 09.11.23 01:59, Andres Freund wrote: > > > I think we could build doc/src/sgml/postgres-full.xml by default. That > > > takes less than 0.5 seconds here and it's an intermediate target for html > > > and man. > > That does require

Re: meson documentation build open issues

On 09.11.23 00:21, Andres Freund wrote: Example output: This is very nice! $ ninja help [0/1 1 0%] Running external command help (wrapped by meson to set env) Code Targets: all Build everything other than documentation backend Build

Re: meson documentation build open issues

On 09.11.23 01:59, Andres Freund wrote: I think we could build doc/src/sgml/postgres-full.xml by default. That takes less than 0.5 seconds here and it's an intermediate target for html and man. That does require the docbook dtd to be installed, afaict. I think we would need a configure test

Re: meson documentation build open issues

Hi, On 2023-11-08 16:19:51 +0100, Peter Eisentraut wrote: > On 08.11.23 13:55, Christoph Berg wrote: > > Re: Peter Eisentraut > > > > If the problem is broken doc patches, then maybe a solution is to > > > > include the `xmllint --noout --valid` target in whatever the check-world > > > >

Re: meson documentation build open issues

Hi, On 2023-11-08 13:55:02 +0100, Christoph Berg wrote: > Re: Peter Eisentraut > > > If the problem is broken doc patches, then maybe a solution is to > > > include the `xmllint --noout --valid` target in whatever the check-world > > > equivalent is for meson. Looking at

Re: meson documentation build open issues

Hi, I really like the idea of an 'help' target that prints the targets. It seemed annoying to document such targets in both the sgml docs and the input for a the help target. Particularly due to the redundancies between id attributes, the target name etc. First I generated the list of targets

Re: meson documentation build open issues

Hi, On 2023-11-08 12:04:30 +0100, Peter Eisentraut wrote: > Ok, I didn't know about ninja install-world. That works for me. Maybe a > "world" target would also be good. Yea, I thought so as well. I'll send out a patch shortly. Kinda wondering if its worth backpatching to 16. Uniformity seems

Re: meson documentation build open issues

Looks good to me. Thanks for finding this. -- Tristan Partin Neon (https://neon.tech)

Re: meson documentation build open issues

On 2023-Nov-08, Peter Eisentraut wrote: > I think we could build doc/src/sgml/postgres-full.xml by default. That > takes less than 0.5 seconds here and it's an intermediate target for html > and man. If that detects problems like the id attributes you mentioned, apart from the other checks in

Re: meson documentation build open issues

On 08.11.23 13:55, Christoph Berg wrote: Re: Peter Eisentraut If the problem is broken doc patches, then maybe a solution is to include the `xmllint --noout --valid` target in whatever the check-world equivalent is for meson. Looking at doc/src/sgml/meson.build, we don't seem to do that

Re: meson documentation build open issues

Re: Peter Eisentraut > > If the problem is broken doc patches, then maybe a solution is to > > include the `xmllint --noout --valid` target in whatever the check-world > > equivalent is for meson. Looking at doc/src/sgml/meson.build, we don't > > seem to do that anywhere. Doing the no-output

Re: meson documentation build open issues

On 07.11.23 17:40, Alvaro Herrera wrote: If the problem is broken doc patches, then maybe a solution is to include the `xmllint --noout --valid` target in whatever the check-world equivalent is for meson. Looking at doc/src/sgml/meson.build, we don't seem to do that anywhere. Doing the

Re: meson documentation build open issues

On 07.11.23 17:08, Andres Freund wrote: make world make check-world make install-world that encompasses everything. Now with meson to handle the documentation one needs to remember a variety of additional targets. (There is a risk that once this gets more widespread, more people will submit

Re: meson documentation build open issues

Re: Andres Freund > > We might get around that by introducing a new postgresql-manpages-XX > > arch:all package, but that might be too much micropackaging. > > I've not done packaging in, uh, a fair while, but isn't the common solution to > that a -common package? There might be a few more files

Re: meson documentation build open issues

Hi, On 2023-11-06 10:45:27 +0100, Christoph Berg wrote: > Re: Andres Freund > > > > The reason for that is simply that the docs take too long to build. > > > > > > That why I'd prefer to be able to separate arch:all and arch:any > > > builds, yes. > > > > What's stopping you from doing that? I

Re: meson documentation build open issues

Alvaro Herrera writes: > If the problem is broken doc patches, then maybe a solution is to > include the `xmllint --noout --valid` target in whatever the check-world > equivalent is for meson. +1, but let's do that for the "make" build too. I see that doc/src/sgml/Makefile has a "check" target,

Re: meson documentation build open issues

On 2023-Nov-07, Andres Freund wrote: > >I would like to have some set of options that enables it so that the > >standard documentation targets become part of "meson compile" and > >"meson install". > > -0.5 - it's just too painfully slow. For all scripted uses you can just as > well use

Re: meson documentation build open issues

Andres Freund writes: > On November 7, 2023 7:55:37 AM PST, Peter Eisentraut > wrote: >> I would like to have some set of options that enables it so that the >> standard documentation targets become part of "meson compile" and "meson >> install". > -0.5 - it's just too painfully slow. For

Re: meson documentation build open issues

Hi, On November 7, 2023 7:55:37 AM PST, Peter Eisentraut wrote: >On 03.11.23 19:19, Christoph Berg wrote: > You can control this with the "docs" option for meson, as of recently. I've been looking into switching the Debian PG 17 build to meson, but I'm running into several

Re: meson documentation build open issues

On 03.11.23 19:19, Christoph Berg wrote: You can control this with the "docs" option for meson, as of recently. I've been looking into switching the Debian PG 17 build to meson, but I'm running into several problems. * The docs are still not built by default, and -Ddocs=enabled doesn't

Re: meson documentation build open issues

On 03.11.23 22:16, Andres Freund wrote: [selinux option] Why isn't it "auto" like the others? I don't really remember why I did that, but it's platform specific, maybe that's why I did it that way? Isn't that kind the point of autodetecting things? Aren't bonjour and bsd_auth autodetected as

Re: meson documentation build open issues

Re: Andres Freund > > > The reason for that is simply that the docs take too long to build. > > > > That why I'd prefer to be able to separate arch:all and arch:any > > builds, yes. > > What's stopping you from doing that? I think the only arch:any content we > have is the docs, and those you

Re: meson documentation build open issues

Hi, On 2023-11-03 20:19:18 +0100, Christoph Berg wrote: > Re: Andres Freund > > The reason for that is simply that the docs take too long to build. > > That why I'd prefer to be able to separate arch:all and arch:any > builds, yes. What's stopping you from doing that? I think the only arch:any

Re: meson documentation build open issues

Re: Andres Freund > The reason for that is simply that the docs take too long to build. That why I'd prefer to be able to separate arch:all and arch:any builds, yes. > The summary does include both. LLVM is 'llvm', man/html docs is 'docs' and pdf > docs as 'docs_pdf'. Sorry, I should have

Re: meson documentation build open issues

Hi, On 2023-11-03 19:19:17 +0100, Christoph Berg wrote: > Re: Andres Freund > > > > You can control this with the "docs" option for meson, as of recently. > > > > > > I've been looking into switching the Debian PG 17 build to meson, but > > > I'm running into several problems. > > > > > > * The

Re: meson documentation build open issues

Re: Andres Freund > > > You can control this with the "docs" option for meson, as of recently. > > > > I've been looking into switching the Debian PG 17 build to meson, but > > I'm running into several problems. > > > > * The docs are still not built by default, and -Ddocs=enabled doesn't > >

Re: meson documentation build open issues

Hi, On 2023-11-03 15:26:05 +0100, Christoph Berg wrote: > Re: Peter Eisentraut > > > "meson compile" doesn't seem to build the docs by default ( see > > > ), > > > and I'd rather it didn't,

Re: meson documentation build open issues

Re: Peter Eisentraut > > "meson compile" doesn't seem to build the docs by default ( see > > ), > > and I'd rather it didn't, building the docs is a separate and optional > > step for the

Re: meson documentation build open issues

On 07.04.23 16:39, Andrew Dunstan wrote: 5. There doesn't appear to be an equivalent of "make world" and "make install-world" that includes documentation builds. This has been addressed with the additional meson auto options.  But it seems that these options only control building, not

Re: meson documentation build open issues

On 2023-04-06 Th 05:11, Peter Eisentraut wrote: On 05.04.23 16:45, Andres Freund wrote: I think it's still an issue that "make docs" builds html and man but "ninja docs" only builds html.  For some reason the wiki page actually claims that ninja docs builds both, but this does not happen for

Re: meson documentation build open issues

On 05.04.23 16:45, Andres Freund wrote: I think it's still an issue that "make docs" builds html and man but "ninja docs" only builds html. For some reason the wiki page actually claims that ninja docs builds both, but this does not happen for me. It used to, but Tom insisted that it should

Re: meson documentation build open issues

Hi, On 2023-04-05 12:24:04 +0200, Peter Eisentraut wrote: > On 15.03.23 08:14, Peter Eisentraut wrote: > > 3. The various build targets and their combinations are mismatching and > > incomplete. > > This has been improved, and I see there is documentation. > > I think it's still an issue that

Re: meson documentation build open issues

On 15.03.23 08:14, Peter Eisentraut wrote: I have identified several open issues with the documentation build under Meson (approximately in priority order): Some work has been done on this. Here is my current assessment. 1. Image files are not handled at all, so they don't show up in the

Re: Remove 'htmlhelp' documentat format (was meson documentation build open issues)

On Tue, 28 Mar 2023 at 10:46, Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 24.03.23 17:58, Andres Freund wrote: > > On 2023-03-24 11:59:23 +0100, Peter Eisentraut wrote: > >> Another option here is to remove support for htmlhelp. > > > > That might actually be the best path -

Re: Remove 'htmlhelp' documentat format (was meson documentation build open issues)

On 24.03.23 17:58, Andres Freund wrote: On 2023-03-24 11:59:23 +0100, Peter Eisentraut wrote: Another option here is to remove support for htmlhelp. That might actually be the best path - it certainly doesn't look like anybody has been actively using it. Or otherwise somebody would have

Re: Remove 'htmlhelp' documentat format (was meson documentation build open issues)

> On 24 Mar 2023, at 17:58, Andres Freund wrote: > On 2023-03-24 11:59:23 +0100, Peter Eisentraut wrote: >> Another option here is to remove support for htmlhelp. > > That might actually be the best path - it certainly doesn't look like anybody > has been actively using it. I had no idea we had

Remove 'htmlhelp' documentat format (was meson documentation build open issues)

Hi, On 2023-03-24 11:59:23 +0100, Peter Eisentraut wrote: > Another option here is to remove support for htmlhelp. That might actually be the best path - it certainly doesn't look like anybody has been actively using it. Or otherwise somebody would have complained about there not being any

Re: meson documentation build open issues

On 24.03.23 08:26, Andres Freund wrote: For the .css: docbook-xsl actually has support for writing the .css: [1] - but it requires the .css file be valid xml. I wonder if the cleanest approch would be to have a build step to create .css.xml - then the non-chunked build's generate.css.header

Re: meson documentation build open issues

Hi, On 2023-03-22 11:59:17 -0700, Andres Freund wrote: > Unless somebody sees a reason to wait, I am planning to commit: > meson: add install-{quiet, world} targets > meson: add install-{docs,doc-html,doc-man} targets > meson: make install_test_files more generic, rename to install_files

Re: meson documentation build open issues

Hi, On 2023-03-20 10:32:49 -0700, Andres Freund wrote: > On 2023-03-20 11:58:08 +0100, Peter Eisentraut wrote: > > Oh, this patch set grew quite quickly. ;-) > > Yep :) Unless somebody sees a reason to wait, I am planning to commit: meson: add install-{quiet, world} targets meson: add

Re: meson documentation build open issues

Hi, On 2023-03-19 19:33:38 -0700, Andres Freund wrote: > I think we can make the docs build in parallel and incrementally, by building > the different parts of the docs in parallel, using --stringparam rootid, > e.g. building each 'part' separately. > > A very very rough draft attached: > >

Re: meson documentation build open issues

Hi, On 2023-03-20 11:58:08 +0100, Peter Eisentraut wrote: > Oh, this patch set grew quite quickly. ;-) Yep :) > [PATCH v2 5/8] docs: html: copy images to output as part of xslt build > > Making the XSLT stylesheets do the copying has some appeal. I think it > would only work for SVG (or

Re: meson documentation build open issues

On 20.03.23 03:33, Andres Freund wrote: I did end up getting stuck when hacking on this, and ended up adding css support for nochunk and support for the website style for htmlhelp and nochunk, as well as obsoleting the need for copying the css files... But perhaps that's a bit too much. Updated

Re: meson documentation build open issues

Hi, On 2023-03-15 20:55:33 -0700, Andres Freund wrote: > WIP patch for that attached. There's now > install-doc-man > install-doc-html > run targets and a > install-docs > alias target. > > > I did end up getting stuck when hacking on this, and ended up adding css > support for nochunk

Re: meson documentation build open issues

Hi, On 2023-03-15 08:14:09 +0100, Peter Eisentraut wrote: > I have identified several open issues with the documentation build under > Meson (approximately in priority order): > > 1. Image files are not handled at all, so they don't show up in the final > product. Hm. Somehow I thought I'd

meson documentation build open issues

I have identified several open issues with the documentation build under Meson (approximately in priority order): 1. Image files are not handled at all, so they don't show up in the final product. 2. Defaults to website stylesheet, no way to configure. This should be adjusted to match the