Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-14 Thread Hiroaki Yutani
I just found the policy is updated and I now understand why GitHub matters in your opinion. Thanks for the clarification, I forgot this fact. > CRAN does not regard github.com (which hosts the index of crates.io) as sufficiently reliable. The good news is that, as of Rust 1.68, Cargo supports

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-13 Thread Hiroaki Yutani
Simin, Sorry that my question was not clear. Let me clarify. I think we all agree that "cargo vendor" is the primary option. Since downloading without explicit permission is not allowed on CRAN in general, it's reasonable. I'm happy that the instructions will describe it clearly. But, some R

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-13 Thread Dirk Eddelbuettel
The concerns over github going away (!!) (or altering references, tags, releases, ...) may be somewhat alleviated by Software Heritage [1] covering and 'preserving' it. FWIW I briefly spoke about that iniative and a possible CRAN connection at useR! in Toulouse four years ago [2]. I think I

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-13 Thread Simon Urbanek
> On Jul 14, 2023, at 11:19 AM, Hadley Wickham wrote: > >>> If CRAN cannot trust even the official one of Rust, why does CRAN have Rust >>> at all? >>> >> >> I don't see the connection - if you downloaded something in the past it >> doesn't mean you will be able to do so in the future.

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-13 Thread Duncan Murdoch
On 13/07/2023 7:19 p.m., Hadley Wickham wrote: If CRAN cannot trust even the official one of Rust, why does CRAN have Rust at all? I don't see the connection - if you downloaded something in the past it doesn't mean you will be able to do so in the future. And CRAN has Rust because it

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-13 Thread Hadley Wickham
> > If CRAN cannot trust even the official one of Rust, why does CRAN have Rust > > at all? > > > > I don't see the connection - if you downloaded something in the past it > doesn't mean you will be able to do so in the future. And CRAN has Rust > because it sounded like a good idea to allow

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-13 Thread Simon Urbanek
Yutani, [moving back to the original thread, please don't cross-post] > On Jul 13, 2023, at 3:34 PM, Hiroaki Yutani wrote: > > Hi Simon, > > Thanks for the response. I thought > >> download a specific version from a secure site and check that the > download is the expected code by some sort

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-13 Thread Hiroaki Yutani
Thank you for the correction. I see. Best, Yutani 2023年7月13日(木) 16:08 Tomas Kalibera : > > On 7/13/23 05:08, Hiroaki Yutani wrote: > > I actually use cargo vendor. > > > > > https://github.com/yutannihilation/string2path/blob/main/src/rust/vendor.sh > > > > One thing to note is that, prior to R

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-13 Thread Tomas Kalibera
On 7/13/23 05:08, Hiroaki Yutani wrote: I actually use cargo vendor. https://github.com/yutannihilation/string2path/blob/main/src/rust/vendor.sh One thing to note is that, prior to R 4.3.0, the vendored directories hit the Windows' path limit so I had to put them into a TAR file. I haven't

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-12 Thread Hiroaki Yutani
Hi Simon, Thanks for the response. I thought > download a specific version from a secure site and check that the download is the expected code by some sort of checksum refers to the usual process that's done by Cargo automatically. If it's not, I think the policy should have a clear

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-12 Thread Hiroaki Yutani
I actually use cargo vendor. https://github.com/yutannihilation/string2path/blob/main/src/rust/vendor.sh One thing to note is that, prior to R 4.3.0, the vendored directories hit the Windows' path limit so I had to put them into a TAR file. I haven't tested on R 4.3.0, but probably this problem

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-12 Thread Simon Urbanek
> On 13/07/2023, at 2:50 PM, Kevin Ushey wrote: > > Package authors could use 'cargo vendor' to include Rust crate sources > directly in their source R packages. Would that be acceptable? > Yes, that is exactly what was suggested in the original thread. Cheers, Simon > Presumedly, the

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-12 Thread Kevin Ushey
Package authors could use 'cargo vendor' to include Rust crate sources directly in their source R packages. Would that be acceptable? Presumedly, the vendored sources would be built using the versions specified in an accompanying Cargo.lock as well.

Re: [R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-12 Thread Simon Urbanek
Yutani, I'm not quite sure your reading fully matches the intent of the policy. Cargo.lock is not sufficient, it is expected that the package will provide *all* the sources, it is not expected to use cargo to resolve them from random (possibly inaccessible) places. So the package author is

[R-pkg-devel] Feedback on "Using Rust in CRAN packages"

2023-07-12 Thread Hiroaki Yutani
Hi, I'm glad to see CRAN now has its official policy about Rust [1]! It seems it probably needs some feedback from those who are familiar with the Rust workflow. I'm not an expert, but let me leave some quick feedback. This email is sent to the R-package-devel mailing list as well as to cran@~ so