[GitHub] spark issue #13461: [SPARK-15721][ML] Make DefaultParamsReadable, DefaultPar...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13461 **[Test build #3067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3067/consoleFull)** for PR 13461 at commit

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread NarineK
Github user NarineK commented on the issue: https://github.com/apache/spark/pull/12836 Locally, run-tests.sh run successfully, but it fails on jenkins ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12836 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12836 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60020/ Test FAILed. ---

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12836 **[Test build #60020 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60020/consoleFull)** for PR 12836 at commit

[GitHub] spark issue #13446: [SPARK-15704] [SQL] add a test case in DatasetAggregator...

2016-06-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13446 Sorry I was interrupted by something and forgot about it... thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #9113: [SPARK-11100][SQL]HiveThriftServer HA issue,HiveTh...

2016-06-05 Thread xiaowangyu
Github user xiaowangyu closed the pull request at: https://github.com/apache/spark/pull/9113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #9113: [SPARK-11100][SQL]HiveThriftServer HA issue,HiveThriftSer...

2016-06-05 Thread xiaowangyu
Github user xiaowangyu commented on the issue: https://github.com/apache/spark/pull/9113 Thanks! I close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #13516: [MLLIB][DOC] Edit logistic regression docs to pro...

2016-06-05 Thread goodsoldiersvejk
Github user goodsoldiersvejk closed the pull request at: https://github.com/apache/spark/pull/13516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #13519: [SPARK-15771] [ML] [Examples] Use 'accuracy' rather than...

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/13519 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13515 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13515 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60016/ Test PASSed. ---

[GitHub] spark issue #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13515 **[Test build #60016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60016/consoleFull)** for PR 13515 at commit

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

2016-06-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r65835938 --- Diff: python/pyspark/sql/readwriter.py --- @@ -180,6 +180,9 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,

[GitHub] spark issue #13461: [SPARK-15721][ML] Make DefaultParamsReadable, DefaultPar...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13461 **[Test build #3067 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3067/consoleFull)** for PR 13461 at commit

[GitHub] spark issue #13285: [Spark-15129][R][DOC]R API changes in ML

2016-06-05 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/13285 @GayathriMurali I think what is there for ```include_example``` is OK. Please see my other inline comments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #13285: [Spark-15129][R][DOC]R API changes in ML

2016-06-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65835075 --- Diff: docs/sparkr.md --- @@ -285,71 +285,28 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized

[GitHub] spark pull request #13285: [Spark-15129][R][DOC]R API changes in ML

2016-06-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65835028 --- Diff: docs/sparkr.md --- @@ -285,71 +285,28 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized

[GitHub] spark pull request #13517: [SPARK-14839][SQL] Support for other types as opt...

2016-06-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13517#discussion_r65834648 --- Diff: python/pyspark/sql/readwriter.py --- @@ -180,6 +180,9 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,

[GitHub] spark issue #9113: [SPARK-11100][SQL]HiveThriftServer HA issue,HiveThriftSer...

2016-06-05 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/9113 @viper-kun no - as I said, "I don't think anybody has thought a lot about it yet." --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #13446: [SPARK-15704] [SQL] add a test case in DatasetAggregator...

2016-06-05 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13446 @cloud-fan next time please leave a message on the pr saying it was merged and the branches it was merged in. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12836 **[Test build #60020 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60020/consoleFull)** for PR 12836 at commit

[GitHub] spark pull request #13446: [SPARK-15704] [SQL] add a test case in DatasetAgg...

2016-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread NarineK
Github user NarineK commented on the issue: https://github.com/apache/spark/pull/12836 @shivaram, I didn't change the code, but merged with master, because prior to this the build was failing because some pyspark tests didn't pass. After my today's merge, when I run gapply

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13373 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13373 **[Test build #60018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60018/consoleFull)** for PR 13373 at commit

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13373 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60018/ Test FAILed. ---

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13505 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60015/ Test FAILed. ---

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13505 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13505 **[Test build #60015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60015/consoleFull)** for PR 13505 at commit

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13505 **[Test build #60019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60019/consoleFull)** for PR 13505 at commit

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13505 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13373 **[Test build #60018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60018/consoleFull)** for PR 13373 at commit

[GitHub] spark issue #13147: [SPARK-6320][SQL] Move planLater method into GenericStra...

2016-06-05 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/13147 @marmbrus Do you have any other thoughts on this? If so, let me know them and why don't we merge the minimal version same as for `branch-2.0` into `master` for now? I think the API difference

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13373 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13373 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60017/ Test FAILed. ---

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13373 **[Test build #60017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60017/consoleFull)** for PR 13373 at commit

[GitHub] spark issue #13373: [SPARK-15616] [SQL] Metastore relation should fallback t...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13373 **[Test build #60017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60017/consoleFull)** for PR 13373 at commit

[GitHub] spark issue #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13515 **[Test build #60016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60016/consoleFull)** for PR 13515 at commit

[GitHub] spark pull request #13515: [MINOR] Fix Typos 'an -> a'

2016-06-05 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13515#discussion_r6583 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala --- @@ -37,7 +37,7 @@ import

[GitHub] spark issue #9113: [SPARK-11100][SQL]HiveThriftServer HA issue,HiveThriftSer...

2016-06-05 Thread viper-kun
Github user viper-kun commented on the issue: https://github.com/apache/spark/pull/9113 @rxin Is there any design about replacement? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #9162: [SPARK-10655][SQL] Adding additional data type map...

2016-06-05 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/9162#discussion_r65828274 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2IntegrationSuite.scala --- @@ -47,19 +49,20 @@ class

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/12836 The error was ``` 1. Error: gapply() on a DataFrame -- java.lang.OutOfMemoryJava heap space ``` @NarineK Do you think there was

[GitHub] spark pull request #13491: [SPARK-15748][SQL] Replace inefficient foldLeft()...

2016-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13491: [SPARK-15748][SQL] Replace inefficient foldLeft() call w...

2016-06-05 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13491 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12836 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12836 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60013/ Test FAILed. ---

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12836 **[Test build #60013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60013/consoleFull)** for PR 12836 at commit

[GitHub] spark issue #13481: [SPARK-15738][PYSPARK][ML] Adding Pyspark ml RFormula __...

2016-06-05 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/13481 That looks pretty good to me too, thanks @MLnick! I'll put that in soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #13401: [SPARK-15657][SQL] RowEncoder should validate the...

2016-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13401: [SPARK-15657][SQL] RowEncoder should validate the data t...

2016-06-05 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/13401 LGTM, merging to master and branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13505 **[Test build #60015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60015/consoleFull)** for PR 13505 at commit

[GitHub] spark issue #13488: [MINOR][R][DOC] Fix R documentation generation instructi...

2016-06-05 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/spark/pull/13488 Thanks On Sun, Jun 5, 2016, 13:05 asfgit wrote: > Closed #13488 via 8a91105 >

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13505 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13505 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60011/ Test FAILed. ---

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13505 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13505 **[Test build #60011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60011/consoleFull)** for PR 13505 at commit

[GitHub] spark issue #13520: [SPARK-15773][CORE][EXAMPLE] Avoid creating local variab...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13520 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60014/ Test PASSed. ---

[GitHub] spark issue #13520: [SPARK-15773][CORE][EXAMPLE] Avoid creating local variab...

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13520 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13512: [SPARK-15769][SQL] Add Encoder for input type to Aggrega...

2016-06-05 Thread koertkuipers
Github user koertkuipers commented on the issue: https://github.com/apache/spark/pull/13512 @cloud-fan i am running into some trouble updating my branch to the latest master. i get errors in tests due to Analyzer.validateTopLevelTupleFields the issue seems to be that in

[GitHub] spark issue #13520: [SPARK-15773][CORE][EXAMPLE] Avoid creating local variab...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13520 **[Test build #60014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60014/consoleFull)** for PR 13520 at commit

[GitHub] spark issue #13512: [SPARK-15769][SQL] Add Encoder for input type to Aggrega...

2016-06-05 Thread koertkuipers
Github user koertkuipers commented on the issue: https://github.com/apache/spark/pull/13512 @cloud-fan from the (added) unit tests: ``` val df2 = Seq("a" -> 1, "a" -> 3, "b" -> 3).toDF("i", "j") checkAnswer(df2.groupBy("i").agg(ComplexResultAgg.toColumn), Row("a",

[GitHub] spark issue #13520: [SPARK-15773][CORE][EXAMPLE] Avoid creating local variab...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13520 **[Test build #60014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60014/consoleFull)** for PR 13520 at commit

[GitHub] spark pull request #13520: [SPARK-15773][CORE][EXAMPLE] Avoid creating local...

2016-06-05 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/13520 [SPARK-15773][CORE][EXAMPLE] Avoid creating local variable `sc` in examples if possible ## What changes were proposed in this pull request? Instead of using local variable `sc` like

[GitHub] spark pull request #13513: [SPARK-15698][SQL][Streaming] Add the ability to ...

2016-06-05 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/13513#discussion_r65825524 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -529,7 +529,28 @@ object SQLConf { .internal()

[GitHub] spark pull request #13513: [SPARK-15698][SQL][Streaming] Add the ability to ...

2016-06-05 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/13513#discussion_r65825474 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala --- @@ -129,3 +131,86 @@ class FileStreamSource(

[GitHub] spark pull request #13513: [SPARK-15698][SQL][Streaming] Add the ability to ...

2016-06-05 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/13513#discussion_r65825480 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala --- @@ -129,3 +131,86 @@ class FileStreamSource(

[GitHub] spark pull request #13513: [SPARK-15698][SQL][Streaming] Add the ability to ...

2016-06-05 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/13513#discussion_r65825440 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala --- @@ -129,3 +131,86 @@ class FileStreamSource(

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/12836 Yeah I think we can still make this to 2.0 -- Are there any other comments @sun-rui ? Also pinging @davies / @rxin again for a SQL reviewer to take a look at this --- If your project is set

[GitHub] spark issue #9113: [SPARK-11100][SQL]HiveThriftServer HA issue,HiveThriftSer...

2016-06-05 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/9113 We have currently inlined the Hive thrift server into the code base, but the long-term replacement is to be determined. I don't think anybody has thought a lot about it yet. Do you mind

[GitHub] spark issue #12836: [SPARK-12922][SparkR][WIP] Implement gapply() on DataFra...

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12836 **[Test build #60013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60013/consoleFull)** for PR 12836 at commit

[GitHub] spark pull request #13444: [SPARK-15530][SQL] Set #parallelism for file list...

2016-06-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13444#discussion_r65823862 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala --- @@ -409,13 +409,24 @@ private[sql] object

[GitHub] spark pull request #13444: [SPARK-15530][SQL] Set #parallelism for file list...

2016-06-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13444#discussion_r65823818 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -75,7 +75,7 @@ class ListingFileCatalog(

[GitHub] spark issue #13295: [SPARK-15294][SPARKR][MINOR] Add pivot functionality to ...

2016-06-05 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13295 @mhnatiuk It looks like the tests are failing with the error message I've pasted below. From reading the code I think this is related to the `if` check we have in the pivot implementation where it

[GitHub] spark pull request #13488: [MINOR][R][DOC] Fix R documentation generation in...

2016-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13488: [MINOR][R][DOC] Fix R documentation generation instructi...

2016-06-05 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13488 Merging this to master and branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13508: [SPARK-15766][SparkR]:R should export is.nan

2016-06-05 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/13508 don't we need to for `isnan` https://github.com/apache/spark/blob/d642b273544bb77ef7f584326aa2d214649ac61b/R/pkg/R/functions.R#L651 this is different from `isNaN` --- If your project is

[GitHub] spark pull request #13476: [SPARK-15684][SparkR]Not mask startsWith and ends...

2016-06-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13476#discussion_r65823398 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1137,6 +1137,13 @@ test_that("string operators", { expect_equal(count(where(df,

[GitHub] spark pull request #13476: [SPARK-15684][SparkR]Not mask startsWith and ends...

2016-06-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13476#discussion_r65823343 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1137,6 +1137,13 @@ test_that("string operators", { expect_equal(count(where(df,

[GitHub] spark pull request #13476: [SPARK-15684][SparkR]Not mask startsWith and ends...

2016-06-05 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13476#discussion_r65822915 --- Diff: R/pkg/R/generics.R --- @@ -691,11 +691,11 @@ setGeneric("contains", function(x, ...) { standardGeneric("contains") }) #' @rdname

[GitHub] spark pull request #13476: [SPARK-15684][SparkR]Not mask startsWith and ends...

2016-06-05 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13476#discussion_r65822919 --- Diff: R/pkg/R/generics.R --- @@ -723,11 +723,11 @@ setGeneric("like", function(x, ...) { standardGeneric("like") }) #' @rdname column

[GitHub] spark pull request #12313: [SPARK-14543] [SQL] Improve InsertIntoTable colum...

2016-06-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r65822892 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -505,6 +506,117 @@ class Analyzer( } }

[GitHub] spark pull request #12313: [SPARK-14543] [SQL] Improve InsertIntoTable colum...

2016-06-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r65822835 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -505,6 +506,117 @@ class Analyzer( } }

[GitHub] spark pull request #12313: [SPARK-14543] [SQL] Improve InsertIntoTable colum...

2016-06-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r65822816 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -505,6 +506,117 @@ class Analyzer( } }

[GitHub] spark issue #7898: [SPARK-9560][MLlib] add lda data generator

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/7898 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60012/ Test FAILed. ---

[GitHub] spark issue #7898: [SPARK-9560][MLlib] add lda data generator

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/7898 **[Test build #60012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60012/consoleFull)** for PR 7898 at commit

[GitHub] spark issue #7898: [SPARK-9560][MLlib] add lda data generator

2016-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/7898 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #7898: [SPARK-9560][MLlib] add lda data generator

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/7898 **[Test build #60012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60012/consoleFull)** for PR 7898 at commit

[GitHub] spark issue #13512: [SPARK-15769][SQL] Add Encoder for input type to Aggrega...

2016-06-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13512 Can you give some examples to show how this PR make the aggregator API more friendly and easier to use? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #13514: [SPARK-15770][ML] Annotation audit for Experiment...

2016-06-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13514: [SPARK-15770][ML] Annotation audit for Experimental and ...

2016-06-05 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13514 Merging in master/2.0. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #13285: [Spark-15129][R][DOC]R API changes in ML

2016-06-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65822439 --- Diff: docs/sparkr.md --- @@ -285,71 +285,28 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized

[GitHub] spark pull request #13285: [Spark-15129][R][DOC]R API changes in ML

2016-06-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65822414 --- Diff: docs/sparkr.md --- @@ -285,71 +285,28 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13505 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #13285: [Spark-15129][R][DOC]R API changes in ML

2016-06-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65822355 --- Diff: docs/sparkr.md --- @@ -285,71 +285,28 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized

[GitHub] spark issue #1110: [SPARK-2174][MLLIB] treeReduce and treeAggregate

2016-06-05 Thread debasish83
Github user debasish83 commented on the issue: https://github.com/apache/spark/pull/1110 @mengxr say I have 20 nodes and 16 cores on each node, do you recommend running treeReduce with 320 partitions and OpenBLAS with numThreads=1 on each partition for SeqOp OR treeReduce with 20

[GitHub] spark pull request #13285: [Spark-15129][R][DOC]R API changes in ML

2016-06-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65822337 --- Diff: docs/sparkr.md --- @@ -285,71 +285,28 @@ head(teenagers) # Machine Learning -SparkR allows the fitting of generalized

[GitHub] spark pull request #13285: [Spark-15129][R][DOC]R API changes in ML

2016-06-05 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13285#discussion_r65822186 --- Diff: examples/src/main/r/ml.R --- @@ -25,8 +25,9 @@ library(SparkR) sc <- sparkR.init(appName="SparkR-ML-example") sqlContext <-

[GitHub] spark issue #13505: [SPARK-15764][SQL] Replace N^2 loop in BindReferences

2016-06-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13505 **[Test build #60011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60011/consoleFull)** for PR 13505 at commit

[GitHub] spark pull request #13505: [SPARK-15764][SQL] Replace N^2 loop in BindRefere...

2016-06-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/13505#discussion_r65821620 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala --- @@ -86,11 +88,42 @@ package object expressions {

  1   2   >