Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r175580545
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java ---
@@ -80,7 +76,7 @@ public void zeroOut() {
public void
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175574690
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175572114
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20859#discussion_r175580404
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -160,6 +160,19 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20859#discussion_r175580451
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -140,6 +140,21 @@ class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175578001
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175572987
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175577866
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175576754
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175577710
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175573673
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175574792
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175573540
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175579550
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
@@ -199,6 +206,91 @@ class ClientSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175579431
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
@@ -35,17 +36,23 @@ import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175573804
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175575697
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175572817
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175571696
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -86,6 +86,13 @@ private[spark] class Client(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175574173
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175572491
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r175573175
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeHelper.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20859#discussion_r175579879
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -160,6 +160,19 @@ object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20208#discussion_r175579537
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaEvolutionTest.scala
---
@@ -0,0 +1,406 @@
+/*
+ *
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Of course! Those command are an illustration of use case of schema
evolution in Hive-side in general.
This PR aims to provide *schema evolution* test coverage in Spark-side. As
you
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175578919
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175578334
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175577945
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20796#discussion_r175577812
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -57,12 +57,39 @@
public Object getBaseObject() { return
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175576249
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -245,6 +245,19 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175575718
--- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala
---
@@ -137,16 +137,29 @@ private[deploy] object DependencyUtils {
def
Github user misutoth commented on the issue:
https://github.com/apache/spark/pull/20853
> Maybe just let the exception propagate? That's what a lot of this code
does... then you don't need to change this file at all.
@vanzin I want to present an error on the CLI. This is what
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20208
Basically, these commands are not issued from Spark. We only have the
support for ALTER TABLE ADD COLUMN. This PR is just testing the capability of
our automatic schema inference, right?
---
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20796#discussion_r175573949
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -57,12 +57,39 @@
public Object getBaseObject() { return
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/20579
@gatorsmile Thank you Sean. I will follow your suggestion.
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20579
Check whether the format is file-based data sources? Then, we do not need
to check the same thing for different file sources.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20844#discussion_r175568778
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -396,9 +396,11 @@ case class RangeExec(range:
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175567819
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -245,6 +245,19 @@ object SparkSubmit extends CommandLineUtils with
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20837#discussion_r175564965
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -517,6 +517,9 @@ class LogisticRegression @Since("1.2.0")
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20837#discussion_r175563532
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -517,6 +517,9 @@ class LogisticRegression @Since("1.2.0")
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20797
ping @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20753
ping @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20657
@jerryshao I know you said you wanted to take a deeper look, but its been a
while. otherwise I'll merge in the next day or two
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20327#discussion_r17284
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -126,7 +126,11 @@ private[spark] abstract class WebUI(
def bind(): Unit = {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175554046
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -245,6 +245,19 @@ object SparkSubmit extends CommandLineUtils with
Logging {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175552660
--- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala
---
@@ -137,16 +137,29 @@ private[deploy] object DependencyUtils {
def
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175553679
--- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala
---
@@ -137,16 +137,29 @@ private[deploy] object DependencyUtils {
def
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175553185
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -105,11 +105,17 @@ class SparkSubmitSuite
//
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175552387
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -606,9 +612,12 @@ class SparkSubmitSuite
}
Github user gerashegalov commented on a diff in the pull request:
https://github.com/apache/spark/pull/20327#discussion_r175551377
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -126,7 +126,11 @@ private[spark] abstract class WebUI(
def bind(): Unit = {
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17272
cc @dongjoon-hyun Are you interested in this PR? Just take it over?
---
-
To unsubscribe, e-mail:
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20816#discussion_r175550955
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -669,11 +672,42 @@ object
Github user yogeshg commented on a diff in the pull request:
https://github.com/apache/spark/pull/6452#discussion_r175548228
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
@@ -46,19 +47,59 @@ class VectorAssembler(override val uid: String)
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20859
**[Test build #88383 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88383/testReport)**
for PR 20859 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r175548118
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java ---
@@ -80,7 +76,7 @@ public void zeroOut() {
public void set(int
GitHub user jose-torres opened a pull request:
https://github.com/apache/spark/pull/20859
[SPARK-23702][SS] Forbid watermarks on both sides of stateful streaming
operators.
## What changes were proposed in this pull request?
Forbid watermarks on both sides of stateful
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20859
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20859
@tdas
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jose-torres closed the pull request at:
https://github.com/apache/spark/pull/20840
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175546041
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -105,11 +105,17 @@ class SparkSubmitSuite
// Necessary to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20327#discussion_r175545093
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -126,7 +126,11 @@ private[spark] abstract class WebUI(
def bind(): Unit = {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20847
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1616/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20847
**[Test build #88382 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88382/testReport)**
for PR 20847 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20847
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20327#discussion_r175544922
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -126,7 +126,11 @@ private[spark] abstract class WebUI(
def bind(): Unit = {
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175544492
--- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala
---
@@ -137,16 +137,29 @@ private[deploy] object DependencyUtils {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20827#discussion_r175544242
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -324,31 +324,28 @@ case class
Github user gerashegalov commented on a diff in the pull request:
https://github.com/apache/spark/pull/20327#discussion_r175544171
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -126,7 +126,11 @@ private[spark] abstract class WebUI(
def bind(): Unit = {
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175543984
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -245,6 +245,19 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20796#discussion_r175543480
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
---
@@ -791,4 +795,21 @@ public void trimRightWithTrimString()
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20701
**[Test build #88381 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88381/testReport)**
for PR 20701 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20701
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20847
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20701
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1615/
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175543124
--- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala
---
@@ -137,16 +137,29 @@ private[deploy] object DependencyUtils {
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20847
The ML bug is fixed. I'll retrigger this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20852
Thank you, @jkbradley and @attilapiros .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20796#discussion_r175542911
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -57,12 +57,39 @@
public Object getBaseObject() { return
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20796#discussion_r175542711
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -57,12 +57,39 @@
public Object getBaseObject() { return
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20669
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175541913
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -245,6 +245,19 @@ object SparkSubmit extends CommandLineUtils with
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20701
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175541331
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -245,6 +245,19 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175540847
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -606,9 +612,12 @@ class SparkSubmitSuite
}
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175540696
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -105,11 +105,17 @@ class SparkSubmitSuite
//
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/20669
Thanks - merging shortly.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175540130
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -606,9 +612,12 @@ class SparkSubmitSuite
}
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175539256
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -105,11 +105,17 @@ class SparkSubmitSuite
// Necessary to
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/20669
There's a section explaining it at the bottom of
https://spark.apache.org/committers.html
---
-
To unsubscribe, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20669
@mccheah you should have gotten an e-mail from Matei explaining the basics
of how to merge PRs.
---
-
To unsubscribe, e-mail:
Github user erikerlandson commented on the issue:
https://github.com/apache/spark/pull/20669
@mccheah workflow is to use `dev/merge_spark_pr.py`
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/20669
Merge button doesn't appear for me in the UI =( will need to look into that.
---
-
To unsubscribe, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20657
Ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20669
@mccheah you're a committer...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20830
Sure thing! I probably won't be able to until later tonight, but I'll give
it a shot as soon as I can, hopefully it will work :-D
On Mar 18, 2018 10:24 PM, "Hyukjin Kwon"
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20818
**[Test build #4141 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4141/testReport)**
for PR 20818 at commit
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175533621
--- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala
---
@@ -137,16 +137,29 @@ private[deploy] object DependencyUtils {
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175521372
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -606,9 +612,12 @@ class SparkSubmitSuite
}
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175515840
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -105,11 +105,17 @@ class SparkSubmitSuite
//
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175529369
--- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala
---
@@ -137,16 +137,29 @@ private[deploy] object DependencyUtils {
201 - 300 of 479 matches
Mail list logo
