Github user peter-toth commented on a diff in the pull request:
https://github.com/apache/spark/pull/22318#discussion_r215255291
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -754,11 +754,16 @@ class Analyzer(
* a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22112
**[Test build #95713 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95713/testReport)**
for PR 22112 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22112
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22338
@cloud-fan I think I tried doing something like what you suggested but it
didn't help. Moreover, the current code in `MemoryBlock` already leverages
`Platform.get*` for most of its methods, so
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22318#discussion_r215252360
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -754,11 +754,16 @@ class Analyzer(
* a logical
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22340
How does the non-test mode resolve the class path issue?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22338
Thanks for working on it! Will it be helpful if we move these hash methods
to `MemoryBlock`? e.g. the code can be `int halfWord =bytes[offset + i];`
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17174
I looked into the code and I thought out another solution for this issue;
it tries to detect specific binary comparisons in `Optimizer`, and then
replaces them with specialized ones;
POC:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215248202
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -82,7 +83,7 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215247634
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -754,6 +754,54 @@ class HiveDDLSuite
}
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18906
**[Test build #95712 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95712/testReport)**
for PR 18906 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22338
cc @cloud-fan @kiszk
I checked the bytecode generated and the size of the generated code seems
not to be the issue either. FYI I am attaching here the disassembled code
before and
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215246692
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class DataFrameReaderWriterSuite
Github user wmellouli commented on the issue:
https://github.com/apache/spark/pull/22332
@HyukjinKwon Thank you for your review. To answer to your question about
using `select`, take a look at my explaination
[here](https://github.com/apache/spark/pull/22332#issuecomment-418526562)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22320
**[Test build #95711 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95711/testReport)**
for PR 22320 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22320
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22340
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22340
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95705/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22340
**[Test build #95705 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95705/testReport)**
for PR 22340 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22319
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22319
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95700/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22319
**[Test build #95700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95700/testReport)**
for PR 22319 at commit
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/21404#discussion_r215232389
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -99,6 +99,7 @@ private[hive] object
Github user tooptoop4 commented on the issue:
https://github.com/apache/spark/pull/21404
Also, can hive 3.1 be supported easily or are there some breaking changes?
---
-
To unsubscribe, e-mail:
Github user tooptoop4 commented on the issue:
https://github.com/apache/spark/pull/21404
@dongjoon-hyun @wangyum @gatorsmile @HyukjinKwon Anything left on this? can
it be merged to master?
---
-
To unsubscribe,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22338#discussion_r215226248
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java ---
@@ -69,22 +70,27 @@ public static int hashUnsafeWords(Object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22336
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22336
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22112
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95701/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22112
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22112
**[Test build #95701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95701/testReport)**
for PR 22112 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95702/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22320
**[Test build #95702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95702/testReport)**
for PR 22320 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22341
**[Test build #95709 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95709/testReport)**
for PR 22341 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22341
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22341
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22341
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22339
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95706/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22339
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22341
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22339
**[Test build #95706 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95706/testReport)**
for PR 22339 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22341
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95708/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22341
**[Test build #95708 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95708/testReport)**
for PR 22341 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95707/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215216011
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95707 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95707/testReport)**
for PR 22328 at commit
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215215098
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -754,6 +754,54 @@ class HiveDDLSuite
}
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215213849
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215214259
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -82,7 +83,7 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22341
**[Test build #95708 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95708/testReport)**
for PR 22341 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22341
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22341
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22341
[SPARK-24889][Core] Update block info when unpersist rdds
## What changes were proposed in this pull request?
We will update block info coming from executors, at the timing like caching
a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22336
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95699/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22336
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22336
**[Test build #95699 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95699/testReport)**
for PR 22336 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22328
**[Test build #95707 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95707/testReport)**
for PR 22328 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22328
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22338#discussion_r215202638
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java ---
@@ -69,22 +70,27 @@ public static int hashUnsafeWords(Object
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215200249
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageOptions.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22340
cc @srowen and @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22338#discussion_r215192739
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java ---
@@ -69,22 +70,27 @@ public static int hashUnsafeWords(Object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22339
**[Test build #95706 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95706/testReport)**
for PR 22339 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22340
**[Test build #95705 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95705/testReport)**
for PR 22340 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22339
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22339
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22340
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22340
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22340
[SPARK-25337][SQL] `runSparkSubmit` should provide non-testing mode
## What changes were proposed in this pull request?
Scala-2.12 test fails due to class path issue.
-
GitHub user ScrapCodes opened a pull request:
https://github.com/apache/spark/pull/22339
SPARK-17159 Significant speed up for running spark streaming against Object
store.
## What changes were proposed in this pull request?
Original work by Steve Loughran.
Github user peter-toth commented on a diff in the pull request:
https://github.com/apache/spark/pull/22318#discussion_r215189187
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -754,11 +754,16 @@ class Analyzer(
* a
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu @maropu sure, thanks, I'll submit a PR for this soon. Thanks.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22338
**[Test build #95704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95704/testReport)**
for PR 22338 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22323#discussion_r215187426
--- Diff: docs/running-on-kubernetes.md ---
@@ -215,6 +215,19 @@
spark.kubernetes.driver.volumes.persistentVolumeClaim.checkpointpvc.options.clai
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22338
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/22338
[SPARK-25317][CORE] Avoid perf regression in Murmur3 Hash on UTF8String
## What changes were proposed in this pull request?
SPARK-10399 introduced a performance regression on the hash
Github user wmellouli commented on the issue:
https://github.com/apache/spark/pull/22332
@jaceklaskowski I refactored with what you suggested in your review. Let me
know what you think.
---
-
To unsubscribe,
Github user wmellouli commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215185048
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user wmellouli commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215184928
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -831,13 +831,21 @@ class DataFrameSuite extends QueryTest with
Github user wmellouli commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215179856
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22337
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95703/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22337
**[Test build #95703 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95703/testReport)**
for PR 22337 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22337
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215179601
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
ok @mgaido91 can u take this over?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user ajithme commented on the issue:
https://github.com/apache/spark/pull/22277
@jiangxb1987 Thanks you for the feedback. Couple of points
1. If introduce a predicate which refers to alias( as u mentioned a > z),
it will throw error
```
spark-sql> create table
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22337
**[Test build #95703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95703/testReport)**
for PR 22337 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22337
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22337
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22337
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22336
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22320
**[Test build #95702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95702/testReport)**
for PR 22320 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
401 - 500 of 553 matches
Mail list logo
