Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22814
**[Test build #98028 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98028/testReport)**
for PR 22814 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22814
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98014/
Test FAILed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22029#discussion_r228245697
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -202,7 +209,11 @@ case class InSubquery(values:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22814
**[Test build #98014 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98014/testReport)**
for PR 22814 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22029
**[Test build #98027 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98027/testReport)**
for PR 22029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22029
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22029
thanks @cloud-fan and @juliuszsompolski. I changed to an approach similar
to the one used in #21403. I think we can also move to have the default value
for the config switched to the new behavior,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22814
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22723
BinaryFileRDD uses the `minPartitions` input from the user. See
https://issues.apache.org/jira/browse/SPARK-22357 I think the logic is more
complex and already takes some account of
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22812
**[Test build #98026 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98026/testReport)**
for PR 22812 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22812
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228239274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22815
Because it was in L457 - multiple function doc blob merged together and
CRAN checks for the final version for missing param
Thx for catching
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228238508
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22821
Please ping me on the R removal.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228238276
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228236882
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22826
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22826
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98024/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22826
**[Test build #98024 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98024/testReport)**
for PR 22826 at commit
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228235105
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22815
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22815#discussion_r228233269
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -54,6 +54,7 @@ import org.apache.spark.sql.util.ExecutionListenerManager
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22815
**[Test build #98025 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98025/testReport)**
for PR 22815 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22815#discussion_r228232993
--- Diff: R/pkg/R/SQLContext.R ---
@@ -434,6 +388,7 @@ read.orc <- function(path, ...) {
#' Loads a Parquet file, returning the result as a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98019/
Test FAILed.
---
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228232332
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22812
**[Test build #98019 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98019/testReport)**
for PR 22812 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22821
I will submit a PR to revert all these changes. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22826
**[Test build #98024 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98024/testReport)**
for PR 22826 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22826
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22826
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22821#discussion_r228230625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -414,7 +414,6 @@ object FunctionRegistry
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228230112
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22821#discussion_r228230052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -414,7 +414,6 @@ object FunctionRegistry
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/22826
[SPARK-25760][DOCS][FOLLOWUP] Add note about AddJar return value change in
migration guide
## What changes were proposed in this pull request?
Add note about AddJar return value change in
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228229829
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22821#discussion_r228227982
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -414,7 +414,6 @@ object FunctionRegistry
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228227624
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22821
@cloud-fan . I'll update my PR to you once more.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/21063#discussion_r228223151
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
---
@@ -111,7 +112,12 @@ trait ProgressReporter
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/22822
@UtkarshMe well there is signal in the lack of responsiveness. Adding and
maintaining cluster managers has proven to be quite painful, case and point is
the lack of love that Mesos is receiving.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22821
Thank you, @rxin . In that case, +1 for complete removal.
It's easier for us to add the expressions back instead of updating exising
expressions.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22690
Actually sorry for the ignorant question @HyukjinKwon but is there a
migration guide for things outside SQL and MLlib? those are the two I've found.
This one isn't specific to those two. I tagged
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22790#discussion_r228215468
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala
---
@@ -109,7 +109,7 @@ class BisectingKMeansModel
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22675
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22814
**[Test build #98023 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98023/testReport)**
for PR 22814 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98023/
Test PASSed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22675
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22814
@cloud-fan @HyukjinKwon I have changed the default value to "FAILFAST" and
remove the migration guide.
See the PR description for details.
---
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22790#discussion_r228211495
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala
---
@@ -109,7 +109,7 @@ class BisectingKMeansModel
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22790#discussion_r228208961
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala
---
@@ -109,7 +109,7 @@ class BisectingKMeansModel
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22794
I am not sure what Hive 1.2 exposes, but we might have more, it needs to be
checked. Anyway, yes, those have to be overridden for sure. When I referred to
the current approach, I meant the one
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/22790
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/22821
We seem to be splitting hairs here. Why are we providing tech preview to
advanced users? Are you saying they construct expressions directly using
internal APIs? I doubt thatâs tech preview.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22823
**[Test build #98022 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98022/testReport)**
for PR 22823 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22814
**[Test build #98023 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98023/testReport)**
for PR 22814 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22821
I'm just confused here. Shall we finish the discussion on the email thread?
@cloud-fan and @gatorsmile . If the decision is officially made like that
(providing tech. preview to advance
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22790
Is this ready to go? We are going to have another RC, and would be good to
include it.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22775
I think I'm not qualified to make the decision here, as I don't fully
understand the use case.
It looks to me that one use case would be to run `schema_of_json` on a
column and manually
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22825
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22825
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22821
@cloud-fan . That's sounds like a Tech. Preview for the advance users,
doesn't it?
It looks like an excuse to ignore the whole context of the discussion and
to try to ship in any
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22825
**[Test build #98021 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98021/testReport)**
for PR 22825 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22825
cc @vofque @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22794
@mgaido91 You are right. But may be we only override
`newExecuteStatementOperation`, `newGetSchemasOperation`,
`newGetTablesOperation`, `newGetTableTypesOperation`,`newGetColumnsOperation`
and
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22825
[SPARK-25772][SQL][FOLLOWUP] remove GetArrayFromMap
## What changes were proposed in this pull request?
In https://github.com/apache/spark/pull/22745 we introduced the
`GetArrayFromMap`
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22812
**[Test build #98020 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98020/testReport)**
for PR 22812 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22824
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22824
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22824
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user sandeep-katta opened a pull request:
https://github.com/apache/spark/pull/22824
[SPARK-25834] Update Mode should not be supported for Outer Joins
## What changes were proposed in this pull request?
As per spark documentation only Append mode is supported for
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22812#discussion_r228195016
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -119,10 +119,9 @@ object ExpressionEncoder {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22812
**[Test build #98019 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98019/testReport)**
for PR 22812 at commit
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22823
Thanks @wangyum for good suggestion!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22823
**[Test build #98018 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98018/testReport)**
for PR 22823 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22821
**[Test build #98017 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98017/testReport)**
for PR 22821 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22821
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22821
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user peter-toth commented on the issue:
https://github.com/apache/spark/pull/22817
I will try to investigate a bit more come up with an other solution.
---
-
To unsubscribe, e-mail:
Github user peter-toth commented on the issue:
https://github.com/apache/spark/pull/22817
So based on the UT results it seems that simply changing the resolution to
bottom-up causes issues with `LambdaFunction`s in the current version of Spark.
The issue seems to be a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22823
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98013/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22823
**[Test build #98013 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98013/testReport)**
for PR 22823 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21933
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22811
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
501 - 600 of 775 matches
Mail list logo
