Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-212023124
Hi, @jaceklaskowski .
What about using `[MINOR][DOCS]` prefix for this PR?
I just leave a note since I know you are a frequent contributor. :)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-211562697
**[Test build #2816 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2816/consoleFull)**
for PR 12469 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-211557808
**[Test build #2816 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2816/consoleFull)**
for PR 12469 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-211487273
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60095404
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -453,8 +453,8 @@ class Dataset[T] private[sql](
* Returns true if this
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60095493
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -46,8 +46,7 @@ import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60094759
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -38,8 +38,6 @@ import org.apache.spark.sql.types._
/**
*
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60094552
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -438,7 +438,6 @@ class LinearRegressionModel private[ml] (
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60092825
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -46,8 +46,7 @@ import
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60092677
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -453,8 +453,8 @@ class Dataset[T] private[sql](
* Returns true if
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60092525
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -38,8 +38,6 @@ import org.apache.spark.sql.types._
/**
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60092387
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -438,7 +438,6 @@ class LinearRegressionModel private[ml]
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-211345914
Rest LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60045159
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -46,8 +46,7 @@ import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60045143
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -453,8 +453,8 @@ class Dataset[T] private[sql](
* Returns true if this
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60045037
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -38,8 +38,6 @@ import org.apache.spark.sql.types._
/**
*
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60045025
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -438,7 +438,6 @@ class LinearRegressionModel private[ml] (
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/12469
Minor typo fixes
## What changes were proposed in this pull request?
Minor typo fixes (too minor to deserve separate a JIRA)
## How was this patch tested?
local
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11802
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-204731893
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-204618869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-204618865
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-204618373
**[Test build #54734 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54734/consoleFull)**
for PR 11802 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-204598269
**[Test build #54734 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54734/consoleFull)**
for PR 11802 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-204597481
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r57876414
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -246,9 +246,7 @@ class StreamingContext private[streaming] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r57465383
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -246,9 +246,7 @@ class StreamingContext private[streaming] (
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r57455819
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -246,9 +246,7 @@ class StreamingContext
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r57452798
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -246,9 +246,7 @@ class StreamingContext private[streaming] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r57139648
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -246,9 +246,7 @@ class StreamingContext private[streaming] (
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56595542
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala ---
@@ -277,7 +277,7 @@ abstract class DStream[T: ClassTag] (
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56595456
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala ---
@@ -269,7 +269,7 @@ abstract class DStream[T: ClassTag] (
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/11802
[MINOR] Typo fixes
## What changes were proposed in this pull request?
Typo fixes. No functional changes.
## How was this patch tested?
Built the sources and ran
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-198125996
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-198135365
I had some small comments from my side. The changes in `ml` look good.
Someone from streaming should take over for the rest.
---
If your project is set up for it,
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56749101
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -246,9 +246,7 @@ class StreamingContext private[streaming] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56638877
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -132,7 +132,7 @@ class StreamingContext private[streaming] (
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56595285
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -132,7 +132,7 @@ class StreamingContext private[streaming] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56636866
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala
---
@@ -32,7 +32,7 @@ import
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-198304050
Yeah this is good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56595822
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStreamCheckpointData.scala
---
@@ -102,8 +102,8 @@ class DStreamCheckpointData[T:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56636690
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -79,13 +79,13 @@ abstract class LogicalPlan
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56638983
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStreamCheckpointData.scala
---
@@ -102,8 +102,8 @@ class DStreamCheckpointData[T:
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56595611
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStreamCheckpointData.scala
---
@@ -45,7 +45,7 @@ class DStreamCheckpointData[T:
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-198593089
Thanks @srowen @thunterdb for review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56738903
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala ---
@@ -277,7 +277,7 @@ abstract class DStream[T: ClassTag] (
46 matches
Mail list logo
