[GitHub] spark pull request #17615: [SPARK-20303][SQL] Rename createTempFunction to r...

2017-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17615 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17615: [SPARK-20303][SQL] Rename createTempFunction to r...

2017-04-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17615#discussion_r111073982 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -59,17 +60,13 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17615: [SPARK-20303][SQL] Rename createTempFunction to r...

2017-04-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17615#discussion_r111070619 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -59,17 +60,13 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17615: [SPARK-20303][SQL] Rename createTempFunction to r...

2017-04-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17615#discussion_r111068193 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -59,17 +60,13 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17615: [SPARK-20303][SQL] Rename createTempFunction to r...

2017-04-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17615#discussion_r111068131 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1050,7 +1050,7 @@ class SessionCatalog(

[GitHub] spark pull request #17615: [SPARK-20303][SQL] Rename createTempFunction to r...

2017-04-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17615#discussion_r111068037 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -124,13 +124,6 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark pull request #17615: [SPARK-20303][SQL] Rename createTempFunction to r...

2017-04-11 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/17615 [SPARK-20303][SQL] Rename createTempFunction to registerFunction ### What changes were proposed in this pull request? Session catalog API `createTempFunction` is being used by Hive build-in