Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18931
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163752999
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +162,96 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163747141
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +162,96 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163746698
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +162,96 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163746605
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +162,96 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163743504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -661,6 +661,15 @@ object SQLConf {
.intConf
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163723759
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1263,6 +1271,8 @@ class SQLConf extends Serializable with Logging
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163723731
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163723249
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163723212
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163723254
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163723195
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163723102
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -661,6 +661,14 @@ object SQLConf {
.intConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163621072
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1263,6 +1271,8 @@ class SQLConf extends Serializable with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163620741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -661,6 +661,14 @@ object SQLConf {
.intConf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163518761
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163516654
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163514909
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163513927
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163512972
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163512277
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163511790
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -661,6 +661,14 @@ object SQLConf {
.intConf
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163477806
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1313,6 +1331,9 @@ object CodeGenerator
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163472676
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1313,6 +1331,9 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163462731
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,13 +149,100 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163462688
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,13 +149,100 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163462698
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,13 +149,100 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163317809
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,13 +149,100 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163316730
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,13 +149,100 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163316509
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,13 +149,100 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163315858
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,13 +149,100 @@ trait CodegenSupport extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163315164
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,13 +149,100 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r144279986
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -175,6 +175,25 @@ trait CodegenSupport extends
Github user a10y commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r144025706
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -175,6 +175,25 @@ trait CodegenSupport extends SparkPlan
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r143321347
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -181,7 +181,7 @@ class WholeStageCodegenSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r143321131
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -181,7 +181,7 @@ class WholeStageCodegenSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r140931214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExpandExec.scala ---
@@ -89,6 +89,8 @@ case class ExpandExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136776281
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136746833
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExpandExec.scala ---
@@ -89,6 +89,8 @@ case class ExpandExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136746468
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala ---
@@ -177,6 +177,8 @@ case class SortExec(
""".stripMargin.trim
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136743435
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala ---
@@ -177,6 +177,8 @@ case class SortExec(
""".stripMargin.trim
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136742515
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExpandExec.scala ---
@@ -89,6 +89,8 @@ case class ExpandExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136742331
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136742282
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136742019
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136741637
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136711099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala ---
@@ -177,6 +177,8 @@ case class SortExec(
""".stripMargin.trim
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136710928
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136710824
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136710234
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136710741
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136710667
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136710909
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136711183
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExpandExec.scala ---
@@ -89,6 +89,8 @@ case class ExpandExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136710872
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,146 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136492055
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,144 @@ trait CodegenSupport extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r136491920
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -149,14 +149,144 @@ trait CodegenSupport extends
57 matches
Mail list logo
