Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18966
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r143808338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -89,6 +89,14 @@ object CodeFormatter
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r143798289
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class CodegenContext {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r143629417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r143628760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r142756140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r142395171
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class CodegenContext {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r142267872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r141445534
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r137164501
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class CodegenContext {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r137050480
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r136491409
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class CodegenContext {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135415687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135392594
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135381627
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135380779
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135378299
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class CodegenContext {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135332868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -582,6 +582,15 @@ object SQLConf {
.intConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135327262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -582,6 +582,15 @@ object SQLConf {
.intConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135326229
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -582,6 +582,15 @@ object SQLConf {
.intConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135324695
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135164815
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BenchmarkWideTable.scala
---
@@ -42,12 +42,16 @@ class BenchmarkWideTable extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135157982
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BenchmarkWideTable.scala
---
@@ -42,12 +42,16 @@ class BenchmarkWideTable
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r134643155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -582,6 +582,15 @@ object SQLConf {
.intConf
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r134368200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -582,6 +582,15 @@ object SQLConf {
.intConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r134305398
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -582,6 +582,15 @@ object SQLConf {
.intConf
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r134134190
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -582,6 +582,15 @@ object SQLConf {
.intConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r134128067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -582,6 +582,15 @@ object SQLConf {
.intConf
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r133594345
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,19 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r133567835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,19 @@ class
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/18966
[SPARK-21751][SQL] CodeGeneraor.splitExpressions counts code size more
precisely
## What changes were proposed in this pull request?
Current `CodeGeneraor.splitExpressions` splits
31 matches
Mail list logo
