[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2018-10-18 Thread mrkm4ntr
Github user mrkm4ntr closed the pull request at: https://github.com/apache/spark/pull/19988 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2017-12-18 Thread mrkm4ntr
Github user mrkm4ntr commented on a diff in the pull request: https://github.com/apache/spark/pull/19988#discussion_r157447946 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -244,9 +244,9 @@ class LinearSVC @Since("2.2.0") ( }

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2017-12-18 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19988#discussion_r157441600 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -244,9 +244,9 @@ class LinearSVC @Since("2.2.0") (

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2017-12-17 Thread mrkm4ntr
Github user mrkm4ntr commented on a diff in the pull request: https://github.com/apache/spark/pull/19988#discussion_r157396794 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -244,9 +244,9 @@ class LinearSVC @Since("2.2.0") ( }

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2017-12-17 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19988#discussion_r157393049 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -244,9 +244,9 @@ class LinearSVC @Since("2.2.0") (

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2017-12-16 Thread mrkm4ntr
Github user mrkm4ntr commented on a diff in the pull request: https://github.com/apache/spark/pull/19988#discussion_r157345097 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala --- @@ -109,6 +109,11 @@ private[optim] class QuasiNewtonSolver(

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2017-12-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19988#discussion_r157342991 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala --- @@ -109,6 +109,11 @@ private[optim] class QuasiNewtonSolver(

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2017-12-15 Thread mrkm4ntr
Github user mrkm4ntr commented on a diff in the pull request: https://github.com/apache/spark/pull/19988#discussion_r157243741 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala --- @@ -109,6 +109,11 @@ private[optim] class QuasiNewtonSolver(

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2017-12-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19988#discussion_r157204320 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala --- @@ -17,10 +17,10 @@ package org.apache.spark.ml.optim

[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

2017-12-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19988#discussion_r157204396 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala --- @@ -109,6 +109,11 @@ private[optim] class QuasiNewtonSolver(