Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20618
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171992166
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,165 @@ object functions {
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171991788
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1500,31 +1534,35 @@ object functions {
}
/**
- *
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171991691
--- Diff: python/pyspark/sql/functions.py ---
@@ -173,16 +172,26 @@ def _():
_functions_2_1 = {
# unary math functions
-
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171991733
--- Diff: python/pyspark/sql/functions.py ---
@@ -173,16 +172,26 @@ def _():
_functions_2_1 = {
# unary math functions
-
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171991647
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -512,7 +529,11 @@ case class Rint(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171836519
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,165 @@ object functions {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171834617
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1500,31 +1534,35 @@ object functions {
}
/**
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171829946
--- Diff: python/pyspark/sql/functions.py ---
@@ -173,16 +172,26 @@ def _():
_functions_2_1 = {
# unary math functions
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171829796
--- Diff: python/pyspark/sql/functions.py ---
@@ -173,16 +172,26 @@ def _():
_functions_2_1 = {
# unary math functions
-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171167374
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -512,7 +529,11 @@ case class Rint(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169313329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -548,7 +579,14 @@ case class Sqrt(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169313008
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +272,10 @@ case class Cos(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169312315
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +272,10 @@ case class Cos(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169311993
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -252,7 +255,14 @@ case class Ceil(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169311232
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2005,71 +1967,63 @@ object functions {
def signum(columnName:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169305293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -539,7 +563,14 @@ case class Sinh(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169305384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -548,7 +579,14 @@ case class Sqrt(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169305100
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +272,10 @@ case class Cos(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169300055
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +272,10 @@ case class Cos(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169299115
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2005,71 +1967,63 @@ object functions {
def signum(columnName:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169299563
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -252,7 +255,14 @@ case class Ceil(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169291756
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,165 @@ object functions {
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169287876
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -521,7 +542,15 @@ case class Signum(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169287270
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +273,11 @@ case class Cos(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169213260
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -521,7 +542,15 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169213138
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +273,11 @@ case class Cos(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169213439
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,165 @@ object functions {
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169187041
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -804,7 +858,6 @@ case class Pow(left:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169186706
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -538,8 +559,14 @@ case class Sinh(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169186651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -512,16 +522,27 @@ case class Rint(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169182568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -804,7 +858,6 @@ case class Pow(left:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169182146
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -512,16 +522,27 @@ case class Rint(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169182499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -562,7 +595,12 @@ case class Cot(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169182420
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -548,7 +575,13 @@ case class Sqrt(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169182396
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -538,8 +559,14 @@ case class Sinh(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169182053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -512,16 +522,27 @@ case class Rint(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169182585
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -916,7 +969,6 @@ case class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169120482
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169100931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169086289
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,168 @@ object functions {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169085966
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169086344
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,168 @@ object functions {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169086471
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1500,31 +1537,35 @@ object functions {
}
/**
- *
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169086090
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,168 @@ object functions {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168670009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -196,7 +208,13 @@ case class Asin(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168670792
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -521,7 +554,13 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168669517
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168578156
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168531352
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child:
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168526385
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168525504
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user misutoth commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168521316
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +285,11 @@ case class Cos(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168511361
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168511774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168504378
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -262,6 +285,11 @@ case class Cos(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168511869
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2873,7 +2945,7 @@ object functions {
* or equal
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168511172
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1313,131 +1313,178 @@ object functions {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168510272
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168510579
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -972,6 +1045,7 @@ case class Logarithm(left:
GitHub user misutoth opened a pull request:
https://github.com/apache/spark/pull/20618
[SPARK-23329][SQL] Fix documentation of trigonometric functions
## What changes were proposed in this pull request?
Provide more details in trigonometric function documentations.
61 matches
Mail list logo
