Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22732
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226527439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -932,6 +935,23 @@ trait ScalaReflection {
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226521257
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -932,6 +935,23 @@ trait ScalaReflection {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226520350
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -932,6 +935,23 @@ trait ScalaReflection {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226517584
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +42,29 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226424308
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +42,29 @@ import
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226384713
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +42,29 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226382186
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +42,29 @@ import
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226156109
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -73,19 +73,21 @@ case class UserDefinedFunction
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226156536
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226156400
--- Diff: docs/sql-programming-guide.md ---
@@ -1978,6 +1978,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
-
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226155205
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226155153
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226145444
--- Diff: docs/sql-programming-guide.md ---
@@ -1978,6 +1978,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226145051
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226145150
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226144670
--- Diff: docs/sql-programming-guide.md ---
@@ -1951,7 +1951,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226143221
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext
{
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226142651
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -73,19 +73,21 @@ case class UserDefinedFunction
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226141983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +42,29 @@ import
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225986215
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala
---
@@ -179,7 +179,8 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225952267
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +40,29 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225807388
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -31,6 +31,9 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225804995
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225764876
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225762708
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225735714
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225724505
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225693558
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225655290
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225651483
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala
---
@@ -179,7 +179,8 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225654592
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225619242
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -31,6 +31,7 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225614430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -31,6 +31,7 @@ import
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225606907
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +40,29 @@ import
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225605581
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -73,27 +73,27 @@ case class UserDefinedFunction
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225602236
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -73,27 +73,27 @@ case class UserDefinedFunction
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225588931
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -73,27 +73,27 @@ case class UserDefinedFunction
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225587391
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -31,6 +31,7 @@ import
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225586820
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -314,24 +314,24 @@ class AnalysisSuite extends
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225585971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2137,36 +2137,27 @@ class Analyzer(
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225585740
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +40,29 @@ import
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225583730
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2137,36 +2137,27 @@ class Analyzer(
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225580591
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2137,36 +2137,27 @@ class Analyzer(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225393919
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +40,29 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225393373
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +40,29 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225393220
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +40,29 @@ import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225281705
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2137,36 +2137,27 @@ class Analyzer(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225280838
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2137,36 +2137,27 @@ class Analyzer(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225280977
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2137,36 +2137,27 @@ class Analyzer(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225278704
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +40,29 @@ import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225279364
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -314,24 +314,24 @@ class AnalysisSuite extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225280125
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -73,27 +73,27 @@ case class UserDefinedFunction
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225280432
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -124,8 +124,10 @@ class UDFRegistration private[sql] (functionRegistry:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225278847
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -31,6 +31,7 @@ import
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/22732
[SPARK-25044][FOLLOW-UP] Change ScalaUDF constructor signature
## What changes were proposed in this pull request?
This is a follow-up PR for #22259. The extra field added in `ScalaUDF`
56 matches
Mail list logo
