Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r232571944
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r232564281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22809
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228725645
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228709483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228706515
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228666789
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228644504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228640680
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228638310
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228637047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -282,6 +283,31 @@ trait RuntimeReplaceable
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228636110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -282,6 +283,31 @@ trait RuntimeReplaceable
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228635413
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228635201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -282,6 +283,31 @@ trait RuntimeReplaceable
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228634827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -282,6 +283,31 @@ trait RuntimeReplaceable
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228634159
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228633284
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228631452
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -282,6 +283,31 @@ trait RuntimeReplaceable
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228239274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228238508
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228238276
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228236882
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228235105
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228232332
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228230112
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228229829
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228227624
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228143956
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228143393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228144382
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala
---
@@ -144,6 +144,8 @@ class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228143428
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Min.scala
---
@@ -57,3 +57,27 @@ case class Min(child:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228144076
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
---
@@ -21,24 +21,32 @@ import
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228142745
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -300,6 +300,10 @@ object FunctionRegistry {
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228143607
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -282,6 +283,31 @@ trait RuntimeReplaceable
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228143368
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228144250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
---
@@ -21,24 +21,32 @@ import
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228020366
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -727,4 +728,67 @@ class DataFrameAggregateSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228013503
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -727,4 +728,67 @@ class DataFrameAggregateSuite extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r227901365
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -80,3 +80,69 @@ SELECT 1 FROM range(10) HAVING true;
SELECT 1 FROM
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r227899342
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
---
@@ -38,6 +39,18 @@ object ReplaceExpressions
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r227881077
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
---
@@ -38,6 +39,18 @@ object ReplaceExpressions
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22809
[SPARK-19851][SQL] Add support for EVERY and ANY (SOME) aggregates
## What changes were proposed in this pull request?
Implements Every, Some, Any aggregates in SQL. These new
42 matches
Mail list logo
