[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r236049216 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1892,7 +1898,7 @@ class JsonSuite extends

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r235584943 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1892,7 +1898,7 @@ class JsonSuite extends

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r235583851 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -240,16 +240,6 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r235583559 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1892,7 +1898,7 @@ class JsonSuite extends

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r235583349 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1892,7 +1898,7 @@ class JsonSuite extends

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r235583315 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1905,7 +1911,7 @@ class JsonSuite extends

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22938 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232605204 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1813,6 +1817,7 @@ class JsonSuite extends

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232594164 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1115,6 +1115,7 @@ class JsonSuite extends

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232589526 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,23 @@ case class JsonToStructs(

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232550860 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1813,6 +1817,7 @@ class JsonSuite extends

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232550733 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1115,6 +1115,7 @@ class JsonSuite extends

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232550502 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,23 @@ case class

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232550186 --- Diff: docs/sql-migration-guide-upgrade.md --- @@ -15,6 +15,8 @@ displayTitle: Spark SQL Upgrading Guide - Since Spark 3.0, the

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232494623 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,33 @@ case class JsonToStructs(

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232484880 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,33 @@ case class

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232446781 --- Diff: docs/sql-migration-guide-upgrade.md --- @@ -15,6 +15,8 @@ displayTitle: Spark SQL Upgrading Guide - Since Spark 3.0, the `from_json`

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232446534 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,33 @@ case class JsonToStructs(

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r232386932 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,33 @@ case class JsonToStructs(

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r231783277 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,33 @@ case class JsonToStructs(

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r231762733 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,33 @@ case class

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r231745125 --- Diff: docs/sql-migration-guide-upgrade.md --- @@ -15,6 +15,8 @@ displayTitle: Spark SQL Upgrading Guide - Since Spark 3.0, the

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r231251408 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,23 @@ case class JsonToStructs(

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r231189880 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,23 @@ case class

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r231156386 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -550,15 +550,23 @@ case class

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r230586281 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -240,16 +240,6 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r230585549 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -552,13 +552,19 @@ case class JsonToStructs(

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22938#discussion_r230581932 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -552,13 +552,19 @@ case class

[GitHub] spark pull request #22938: [SPARK-25935][SQL] Prevent null rows from JSON pa...

GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/22938 [SPARK-25935][SQL] Prevent null rows from JSON parser ## What changes were proposed in this pull request? An input without valid JSON tokens on the root level will be treated as a bad