Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23142
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23142
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99883/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23142
**[Test build #99883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99883/testReport)**
for PR 23142 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23258#discussion_r240026727
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -182,10 +182,13 @@ class SQLMetricsSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23249#discussion_r240026485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -118,10 +115,12 @@ case class
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23255
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23255#discussion_r240026441
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -752,6 +752,17 @@ class InsertSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23262#discussion_r240026394
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -53,7 +53,7 @@ object RDDConversions {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23262#discussion_r240026388
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -33,7 +33,7 @@ object RDDConversions {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23248#discussion_r240026330
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
---
@@ -131,8 +131,20 @@ object ExtractPythonUDFs
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23253#discussion_r240026245
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -35,7 +35,9 @@ displayTitle: Spark SQL Upgrading Guide
- Since Spark 3.0, CSV datasource
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23253#discussion_r240026237
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/TestJsonData.scala
---
@@ -229,6 +229,11 @@ private[json] trait
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23265
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23265
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23204
+1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23265
**[Test build #99884 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99884/testReport)**
for PR 23265 at commit
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/23265
[2.4][SPARK-26021][SQL][FOLLOWUP] only deal with NaN and -0.0 in
UnsafeWriter
backport https://github.com/apache/spark/pull/23239 to 2.4
-
## What changes were proposed
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23265
cc @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user seancxmao commented on a diff in the pull request:
https://github.com/apache/spark/pull/23258#discussion_r240024723
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -182,10 +182,13 @@ class SQLMetricsSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23142
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23142
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan and @JkSelf .
For the partial revert, we had better create a new Apache JIRA issue. That
will be a more cleaner way to backport.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23142
**[Test build #99883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99883/testReport)**
for PR 23142 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23142
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23142
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23142
**[Test build #99882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99882/testReport)**
for PR 23142 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23142
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99882/
Test FAILed.
---
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/23238
Thank you! @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
Fortunately the syntax is "100m", which has always meant "100 * 1024 *
1024" or "100 MiB"
---
-
To unsubscribe, e-mail:
Github user JkSelf commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan ok, i will revert as your comments later.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user JkSelf commented on the issue:
https://github.com/apache/spark/pull/23204
The result of all queries in tpcds with 1TB data scale is in [tpcds
result](https://docs.google.com/spreadsheets/d/18a5BdOlmm8euTaRodyeWum9yu92mbWWu6JbhGXtr7yE/edit#gid=0)
---
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/23252#discussion_r240022921
--- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala
---
@@ -440,12 +473,27 @@ class SecurityManagerSuite extends SparkFunSuite
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/23224
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/23256
ideally, but really not for this PR
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23201#discussion_r240022552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
---
@@ -121,7 +122,26 @@ private[sql] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22088
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23207
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r240022467
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSourceSuite.scala
---
@@ -222,4 +222,61 @@ class HiveParquetSourceSuite
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23207
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23204
according to
https://github.com/apache/spark/pull/23214#issuecomment-443999282 , the hash
join metrics is wrongly implemented. I think it's fine to revert it and
re-implement it later.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23142
**[Test build #99882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99882/testReport)**
for PR 23142 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23142
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23142
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23142
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23204
Hi, @LuciferYang . If we are not going to revert this, could you close this
PR?
---
-
To unsubscribe, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23238
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23238
Thanks, @seancxmao .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23238
Merged to master and branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23253
cc @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99881/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23257
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23257
**[Test build #99881 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99881/testReport)**
for PR 23257 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23259
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23259
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99880/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23259
**[Test build #99880 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99880/testReport)**
for PR 23259 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23253
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99879/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23253
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23253
**[Test build #99879 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99879/testReport)**
for PR 23253 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23242
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99877/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23242
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23242
**[Test build #99877 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99877/testReport)**
for PR 23242 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99878/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99878/testReport)**
for PR 23169 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23257
**[Test build #99881 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99881/testReport)**
for PR 23257 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23257
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23257
@cloud-fan What do you think of the PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23259
cc @hvanhovell , @mgaido91 , too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23259
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23259
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23259
**[Test build #99880 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99880/testReport)**
for PR 23259 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23259
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23253
**[Test build #99879 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99879/testReport)**
for PR 23253 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23253
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23253
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23253#discussion_r240014440
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -37,6 +37,8 @@ displayTitle: Spark SQL Upgrading Guide
- In Spark version 2.4 and earlier,
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r240014393
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
---
@@ -190,4 +192,103 @@ class HiveOrcSourceSuite extends
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/23264
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23225#discussion_r240014126
--- Diff:
core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java
---
@@ -235,11 +235,8 @@ public void writeEmptyIterator()
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23239
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99878/testReport)**
for PR 23169 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23239
Hi, @cloud-fan . Please make another PR for `branch-2.4`. There is a
conflict on `branch-2.4`.
---
-
To unsubscribe,
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23253#discussion_r240013729
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -37,6 +37,8 @@ displayTitle: Spark SQL Upgrading Guide
- In Spark version 2.4 and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23264
This is merged now. Please close the PR, @srowen . :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23264
Merged to branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23242
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23242
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23242
**[Test build #99877 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99877/testReport)**
for PR 23242 at commit
Github user abellina commented on a diff in the pull request:
https://github.com/apache/spark/pull/23242#discussion_r240013209
--- Diff:
examples/src/main/scala/org/apache/spark/examples/AccumulatorMetricsTest.scala
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23253
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23253
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99875/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23253
**[Test build #99875 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99875/testReport)**
for PR 23253 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99876/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99876 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99876/testReport)**
for PR 23169 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 243 matches
Mail list logo
