[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-15 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r71028688 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -168,15 +173,37 @@ class RandomForestRegressionModel

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70642695 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +108,55 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70640862 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -168,15 +173,37 @@ class RandomForestRegressionModel

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70639350 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +109,54 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70638775 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +109,54 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70638644 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +109,54 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70637087 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +109,54 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70637181 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +109,54 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70638276 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +109,54 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70637680 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +109,54 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70637268 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +109,54 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70607599 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -168,15 +173,37 @@ class RandomForestRegressionModel

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70607457 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -168,15 +173,37 @@ class RandomForestRegressionModel

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70603646 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala --- @@ -44,7 +44,8 @@ private[shared] object

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70601786 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -168,15 +173,37 @@ class RandomForestRegressionModel

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-07-13 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r70601639 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -93,6 +94,10 @@ class RandomForestRegressor

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-29 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r69039559 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +108,55 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-29 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r68985017 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -168,15 +173,39 @@ class RandomForestRegressionModel

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-20 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r67747441 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +108,55 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-20 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r67746985 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +108,55 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-20 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r67743994 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/RandomForestRegressorSuite.scala --- @@ -105,6 +108,55 @@ class RandomForestRegressorSuite

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-20 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r67741186 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -168,15 +173,39 @@ class RandomForestRegressionModel

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-20 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r67741020 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala --- @@ -149,6 +149,8 @@ private[ml] trait HasVarianceCol extends Params {

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-20 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r67740952 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -168,15 +173,39 @@ class RandomForestRegressionModel

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-20 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13650#discussion_r67740399 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala --- @@ -168,15 +173,39 @@ class RandomForestRegressionModel

[GitHub] spark pull request #13650: [SPARK-9623] [ML] Provide variance for RandomFore...

2016-06-13 Thread MechCoder
GitHub user MechCoder opened a pull request: https://github.com/apache/spark/pull/13650 [SPARK-9623] [ML] Provide variance for RandomForestRegressor predictions ## What changes were proposed in this pull request? It is useful to get the variance of predictions from the