Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164971509
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnarRow.java
---
@@ -146,9 +146,7 @@ public UTF8String
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20438
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164944493
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnarRow.java
---
@@ -146,9 +146,7 @@ public UTF8String
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164943981
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarRow.java ---
@@ -139,9 +139,7 @@ public UTF8String getUTF8String(int ordinal) {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164943754
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnarRow.java
---
@@ -146,9 +146,7 @@ public UTF8String
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164942783
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -236,9 +238,29 @@ public MapData getMap(int ordinal) {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164807808
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -236,9 +238,29 @@ public MapData getMap(int ordinal) {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164806777
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -236,9 +238,29 @@ public MapData getMap(int ordinal) {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164802008
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -236,9 +238,29 @@ public MapData getMap(int ordinal) {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164801042
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -235,10 +237,30 @@ public MapData getMap(int ordinal) {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164769822
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -236,9 +238,29 @@ public MapData getMap(int ordinal) {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164730300
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarArray.java ---
@@ -135,9 +135,7 @@ public UTF8String getUTF8String(int ordinal)
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164728359
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
---
@@ -87,7 +87,7 @@ public static CalendarInterval
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164729684
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -235,10 +237,30 @@ public MapData getMap(int ordinal) {
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164729086
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -235,10 +237,30 @@ public MapData getMap(int ordinal) {
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164729429
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -235,10 +237,30 @@ public MapData getMap(int ordinal) {
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164729250
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -235,10 +237,30 @@ public MapData getMap(int ordinal) {
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164717772
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -195,6 +196,7 @@
* struct field.
*/
public
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164719793
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarArray.java ---
@@ -135,9 +135,7 @@ public UTF8String getUTF8String(int ordinal) {
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20438
[SPARK-23272][SQL] add calendar interval type support to ColumnVector
## What changes were proposed in this pull request?
`ColumnVector` is aimed to support all the data types, but
20 matches
Mail list logo
