Github user wmellouli closed the pull request at:
https://github.com/apache/spark/pull/22332
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wmellouli commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215185048
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user wmellouli commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215184928
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -831,13 +831,21 @@ class DataFrameSuite extends QueryTest with
Github user wmellouli commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215179856
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215144932
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215145065
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215144732
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215145351
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -831,13 +831,21 @@ class DataFrameSuite extends QueryTest with
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215144982
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
