[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22362 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-25 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r220364426 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -726,7 +726,11 @@ private[spark] object SparkConf extends Logging {

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r220360201 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -726,7 +726,11 @@ private[spark] object SparkConf extends Logging {

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-25 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r220356187 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -726,7 +726,11 @@ private[spark] object SparkConf extends Logging {

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r220354878 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -726,7 +726,11 @@ private[spark] object SparkConf extends Logging {

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-21 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r219638207 --- Diff: R/pkg/R/sparkR.R --- @@ -624,8 +624,8 @@ sparkConfToSubmitOps[["spark.driver.extraClassPath"]] <- "--driver-class-path"

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r216122659 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -199,8 +199,8 @@ private[deploy] class

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r216108106 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -199,8 +199,8 @@ private[deploy] class SparkSubmitArguments(args:

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r216107597 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -199,8 +199,8 @@ private[deploy] class SparkSubmitArguments(args:

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r216107505 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -520,6 +520,10 @@ private[spark] class SparkSubmit extends Logging {

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r216107385 --- Diff: R/pkg/R/sparkR.R --- @@ -624,8 +624,8 @@ sparkConfToSubmitOps[["spark.driver.extraClassPath"]] <- "--driver-class-path"

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-07 Thread ifilonenko
GitHub user ifilonenko opened a pull request: https://github.com/apache/spark/pull/22362 [SPARK-25372][YARN][K8S] Deprecate and generalize keytab / principal config ## What changes were proposed in this pull request? SparkSubmit already logs in the user if a keytab is