Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/22419
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r224318028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,27 @@ case class BRound(child:
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r222554828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,27 @@ case class BRound(child:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r222539741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,27 @@ case class BRound(child:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r220973430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,27 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r219858062
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2214,6 +2214,26 @@ object functions {
*/
def
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r219858027
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2214,6 +2214,26 @@ object functions {
*/
def
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r219660644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -413,6 +413,7 @@ object Decimal {
val ROUND_HALF_EVEN =
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r219655441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -413,6 +413,7 @@ object Decimal {
val ROUND_HALF_EVEN =
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r219651627
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -413,6 +413,7 @@ object Decimal {
val ROUND_HALF_EVEN =
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r218749189
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,80 @@ case class BRound(child:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r218535402
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2214,6 +2214,24 @@ object functions {
*/
def
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r218534147
--- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql ---
@@ -96,3 +96,9 @@ select positive('-1.11'), positive(-1.11),
negative('-1.11'),
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r218524063
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,65 @@ case class BRound(child:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r218525420
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
---
@@ -644,4 +644,31 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r218531021
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,65 @@ case class BRound(child:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r218525567
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
---
@@ -644,4 +644,31 @@ class
17 matches
Mail list logo
