[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r239185785 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-04 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238739905 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-04 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238731915 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238424342 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238388633 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-03 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238380513 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-03 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238377911 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-03 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238377498 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238371374 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238363825 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238366634 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-12-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r238363142 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237993972 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237992560 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237990856 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237982013 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237975861 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -138,19 +138,22 @@ private[spark] class ProcfsMetricsGetter(

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237981353 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237978529 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237979881 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237977304 --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala --- @@ -49,14 +47,14 @@ class ExecutorMetrics private[spark] extends

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-30 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237982177 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-29 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237737064 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-29 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237736770 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-28 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r237161182 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236863378 --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala --- @@ -28,16 +28,14 @@ import org.apache.spark.metrics.ExecutorMetricType

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236856360 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236858045 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236856995 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236860940 --- Diff: core/src/test/scala/org/apache/spark/executor/ProcfsMetricsGetterSuite.scala --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236857465 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236855952 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236860104 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -95,10 +136,22 @@ private[spark] object ExecutorMetricType {

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236855451 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236848338 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236847493 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236828402 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236769432 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -84,6 +122,8 @@ case object MappedPoolMemory extends

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236766605 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-26 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r236432819 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -84,6 +122,8 @@ case object MappedPoolMemory extends

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-21 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r235542735 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-21 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r235541704 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -84,6 +122,8 @@ case object MappedPoolMemory extends

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r235124501 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-19 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234815376 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234340260 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234340168 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234343451 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234342703 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234337409 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234344505 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234341965 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234344631 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -19,25 +19,43 @@ package org.apache.spark.metrics import

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234347780 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -84,6 +122,8 @@ case object MappedPoolMemory extends

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234343988 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234334930 --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala --- @@ -28,16 +28,14 @@ import org.apache.spark.metrics.ExecutorMetricType

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234339484 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234340136 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234337238 --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala --- @@ -69,9 +67,8 @@ class ExecutorMetrics private[spark] extends

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234339856 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234344821 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -19,25 +19,43 @@ package org.apache.spark.metrics import

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234342892 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234338058 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234334582 --- Diff: core/src/main/scala/org/apache/spark/Heartbeater.scala --- @@ -60,11 +60,16 @@ private[spark] class Heartbeater( } /** -

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234339667 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234348523 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234342770 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234343203 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234344763 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -19,25 +19,43 @@ package org.apache.spark.metrics import

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234347011 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -47,18 +65,39 @@ private[spark] abstract class

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234340033 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234337384 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r234342135 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r233255758 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -19,18 +19,31 @@ package org.apache.spark.metrics import

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-13 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r233254497 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-13 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r233252552 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -19,18 +19,31 @@ package org.apache.spark.metrics import

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-13 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r233250143 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r231921807 --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala --- @@ -69,11 +67,10 @@ class ExecutorMetrics private[spark] extends

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r232224322 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -95,10 +148,18 @@ private[spark] object ExecutorMetricType {

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r232221648 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -19,18 +19,31 @@ package org.apache.spark.metrics import

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r232220878 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r231980219 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r23535 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -19,18 +19,31 @@ package org.apache.spark.metrics import

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r23970 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -95,10 +148,18 @@ private[spark] object ExecutorMetricType {

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r231982148 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r231980858 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r232224769 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -394,10 +394,13 @@ private[spark] object JsonProtocol { /**

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r231925282 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r232221783 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -19,18 +19,31 @@ package org.apache.spark.metrics import

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r231926797 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-05 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r230864147 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -394,9 +394,15 @@ private[spark] object JsonProtocol { /**

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-05 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r230852432 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -394,9 +394,15 @@ private[spark] object JsonProtocol { /**

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-05 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r230858827 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -394,9 +394,15 @@ private[spark] object JsonProtocol { /**

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-11-05 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r230787617 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -394,9 +394,15 @@ private[spark] object JsonProtocol { /**

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-29 Thread LantaoJin
Github user LantaoJin commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r228830146 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -394,9 +394,15 @@ private[spark] object JsonProtocol { /**

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-22 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r22741 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -95,10 +135,29 @@ private[spark] object ExecutorMetricType {

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r227082371 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r227080176 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-22 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r227058059 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r227054255 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-22 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r227054038 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software

  1   2   >