On Fri, 17 May 2024 02:08:34 GMT, Leonid Mesnik wrote:
>> The JvmtiTrace::safe_get_thread_name sometimes crashes when called while
>> current thread is in native thread state.
>>
>> It happens when thread_name is set for tracing from jvmti functions.
>> See:
>>
On Fri, 17 May 2024 00:38:07 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/prims/jvmti.xml line 1008:
>>
>>> 1006: function descriptions. Empty lists, arrays, sequences, etc are
>>> 1007: returned as nullptr which is C programming language
>>> 1008: null pointer.
>>
>> Perhaps
On Fri, 17 May 2024 02:00:29 GMT, David Holmes wrote:
> But this clarification doesn't actually clarify that the rest of the spec
> uses `nullptr`. Based on the proposed wording I would expect things like:
>
> ```
> The function may return nullptr
> ```
>
> to say
>
> ```
> The function may
On Fri, 17 May 2024 00:43:18 GMT, Serguei Spitsyn wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>>
> The JvmtiTrace::safe_get_thread_name sometimes crashes when called while
> current thread is in native thread state.
>
> It happens when thread_name is set for tracing from jvmti functions.
> See:
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/jvmtiEnter.xsl#L649
>
>
>
On Fri, 17 May 2024 00:43:18 GMT, Serguei Spitsyn wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>>
On Fri, 17 May 2024 00:43:18 GMT, Serguei Spitsyn wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>>
The JvmtiTrace::safe_get_thread_name sometimes crashes when called while
current thread is in native thread state.
It happens when thread_name is set for tracing from jvmti functions.
See:
https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/jvmtiEnter.xsl#L649
The setup is
> The following RFE was fixed recently:
> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
> nullptr in JVMTI generated code
>
> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
> agents can be developed in C or C++.
> This update is to make it
On Thu, 16 May 2024 07:59:51 GMT, Kim Barrett wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: corrected the nullptr clarification
>
> src/hotspot/share/prims/jvmti.xml line 1008:
>
>> 1006:
On Thu, 16 May 2024 19:26:07 GMT, Chris Plummer wrote:
>> src/hotspot/share/prims/jvmti.xml line 1008:
>>
>>> 1006: function descriptions. Empty lists, arrays, sequences, etc are
>>> 1007: returned as nullptr which is C programming language
>>> 1008: null pointer.
>>
>> Shouldn't
On Thu, 16 May 2024 02:37:40 GMT, Serguei Spitsyn wrote:
> The following RFE was fixed recently:
> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
> nullptr in JVMTI generated code
>
> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
> agents
On Thu, 16 May 2024 19:53:48 GMT, Sean Mullan wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> IllegalArgumentException throws doc update
>
>
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In javax/management/remote/rmi/RMIConnectionImpl.java:
>
On Thu, 16 May 2024 11:46:30 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
On Wed, 15 May 2024 06:00:46 GMT, Serguei Spitsyn wrote:
>> I'm not sure this answered Chris' query properly. Or I'm reading Chris'
>> query wrong.
>>
>> Perhaps this is not what Chris had in mind, but I'm wondering what happens
>> in some
>> Thread-A when it is checked and passed by but then
On Thu, 16 May 2024 07:57:58 GMT, Alan Bateman wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>>
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and
On Thu, 16 May 2024 15:31:15 GMT, Chris Plummer wrote:
>> This PR adds ranked monitor support to the debug agent. The debug agent has
>> a large number of monitors, and it's really hard to know which order to grab
>> them in, and for that matter which monitors might already be held at any
>>
On Thu, 16 May 2024 15:31:15 GMT, Chris Plummer wrote:
>> This PR adds ranked monitor support to the debug agent. The debug agent has
>> a large number of monitors, and it's really hard to know which order to grab
>> them in, and for that matter which monitors might already be held at any
>>
On Thu, 16 May 2024 11:00:33 GMT, Johan Sjölen wrote:
> Please wait 24 hours before attempting to integrate. In other words: Do not
> sponsor this until 24 hours has passed since opening the PR.
OTOH, I would say this is good and _trivial_, so the usual 24 hour rule does
not really apply. :)
On Wed, 15 May 2024 21:12:03 GMT, Andrei Pangin wrote:
> The fix for [JDK-8313332](https://bugs.openjdk.org/browse/JDK-8313332) has
> [removed](https://github.com/openjdk/jdk/commit/21867c929a2f2c961148f2cd1e79d672ac278d27#diff-7d448441e80a0b784429d5d8aee343fcb131c224b8ec7bc70ea636f78d561ecd
>
> This PR adds ranked monitor support to the debug agent. The debug agent has a
> large number of monitors, and it's really hard to know which order to grab
> them in, and for that matter which monitors might already be held at any
> given moment. By imposing a rank on each monitor, we can
On Wed, 15 May 2024 21:12:03 GMT, Andrei Pangin wrote:
> The fix for [JDK-8313332](https://bugs.openjdk.org/browse/JDK-8313332) has
> [removed](https://github.com/openjdk/jdk/commit/21867c929a2f2c961148f2cd1e79d672ac278d27#diff-7d448441e80a0b784429d5d8aee343fcb131c224b8ec7bc70ea636f78d561ecd
>
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
> the use of JNI in the following ways:
>
> * `System::load` and `System::loadLibrary` are now restricted methods
> * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods
> * binding a JNI `native`
On Thu, 16 May 2024 11:55:35 GMT, Jaikiran Pai wrote:
>> We already do, see
>> https://github.com/openjdk/jdk/pull/19213/files/1c45e5d56c429205ab8185481bc1044a86ab3bc6#diff-d05029afe6aed86f860a10901114402f1f6af4fe1e4b46d883141ab1d2a527b8R582
>
> This is slightly different from what we do in the
On Thu, 16 May 2024 11:47:13 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/sun/launcher/resources/launcher.properties line
>> 72:
>>
>>> 70: \ by code in modules for which native access is not
>>> explicitly enabled.\n\
>>> 71: \ is one of
On Thu, 16 May 2024 11:42:48 GMT, Jaikiran Pai wrote:
> Hello Maurizio, in the current mainline, we have code in `LauncherHelper`
> https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/launcher/LauncherHelper.java#L636
> where we enable native access to all unnamed
On Thu, 16 May 2024 11:38:28 GMT, Daniel Fuchs wrote:
>> Yes, completely understand. I just don't think it has any benefit.
>
> Hmmm... the spec still says:
>
> * @throws IllegalArgumentException if names or
> * filters is null, or if names contains
> * a null element, or if the
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In javax/management/remote/rmi/RMIConnectionImpl.java:
>
On Wed, 15 May 2024 16:08:17 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and
On Thu, 16 May 2024 10:37:36 GMT, Kevin Walls wrote:
>> This shows that when SubjectDelegation was not used, a null-filled array of
>> the same length as the two other arrays was expected before (in previous
>> versions of the JDK where SubjectDelegation was supported, but in the case
>>
On Wed, 15 May 2024 16:08:17 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and
On Sun, 12 May 2024 01:58:38 GMT, Nizar Benalla wrote:
> Please review this simple change where I add "@ since" tags to the
> package-info file of the following packages
>
> com.sun.jdi
> com.sun.jdi.connect
> com.sun.jdi.connect.spi
> com.sun.jdi.event
> com.sun.jdi.request
>
> I used the
On Mon, 13 May 2024 19:30:31 GMT, Nizar Benalla wrote:
>> Please review this simple change where I add "@ since" tags to the
>> package-info file of the following packages
>>
>> com.sun.jdi
>> com.sun.jdi.connect
>> com.sun.jdi.connect.spi
>> com.sun.jdi.event
>> com.sun.jdi.request
>>
>> I
On Wed, 15 May 2024 21:12:03 GMT, Andrei Pangin wrote:
> The fix for [JDK-8313332](https://bugs.openjdk.org/browse/JDK-8313332) has
> [removed](https://github.com/openjdk/jdk/commit/21867c929a2f2c961148f2cd1e79d672ac278d27#diff-7d448441e80a0b784429d5d8aee343fcb131c224b8ec7bc70ea636f78d561ecd
>
On Thu, 16 May 2024 10:26:25 GMT, Daniel Fuchs wrote:
>> That the JConsole tab was blank shows that the older RMIConnector's
>> addListenerWithSubject creates a new single-entry array from the given
>> delegationSubject (which is null) and passes it onwards. The app is not
>> creating the
On Thu, 16 May 2024 10:16:58 GMT, Kevin Walls wrote:
>> Well my thinking was this: the fact that the jconsole tab was blank shows
>> that the array may being passed. The previous code verified that all three
>> arrays had the same length - so it would have failed if the array had a
>> length
On Thu, 16 May 2024 09:40:58 GMT, Daniel Fuchs wrote:
>> That seems pretty extreme -- it's an array we explicitly don't want and are
>> going to ignore? If somebody passes a non-null member, we will throw as
>> unsupported. I was thinking that was enough, hence removing the sbjs array
>> to
On Wed, 15 May 2024 20:02:26 GMT, Kevin Walls wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
>> line 984:
>>
>>> 982: }
>>> 983: if (names.length != filters.length) {
>>> 984: final String msg = "The lengths of
On Wed, 15 May 2024 22:44:03 GMT, Serguei Spitsyn wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
On Wed, 15 May 2024 23:40:00 GMT, Chris Plummer wrote:
> If jconsole is passing null, why is it triggering this exception?
JConsole passes null, but when running on an older jdk, the older RMIConnector
actually "promotes" it to an array before making the remote call. If you
connect to a
On Thu, 16 May 2024 02:37:40 GMT, Serguei Spitsyn wrote:
> The following RFE was fixed recently:
> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
> nullptr in JVMTI generated code
>
> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
> agents
On Wed, 15 May 2024 13:32:38 GMT, Magnus Ihse Bursie wrote:
> Hi Julian, sorry for not getting back to you.
>
> The problem from my PoV is that this is a very large and intrusive patch in
> the build of the actual product, for a claimed problem in the tangential
> hsdis library. I have not
44 matches
Mail list logo
